17:02:04 <kzaitsev_mb> #startmeeting murano
17:02:04 <kzaitsev_mb> hm
17:02:04 <kzaitsev_mb> looks like openstack bot doesn't feel well today
17:02:05 <openstack> Meeting started Tue Sep 13 17:02:04 2016 UTC and is due to finish in 60 minutes.  The chair is kzaitsev_mb. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:02:06 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:02:08 <openstack> The meeting name has been set to 'murano'
17:02:30 <DmytroDovbii> o/
17:02:58 <kzaitsev_ws> hm
17:03:02 <vakovalchuk> o/
17:03:06 <Nikolay_St> o/
17:03:08 <kzaitsev_ws> my irc client seems stuck
17:03:24 <Nikolay_St> looks same for me kzaitsev_ws
17:03:48 <ding> o/
17:04:52 <tlashchova_> o/
17:06:57 <kzaitsev_mb> #link https://wiki.openstack.org/wiki/Meetings/MuranoAgenda
17:08:59 <kzaitsev_mb> Looks like we do not have anything specific in agenda today
17:09:31 <kzaitsev_mb> and no AIs from prev meeting
17:10:10 <kzaitsev_mb> #topic Open Discussion
17:11:11 <kzaitsev_mb> vakovalchuk: do we have bockports meeting today?
17:11:46 <vakovalchuk> yep, the candidates are here: #link https://etherpad.openstack.org/p/murano-stable-backports
17:11:55 <kzaitsev_mb> #link https://etherpad.openstack.org/p/murano-stable-backports
17:11:59 <vakovalchuk> still not much to look at
17:12:05 <ding> Myself and a few other developers have started working to increase the unit test coverage within Murano.  It started at 69%, and we are getting close to 75%.  I was hoping to commit the new tests once we hit 75%.
17:12:49 <kzaitsev_mb> ding: thats great news!
17:13:33 <Nikolay_St> ding: how much lines do you have in commit right now?
17:13:47 <kzaitsev_mb> well from my side — we have 0 high bugs
17:13:55 <kzaitsev_mb> before rc1 )
17:14:19 <kzaitsev_mb> ok actually 1 new and 1 incomplete
17:14:32 <ding> Nikolay: Not sure on the exact number, but several hundred would be my best guess.
17:14:33 <kzaitsev_mb> #link https://bugs.launchpad.net/murano
17:14:47 <kzaitsev_mb> looks pretty good from rc1 standpoint
17:15:08 <kzaitsev_mb> we have rc1 planned for this thursday
17:17:12 <ding> Is there a style guide or best practice for test coverage?
17:17:24 <Nikolay_St> ding: ok. it's better to split commit to some logical parts it'l be easier to review
17:17:52 <kzaitsev_mb> ding: I don't think we or any other project in Openstack has style guide for unit tests )
17:18:46 <ding> We will split them into more manageable pieces.
17:18:59 <ding> How large would you say is too big?
17:19:05 <ding> for one commit?
17:19:43 <kzaitsev_mb> 600-700 lines? =) idk =) use common sense )
17:20:24 <Nikolay_St> ding: not more than 500 lines :p
17:20:40 <Nikolay_St> but I agree with kzaitsev_mb - use common sense
17:20:43 <kzaitsev_mb> Nikolay_St: well it's tests, so it's a lot of boilerplate code
17:20:57 <kzaitsev_mb> so it can probably be more than that )
17:22:13 <ding> Alright.  Thanks :)
17:22:44 <kzaitsev_mb> ding: really appreciate your efforts =) come around #murano if you'll have some time to invest in murano =) I believe we have a lot of things to share ))
17:23:41 <kzaitsev_mb> it's just that this time of the year is really stressfull with release just behind the corner ))
17:23:53 <ding> I will if I have the chance.  Unfortunately, our corporate wifi doesn't get along well with IRC...
17:25:33 <Nikolay_St> ding: that's bad
17:27:46 <kzaitsev_mb> unfortunatelly I don't have any more updates on my ffe. chances are that we would not merge it in newton, but rather early in ocata
17:27:53 <kzaitsev_mb> ok
17:28:01 <kzaitsev_mb> guess that's all I had to share
17:28:34 <kzaitsev_mb> does anyone have anything murano to share/discuss?
17:32:30 <kzaitsev_mb> ok looks like we can end the meeting a bit early today and get back to all the pre-release hassle )
17:32:42 <kzaitsev_mb> will wait 3-5 more minutes to see if anyone has anything to add
17:33:11 <NanKe> hello https://review.openstack.org/#/c/369275/
17:33:50 <NanKe> i see in murano-latest-DOCS the command is tox -e genconfig,just add a blank space between in -e and genconfig .  so i do this fix...
17:33:51 <NanKe> you can find here http://murano.readthedocs.io/en/latest/install/manual.html#install-the-api-service-and-engine
17:34:37 <kzaitsev_mb> NanKe: those two commands are equivalent, so tend to agree with zhurong — the change seems unnecessary
17:35:00 <NanKe> i think  should  Keep consistency here
17:35:23 <NanKe> so  if you agree with  him  it's ok
17:35:28 <NanKe> ；－）
17:35:55 <kzaitsev_mb> NanKe: honestly — I don't see any value in keeping these consistent =) they both work, they're from different documents
17:36:01 <kzaitsev_mb> looks like nitpicking )
17:36:54 <kzaitsev_mb> NanKe: you can try and convince docs team to put a recomendation on how to put tox commands in documentation
17:36:55 <NanKe> 我想我明白你的意思了
17:36:55 <NanKe> I think I know what you mean.
17:37:28 <NanKe> sorry  i  send chinese ；-)
17:37:59 <kzaitsev_mb> then all the docs in all of the openstack would adhere to that recomendation
17:38:27 <kzaitsev_mb> NanKe: so if you're really interested in making things consistent there — I'd recommend going that way )
17:38:53 <NanKe> ok  thanks  i will abandon these patch
17:39:30 <Nikolay_St> NanKe: thank you for your initiative =)
17:39:52 <NanKe> ：）
17:46:04 <kzaitsev_mb> ok if that's all — let's get back to fixing bugs and FFEs we still have a bit of time before rc1
17:46:11 <kzaitsev_mb> #endmeeting