17:02:03 <Sukhdev> #startmeeting networking_l2gw
17:02:04 <openstack> Meeting started Mon Feb  1 17:02:03 2016 UTC and is due to finish in 60 minutes.  The chair is Sukhdev. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:02:05 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:02:07 <openstack> The meeting name has been set to 'networking_l2gw'
17:02:52 <Sukhdev> #topic: Agenda
17:02:57 <Sukhdev> #link: https://review.openstack.org/#/c/269157/
17:03:27 <Sukhdev> Opps - sorry for wrong link
17:03:31 <Sukhdev> #link: https://wiki.openstack.org/wiki/Meetings/L2Gateway#Meeting_February_1.2C_2016
17:03:37 <Sukhdev> that is correct agenda link
17:03:51 <Sukhdev> #topic: Announcements
17:04:22 <Sukhdev> The deadline for Austin summit proposal submission is extended by one day to Feb 2
17:04:50 <Sukhdev> oferby_ : Are you planning on making any presentation?
17:05:19 <oferby_> I submitted a talk
17:05:27 <oferby_> on the extension to the L2GW
17:05:51 <Sukhdev> cool -
17:05:58 <oferby_> I'm planning to do it with Irena or Alon from Midokura
17:06:19 <oferby_> Irena may join here. Irena, are you here?
17:06:31 <Sukhdev> that would be a good topic for presentation
17:07:00 <oferby_> we still need to get elected ....
17:07:19 <Sukhdev> is it on networking track, right?
17:07:57 <Sukhdev> when the voting time comes, send me link, we can get some additional votes -
17:08:25 <oferby_> great. I will
17:08:38 <Sukhdev> #topic: Patches under review
17:08:44 <oferby_> I posted 2. one for networking and one for architecture
17:09:09 <Sukhdev> I did not know there is architecture track as well :-)
17:09:34 <Sukhdev> same topic on both tracks or different ones
17:09:52 <oferby_> same topic different tech level
17:10:01 <Sukhdev> got it...
17:10:39 <Sukhdev> I approved and merged few patches -
17:10:54 <irenab> hi guys, sorry I am on parallel meeting
17:11:01 <Sukhdev> oferby_ : I reviewed your proposal and posted some comments
17:11:06 <Sukhdev> irenab : hi
17:11:18 <irenab> hi
17:11:33 <oferby_> hi irena
17:11:41 <irenab> oferby_: I will review the updated spec later today or tomorrow
17:12:11 <irenab> for some reason it gets a lot of pep8 error and I beleive they are related to the code patch
17:12:30 <oferby_> sukhdev, I started to do some fixes but I was a bit busy today. will commit tomorrow
17:12:57 <Sukhdev> oferby_ : no worries
17:13:00 <oferby_> I know. sukhdev already sent some remarks on it
17:13:06 <oferby_> I will fix it tomorrow
17:13:15 <Sukhdev> irenab : yes, I saw those pep8 errors
17:13:42 <oferby_> it was mainly because the line was too long.
17:14:02 <Sukhdev> irenab : in one of my comments I mentioned the line being too long
17:14:23 <oferby_> but what did you think about the commands? is anything missing?
17:14:53 <Sukhdev> It looked good on the surface
17:15:07 <oferby_> ok
17:15:16 <irenab> I will review it again, but if you addressed posted comments, I beleive it should be ok
17:15:49 <Sukhdev> If you can add a section on the flow (which you replied to armax's comments) in the doc itself
17:15:59 <Sukhdev> it will help the readers a lot
17:16:02 <irenab> on the pep8 errors, seems the problem is all over the code, it is not related to the spec
17:16:28 <oferby_> sure. i will add the flow
17:16:36 <oferby_> will do that tomorrow.
17:16:59 <Sukhdev> irenab : there is no code in the spec pep8 can be confusing sometime
17:17:15 <irenab> http://logs.openstack.org/86/270786/2/check/gate-networking-l2gw-pep8/a2baae0/console.html
17:17:31 <Sukhdev> you can run it locally in your environment before pushing the patch
17:17:58 <irenab> I can try to look at this later this week
17:18:15 <oferby_> you are right. should have done that.
17:18:40 <Sukhdev> you can run it locally (tox -e pep8)
17:18:40 <irenab> some unit tests are failing too …
17:19:02 <irenab> Sukhdev: I think most are not related to oferby_ spec patch
17:19:48 <Sukhdev> that seems very odd
17:21:32 <oferby_> anyway we are now running tests on the code so we will find if I did that.
17:22:37 <Sukhdev> I just issued a recheck on your patch - see what happens
17:23:22 <Sukhdev> but, you should run it locally to fix the main culprits
17:23:37 <Sukhdev> oferby_ : Anyhow coming back to the content of your patch,
17:23:47 <Sukhdev> I think overall it looks good
17:24:02 <Sukhdev> armax posted some good comments as well
17:24:28 <oferby_> great. I will take care of all yours are armax remarks tomorrow.
17:24:51 <oferby_> the ones not yet replied.
17:25:01 <Sukhdev> sounds good - once this is done, then we can dive into the code
17:25:26 <oferby_> ok.
17:25:31 <Sukhdev> I had forwarded your patch to the India team as well - I did not see any response from them yet
17:25:43 <Sukhdev> will ping them again - otherwise, we will proceed
17:25:53 <oferby_> ok.
17:26:38 <Sukhdev> oferby_ : any word on the patch for the ovslib ?
17:27:31 <oferby_> They wanted unit tests with the code
17:27:42 <Sukhdev> we are holding https://review.openstack.org/#/c/202495/ patch until we get that done
17:27:51 <oferby_> when I submitted it they asked for ipv6  tests too
17:28:13 <Sukhdev> yup - tests are necessary evil :-):-)
17:28:42 <oferby_> right but I requests one after the other ....
17:28:51 <oferby_> one at a time.
17:29:36 <oferby_> I hope after tests in ipv6 we will be able to commit the code.
17:30:15 <Sukhdev> I'll keep the fingers crossed :-)
17:30:20 <oferby_> :-)
17:30:37 <Sukhdev> Anything else we need to discuss today?
17:31:23 <oferby_> I think we should start to work on separating the API from the impl
17:31:48 <oferby_> do you like me to do that or someone else as you said you thought of it
17:32:26 <Sukhdev> Please go ahead -
17:32:45 <oferby_> sure. I will.
17:33:13 <oferby_> Also, we made changes to the vtep emulator
17:33:25 <oferby_> in openvswitch project.
17:33:52 <oferby_> this is to emulate hardware switch that support the new API
17:34:02 <Sukhdev> there are couple of patches by vikas - you may want to take look at those - he is refactoring some of the code in those
17:34:41 <oferby_> in gerrit?
17:34:57 <Sukhdev> yup
17:35:07 <oferby_> ok. will look at it tomorrow.
17:35:20 <oferby_> (I'm at home now .....)
17:35:22 <Sukhdev> check here - https://review.openstack.org/#/q/status:open+project:openstack/networking-l2gw,n,z
17:35:45 <oferby_> got it.
17:36:11 <Sukhdev> Anything else to discuss?
17:36:37 <oferby_> yes. I would like to change the gateway command
17:36:58 <oferby_> in a way that it will not be mandatory to add physical port.
17:36:58 <Sukhdev> what do you mean? which command?
17:37:10 <oferby_> l2-gateway-create
17:37:29 <oferby_> I will add it as a bug. ok?
17:37:42 <Sukhdev> oferby_ : you have to remember people are using it - we can not break backward compatibility
17:38:03 <oferby_> we can have it as an option
17:38:11 <Sukhdev> yes, bug is correct way to go
17:38:15 <oferby_> in the command it is use like that:
17:38:27 <oferby_> --device .......
17:38:39 <oferby_> which means that we can make it optional.
17:39:32 <Sukhdev> when you post a bug, please describe it clearly so that everybody can know what is being changed and why -
17:39:49 <oferby_> sure. i will.
17:39:58 <Sukhdev> sounds good
17:40:16 <oferby_> i guess this is it from me.
17:40:22 <Sukhdev> anything else?
17:40:42 <oferby_> irena,  something from you?
17:42:18 <oferby_> I think this is it.
17:42:20 <Sukhdev> looks like we are done - silence means no from irenab :-)
17:42:29 <oferby_> yep.
17:42:37 <Sukhdev> thanks folks
17:42:46 <Sukhdev> bye
17:42:50 <oferby_> talk to you. bye.
17:42:52 <Sukhdev> #endmeeting