16:02:29 <Sukhdev> #startmeeting networking_ml2
16:02:30 <openstack> Meeting started Wed Apr  5 16:02:29 2017 UTC and is due to finish in 60 minutes.  The chair is Sukhdev. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:02:31 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:02:34 <openstack> The meeting name has been set to 'networking_ml2'
16:02:46 <Sukhdev> #topic: Agenda
16:03:05 <Sukhdev> #link: https://wiki.openstack.org/wiki/Meetings/ML2#Meeting_April_5.2C_2017
16:03:19 <Sukhdev> #topic: Announcements
16:03:48 <Sukhdev> I mistyped the meeting name last time and hence, the logs went to wrong place - sorry about that -
16:04:18 <Sukhdev> Here is the link to the logs, if you need to go back and refer to them - http://eavesdrop.openstack.org/meetings/__networking_ml2/
16:04:29 <dasanind> Sukhdev: ack
16:05:34 <Sukhdev> rkukura will be here in and out - so, may not participate activly
16:06:07 <Sukhdev> Anybody has any announcements before we jump into the agenda?
16:07:06 <dasanind> I don't have anything
16:07:07 <Sukhdev> #topic: QinQ Driver
16:07:28 <trevormc> I removed the WIP tag!
16:07:32 <Sukhdev> #link: https://review.openstack.org/#/c/446047
16:07:52 <Sukhdev> trevormc : I looked at the patch - looks really good
16:07:57 <trevormc> but I think i will have to add tempest tests
16:08:08 <trevormc> thanks Sukhdev, I updated Qinq to QinQ
16:09:10 <trevormc> I'm not working on the next item on the agenda :)
16:09:14 <trevormc> im now*
16:09:19 <Sukhdev> trevormc : what about the mech driver? are you going to work on it next?
16:09:45 <trevormc> Sukhdev, oh is that a requirement for the QinQ driver?
16:10:18 <Sukhdev> trevormc : no
16:10:25 <Sukhdev> just curious
16:10:43 <trevormc> I'm working on create a vf_policy object to store the advanced configuration for SR-IOV
16:11:09 <trevormc> I'm trying to make an api extension like port_secuirty
16:12:05 <Sukhdev> trevormc : Sounds good
16:12:24 <trevormc> at least I think thats the right approach, I'm also looking at how QoS policy id was attached to the port model.
16:12:33 <Sukhdev> trevormc: just beef up the tests, and, this one looks pretty much ready to go
16:12:58 <trevormc> Sukhdev, ok I will add more unit tests. Do we need tempest tests?
16:13:18 <Sukhdev> trevormc: I do not believe that is the requirement
16:13:39 <trevormc> ok great :)
16:13:42 <Sukhdev> you already have the tests
16:14:36 <Sukhdev> trevormc : IMO this is looking good - have rkukura take a look as well, if he has not done yet
16:14:37 <trevormc> oh? I guess there is a framework that tests every available driver type.
16:14:55 <trevormc> ok sounds good
16:15:23 <Sukhdev> trevormc : you can push a separate patch for tempest tests, but, this code looks good to me
16:15:43 <trevormc> ok
16:16:14 <Sukhdev> anything else on this ?
16:16:27 <trevormc> no thats all.
16:16:52 <Sukhdev> cool
16:17:16 <Sukhdev> #topic:  Port binding extension support
16:17:22 <Sukhdev> #link: https://review.openstack.org/#/c/446047
16:17:43 <Sukhdev> dasanind : I looked at the patch - this looked good to me
16:17:54 <dasanind> Sukhdev: thank you for the review
16:18:21 <dasanind> In couple of hours I will update the patch with API test cases
16:18:28 <Sukhdev> even though it is a WIP, I gave it a +1 to indicate that this is in good shape
16:18:36 <dasanind> Thank you
16:19:18 <dasanind> After I finish with the test cases I will proceed with the changes in the ml2 code
16:19:31 <Sukhdev> dasanind : sounds good -
16:19:58 <dasanind> Do you think I should put the changes in the same patch or separate patch?
16:20:26 <Sukhdev> dasanind : separate, please
16:20:42 <dasanind> cool will do that
16:20:48 <Sukhdev> dasanind : multiple patches with smaller fixes is much easier to review and get approvals
16:20:51 <dasanind> and make it dependednt on this patch
16:21:29 <Sukhdev> dasanind : yes
16:21:56 <dasanind> Sukhdev: One other question is do we need tempest tests for these apis
16:22:09 <Sukhdev> dasanind : yes
16:22:17 <dasanind> Currently, I am writing unit tests for this extension
16:22:33 <dasanind> Sukhdev: ack
16:23:42 <Sukhdev> dasanind : be sure to make sure all these patches refer to the RFE as well
16:24:28 <dasanind> Sukhdev: sure
16:24:40 <Sukhdev> anything else?
16:25:12 <dasanind> I am good for now
16:25:23 <Sukhdev> cool
16:25:35 <Sukhdev> #topic: Open Discussion
16:25:54 <Sukhdev> Anything general to discuss?
16:26:01 <trevormc> no
16:26:05 <Sukhdev> Are you guys going to Boston summit?
16:26:12 <trevormc> yes
16:26:12 <dasanind> nothing from my side
16:26:21 <dasanind> I am not going
16:26:37 <Sukhdev> dasanind : oh no :-)
16:27:00 <dasanind> :(
16:27:11 <Sukhdev> trevormc : I will see you in Boston
16:27:20 <Sukhdev> I guess we are done  -
16:27:22 <trevormc> looking forward to it
16:27:30 <dasanind> Thank you
16:27:34 <Sukhdev> Thanks for attending
16:27:37 <trevormc> thanks o/
16:27:38 <Sukhdev> bye
16:27:45 <Sukhdev> #endmeeting