18:00:26 #startmeeting networking_policy 18:00:27 Meeting started Thu Jun 30 18:00:26 2016 UTC and is due to finish in 60 minutes. The chair is SumitNaiksatam. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:00:28 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:00:30 The meeting name has been set to 'networking_policy' 18:00:47 #info agenda https://wiki.openstack.org/wiki/Meetings/GroupBasedPolicy#June_30th.2C_23rd_2016 18:00:55 SumitNaiksatam: hi! 18:01:06 hi 18:01:20 does anyone have anything critical to bring up before we dive into the NFP patches? 18:01:56 #topic NFP Implementation patches 18:02:10 #link https://review.openstack.org/#/q/topic:bp/gbp-network-services-framework 18:02:17 hi 18:03:07 we are currently reviewing patches until: #link https://review.openstack.org/#/c/309145/ 18:03:38 hemanthravi: thanks to you and the other authors for responding to the review comments 18:04:08 most of the review comments have been addressed, currently gate tests are broken and this shoudld be resolved today 18:04:09 i think a lot of the pending comments have been addressed 18:04:53 hemanthravi: in some cases i noticed that it was mentioned that the comment wil be addressed as a follow bug 18:04:55 the dependency chain seems to be broken with one of the recent submit, will resolve this after the irc 18:05:32 hemanthravi: the expectation is that the bug be filed, and the bug link be provided in the patch comments 18:05:33 hi 18:05:53 ok, will do that 18:05:57 hemanthravi: otherwise its difficult to track what was addressed and what needs to be addressed as follow up bugs 18:06:11 hemanthravi: i did not see any follow up bugs being filed 18:06:42 the team is keeping track of the bugs to be filed, will file these bugs and edit the comment with the bug 18:07:27 hemanthravi: great, thanks 18:08:15 hemanthravi: my comments in patch set 120 have not been responded to: #link https://review.openstack.org/#/c/309145/120 18:08:31 hemanthravi: have these been fixed? 18:10:46 these are not fixed yet 18:10:51 hemanthravi: okay 18:11:37 hemanthravi: until which patch are all the comments completely fixed, or is it that there are few here and there? 18:12:51 most of the comments have been addressed, the gate test comments are pending since the failure in the gate test was being resolved 18:12:52 * SumitNaiksatam anticipates this is going to be a slow meeting since we are reviewing patches in real time! 18:13:04 hemanthravi: okay 18:13:20 all the gate test comments will be addressed 18:14:03 hemanthravi: when do you think you will get to that point? 18:14:33 should be done fri PST 18:14:40 morning 18:14:45 hemanthravi: okay great 18:15:35 once these are resolved, can we start the merge fri or sat PSt 18:16:04 hemanthravi: i am good with that tentative plan, what does the rest of the team think? 18:16:41 we might have a good window when the gate is hopefully less loaded over the next few days 18:16:52 the main pending ones are to have the gate tests running and the validations added in the gate tests 18:17:23 * tbachman is fine with the plan 18:17:32 hemanthravi: yes i am definitely hoping to see the integration test validations 18:17:39 tbachman: thanks for the feedback 18:17:44 SumitNaiksatam: sure :) 18:18:07 thanks 18:18:30 rkukura: ivar-laz_: igordcard: songole: what do you guys think about the plan to start merging tomorrow if the fixes are in place by then? 18:19:00 SumitNaiksatam: Yes to the merge!! 18:19:12 songole: okay 18:19:20 SumitNaiksatam: I’m not opposed, but I have not been doing much reviewing of this code, so I’ll defer to others. 18:19:27 rkukura: sure 18:20:02 I'm okay with it 18:20:10 igordcard: okay, thanks 18:20:41 I will be pretty much completely offline from tomorrow mid afternoon east coast time until sometime Sunday. 18:20:54 SumitNaiksatam: I'll be on PTO until the 5th, but it sounds good 18:21:06 rkukura: thanks for informing us 18:21:10 ivar-laz_: thanks for the note 18:21:32 so looks like there are no major objections in the team 18:21:38 SumitNaiksatam: one question 18:21:43 are these only going into master? 18:21:44 tbachman: yes sure 18:21:48 or are they going to be backported? 18:21:54 tbachman: good question 18:21:56 * tbachman guesses just master 18:22:02 is this considered a new feature? 18:22:16 those are tought questions :-P 18:22:19 lol 18:22:19 tbachman: this is GBP! 18:22:20 *tough 18:22:20 they need to be backported as well 18:22:26 rkukura: lol! 18:22:35 rkukura: ACK — just wasn’t sure what our policy was :) 18:22:50 tbachman: so here is dimension to this - 18:22:51 * tbachman stirs the pot :P 18:23:18 almost all the code that is being introduced by these patches is additive, and is contained new modules 18:23:24 *in new 18:24:05 hemanthravi: songole: please correct if this is not accurate 18:24:33 that's correct, except for one patch in gbp code 18:24:57 99% yes. There are a couple of lines of change in 1 file 18:25:46 backport is required as the most of the users are moving upto liberty at this stage 18:26:22 so, just to liberty? 18:26:28 * tbachman is fine with that 18:27:37 tbachman: yes 18:27:40 Is the plan to back-port as we go, or wait til we get to some level of confidence on master before we start back-porting? 18:27:43 songole: thx! 18:27:56 rkukura: that is a good point 18:28:13 so are we saying that we are definitely not backporting to kilo? 18:28:20 currently there is a requirement to backport to liberty for some of the evals 18:28:47 not sure on kilo, will check on this 18:29:13 hemanthravi: kilo is kind of EoL so its difficult to do this 18:29:48 ok 18:30:28 so the easier things first, we will try to merge in master, and mitaka backport is automatic since our master is still at mitaka 18:30:37 hopefully no issues with that 18:30:53 we are saying that we will not do kilo backports 18:31:04 that leaves liberty 18:31:16 we have also a local backport to liberty that we have been testing 18:31:27 and the suggestion over there is that we first test liberty 18:31:31 the changes are minor for the liberty backport 18:31:31 hemanthravi: ah right on cue 18:32:40 so lets first merge master and mitaka backport, and then have the liberty backport patches posted 18:33:07 we can then test the stability of the master and mitaka branches before we make a call on merging in liberty 18:33:13 does that sound okay to all? 18:33:22 * tbachman nods 18:33:25 mostly with i18n being _i18n and some constants for topics in a differnt location 18:33:31 tbachman: thanks 18:34:06 hemanthravi: yes, that is true but i guess the concern is about the stability of the master branch once this merges 18:34:42 we want to be sure that merging does not majorly disrupt the master/mitaka 18:34:46 branches 18:34:57 ok, as you said we can wait for the stability on master/mitaka 18:35:21 hemanthravi: yeah lets get to the point first where have those merged, and then make a call accordingly 18:37:00 okay, seems like we are mostly in agreement, and have a reasonable plan moving forward 18:38:09 #topic Open Discussion 18:38:25 thats pretty much from me for today 18:38:29 anyone have anything else? 18:38:38 don't have anything from my side 18:38:47 igordcard: QoS next week? 18:39:07 SumitNaiksatam: not sure 18:39:11 igordcard: okay 18:39:16 igordcard: best effort :-) 18:40:29 the deadline for submissions for the Barcelona summit is July 13th 18:40:44 fast approaching 18:41:11 all right, thanks all for joining, and happy 4th of July to those in the US! 18:41:24 bye 18:41:28 SumitNaiksatam: thanks! 18:41:31 SumitNaiksatam: bye! 18:41:33 bye 18:41:34 bye 18:41:34 bye 18:41:40 #endmeeting