18:02:51 <SumitNaiksatam> #startmeeting networking_policy 18:02:52 <openstack> Meeting started Thu Jul 6 18:02:51 2017 UTC and is due to finish in 60 minutes. The chair is SumitNaiksatam. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:02:53 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:02:55 <openstack> The meeting name has been set to 'networking_policy' 18:03:07 <SumitNaiksatam> #info agenda https://wiki.openstack.org/wiki/Meetings/GroupBasedPolicy#July_6th_2017 18:03:31 <SumitNaiksatam> lets start with a bang today ;-) 18:03:47 <SumitNaiksatam> bang -> fireworks 18:04:18 <SumitNaiksatam> in keeping with the july 4th sentiment 18:04:26 <SumitNaiksatam> #topic Proposal to add Anna K and Thomas B to core team 18:04:32 <tbachman> :) 18:04:48 <rkukura> +2 18:04:56 <SumitNaiksatam> rkukura: wow that was fast :-) 18:05:27 <SumitNaiksatam> obviously +2 for me 18:05:55 <SumitNaiksatam> both annak (ocata sync) and tbachman (dual stack) have been doing great work for the project 18:06:43 <SumitNaiksatam> and have gained enough expertise to perform insightful reviews and perform are gate keepers for the project 18:07:07 <SumitNaiksatam> tbachman and annak thanks for agreeing to take up this added responsibility 18:07:19 <tbachman> SumitNaiksatam: my pleasure! 18:07:20 <SumitNaiksatam> i should add that annak is on vacation but I had reached out to her earlier 18:08:19 <SumitNaiksatam> so I will send out an email to the broader team and if there are no objections (which I dont think there will be), I will immediately add to the core team 18:08:33 <tbachman> Thanks all for the nomination! 18:08:54 <SumitNaiksatam> tbachman: our pleasure and honor! :-) 18:08:56 <SumitNaiksatam> #topic Ocata sync 18:09:07 <SumitNaiksatam> #link https://review.openstack.org/#/q/topic:ocata_sync 18:09:14 <SumitNaiksatam> so we have made good progress 18:09:53 <SumitNaiksatam> the engine facade issues we were discussing were a combination of an issue in our patch, and also the need to patch in a small place in neutron 18:10:01 <SumitNaiksatam> more specifically: 18:10:57 <SumitNaiksatam> this was removed: 18:10:58 <SumitNaiksatam> https://review.openstack.org/#/c/477035/27..32/gbpservice/neutron/extensions/patch.py 18:11:00 <SumitNaiksatam> and 18:12:11 <SumitNaiksatam> this was added: 18:12:11 <SumitNaiksatam> https://review.openstack.org/#/c/477035/32/gbpservice/neutron/extensions/patch.py 18:12:49 <SumitNaiksatam> the above two helped to fix the issues in the AIM gate job 18:12:56 <SumitNaiksatam> in addition, the following fix: 18:13:01 <SumitNaiksatam> https://review.openstack.org/#/c/477035/32/gbpservice/tests/contrib/gbpfunctests/libs/verify_libs.py 18:13:18 <SumitNaiksatam> (which was an issue in the test suite) 18:13:30 <SumitNaiksatam> helped to fix the resource_mapping devstack gate job 18:13:39 <rkukura> so no net gain in the number of monkey-patches? 18:13:47 <SumitNaiksatam> rkukura: :-( 18:14:06 <SumitNaiksatam> yeah adding one more 18:14:31 <SumitNaiksatam> so if you look at: 18:14:31 <SumitNaiksatam> https://review.openstack.org/#/c/477035/32 18:14:57 <SumitNaiksatam> all the jobs we tyically gate on and look for added validation have passed 18:15:26 <SumitNaiksatam> *typically 18:15:38 <SumitNaiksatam> i have disabled the NFP gate job 18:15:54 <SumitNaiksatam> since we will need someone from the NFP sub-team to fix this 18:16:04 <SumitNaiksatam> songole is not in the meeting today 18:16:39 <SumitNaiksatam> i also tried to fix the rally job 18:16:54 <SumitNaiksatam> but it will take more time since we hadnt updated our rally branch for a long time 18:17:09 <SumitNaiksatam> i rebased the branch, but i am seeing new failures in the setup 18:17:57 <SumitNaiksatam> i propose that we dont wait for these two jobs to merge the ocata sync patches 18:18:42 <rkukura> I’m OK with that I think 18:18:43 <SumitNaiksatam> i also propose that we dont merge any more non-critical patches until we merge the ocata sync patches 18:19:18 <rkukura> OK with that too 18:19:27 <SumitNaiksatam> rkukura: thanks 18:19:31 <SumitNaiksatam> tbachman: what do you think? 18:19:39 <tbachman> SumitNaiksatam: sounds good 18:19:43 <SumitNaiksatam> the non-ocata pending patches will unfortunately take a bit of a hit 18:19:45 <SumitNaiksatam> tbachman: thanks 18:19:52 <SumitNaiksatam> and will have to be reworked 18:20:36 <SumitNaiksatam> but i think its important that we keep moving forward with the ocata branch since we are already behind 18:21:07 <SumitNaiksatam> rkukura: tbachman: any chance you can take a quick look at the two ocata sync patches? 18:21:19 <tbachman> SumitNaiksatam: will have a look 18:21:24 <SumitNaiksatam> we would still need to fix the client, horizon and UI 18:21:26 <rkukura> yes 18:21:26 <SumitNaiksatam> tbachman: thanks 18:21:30 <SumitNaiksatam> rkukura: thanks 18:22:06 <SumitNaiksatam> annak is on vacation so i will try to respond to any review comments in case the need arises 18:22:21 <SumitNaiksatam> i believe she will be back starting monday 18:22:28 <rkukura> ok 18:22:40 <SumitNaiksatam> so not a long vacation, in case you want to wait for her 18:23:02 <SumitNaiksatam> but we certainly dont have to wait for that 18:23:39 <SumitNaiksatam> she did a great job with wrapping things up before she went on vacation 18:24:01 <SumitNaiksatam> rkukura: tbachman: anything you need to discuss on this topic? 18:24:53 <rkukura> SumitNaiksatam: are we planning to create stable/ocata any time soon? 18:25:21 <SumitNaiksatam> rkukura: immediately after we merge this patch 18:25:31 <SumitNaiksatam> this -> these 18:25:44 <SumitNaiksatam> rkukura: any issues with that? 18:25:48 <rkukura> ok, so we’ll have more backports to do, but that’s ok 18:25:56 <SumitNaiksatam> rkukura: :-( 18:26:16 <SumitNaiksatam> master will still be ocata until we move to pike with a similar effort (hopefully soon) 18:26:28 <SumitNaiksatam> but yes, this will mean one extra backport 18:26:43 <SumitNaiksatam> and it might not always be a trivial cherry-pick 18:27:00 <rkukura> as long as we keep master and stable/ocata in sync, they will be trivial 18:27:21 <SumitNaiksatam> yeah, i meant stable/ocata to stable/newton 18:27:25 <rkukura> right 18:27:42 <SumitNaiksatam> hopefully we wont have to go much farther than that 18:27:58 <SumitNaiksatam> because stable/newton to stable/mitaka is also not always trivial 18:29:24 <SumitNaiksatam> tbachman: we would need to update the apic repo dependencies as a follow up to merging these patches 18:30:04 <SumitNaiksatam> so in parallel we will work to to get rid of the dependency on apic_ml2 and accordingly update GBP requirements 18:30:14 <rkukura> sounds good 18:30:55 <SumitNaiksatam> i think we have added revisit/todos in the patches wherever relevant, but if missing please comment on the reviews 18:31:03 <rkukura> ok 18:31:23 <SumitNaiksatam> these things are easy to miss/forget once done, and go in circles later with incorrect depedencies 18:31:25 <SumitNaiksatam> rkukura: thanks 18:32:14 <SumitNaiksatam> #topic Subnetpools in resource_mapping driver 18:32:29 <SumitNaiksatam> #link https://review.openstack.org/469681 18:33:05 <SumitNaiksatam> unfortunately i dont have any more suggestions on this beyond what i suggested over the emails 18:33:18 <SumitNaiksatam> i dont think annak had a chance to get back to this either 18:33:33 <rkukura> I haven’t looked at it or the emails in a while 18:33:39 <SumitNaiksatam> rkukura: okay 18:33:46 <SumitNaiksatam> songole is not here, so I will skip NFP 18:33:52 <SumitNaiksatam> there are a few pending patches there 18:33:55 <SumitNaiksatam> we merged some 18:34:07 <SumitNaiksatam> #topic Open Discussion 18:34:09 <rkukura> but one question is whether we would need a data migration for the switch to subnetpools? 18:34:18 <SumitNaiksatam> rkukura: yeah good question 18:35:03 <SumitNaiksatam> rkukura: i guess we can discuss that once we firm up on what approach we are going to take to use subnetpools in the resource_mapping driver? 18:36:24 <rkukura> sure, but I suspect the data migration issues will be similar to with the APIC plugin migration 18:36:51 <SumitNaiksatam> rkukura: agree 18:36:58 <rkukura> lets discuss this with annak when she is back next week 18:37:16 <SumitNaiksatam> rkukura: yeah 18:37:38 <SumitNaiksatam> tbachman: regarding the fix you put for updating the floating_ip description 18:38:14 <SumitNaiksatam> tbachman: please note that in the ocata patch we are completely getting rid of that monkey patch 18:38:41 <SumitNaiksatam> tbachman: so kindly confirm that doing so will still keep things working 18:38:54 * tbachman returns from his distrations 18:38:57 <tbachman> SumitNaiksatam: sorry about that 18:38:58 <tbachman> back 18:38:59 <tbachman> :) 18:39:29 <tbachman> SumitNaiksatam: if the monkey-patch is gone, then we’ll use the upstream code, which already has this 18:39:33 <SumitNaiksatam> tbachman: https://review.openstack.org/#/c/465784/31/gbpservice/neutron/extensions/patch.py 18:39:34 <tbachman> So, we’re good :) 18:39:46 <SumitNaiksatam> tbachman: nice, thanks for the quick turnaround :-) 18:39:50 <tbachman> np 18:39:55 <rkukura> do we need the fix for stable/newton? 18:40:12 <SumitNaiksatam> rkukura: good point, i think tbachman was planning to post the backport 18:40:25 <tbachman> rkukura: SumitNaiksatam: FWIW, Amit has already just +2’d +w’d the other patches 18:40:31 <tbachman> SumitNaiksatam: I’d already posted the backports 18:40:36 <tbachman> all the way to stable/mitaka 18:40:50 <SumitNaiksatam> tbachman: ah nice, i see its been +A’ed 18:40:52 <tbachman> but, again, if the monkey-patch is removed from those branches, then we’ll get the (same) upstream behavior 18:41:06 * tbachman always gets confused with +A/+W :P 18:41:23 <rkukura> forgot that this already merged to master 18:41:27 <SumitNaiksatam> tbachman: we wont backport the ocata sync patch 18:41:34 <tbachman> ah 18:41:41 <tbachman> I guess the point is: we’re good, either way 18:41:45 <SumitNaiksatam> tbachman: so the fix in stable/newton is the most relevant 18:41:48 <tbachman> if the monkeypatch is there or isn't 18:42:01 <tbachman> b/c the patches to the monkeypatch have merged 18:42:07 <SumitNaiksatam> tbachman: right 18:42:30 <SumitNaiksatam> nothing more today from my side 18:42:58 <rkukura> same here 18:43:10 <SumitNaiksatam> rkukura: tbachman: thanks for joining 18:43:17 <rkukura> thanks SumitNaiksatam! 18:43:18 <tbachman> SumitNaiksatam: thanks! 18:43:24 <SumitNaiksatam> see you next week here 18:43:26 <SumitNaiksatam> bye! 18:43:29 <rkukura> bye 18:43:31 <SumitNaiksatam> #endmeeting