14:00:10 <lajoskatona> #startmeeting neutron_drivers
14:00:10 <opendevmeet> Meeting started Fri Sep  9 14:00:10 2022 UTC and is due to finish in 60 minutes.  The chair is lajoskatona. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:10 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:10 <opendevmeet> The meeting name has been set to 'neutron_drivers'
14:00:12 <lajoskatona> o/
14:00:12 <mlavalle> o/
14:00:16 <obondarev> hi
14:00:26 <skingFD> hi
14:00:43 <haleyb> hi
14:00:53 <slaweq> o/
14:02:06 <lajoskatona> Let's start we have quoume as I count
14:02:14 <lajoskatona> We have one RFE for today
14:02:17 <lajoskatona> [RFE] OVN support for vnic type virtio-forwarder (#link https://bugs.launchpad.net/neutron/+bug/1988542 )
14:02:34 <skingFD> Hi, this RFE is reported by me
14:03:04 <lajoskatona> If I understand well this is realted to some smart-nic feature, am I rigth?
14:03:16 <lajoskatona> Hi skingFD, thanks for proposing
14:03:39 <skingFD> Yes, it is a new feature related to smart-nic
14:04:10 <skingFD> It is a standard already supported by NOVA and some smartnics, while neutron does not
14:04:28 <lajoskatona> the nova spec speaks about netronome only, and as I remember some work was done in Neutron also
14:04:32 <lajoskatona> for OVS
14:04:47 <skingFD> Yes, the ovs plugin already supports it
14:04:56 <skingFD> but the ovn still does not
14:04:57 <slaweq> are there any more changes required on neutron side for that, besides what You already proposed?
14:05:34 <skingFD> I don't think there are more changes needed
14:05:56 <mlavalle> then it seems like a no brainer to me
14:05:58 <skingFD> It is a open-sourced vnic type, beside netronome, everyone can use it
14:06:02 <lajoskatona> Agree
14:06:19 <obondarev> cool then, +1 from me as well
14:06:25 <lajoskatona> even an RFE is too much perhaps, but we discussed it and have clear picture
14:06:29 <lajoskatona> +1
14:07:13 <slaweq> thx
14:07:24 <slaweq> +1
14:07:28 <haleyb> +1
14:07:37 <mlavalle> to formalize my position.... +1
14:07:45 <lajoskatona> We have agreement than :-)
14:08:00 <mlavalle> I like this type of RFE
14:08:05 <skingFD> thx
14:08:05 <lajoskatona> skingFD: thanks for proposing  and working on this
14:08:09 <mlavalle> straightforward
14:08:13 <slaweq> yeah
14:08:17 <mlavalle> given the evidence
14:08:42 <lajoskatona> #topic On Demand Agenda
14:08:53 <lajoskatona> Do you have anything to discuss today?
14:08:54 <skingFD> Appreciate more code reviewing on the patch I've supported
14:09:09 <skingFD> It's my first time contributing to neutron
14:09:09 <mlavalle> skingFD: I'll take a look soon
14:09:28 <mlavalle> and thank you for your contribution. we welcome you!
14:09:31 <skingFD> So more check is needed I guess :)
14:09:35 <lajoskatona> skingFD: sure, we are now closing the Zed release so next weeks will be busy
14:09:58 <skingFD> :mlavalle Thanks!
14:10:51 <ges> Do we have time for another small RFE?
14:11:13 <lajoskatona> ges: I think yes
14:11:26 <slaweq> we have plenty of time still :)
14:11:31 <ges> [rfe] rate-limit metadata API : https://bugs.launchpad.net/neutron/+bug/1989199
14:11:38 <mlavalle> keep in time haleyb will drop off soon
14:11:44 <mlavalle> will we still have quorum?
14:12:02 <haleyb> mlavalle: i'm still here for now :)
14:12:16 <mlavalle> ok
14:12:35 <mlavalle> LOL, this RFE is hot just out of the oven
14:12:41 <ges> yep!
14:12:55 <mlavalle> be careful, don't burn yourselves
14:13:24 <lajoskatona> :-)
14:13:59 <ges> too early maybe? I understand if we need to wait a bit!
14:14:28 <mlavalle> naah, I don't think so
14:14:41 <slaweq> ges: do You want to do it with config option so it will be for all networks or routers on nodes?
14:14:41 <mlavalle> ges: is this for ml2/ovs
14:14:43 <mlavalle> ?
14:14:50 <slaweq> or somehow through API per network or router?
14:15:15 <slaweq> mlavalle: I think that the same can apply to ovn as well
14:15:20 <ges> slaweq: in our PoC I have done that with some config options
14:15:21 <obondarev> I know some users set rate limiting for metadata at the VIP level, having this native does make sense to me
14:15:22 <lajoskatona> agree
14:15:27 <slaweq> as we do have haproxy in the ovn-meta namespace there
14:16:06 <ges> the rate-limiting would be done by source ip
14:16:39 <haleyb> https://www.haproxy.com/blog/four-examples-of-haproxy-rate-limiting/#sliding-window-rate-limiting
14:17:02 <obondarev> I think it might worth a spec to discuss options
14:17:11 <lajoskatona> +1
14:17:34 <ges> mlavalle: I'm not sure I understand how it relates to either ml2 or ovs :/
14:17:37 <slaweq> I agree
14:18:14 <slaweq> for example: will it be just config knob to enable/disable rate-limit or will there be knob to configure actual limit of requests
14:18:28 <lajoskatona> ges: In neutron there's 2 metadata agent now one for OVN and one for all other (OVS, linuxbridge)
14:19:44 <haleyb> i would think we could enable this by default, if it's by source IP it should be Ok and not impact normal operations, correct?
14:20:34 <slaweq> haleyb: as long as it will be set to some reasonable value to not affect e.g. cloud-init during boot of the vms
14:20:46 <ges> lajoskatona: ah I see! We don't use OVN but I suppose it could go there as well
14:20:57 <lajoskatona> ges: yes, exactly
14:21:20 <lajoskatona> As I see there's a lot of things which should be clarified in a spec
14:21:58 <lajoskatona> So to summarize: the RFE generally looks ok, but we need a spec to discuss the details, is that correct?
14:22:12 <obondarev> +1
14:22:16 <haleyb> slaweq: yes, making it large enough to cover the cloud-init case +some% should limit someone doing a DoS after they boot
14:22:44 <slaweq> +1 for me
14:22:47 <haleyb> Ok, well my repair guy is here, have to run, i'm fine with this for now...
14:22:48 <lajoskatona> +1
14:22:50 <mlavalle> +1
14:22:58 <lajoskatona> haleyb: thanks
14:23:11 <ges> thanks!
14:23:40 <lajoskatona> Ok, I wil update the RFE, thanks ges for proposing it
14:24:13 <ges> yw! next step is to write a spec, right? Should I do it?
14:25:00 <lajoskatona> ges: yes, here is a template: https://opendev.org/openstack/neutron-specs/src/branch/master/specs/zed/placeholder.rst
14:25:16 <lajoskatona> soon there will be a new folder for Antelope/2023.1
14:25:34 <mlavalle> I think the folder is already there
14:26:00 <lajoskatona> and it is really there
14:26:01 <mlavalle> https://opendev.org/openstack/neutron-specs/src/branch/master/specs/2023.1
14:26:13 <lajoskatona> thanks mlavalle
14:26:20 <mlavalle> yeah, I recently approved the patch ;-)
14:26:37 <ges> Alright!
14:26:38 <lajoskatona> I looked for the end of alphabet as usual, and we reached the end of it :-)
14:26:53 <mlavalle> LOL, you just went to the end
14:26:53 <lajoskatona> Is there anything we can discuss today?
14:28:07 <slaweq> nothing from me
14:28:14 <mlavalle> neither from me
14:28:18 <lajoskatona> If nothing more , let's close the meeting for today
14:28:24 <lajoskatona> Thanks for coming :-)
14:28:29 <lajoskatona> #endmeeting