15:00:54 <ralonsoh> #startmeeting neutron_qos
15:00:54 <openstack> Meeting started Tue Mar 14 15:00:54 2017 UTC and is due to finish in 60 minutes.  The chair is ralonsoh. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:55 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:57 <openstack> The meeting name has been set to 'neutron_qos'
15:01:00 <ralonsoh> Hi
15:01:03 <slaweq> hello
15:01:08 <davidsha> Hi
15:01:25 <ralonsoh> let's wait 30 secs
15:01:36 <slaweq> ok, 1..2..3.. :P
15:01:51 <ralonsoh> #topic RFEs
15:01:53 <ralonsoh> let's go
15:02:04 <ralonsoh> the first one
15:02:06 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1657089
15:02:07 <openstack> Launchpad bug 1657089 in neutron "[RFE]Add bandwidth_limit to vip" [Undecided,New]
15:02:19 <ralonsoh> a new one
15:02:25 <reedip> nice transition
15:02:36 <betherly> o/
15:02:50 <ralonsoh> not assigned, but should be in the whislist
15:03:07 <ralonsoh> I mean, there are other features to be implemented in QoS
15:03:12 <ralonsoh> for example, QoS on FIP
15:03:32 <ralonsoh> I'll ping ajo to set this to low priority
15:03:47 <ralonsoh> next one
15:03:49 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1505627
15:03:49 <openstack> Launchpad bug 1505627 in neutron "[RFE] QoS Explicit Congestion Notification (ECN) Support" [Wishlist,Incomplete] - Assigned to Reedip (reedip-banerjee)
15:03:52 <ralonsoh> reedip?
15:04:22 <ajo> hi ralonsoh , betherly , slaweq , reedip  :) o/ (sorry to be late)
15:04:29 <ralonsoh> ajo: np!
15:04:30 <davidsha> np
15:04:36 <ralonsoh> reedip: any update on this one?
15:04:37 <slaweq> hello ajo
15:04:39 <reedip> ralonsoh : awaiting review on the etherpad from you guys. I have created the environment, would be testing for qrouter and update you with the results soon
15:04:50 <ralonsoh> perfect!
15:05:12 <ralonsoh> as soon as you have patches, ping us to review them
15:05:42 <davidsha> reedip: this is the etherpad right? https://etherpad.openstack.org/p/QoS_ECN
15:05:47 <reedip> ralonsoh : ok, I will draft the spec now, I guess it would be better to get it in for now... else it would always be in the nascent stage
15:05:53 <reedip> davidsha  yeah
15:06:06 <ralonsoh> reedip: ok, yes
15:06:09 <davidsha> reedip: cool.
15:06:25 <ralonsoh> reedip: I need to take a second look and make some comments
15:06:54 <ralonsoh> next one
15:06:56 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1596611
15:06:56 <openstack> Launchpad bug 1596611 in neutron "[RFE] Create L3 IPs with qos (rate limit)" [Wishlist,In progress] - Assigned to LIU Yulong (dragon889)
15:07:16 <ralonsoh> my main concern with this one: to make it compatible with current qos implementation
15:07:28 <ralonsoh> the spec in under review
15:07:56 <ralonsoh> one sec
15:08:19 <ralonsoh> I don't find the spec now
15:08:56 <davidsha> https://review.openstack.org/#/c/374506/
15:08:59 <ralonsoh> #link https://review.openstack.org/#/c/374506/
15:09:03 <ralonsoh> Yes, thanks
15:09:25 <ralonsoh> is LIU here?
15:09:47 <davidsha> Is dragon889 his irc?
15:09:55 <ralonsoh> I don't know....
15:10:33 <ralonsoh> OK, please continue with the reviews. I'll try to ping him
15:10:54 <ralonsoh> next one
15:10:57 <ralonsoh> https://bugs.launchpad.net/neutron/+bug/1639220
15:10:57 <openstack> Launchpad bug 1639220 in neutron "[RFE] Introduce Network QoS policy "is_default" behaviour" [Low,In progress] - Assigned to Rodolfo Alonso (rodolfo-alonso-hernandez)
15:11:16 <ralonsoh> ajo: I need you to answer to Ihar and me
15:11:26 <ralonsoh> in launchpad
15:11:39 <ajo> oh, let me check
15:11:44 <ralonsoh> thanks
15:12:19 <ralonsoh> ok, let's move to bugs
15:12:25 <ralonsoh> #topic Bugs
15:12:38 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1669430
15:12:38 <openstack> Launchpad bug 1669430 in neutron "Deprecation warning in Neutron QoSDSCPMarkingRule functional tests" [Low,In progress]
15:12:42 <ajo> I'll answer on LP I need to think :D
15:12:52 <ralonsoh> ajo: np, and thanks!
15:13:22 <ralonsoh> this bug should be closed because is addressed by https://review.openstack.org/#/c/438148
15:13:29 <ralonsoh> as soon as the patch is merged
15:13:53 <ralonsoh> actually, I don't think this is a QoS problem
15:14:01 <reedip> ralonsoh : -1 Add related bug or partially closes :)
15:14:25 <ralonsoh> ok, but we should remove qos tag
15:14:28 <ralonsoh> is not related
15:14:58 <davidsha> ralonsoh: Sorry, saw it in a functional test for a patch I was reviewing!
15:15:13 <reedip> ralonsoh : if this bug is being closed by the above patch, some sort of indication needs to be given, isnt it
15:15:36 <ralonsoh> reedip: you are right
15:15:43 <ralonsoh> davidsha: can you take this one?
15:16:19 <davidsha> ralonsoh: Sure.
15:16:19 <ralonsoh> davidsha: just follow it properly
15:16:22 <ralonsoh> perfect
15:16:37 <ralonsoh> next one
15:16:42 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1667138
15:16:42 <openstack> Launchpad bug 1667138 in neutron "Minumum bandwidth can be higher than maximum bandwidth limit in same QoS policy" [Medium,In progress] - Assigned to Reedip (reedip-banerjee)
15:16:56 <ralonsoh> reedip: how is going?
15:16:59 <reedip> aah , I will push this patch in another hour....
15:17:02 <reedip> test cases pending
15:17:13 <slaweq> for me it looks fine now
15:17:22 <slaweq> but needs tests still
15:17:31 <reedip> yeah slaweq :)
15:17:38 <ralonsoh> https://review.openstack.org/#/c/442375/: we will follow the patch
15:17:54 <ralonsoh> reedip: thank you for taking care of it
15:18:10 <ralonsoh> next one
15:18:16 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1663908
15:18:16 <openstack> Launchpad bug 1663908 in neutron "Qos rules not cleaned by L2 agent" [Undecided,New] - Assigned to David Shaughnessy (david-shaughnessy)
15:18:16 <reedip> ralonsoh : naah , just doing my job
15:18:30 <ralonsoh> davidsha: how is going?
15:19:21 <davidsha> ralonsoh: I was looking into it, wanted to ask slaweq a few question. I'll follow up after the meeting
15:19:32 <slaweq> davidsha: ok, no problem :)
15:19:46 <ralonsoh> perfect, and thanks
15:19:52 <ralonsoh> next one
15:19:59 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1662109
15:19:59 <openstack> Launchpad bug 1662109 in neutron "tempest scenario test_qos fails intermittently" [High,Confirmed] - Assigned to Miguel Angel Ajo (mangelajo)
15:20:11 <ralonsoh> this one is problematic...
15:20:15 <ajo> yup it is
15:20:21 <ajo> the test is disabled
15:20:42 <ralonsoh> yes... and there is no solution or clue about the problem?
15:20:43 <ajo> as far as I could understand, the issue we have is that somehow, the agent doesn't realize that a port has been updated to have a policy
15:20:59 <ajo> either because the notification about port update doesn't arrive under some condition
15:21:07 <ajo> or because it talks back to neutron, and the policy isn't there?
15:21:15 <ajo> I couldn't identify the exact root cause
15:21:16 <ajo> but
15:21:39 <ajo> I could see how the policy was created, and attached to port
15:21:42 <ajo> and agent never sees the port being updated with the policy
15:21:45 <ajo> hance, the rule is not applied
15:22:00 <ralonsoh> a rpc problem?
15:22:02 <ajo> I should probably unassign the bug from myself if anybody else has bw to look at it
15:22:14 <ajo> there were changes recently on the ML2 plugin
15:22:16 <ajo> for port_updates
15:22:18 <ajo> and notifications
15:22:22 <ajo> may be it's related to that
15:22:38 <ajo> basically, we check wether the policy_id changed, and hence trigger the update
15:22:41 <ajo> let me grab a link
15:22:59 <ralonsoh> ok
15:23:39 <ajo> https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L1207
15:23:44 <ajo> just look for qos_policy_id in that file, same thing for network policies
15:24:51 <ralonsoh> now I don't have time to take a look at this bug
15:24:53 <ralonsoh> bt
15:24:56 <ralonsoh> but
15:25:20 <ralonsoh> in two weeks I'll have more time
15:25:33 <ralonsoh> ajo: so if you need help, ping me
15:25:50 <ralonsoh> ok, next one
15:25:54 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1659265
15:25:54 <openstack> Launchpad bug 1659265 in neutron "Network level QoS policies should apply to network:router_gateway" [Wishlist,In progress] - Assigned to Maxime (maxime-guyot-p)
15:26:02 <ralonsoh> this one is under review
15:26:12 <ralonsoh> IMO, the logic implemented is not correct
15:26:21 <ralonsoh> one sec
15:26:40 <ralonsoh> https://review.openstack.org/#/c/425218/11/neutron/tests/unit/objects/qos/test_rule.py
15:27:00 <ralonsoh> This logic allows a net qos policy to override a port qos policy
15:27:24 <ralonsoh> reviews to this patch are welcome
15:27:37 <slaweq> ralonsoh: I will check it today
15:27:42 <ralonsoh> thanks
15:27:53 <ralonsoh> next one
15:27:56 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1657381
15:27:56 <openstack> Launchpad bug 1657381 in neutron "QoS drivers need to implement a precommit for the actions" [Medium,In progress] - Assigned to Miguel Angel Ajo (mangelajo)
15:28:03 <ralonsoh> ajo restarted this one
15:28:10 <ajo> right
15:28:18 <ajo> I had a talk on summit with the ODL people
15:28:36 <ajo> and they explained me that they had some synchronization constraints in the way the implement things
15:28:41 <ajo> and they don't need to stop a transaction
15:28:53 <ajo> but need a log entry in their journal before DB change is commited
15:29:15 <ajo> I can't remember all the details now, but it made sense at that time :]
15:29:40 <ajo> manjeets could probably explain it again if necessary
15:29:45 <ralonsoh> perfect: now all extensions will have the qos service extended with this new events
15:29:46 <ajo> btw, I need to leave, I'll read the log later
15:29:49 <reedip> ajo : its basically how the newtorking-odl's v2 driver is created
15:29:53 <ralonsoh> see you!
15:30:00 <ajo> thank you folks
15:30:00 <reedip> it needs both pre-commit and post-commit behavior
15:30:10 <davidsha> thanks, see ya
15:30:20 <ralonsoh> now ajo needs to write the tests in this patch
15:30:38 <ralonsoh> ok, last one
15:30:44 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1649503
15:30:44 <openstack> Launchpad bug 1649503 in neutron "Mechanism driver can't be notified with updated network" [High,In progress] - Assigned to Hong Hui Xiao (xiaohhui)
15:31:10 <ralonsoh> it has high importance
15:31:17 <ralonsoh> and it's stopped
15:31:34 <ralonsoh> today i'll ping the author. If there is no answer, I'll take this one
15:31:45 <ralonsoh> or anyone here, of course
15:31:47 <slaweq> it's waiting for kevinbenton opinion AFAIR
15:31:56 <ralonsoh> no no
15:32:05 <ralonsoh> look at this: https://review.openstack.org/#/c/410101/
15:32:24 <slaweq> ralonsoh: yes, and there is comment from armax
15:32:32 <ralonsoh> and there is no activity in launchpad
15:32:39 <slaweq> that maybe kevinbenton has a better suggestion
15:32:40 <slaweq> :)
15:33:19 <ralonsoh> I'll try to re-activate this patch and, eventually, I'll take care of it
15:33:27 <slaweq> k
15:33:37 <ralonsoh> if you don't mind, of course
15:33:42 <slaweq> me, no :)
15:33:47 <ralonsoh> hehehe
15:33:54 <ralonsoh> ok, next topic
15:33:57 <ralonsoh> sorry
15:34:03 <ralonsoh> any other hidden bug?
15:34:08 <slaweq> bugs no
15:34:19 <slaweq> but I think You forgot earlier about https://bugs.launchpad.net/neutron/+bug/1586056
15:34:19 <openstack> Launchpad bug 1586056 in neutron "[RFE] Improved validation mechanism for QoS rules with port types" [Wishlist,In progress] - Assigned to Slawek Kaplonski (slaweq)
15:34:21 <slaweq> :)
15:34:24 <slaweq> or I missed it
15:34:25 <ralonsoh> yes!!
15:34:27 <ralonsoh> no no
15:34:30 <ralonsoh> you are right
15:34:39 <slaweq> so patch is there https://review.openstack.org/#/c/426946/ and waiting for review
15:34:51 <slaweq> I will address ralonsoh comments today
15:34:56 <ralonsoh> perfect!
15:35:10 <ralonsoh> I think this patch is going fast and very well
15:35:12 <slaweq> there is one strange thing with fullstack tests
15:35:18 <ralonsoh> buy reviews are always welcome
15:35:27 <ralonsoh> s/buy/but/
15:35:43 <slaweq> yes :)
15:35:51 <slaweq> some of tests are failing but I'm not sure how it can be related to this patch
15:36:06 <ralonsoh> slaweq: ping ajo to review it
15:36:16 <slaweq> also, ralonsoh, please double check if supported rules and attributes are properly set
15:36:37 <ralonsoh> slaweq: ?
15:36:46 <slaweq> because e.g for linuxbridge driver https://review.openstack.org/#/c/426946/13/neutron/services/qos/drivers/linuxbridge/driver.py there was MINIMUM BANDWIDT LIMIT RULE
15:37:01 <slaweq> but I'm not sure if it's really supported currently
15:37:08 <ralonsoh> no, it's not
15:37:21 <slaweq> that's what I thougt but I wasn't sure
15:37:21 <slaweq> thx
15:37:28 <ralonsoh> sriov: max, min
15:37:34 <ralonsoh> ovs: max, dscp
15:37:41 <ralonsoh> lb: max, dscp
15:37:50 <slaweq> ok, so I have it like that
15:37:52 <slaweq> thx ralonsoh
15:38:06 <ralonsoh> ok, next topic!
15:38:07 <ralonsoh> #topic Other Changes
15:38:12 <ralonsoh> There is no agenda...
15:38:17 <ralonsoh> any suggestion?
15:38:33 <betherly> im in process of developing qos panel in horizon
15:38:59 <betherly> ajo has been awesome at helping me know what information you will want in the panel and so far i have a basic view available
15:39:03 <ralonsoh> betherly: yes, I put this in open discussion
15:39:16 <betherly> ralonsoh: ah sorry!
15:39:19 <ralonsoh> betherly: no!
15:39:21 <davidsha> betherly: Have you a link to the patch?
15:39:23 <ralonsoh> doesn't matter
15:39:25 <betherly> https://review.openstack.org/#/c/418828/
15:39:28 <ralonsoh> perfect!
15:39:29 <davidsha> Thanks!
15:39:50 <betherly> no actions currently available but its getting there bit by bit
15:40:05 <ralonsoh> I'm not an expert in horizon, but I'll take a look at it
15:40:13 <betherly> ralonsoh: awesome thanks :)
15:40:20 <ralonsoh> I'll add this patch to our meetings
15:40:42 <slaweq> I will look at it also
15:40:48 <ralonsoh> and if you have any problem, ping us
15:41:21 <ralonsoh> ok, last topic
15:41:22 <ralonsoh> #topic Open Discussion
15:41:26 <ralonsoh> Any other announcement??
15:41:42 <slaweq> FYI: I will have talk about QoS in Neutron on Openstack day in Poland
15:41:49 <davidsha> I should have a PoC for the common classifier up within the next hour or 2
15:41:50 <slaweq> it's next wednesday :)
15:42:03 <davidsha> slaweq: congrats and good luck!
15:42:03 <ralonsoh> slaweq: send the link!!
15:42:14 <slaweq> davidsha: thx
15:42:21 <slaweq> ralonsoh: link to what? slides?
15:42:39 <ralonsoh> slaweq: the youtube video hehehe
15:42:48 <slaweq> http://www.openstackday.pl/agenda/
15:43:01 <slaweq> ralonsoh: if it will be on Youtube I will send on next meeting :)
15:43:10 <ralonsoh> perfect!!!
15:43:25 <slaweq> but it will be probably in polish so You will not understand it :P
15:43:44 <reedip> good luck slaweq :)
15:43:51 <davidsha> slaweq: Half the fun is seeing what google translate will say you said :P
15:43:52 <ralonsoh> youtbe translator hehehe
15:43:55 <ralonsoh> good luck
15:43:57 <slaweq> thx reedip
15:44:04 <slaweq> :D
15:44:27 <ralonsoh> ok, guys, thank you very much!!
15:44:33 <reedip> davidsha : LOL
15:44:33 <ralonsoh> let's finish
15:44:39 <slaweq> ok
15:44:40 <slaweq> thx
15:44:47 <ralonsoh> #endmeeting