15:00:59 <slaweq> #startmeeting neutron_qos
15:01:00 <openstack> Meeting started Tue Oct  9 15:00:59 2018 UTC and is due to finish in 60 minutes.  The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:01:01 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:01:03 <openstack> The meeting name has been set to 'neutron_qos'
15:01:05 <njohnston> o/
15:01:06 <mlavalle> o/
15:01:07 <ralonsoh> hi
15:01:07 <slaweq> lets start next one :)
15:01:10 <hongbin> o/
15:01:12 <rubasov> o/
15:01:14 <lajoskatona> o/
15:01:21 <slaweq> welcome back ralonsoh!
15:01:27 <slaweq> and welcome all of You too :)
15:02:07 <slaweq> #topic RFEs
15:02:25 <slaweq> first one (as always) is:
15:02:28 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1560963
15:02:29 <openstack> Launchpad bug 1560963 in neutron "[RFE] Minimum bandwidth support (egress)" [Wishlist,In progress]
15:02:35 <slaweq> and there is still no any progress on that one
15:03:16 <slaweq> next on the list is:
15:03:17 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1727578
15:03:18 <openstack> Launchpad bug 1727578 in neutron "[RFE]Support apply qos policy in VPN service" [Wishlist,Triaged]
15:03:45 <mlavalle> I folowed up on this one
15:03:51 <slaweq> There was some update on patch but it's not WIP
15:03:57 <slaweq> patch #link https://review.openstack.org/#/c/558986/
15:04:03 <slaweq> thx mlavalle :)
15:04:07 <mlavalle> zhaobo is definitely going to continue working on it
15:04:34 <slaweq> that's very good :)
15:04:47 <mlavalle> he is currently working on a feature for Octavia
15:05:11 <mlavalle> but he is commited to finish this blueprint this cycle
15:05:31 <mlavalle> it is in his goals sheet with his employer
15:05:41 <mlavalle> which is also min ;-)
15:05:46 <mlavalle> mine^^^
15:05:49 <slaweq> great to hear that, thx mlavalle for update on this :)
15:06:05 <slaweq> and are You his manager maybe? :)
15:06:07 <mlavalle> let's just be a little patient over the next few weeks
15:06:17 <mlavalle> until he is done with his Octavia work
15:06:26 <mlavalle> I'm not his manager
15:06:33 <mlavalle> but I'm his techincal lead
15:06:45 <mlavalle> so, yes, I can influence
15:06:49 <slaweq> good, that also can help us ;)
15:07:13 <slaweq> thx for update, I will just keep mentioning this on our meetings to not forget about it :)
15:07:18 <mlavalle> sure
15:07:22 <mlavalle> np
15:08:25 <slaweq> ok, next one
15:08:28 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1757044
15:08:28 <openstack> Launchpad bug 1757044 in neutron "[RFE] neutron L3 router gateway IP QoS" [Wishlist,In progress] - Assigned to LIU Yulong (dragon889)
15:08:52 <slaweq> patches have good progress IMO, but I didn't review them yet recently:
15:08:55 <slaweq> #link https://review.openstack.org/#/c/424468/ - server side patch
15:09:01 <slaweq> #link https://review.openstack.org/#/c/568526/ - agent side patch
15:11:06 <slaweq> anyone wants to add something about this one maybe?
15:11:12 <slaweq> or can we move forward?
15:11:45 <mlavalle> let's move forward
15:11:55 <mlavalle> just review them when you have a chance
15:11:59 <slaweq> ok, next one
15:12:02 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1777627
15:12:02 <openstack> Launchpad bug 1777627 in neutron "RFE: QoS – rule's management (set,delete, show…) requires <qos-policy> parameter in addition to <rule-id>" [Wishlist,In progress] - Assigned to Miguel Lavalle (minsel)
15:12:04 * mlavalle looks at himself
15:12:08 <slaweq> it's Yours mlavalle :)
15:12:27 <mlavalle> I pushed the neutron-lib patch:
15:12:31 <mlavalle> https://review.openstack.org/#/c/608473/
15:12:47 <mlavalle> it is esentially in its final form
15:13:29 <mlavalle> but Michel Peterson left some comments about the position of the } in the resource attribute map
15:13:54 <mlavalle> I'll fix those later today and it will be good to go as far as I can tell
15:14:10 <slaweq> ok, added to my review queue then
15:14:29 <mlavalle> Next step for this week, is a patch with entry points for the qos plugin in Neutron
15:14:36 <ralonsoh> I'll review it today
15:14:38 <mlavalle> and that will wrap this RFE
15:15:16 <slaweq> but some neutron patch will be necessary also? or not?
15:15:33 <mlavalle> Yes, that's what I meant ^^^^
15:15:43 <slaweq> ahh, sorry
15:15:44 <mlavalle> about the patch for the QoS plugin
15:16:01 <slaweq> I missed one line somehow :)
15:16:08 <mlavalle> we need to retrieve the policy id
15:16:16 <mlavalle> and redirect the call to the current API
15:16:59 <slaweq> ok, so we should be good with this one soon, thx mlavalle :)
15:17:58 <slaweq> ok, moving one
15:18:05 <slaweq> *moving on
15:18:11 <slaweq> last rfe on the list:
15:18:14 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1578989
15:18:14 <openstack> Launchpad bug 1578989 in neutron "[RFE] Strict minimum bandwidth support (egress)" [Wishlist,In progress] - Assigned to Lajos Katona (lajos-katona)
15:18:31 <lajoskatona> Yes, we are on it
15:18:34 <slaweq> lajoskatona: rubasov any updates?
15:18:56 <lajoskatona> We try to move the neutron side patches one-by-one through the review
15:18:57 <rubasov> I was on vacation for more than a week so I'll let lajoskatona give an update
15:19:44 <lajoskatona> Actually I tried to fix the comments for the agent heartbeat patches, as those are at the bottom, so I feel that we have some progress
15:20:03 <slaweq> I was reviewing some of Your patches today
15:20:22 <lajoskatona> On the other side for the pathces which are not for rubasov's patches, I tried to do the same :-)
15:20:36 <lajoskatona> Thanks for everybody for the reviews
15:21:03 <lajoskatona> yeah, thanks I hope we are moving toward the final version with them
15:21:32 <lajoskatona> Otherwise we try to do some preparation for the Berlin summit demo, but with that not too much progress
15:21:47 <lajoskatona> That's all I think
15:21:59 <ralonsoh> good job, BTW
15:22:05 <slaweq> ok, thx for updates
15:22:07 <mlavalle> I'll review the series at some point this week
15:22:14 <slaweq> and thx a lot for all Your work on this
15:22:18 <lajoskatona> ralonsoh: thanks
15:22:22 <mlavalle> thanks for the update and the hard work
15:22:37 <lajoskatona> mlavalle: thanks
15:23:12 <slaweq> btw. lajoskatona, I'm now looking at api test results in https://review.openstack.org/#/c/584927/
15:23:39 <slaweq> and now I understand why You wanted this neutron patch to be depends on neutron-tempest-plugin patch
15:23:59 <slaweq> but I think that we don't need test test_rule_create_fail_for_direction_ingress at all now
15:24:23 <slaweq> as we will support creation of ingress min_bw_limit_rule now
15:24:37 <lajoskatona> slaweq: ok, so as tempest is branchless, I should skip that, or delete?
15:24:39 <slaweq> so maybe the easiest way would be to propose separate patch with removal of this tes
15:24:41 <slaweq> *test
15:24:53 <slaweq> and then all other should go smooth
15:24:57 <ralonsoh> agree
15:25:22 <slaweq> ahh, so You want to have it still running for stable branches
15:25:26 <lajoskatona> slaweq: then I create a patch for deleting the test, make the neutron patch depend on that and hope for the best?
15:26:01 <lajoskatona> slaweq:  I don't want, but now we run the same tempest, or not?
15:26:08 <slaweq> personally I think that this can be removed from tempest api tests
15:26:23 <lajoskatona> ok, I push a patch with the deletion
15:26:41 <slaweq> if we want to have it in stable branches, we can add it maybe to fullstack tests there - mlavalle what do You think about that?
15:27:29 <mlavalle> yesh, fullstack is a good approach
15:28:09 <lajoskatona> You mean to have fullstack test for it on stab;e branches?
15:28:50 <lajoskatona> I mean for this test: test_rule_create_fail_for_direction_ingress?
15:29:21 <slaweq> lajoskatona: yes, basically on master we don't need it as we would always skip it, so we can remove if from there and move to fullstack but only for stable branches where it should raise this expetion as it's now
15:29:53 <slaweq> so it would be 2 patches: 1 to remove this test from neutron_tempest_plugin and later patch with adding it to fullstack in stable/rocky
15:30:05 <slaweq> and then some cherry-picks to stable/queens and stable/pike also
15:30:14 <lajoskatona> slaweq: ok, I create a note for it for my tasklist :-)
15:30:24 <slaweq> lajoskatona: thx :)
15:30:34 <slaweq> I can help You with that if You want
15:31:01 <mlavalle> slaweq likes fullstack tests a lot
15:31:07 <lajoskatona> slaweq:thanks
15:31:13 <slaweq> mlavalle: LOL
15:31:22 <slaweq> especially debugging it :)
15:31:50 <slaweq> ok, lets move on
15:31:52 <slaweq> #topic Bugs
15:32:03 <slaweq> first one:
15:32:06 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1784006
15:32:06 <openstack> Launchpad bug 1784006 in neutron "Instances miss neutron QoS on their ports after unrescue and soft reboot" [Medium,Confirmed] - Assigned to Miguel Lavalle (minsel)
15:32:20 <slaweq> mlavalle: any updates?
15:32:35 <mlavalle> I didn't have to to work on this one
15:32:42 <mlavalle> time^^^^
15:32:50 <mlavalle> I'll try again this week
15:33:25 <slaweq> sure
15:33:55 <slaweq> next one:
15:33:58 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1779052
15:33:58 <openstack> Launchpad bug 1779052 in neutron "Quality of Service (QoS) in Neutron (documentation) - only different types rules can be combined in QoS policy" [Low,In progress] - Assigned to Slawek Kaplonski (slaweq)
15:34:06 <slaweq> there is patch https://review.openstack.org/#/c/581941/ still no any response from patch owner, I updated this PS today
15:34:57 <slaweq> next one
15:35:00 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1776160
15:35:01 <openstack> Launchpad bug 1776160 in neutron "'burst' does not take effect for neutron egress qos bindlimit by ovs" [Undecided,New]
15:35:11 <slaweq> I wanted to check it but I still didn't have time
15:35:28 <slaweq> if someone wants to play with it, feel free :)
15:36:23 <slaweq> and the last one on my list:
15:36:26 <slaweq> #link https://bugs.launchpad.net/neutron/+bug/1785189
15:36:26 <openstack> Launchpad bug 1785189 in neutron "Floatingip and router bandwidth speed limit failure" [Undecided,In progress] - Assigned to Brian Haley (brian-haley)
15:36:29 <slaweq> Patch is proposed: https://review.openstack.org/#/c/596637/
15:37:32 <mlavalle> There is a comment from liuyulong that has been unaddressed for several weeks now
15:37:33 <slaweq> have one +2 but also some -1 - there are some questions with no answers there, I think we can review it and wait few more weeks for update from owner of patch
15:37:50 <liuyulong> yep
15:39:29 <slaweq> and that's all from my side
15:39:41 <slaweq> do You have anything else You want to talk?
15:39:45 <liuyulong> Give me one minute, thanks.
15:39:50 <slaweq> #topic Open Discussion
15:39:57 <slaweq> sure liuyulong, go on :)
15:39:58 <liuyulong> It's bout the port forwarding floating IP QoS.
15:40:21 <liuyulong> Since the port_forwarding l3 agent extension handle it's own floating IPs, I think we can add these IPs to L3 (fip_qos) QoS extension procedure.
15:41:28 <slaweq> it sounds like new RFE for me :)
15:41:46 <liuyulong> I'll add a LP bug for it.
15:41:50 <mlavalle> ok
15:41:55 <mlavalle> we can review it soon
15:42:43 <liuyulong> Let all floating IPs can be limited under the QoS policy.
15:43:11 <liuyulong> Thanks
15:43:30 <slaweq> ok, let's create lp bug for that and discuss there
15:43:37 <slaweq> thx for bringing this up liuyulong :)
15:44:03 <liuyulong> slaweq, you are welcome. : )
15:44:21 <slaweq> ok, anything else?
15:44:27 <mlavalle> not from me
15:44:35 <slaweq> if not, I will give You back about 15 minutes :)
15:44:35 <liuyulong> no from me
15:45:04 <lajoskatona> bye
15:45:06 <slaweq> ok, so thx for attending
15:45:10 <slaweq> #endmeeting