14:11:48 <ihrachys> #startmeeting neutron_upgrades
14:11:48 <openstack> Meeting started Thu Sep 21 14:11:48 2017 UTC and is due to finish in 60 minutes.  The chair is ihrachys. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:11:49 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:11:52 <openstack> The meeting name has been set to 'neutron_upgrades'
14:12:12 <ihrachys> no action items so we dive straight into
14:12:13 <ihrachys> #topic OVO patches
14:12:21 <ihrachys> https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db
14:12:41 <ihrachys> first is port ovo, part 2: https://review.openstack.org/#/c/506037/
14:12:49 <ihrachys> lujinluo, was there part 1?
14:13:06 <lujinluo> ihrachys: the really small piece meal thing
14:13:42 <lujinluo> ihrachys: this part 2 still needs some work
14:13:47 <ihrachys> ok
14:13:58 <ihrachys> https://review.openstack.org/#/c/501190/ "Integration of L3HARouterAgentPortBinding in ml2/drivers/l2pop/db.py"
14:14:38 <TuanVu> there's a concern from Luo
14:15:00 <TuanVu> we'll change the name the new function
14:15:09 <ihrachys> ok
14:15:25 <ihrachys> I also see Garry's comment but I don't think it's valid
14:15:44 <lujinluo> +1
14:15:47 <TuanVu> I think so
14:16:00 <ihrachys> https://review.openstack.org/#/c/504337/ " Use Network OVO in db_base_plugin_common "
14:16:01 <TuanVu> +1
14:16:20 <TuanVu> we're still working on it
14:16:24 <ihrachys> ok
14:16:36 <ihrachys> https://review.openstack.org/#/c/321001/ "WIP objects: get, update and delete converted to Subnet OVO usage"
14:16:47 <ihrachys> slaweq started looking at that on
14:16:48 <ihrachys> *one
14:16:58 <ihrachys> he said he will help with OVO transition this cycle
14:17:07 <lujinluo> great!
14:17:21 <ihrachys> by the looks of it, the patch still needs a lot of work
14:17:43 <ihrachys> https://review.openstack.org/#/c/466237/ " Change join relationship between routerport and router "
14:17:58 <ihrachys> we had tracebacks in the past, gotta check if they are no longer
14:19:04 <ihrachys> I don't see anything suspicious in q-svc log in full job, so that's good
14:20:18 <ihrachys> I will have a closer look later
14:20:24 <ihrachys> but seems like they are gone
14:20:30 <lujinluo> thanks! i will also ask Kevin for another eye on it too, if he has time
14:20:31 <ihrachys> this is needed for router ovo
14:20:43 <lujinluo> yeah
14:21:16 <ihrachys> lujinluo, you better hurry then since he is moving to another project ;)
14:21:33 <lujinluo> ihrachys: ahhhh, i will
14:21:53 <lujinluo> btw, do you know which proj that would be?
14:22:04 <ihrachys> lujinluo, something outside openstack
14:22:12 <ihrachys> internal ibm projec
14:22:15 <lujinluo> i see.. so sad
14:22:15 <ihrachys> *project
14:22:18 <ihrachys> yeah
14:22:40 <ihrachys> he may stick around, but won't do neutron fulltime
14:23:05 <lujinluo> i see. please stay with us, Ihar!
14:23:07 <ihrachys> next are agent OVO patches: https://review.openstack.org/495810 and https://review.openstack.org/501925
14:23:10 <ihrachys> both in conflict
14:23:55 <TuanVu> for 495810, I'll solve to conflict tomorrow
14:24:14 <TuanVu> it is expected to be fixed soon
14:24:20 <ihrachys> ok cool
14:24:35 <ihrachys> https://review.openstack.org/#/c/396351/ "Integration of Floating IP OVO"
14:24:42 <TuanVu> about 501925, there's only 1 unit test failed
14:24:48 <TuanVu> please wait
14:25:00 <ihrachys> TuanVu, ok, go on
14:25:06 <annp> http://logs.openstack.org/25/501925/2/check/gate-neutron-python27-ubuntu-xenial/b8ad6db/testr_results.html.gz
14:25:10 <lujinluo> Floating IP is ready for review
14:25:12 <TuanVu> it would be great if we could have your recommendation for current failed test
14:25:27 <annp> there are 4 unit test failed
14:25:49 <TuanVu> yeah, sorry, 4 tests failed
14:26:28 <annp> We'd like to know order of expected and actual result is important or not?
14:27:09 <annp> ihrachys, Could take your eye to result of these unittest?
14:27:32 <ihrachys> looking
14:27:32 <lujinluo> do you mean something like assertEqual(actual, expect) and assertEqual(expect, actual)?
14:27:50 <ihrachys> lujinluo, more like assertEqual -> assertItemsEqual
14:28:06 <ihrachys> that would fix the failure but we need to look at whether order is meaningful for the method
14:29:12 <annp> ihrachys, lujinluo, got it.
14:29:19 <ihrachys> that's probably a question to l3 subteam
14:30:21 <ihrachys> I asked in the neutron channel
14:30:49 <annp> ihrachys, thanks a lot. :)
14:31:12 <ihrachys> ok, back to fip OVO: https://review.openstack.org/#/c/396351/
14:31:18 <ihrachys> so it's ready for review
14:31:22 <lujinluo> yes
14:31:48 <annp> please go ahead
14:32:25 <ihrachys> ok I will have a look after. I assume it doesn't depend on the router relationship patch
14:32:56 <ihrachys> other patches in the query are old and in conflicts
14:33:11 <ihrachys> we will need to respin to later codebase before discussing them
14:33:19 <lujinluo> no, it does not
14:34:12 <ihrachys> #topic Open discussion
14:34:30 <ihrachys> as I said, slaweq volunteered to help with some OVO patches, starting from subnet
14:35:03 <lujinluo> huge thanks!
14:35:31 <ihrachys> he I believe will also have +2 in the tree in the future and will be able to help us with merging. which is esp. important because kevin leaves.
14:35:57 <lujinluo> yeah...
14:36:08 <ihrachys> I don't have anything else to discuss
14:36:13 <ihrachys> you?
14:36:21 <lujinluo> none from me either
14:36:28 <ihrachys> annp, TuanVu ?
14:36:29 <TuanVu> me either
14:36:37 <annp> me too
14:36:47 <ihrachys> ok thanks for joining and sorry for late start
14:36:49 <ihrachys> cheers
14:36:51 <ihrachys> #endmeeting