14:00:16 <lujinluo> #startmeeting neutron_upgrades
14:00:20 <openstack> Meeting started Thu Apr 12 14:00:16 2018 UTC and is due to finish in 60 minutes.  The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:21 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:24 <openstack> The meeting name has been set to 'neutron_upgrades'
14:00:27 <mlavalle> o/
14:00:31 <lujinluo> o/
14:01:04 <ihrachys> o/
14:01:32 <lujinluo> We do not have any action items from last week. So let's jump into all the patches now
14:02:10 <lujinluo> First of all, the two engine facade related patches have been updated https://review.openstack.org/#/c/556667/ and https://review.openstack.org/#/c/553617/
14:02:34 <ihrachys> yeah took a while to get them where they are. they are green now in CI except for requirements issue.
14:02:54 <ihrachys> I need to understand how to bump sqlalchemy version properly in the new world of no requirements synced / lower-constraints job
14:03:05 <ihrachys> that's why we see https://review.openstack.org/#/c/556667/ failing
14:03:18 <ihrachys> code wise, it should be ready to go so reviews are very welcome
14:03:24 <lujinluo> is this failure due to requirement? ihrachys
14:03:27 <lujinluo> http://logs.openstack.org/17/553617/11/check/openstack-tox-lower-constraints/c2fe504/testr_results.html.gz
14:03:40 * mlavalle has both patchsets in his review pile
14:04:32 <ihrachys> lujinluo, oh. I haven't digged into the specific failure for the latest patch set. it seems like something more than just version bump gone awry.
14:04:59 <ihrachys> maybe sqlalchemy 1.1.0 is still old / buggy for what I try to do. note that unit tests with 1.2.* pass fine. I will have a look
14:05:32 <ihrachys> I should tackle that today, shouldn't be too hard.
14:05:43 <lujinluo> thanks! but besides that, I think the codes are ready to go
14:05:56 <mlavalle> so we should exepect a follow up revision, right?
14:05:58 <ihrachys> I also think that since it's ready / almost ready to go, folks can rebase their OVO adoption patches on top to start testing it
14:06:21 <ihrachys> mlavalle, yes, I assume. I should look closer to make sure but looks like it
14:06:22 <TuanVu> yes
14:06:30 <lujinluo> ihrachys: yes, I think TuanVu and hungpv_ are already rebasing it locally
14:06:38 <ihrachys> great
14:06:43 <ihrachys> sorry it took so long :)
14:06:44 <TuanVu> I’ve rebased my patch on Ihar’s 2 patches.
14:06:44 <TuanVu> However I haven’t had a chance to run the test yet.
14:06:44 <TuanVu> I’ll try it tomorrow and update the result on Gerrit.
14:07:02 <hungpv_> Yeah me too
14:07:06 <TuanVu> Thanks for your great work, Ihar :)
14:07:08 <lujinluo> awesome
14:07:17 <lujinluo> #topic OVO
14:07:26 <lujinluo> https://review.openstack.org/#/q/topic:bp/adopt-oslo-versioned-objects-for-db+status:open
14:07:40 <lujinluo> we have one new patch of segment pushed by hongbin
14:07:48 <lujinluo> https://review.openstack.org/#/c/559414
14:08:47 <lujinluo> I think the changes are fine, except it also contains potential mixing of old and new engine facade in https://review.openstack.org/#/c/559414/3/neutron/services/segments/plugin.py@110 so we may need to wait for the above 2 patches get merged first
14:09:03 <ihrachys> looks like a no brainer, I will review. yes we should wait / rebase
14:09:32 <lujinluo> thanks!
14:09:43 <lujinluo> next is simple test refactor https://review.openstack.org/#/c/559652/
14:10:37 <TuanVu> it got +2 from Slawek and +1 from Luo
14:10:39 <ihrachys> +W
14:10:47 <lujinluo> \o/
14:11:03 <TuanVu> thank you, Ihar :)
14:11:20 <lujinluo> Then the rest are all pending patches
14:12:09 <ihrachys> pending as in 'wait for respin'?
14:12:28 <lujinluo> yes, we need to rebase them upon your patches
14:12:51 <lujinluo> they are all affected by the new engine facade
14:13:05 <ihrachys> ok
14:15:09 <lujinluo> Also previously we had discussions about the two RFE proposed by boden https://review.openstack.org/#/c/509564/ and https://review.openstack.org/#/c/473531/. A reminder that those two RFEs have been updated, and if people are available, please review
14:16:03 <lujinluo> #topic open discussion
14:16:22 <ihrachys> I am good with both, just didn't feel like +Wing them
14:17:09 <ihrachys> ftr I don't have anything for open floor
14:17:09 <lujinluo> And I need to read them again ( the reminder is also for me, LOL)
14:17:20 <mlavalle> ihrachys: I'll wait until early next week. if we don't get more feedback, I'll merge them
14:17:46 <mlavalle> I would like lujinluo to look at them
14:18:11 <lujinluo> Yes, I will. Added to my to-do list
14:18:24 <mlavalle> Thanks!
14:18:32 <lujinluo> As per my employer's request, TuanVu, hungpv_ and I have taken some of the remaining tasks in https://docs.google.com/spreadsheets/d/1Mz7V40GSdcUH_aBoNWjsFaNRp4wf-duz1GFWligiNXc/edit#gid=1051788848
14:19:14 <lujinluo> We will try to cover them all eventually. But that is the how it looks currently
14:19:38 <mlavalle> ahhh, nice!
14:19:45 <ihrachys> lujinluo, that's great
14:20:02 <lujinluo> Of course, if anyone is interested to help, we will give you open arms!
14:20:12 <mlavalle> would it be helpful if we advertise this spresdsheet during the weekly Neutron meeting?
14:20:28 <lujinluo> Yeah! That would be appreciated!
14:20:47 <mlavalle> ok, we have kind of a point in the agenda already
14:20:56 <lujinluo> thanks
14:21:08 <mlavalle> I will fix it a little bit and we will cover it every week
14:21:30 <mlavalle> this way we have visibility with a larger audience
14:21:37 <lujinluo> great!
14:22:21 <lujinluo> OK. That is all the topics I have for today. If anyone has anything else, please shoot
14:22:38 <mlavalle> I'm good
14:23:04 <ihrachys> me good
14:23:17 <lujinluo> how about TuanVu and hungpv_ ?
14:23:33 <hungpv_> None from me
14:24:19 <TuanVu> None from me
14:24:26 <lujinluo> OK then. Let's call it a day and see you guys next week :)
14:24:47 <TuanVu> thank you guys, see you guys next week :)
14:25:20 <lujinluo> #endsmeeting
14:25:32 <mlavalle> o/
14:25:33 <lujinluo> oops wrong commands again?!
14:25:38 <lujinluo> #endmeeting