14:01:34 <njohnston> #startmeeting neutron_upgrades
14:01:35 <openstack> Meeting started Thu Jul  5 14:01:34 2018 UTC and is due to finish in 60 minutes.  The chair is njohnston. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:36 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:01:38 <openstack> The meeting name has been set to 'neutron_upgrades'
14:01:58 <njohnston> Hello all
14:02:03 <TuanVu> Hi Nate :)
14:02:23 <njohnston> Unfortunately lujinluo has been called away on urgent family business.  We wish her the best!
14:02:44 <TuanVu> oh, thanks for the notice, Nate
14:03:08 <njohnston> She asked me to take care of the meeting this week and, if I remember correctly, next as well.
14:04:13 <TuanVu> oh, what a bad news
14:04:23 <njohnston> The action items from last week are both ones for her, so let's skip them for now and perhaps we can address them in due course.
14:04:26 <TuanVu> hopefully she'll come back soon
14:04:34 <njohnston> #topic OVO
14:04:51 <njohnston> #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db
14:05:20 <njohnston> I have a few up this week, starting with
14:05:24 <njohnston> #link https://review.openstack.org/579053
14:06:13 <njohnston> I need to look at the testing more clearly and figure out why tests are failing.
14:06:25 <njohnston> I will have an update on that later today
14:06:43 <TuanVu> thanks
14:06:50 <njohnston> #link https://review.openstack.org/579678
14:07:29 <TuanVu> I've just left a comment on that one
14:07:57 <TuanVu> It'll be merged soon, I think
14:08:12 <njohnston> I saw your comment, TuanVu, and that makes me scratch my head because I put it back.  I'll do it again, the right way this time. :-)
14:08:22 <njohnston> thanks for your reviews
14:08:23 <TuanVu> awesome :)
14:08:38 <njohnston> next is one of yours
14:08:54 <njohnston> sorry, one of Van's
14:09:01 <njohnston> #link https://review.openstack.org/549168
14:09:54 <njohnston> This one has a long history
14:10:33 <njohnston> but it seems to be failing everything except pep8 and sphinx docs
14:10:53 <hungpv> yes, i've tried to reduce the failed casasse
14:11:08 <njohnston> then you have looked at it more than I have :-)
14:11:13 <njohnston> what did you see?
14:11:52 <hungpv> one off common problem
14:12:24 <hungpv> I encountered for those UTs
14:13:00 <hungpv> is something like "    router['router']['id'], KeyError: 'router'
14:13:18 <hungpv> i'm still wrap my head around it
14:13:30 <hungpv> can you give a suggestion
14:14:11 <hungpv> i feel that some OVO code I've converted incorrectly
14:14:28 <hungpv> but haven't figured out it
14:14:48 <njohnston> Hmm, it strikes me as odd that a router would have a field called 'router'.  Why would the object be built to nest router information like that?
14:15:57 <njohnston> ok, we can continue the discussion in gerrit
14:16:05 <hungpv> ok cool
14:16:17 <hungpv> thank you nate
14:16:39 <njohnston> #link https://review.openstack.org/579689
14:17:04 <njohnston> This is one of mine; I just asked for a recheck
14:17:24 <TuanVu> it looks great
14:17:39 <TuanVu> there's only 1 failed fullstack test remaining
14:18:00 <njohnston> I added a note on this to the tracking spreadsheet as well, like 62: This partially covers the needed work.  But we need to talk about db/provisioning_blocks.py, because models are being passed to functions there as arguments.
14:18:05 <TuanVu> the recheck will solve it, I think
14:18:42 <TuanVu> yeah, I see
14:19:21 <njohnston> So the method being called from test_provisioning_blocks.py is add_model_for_resource: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/provisioning_blocks.py#n36
14:19:39 <njohnston> that takes a db model and maps it to a callback resource
14:20:20 <hungpv> looks very good
14:21:07 <njohnston> So I think provisioning_blocks.py will be one of the last things converted; it is noted so in the spreadsheet (line 128 in one of lujinluo's sections)
14:21:22 <njohnston> but I wanted to discuss it with you just to be transparent
14:21:52 <TuanVu> thanks for this info, Nate
14:22:09 <njohnston> next up is TuanVu with
14:22:15 <njohnston> #link https://review.openstack.org/507772
14:22:33 <TuanVu> I’ll need to spend more time on it to figure out how to build the compatibility layer
14:22:33 <TuanVu> I’ll upload a new patch set soon
14:23:28 <njohnston> Do you know what it is that vmware-nsx is using?
14:25:35 <TuanVu> other than what have been mentioned by boden, I haven't covered all of them yet
14:27:37 <njohnston> I don't have anything else to add on this topic, moving on
14:27:55 <njohnston> #link https://review.openstack.org/579682
14:28:37 <njohnston> Thanks manjeets for the review; he suggested that I incorporate some additional model transitions I mad missed.  That is on my todo list for this week.
14:29:13 <njohnston> #link https://review.openstack.org/562489
14:29:21 <njohnston> TuanVu, tell us about this
14:29:40 <TuanVu> yeah
14:30:04 <TuanVu> As the discussion in last IRC meeting, in order to avoid blocking the delivery of OVO, I've moved joins to object and add corresponding TODO for it.
14:30:47 <TuanVu> If you have any other suggestions, please don't hesitate to let me know.
14:31:24 <njohnston> I just +1ed it, it looks good to me
14:31:41 <TuanVu> thank you, Nate
14:32:00 <TuanVu> so I'll apply the same solution for https://review.openstack.org/#/c/561834/
14:32:07 <njohnston> very good
14:33:17 <njohnston> #link https://review.openstack.org/565773
14:33:30 <njohnston> that says updated 6 days ago, but I don't see what updated
14:33:52 <njohnston> hopefully lajoskatona has completed the timeboxed assignment and can return to this
14:34:01 <njohnston> I will ask for a status update in gerrit
14:34:34 <TuanVu> ok, that's great
14:35:04 <njohnston> #link https://review.openstack.org/561834
14:35:17 <njohnston> TuanVu, tell us about this
14:35:43 <TuanVu> it's the same with Service Type patch which has just got +1 from you
14:35:55 <TuanVu> about doing "join queries"
14:36:47 <njohnston> indeed, I look forward to the new PS
14:37:09 <TuanVu> yeah, I will upload it tomorrow morning
14:38:06 <njohnston> The next few changes are from lujinluo, and are in merge conflict
14:38:24 <njohnston> so I think we should leave them until she can return
14:38:34 <TuanVu> ok
14:38:41 <TuanVu> I agree
14:39:56 <njohnston> I did want to circle back to one change from earlier
14:40:05 <njohnston> because it has an issue that I am not sure how to resolve
14:40:21 <njohnston> #link https://review.openstack.org/#/c/579053/ revisited
14:41:30 <njohnston> that code is failing the unit test neutron.tests.unit.ipam.test_subnet_alloc.TestSubnetAllocation.test_subnetpool_concurrent_allocation_exception
14:42:18 <TuanVu> I see
14:42:25 <njohnston> The code for that test is here: https://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/unit/ipam/test_subnet_alloc.py#n190
14:42:52 <njohnston> You can see that the test has the expectation that the db model will reject the addition with an ORM error
14:43:03 <njohnston> I am not sure how to best implement that in an OVO way
14:43:11 <njohnston> Does anyone have any thoughts?
14:45:30 <TuanVu> hmm, I have no experience with this so I have no idea at this moment. I'll put it on my check list tomorrow and send you feedback if there's any
14:45:33 <TuanVu> is that ok?
14:45:49 <njohnston> That would be wonderful
14:46:19 <njohnston> #topic Open Discussion
14:46:31 <njohnston> Does anyone have anything else they would like to discuss?
14:46:42 <TuanVu> one question about Rolling Upgrade
14:47:01 <TuanVu> for example from Queens to Rocky
14:47:32 <TuanVu> is that possible without current state of OVO?
14:47:46 <TuanVu> sorry
14:48:04 <TuanVu> I mean *is that possible with current state of OVO?*
14:49:27 <njohnston> I would not consider myself a deep expert on that yet, but I feel pretty safe in saying that it is probably not safe yet.
14:50:05 <njohnston> There are a few central changes that are waiting on everything to be converted to OVO, and then they can be done
14:50:11 <TuanVu> thank you Nate
14:50:27 <TuanVu> I ask this because we're about to do some tests for this
14:50:49 <njohnston> like line 68 on the spreadsheet in neutron/db/db_base_plugin_common.py
14:51:29 <njohnston> and the add_model_to_resource code in neutron/db/provisioning_blocks.py we discussed earlier
14:52:17 <TuanVu> thanks for giving your opinion on this matter
14:52:24 <TuanVu> I really appreciate it :)
14:52:54 <njohnston> i think it will be less bumpy than before, but the spreadsheet says we are only 26% done so I am afraid I can't give better news :-)
14:53:55 <njohnston> anything else?
14:53:56 <TuanVu> yeah, thank you Nate
14:54:01 <TuanVu> that's all from me
14:54:24 <njohnston> Thanks for everything TuanVu and hungpv_, look forward to chatting with you next week.
14:54:56 <hungpv_> thank you nate, sweee u
14:55:00 <TuanVu> see you soon Nate
14:55:04 <TuanVu> :)
14:55:39 <njohnston> #endmeeting