14:00:16 <lujinluo> #startmeeting neutron_upgrades
14:00:17 <openstack> Meeting started Thu Oct  4 14:00:16 2018 UTC and is due to finish in 60 minutes.  The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:19 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:21 <openstack> The meeting name has been set to 'neutron_upgrades'
14:00:28 <lujinluo> o/
14:01:02 <TuanVu> Hi Luo-san :D
14:01:07 <TuanVu> nice to see you
14:01:19 <lujinluo> hi TuanVu!
14:01:26 <njohnston> o/
14:01:52 <lujinluo> ok, let's get started
14:01:57 <lujinluo> #topic OVO
14:02:34 <lujinluo> #link https://review.openstack.org/#/c/605365/ retry decorator in neutron-lib
14:03:35 <lujinluo> Michel addressed a point that after engine facade transform, we would always have a "context" as parameters, thus the lookup maybe unnecessary
14:04:09 <njohnston> yes, I read that, it is an interesting point
14:05:28 <lujinluo> yeah, but as we are still in the middle of the switch, i believe we still need the change
14:05:53 <lujinluo> and i happen to look up the old engine facade in Neutron yesterday, and this is the current status
14:05:56 <lujinluo> #link http://codesearch.openstack.org/?q=session.begin&i=nope&files=&repos=neutron
14:08:26 <njohnston> Do you think he would accept it if we put in a note that this would later be deprecated?
14:08:50 <njohnston> once the OVO transition is complete it will be rather moot in any event
14:08:59 <lujinluo> i think this is what we need to do
14:09:30 <njohnston> ok
14:11:00 <lujinluo> i will put a comment explaining that, and let's see if he would take it
14:11:09 <lujinluo> #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db
14:11:29 <lujinluo> #link https://review.openstack.org/#/c/544206/ Port Binding OVO
14:11:47 <lujinluo> manjeet put some comments last week and I have addressed them
14:12:03 <lujinluo> and I just found that there is another one coming from slawek
14:12:34 <lujinluo> oh, it is totally correct. i will address it very soon too
14:13:05 <annp> Hi
14:13:10 <annp> Sorry I'm late
14:13:15 <lujinluo> after that, please feel free to leave your comments
14:13:20 <lujinluo> hi annp, no worries
14:13:30 <TuanVu> Hi An-san :)
14:13:51 <lujinluo> next is #link https://review.openstack.org/#/c/602362/ retry decorators in Tag
14:14:07 <annp> Hi lujinluo, Tuanvc Thanks.
14:14:13 <annp> :-)
14:14:23 <lujinluo> at first, I thought the failures come from the mistake in commit message, but it turns out not..
14:14:39 <lujinluo> then i do not understand why it is failing almost all the tests
14:16:25 <lujinluo> i downloaded the patch locally to test it, and the error i met in pep 8 is that it obviously does not understand keyword "context_attr_name"
14:16:59 <lujinluo> njohnston: will you be available to have a look at it some time?
14:17:00 <njohnston> looking at the py35 tests it looks like the error is "RuntimeError: Could not find position of var context"
14:17:17 <njohnston> lujinluo: yes I will take a look
14:17:45 <lujinluo> yeah, i thought it was the dependency issue thus it could not locate the context
14:18:06 <lujinluo> but if the "Depend-On" grammar is correct, it should work
14:18:48 <njohnston> so delete_objects is defined as: def delete_objects(cls, context, ...
14:18:54 <njohnston> context is not a kwarg
14:19:31 <njohnston> but in tag_plugin.py it is being handled as a kwarg, not a positional parameter
14:19:34 <njohnston> tag_obj.Tag.delete_objects(
14:19:34 <njohnston> context=context,
14:19:34 <njohnston> standard_attr_id=res.standard_attr_id,
14:20:12 <lujinluo> oh, i see
14:20:45 <njohnston> so delete_objects would need to change to utilize context as a kwarg
14:21:46 <njohnston> I will comment in gerrit
14:22:15 <lujinluo> thanks!
14:22:54 <lujinluo> next #link https://review.openstack.org/#/c/602497/ L3HARouterAgentPortBinding in l3_hamode
14:23:35 <lujinluo> the codes are fine to me. it is a small change
14:24:04 <lujinluo> so when you are available, please review and comment
14:24:06 <njohnston> It's on my pile for today
14:24:16 <lujinluo> great!
14:24:47 <lujinluo> next #link https://review.openstack.org/#/c/507772/ network OVO
14:25:32 <TuanVu> There are new comments from Hongbin and Luo.
14:25:38 <TuanVu> Thanks for your feedback, Luo-san :)
14:25:42 <lujinluo> i have some concerns about NetworkRBAC
14:25:52 <TuanVu> yes, I see
14:25:52 <lujinluo> could you please have a look TuanVu?
14:25:57 <TuanVu> I was busy with other tasks and haven’t had time to address them yet
14:26:02 <TuanVu> However, I will work on these items tomorrow and next week
14:26:20 <lujinluo> perfect!
14:26:41 <TuanVu> thanks again for your help on this patch :D
14:26:58 <lujinluo> nope :)
14:27:09 <lujinluo> next #link https://review.openstack.org/#/c/549168/ router OVO
14:27:16 <annp> Hi
14:27:19 <lujinluo> i believe you are still working on it? annp
14:27:39 <annp> lujinluo, yes. I'm working on it
14:27:59 <annp> This week I don't have time for this due to internal task.
14:28:14 <annp> So I'm planing continue update this one in next week.
14:28:24 <annp> So sorry about that. :-)
14:28:35 <lujinluo> no problem! thanks!
14:29:34 <annp> lujinluo, thanks you too.
14:29:37 <lujinluo> the rest two patches are not updated and we may give them more time
14:29:44 <lujinluo> #topic engine facade
14:30:20 <lujinluo> #link https://review.openstack.org/#/q/topic:bp/enginefacade-switch+status:open
14:30:49 <lujinluo> as i mentioned earlier, i was looking up the current old engine facades, and the result if here #link http://codesearch.openstack.org/?q=session.begin&i=nope&files=&repos=neutron
14:31:13 <lujinluo> if you feel you have more bandwidth, you are more than welcome to take the small pieces! :)
14:31:35 <lujinluo> i will try to upload a small one later this week
14:31:59 <lujinluo> #topic open discussion
14:32:01 <njohnston> thanks, that is great
14:32:16 <lujinluo> Does anyone have anything else to share?
14:33:13 <TuanVu> nothing else from me
14:33:23 <njohnston> nothing for me.  I have somewhat limited bandwidth right now, mostly because my top priority is the bulk port optimization bp, but after S-1 I should have more time
14:33:45 <lujinluo> got it. njohnston
14:34:17 <lujinluo> ok then, let's give the rest time back to us
14:34:25 <njohnston> thanks all!
14:34:28 <lujinluo> thank you guys and see you next week
14:34:35 <lujinluo> #endmeeting