14:00:18 <lujinluo> #startmeeting neutron_upgrades
14:00:19 <openstack> Meeting started Thu Nov  8 14:00:18 2018 UTC and is due to finish in 60 minutes.  The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:20 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:22 <openstack> The meeting name has been set to 'neutron_upgrades'
14:00:30 <lujinluo> o/
14:00:33 <ralonsoh> o/
14:00:41 <lujinluo> hi ralonsoh :)
14:01:57 <lujinluo> haha, it seems to be just the two of us today ralonsoh
14:02:09 <ralonsoh> yes
14:02:34 <lujinluo> so let's do it quick and then go back to our work!
14:02:43 <lujinluo> last week we only have one action item
14:02:55 <lujinluo> lujinluo to review https://review.openstack.org/#/c/549168/
14:03:12 <lujinluo> I did that, but since the patch was pretty red, so i think it needs more work
14:03:28 <ralonsoh> me too, I'll put this in my list
14:03:37 <lujinluo> thanks! ra
14:03:47 <lujinluo> thanks ralonsoh :-)
14:03:55 <lujinluo> #topic OVO
14:04:05 <lujinluo> #link https://review.openstack.org/#/q/topic:bp/adopt-oslo-versioned-objects-for-db+(status:open)
14:04:46 <lujinluo> We just merged #link https://review.openstack.org/#/c/608638/ 4 hours ago. \o/
14:05:07 <lujinluo> #link https://review.openstack.org/#/c/610280/ Use RBACBaseObject OVO in neutron/db/rbac_db_mixin.py
14:05:11 <ralonsoh> yes, now I'm working in the next one
14:05:21 <ralonsoh> I've submitted my last patch 1 hour ago
14:05:27 <lujinluo> I saw you have updated the patch. I will look at it again later today
14:05:28 <ralonsoh> addressing the comments
14:05:34 <ralonsoh> perfect!
14:06:06 <lujinluo> #link https://review.openstack.org/#/c/610182/ Support fetching specific db column in OVO
14:06:24 <lujinluo> The codes are fine to me, but i got one small question regarding the method name
14:06:44 <lujinluo> Otherwise, i think the patch is good to go
14:06:46 <ralonsoh> yes, IMO the patch is finished, code looks great
14:07:24 <lujinluo> yes!! so please put your comments in the patch ralonsoh :)
14:07:30 <ralonsoh> sure
14:07:48 <lujinluo> #link https://review.openstack.org/#/c/544206/ Integration of (Distributed) Port Binding OVO
14:08:10 <lujinluo> I updated the patch and will reply to the comments which i have not replied to before
14:08:29 <lujinluo> but the codes are ready for review now :) so if you have time, you are very welcome to do so
14:08:48 <ralonsoh> just one very small nit, but the code is +2
14:09:19 <lujinluo> oh right. i will update the patch addressing the nit, just before anyone reviews it later today
14:09:30 <lujinluo> thanks! ralonsoh
14:09:54 <lujinluo> #link https://review.openstack.org/#/c/610184/ Convert Subnet to OVO in ipam_pluggable_backend.py
14:10:17 <lujinluo> This patch needs to wait for 610182 to get in first, but it is a small change
14:10:26 <ralonsoh> I need to check Nate's comments
14:10:41 <ralonsoh> but almost done, I'll review this today
14:10:53 <lujinluo> Excellent!
14:11:24 <lujinluo> #link https://review.openstack.org/#/c/549168/ router OVO which we discussed in the beginning of our meeting
14:12:09 <ralonsoh> I didn't have time for this one (added to my pile)
14:12:20 <lujinluo> #link https://review.openstack.org/#/c/609848/ port ovo in db/ipam_pluggable_backend.py
14:12:28 <lujinluo> still -w
14:12:36 <lujinluo> let's give it more time
14:12:47 <lujinluo> ralonsoh: sure, thanks
14:13:10 <lujinluo> #link https://review.openstack.org/#/c/579053/ Use OVO in neutron/ipam/subnet_alloc.py
14:14:01 <lujinluo> nate deleted the test which checks the race condition, which i do not think it what we should do..
14:14:07 <ralonsoh> I need to check my comment in PS11, I don't know if this is correct
14:14:11 <ralonsoh> yes, I need to recheck this
14:14:43 <lujinluo> i need to check it in more details too
14:15:35 <lujinluo> the rest of the patches are not touched since last week, so let's give them more time
14:15:43 <lujinluo> #topic engine facade
14:16:01 <lujinluo> #link https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/enginefacade-switch
14:16:19 <lujinluo> Switch to new engine facade in neutron/db/agents_db.py
14:16:20 <lujinluo> #link https://review.openstack.org/#/c/611462/
14:16:32 <lujinluo> I addressed hongbin's comment in 6114162
14:16:50 <lujinluo> please kindly review if you have time
14:16:54 <ralonsoh> sure
14:16:57 <lujinluo> thanks
14:17:09 <lujinluo> #topic open discussion
14:17:19 <lujinluo> do you have anything you want to share? ralonsoh
14:17:30 <ralonsoh> not at this moment, thanks!
14:17:36 <lujinluo> thank you too! ralonsoh
14:17:57 <lujinluo> let's call it a day and have 43 min back! :-) how nice
14:18:07 <ralonsoh> hehehehe
14:18:15 <lujinluo> oh, one more thing
14:18:25 <lujinluo> are you going to the summit ralonsoh next week?
14:18:39 <ralonsoh> nope 8-(
14:18:46 <lujinluo> i see. me neither
14:19:03 <lujinluo> nate is not going either, so i think we can continue our meeting as usual
14:19:11 <ralonsoh> I think so
14:19:19 <ralonsoh> I'll ping him today to check
14:19:26 <lujinluo> ok, that's all! thank you to showing up ralonsoh !
14:19:47 <lujinluo> we always miss people on the first meeting when day time saving ends, haha
14:19:55 <lujinluo> have a good day ralonsoh
14:20:00 <ralonsoh> you too, bye
14:20:03 <lujinluo> #endmeeting