13:00:16 #startmeeting nova api 13:00:16 Meeting started Wed Aug 24 13:00:16 2016 UTC and is due to finish in 60 minutes. The chair is alex_xu. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:00:17 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:00:19 The meeting name has been set to 'nova_api' 13:00:25 who is here today? 13:00:26 o/ 13:00:29 o/ 13:00:57 Sean is not here this week due to some openstack event in the US 13:01:19 so let us start the meeting 13:01:26 #topic API Priorities 13:01:42 as I know, we just left two patches for newton 13:02:21 microversion 2.38 merged. deprecate network CLI merged 13:02:31 (until the api-ref push, I guess) 13:02:52 johnthetubaguy: ah, thanks, you are right 13:03:10 so there is a policy one from alaski 13:03:26 s/left two patches for newton/left two patches before freeze/ :) 13:03:33 #link https://review.openstack.org/356963 13:03:43 * edleafe wanders in late 13:04:01 johnthetubaguy: have you checked Sean's comment? 13:04:17 not seen it 13:05:17 #link https://review.openstack.org/#/c/335667/ 13:05:17 johnthetubaguy: so just some check without any IO, so is the performance problem ok? 13:05:24 policy one^ 13:06:01 johnthetubaguy: thanks, another one I missed 13:06:42 #link https://review.openstack.org/322944 13:06:48 policy cli ^ 13:08:06 so we should go through those I guess 13:08:20 #link https://review.openstack.org/#/c/356963/4/nova/policy.py 13:08:28 what way do we feel we should go with this one 13:08:52 does it look terrible to not do that check every time? 13:10:31 johnthetubaguy: yes, I feel user like change that in runtime? 13:12:28 do we know how long that operation takes? 13:12:42 I guess it might be quick 13:13:06 johnthetubaguy: yes, no IO happened in that check 13:13:19 I have no exact number 13:14:18 I just wonder if we should complie the regular expression, I can't remember if that is still needed these days 13:14:38 just checked, its not required 13:14:53 assuming we are a program that only uses a few regular expressions at a time 13:15:18 I can check that or just compile it 13:15:20 johnthetubaguy: yeah, that's usually only helpful for things used very often 13:15:36 edleafe: you mean like something that gets used on every API call? 13:15:57 johnthetubaguy: well, yeah, that's usually a good use case :) 13:17:06 alex_xu: so I should just go check that, and see how slow it really is 13:17:29 johnthetubaguy: ok, thanks, I will check that also. 13:18:42 so, any more question for this patch? 13:19:47 I guess no 13:20:10 #link https://review.openstack.org/322944 13:20:26 johnthetubaguy: I think I should write a release for this patch? 13:20:43 /release/release note/ 13:21:14 alex_xu: hmm, we probably should, its a new feature 13:21:31 johnthetubaguy: ok, got it, I will update that 13:21:47 I noticed it calls init() in policy, that isn't required 13:23:59 johnthetubaguy: we need to filter the rules at https://review.openstack.org/#/c/322944/10/nova/cmd/policy_check.py@133 13:24:45 anyways, maybe what I am getting is we should all go away and review those three patches carefully, and just end the meeting now? 13:25:13 johnthetubaguy: ah, you are right, this cmd only enforce on the default rule 13:25:25 johnthetubaguy: yea, agree 13:26:15 so any other question want to bring up? otherwise let us back to work. 13:26:28 alex_xu: we could call it just before list_rules, that could make some sense 13:26:40 but actually, yeah, that doesn't change 13:28:11 johnthetubaguy: yea 13:28:15 this cmd, I wonder if we really want to return Pass/Fail for each rule we have checked 13:28:55 johnthetubaguy: you mean the full-list? 13:29:04 no, just the matched ones 13:29:33 johnthetubaguy: that is the current patch doing 13:29:52 I was unclear 13:30:11 I was thinking we could return the ones we pass or fail, but I remember why we don't do that now 13:30:29 i.e. matches the api-name 13:30:42 but the context.can result is just reported 13:31:05 foo:a PASS foo:b FAIL foo:c PASS, etc 13:31:55 anyways, ignore me 13:31:58 lets just go review things 13:32:14 johnthetubaguy: I kind of like your idea, good for user to know how much rules we have 13:32:51 johnthetubaguy: ok 13:33:01 I think the cmd was going to try match the API I guess 13:33:07 hence the different approach 13:33:44 johnthetubaguy: the parameter '--api-name' is really a wrong name for current implementation 13:34:15 but looks like no really easy way to match the rule and api 13:34:51 anyway let us back to work, or just discuss the patch off the meeting 13:35:00 so thanks all! 13:35:05 #endmeeting