13:00:02 <alex_xu> #startmeeting nova api
13:00:03 <openstack> Meeting started Wed Apr 26 13:00:02 2017 UTC and is due to finish in 60 minutes.  The chair is alex_xu. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:00:04 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:00:06 <openstack> The meeting name has been set to 'nova_api'
13:00:10 <alex_xu> who is here today?
13:00:30 <Kevin_Zheng> o/
13:01:13 <alex_xu> emm...let us wait one more minutes
13:01:17 * johnthetubaguy is lurking with intent
13:01:49 <alex_xu> super quite today
13:02:03 <alex_xu> s/quite/quiet/
13:02:53 <alex_xu> ok, let us start
13:02:59 <Kevin_Zheng> ha
13:03:36 <alex_xu> since OSIC stuff, we have few things need help
13:03:52 <alex_xu> #link https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/policy-docs
13:04:29 <mriedem> o/
13:04:32 <cdent> o/
13:04:37 <alex_xu> #link http://docs-draft.openstack.org/91/459791/5/check/gate-nova-docs-ubuntu-xenial/c062c69//doc/build/html/sample_policy.html
13:05:45 <alex_xu> ^ we fnished most of them, so I already saw people sign up to help, so I think it isn't so hard for us
13:05:50 <alex_xu> I will help on those also
13:06:02 <alex_xu> #link https://review.openstack.org/459608
13:06:32 <alex_xu> and johnthetubaguy already bring up the patch for removing discoverable policy rules
13:06:52 <johnthetubaguy> yeah, just tidying that up
13:07:06 <alex_xu> johnthetubaguy: thanks for bring those patches up
13:07:13 <johnthetubaguy> I was wondering about splitting it, but its not really as bad as it first seems
13:07:32 <alex_xu> yea, it isn't hard in one patch
13:07:49 <johnthetubaguy> yeah, seemed easier in the end, given all the files are given a similar treatment
13:08:18 <johnthetubaguy> I did go through policy-docs
13:08:28 <johnthetubaguy> and updated the BP with a list of what is missing
13:08:39 <johnthetubaguy> #link https://blueprints.launchpad.net/nova/+spec/policy-docs
13:09:08 <johnthetubaguy> finding raising a few of those patches quite... therapeutic given everything thats going on at the moment
13:09:43 <alex_xu> cool, it is great to have a list
13:11:34 <alex_xu> #link https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1661360
13:12:03 <alex_xu> cdent: nova api via apache wsgi ^
13:12:09 <mriedem> should https://review.openstack.org/#/c/428404/ be abandoned?
13:12:12 <mriedem> dansmith: ^
13:12:21 <alex_xu> yea, I guess that is old one
13:12:38 <cdent> yeah, the wsgi stuff is coming along nicely
13:12:47 <alex_xu> cdent: that is all what we need for this?
13:12:51 <cdent> there are wsgi apps for both nova-api and metadata, and some pending devstack stuff
13:12:58 <cdent> alex_xu: probably some docs too?
13:13:07 <cdent> the major work is on the devstack and grenade side of the world
13:13:12 <johnthetubaguy> so plan is get the nova stuff in now ish, and follow up with the devstack bits?
13:13:32 <cdent> the nova stuff can merge (without being used) whenever
13:13:33 <mriedem> would be nice to see the devstack changes passed on these nova patches
13:13:48 <cdent> mriedem: they have to some extent, but need to be changed into order to work with grenade
13:13:54 * cdent locates link
13:14:16 <cdent> #link nova-wsgi devstack https://review.openstack.org/#/c/457715/
13:14:25 <cdent> that's all happy except for grenade
13:15:04 <mriedem> need help with the grenade stuff?
13:15:28 <mriedem> reading the steps it looks like just setting a flag in grenade to not use wsgi,
13:15:33 <mriedem> and devstack on master would use wsgi by default
13:15:37 <mriedem> i don't know what "We honestly probably also need to do the systemd cut over before this to simplify the world." means though
13:15:48 <cdent> mriedem: maybe, sdague had some comments that mostly mean me putting some stuff back into lib/nova
13:16:06 <mriedem> yeah you can't remove the non-wsgi stuff yet
13:16:18 <mriedem> probably in queens
13:16:48 <cdent> wasn't planning to remove it, just planning to not test it ;)
13:16:53 <cdent> but yeah, agree
13:16:56 <johnthetubaguy> so I have a quick thing
13:16:57 <sdague> mriedem: there are some edge conditions around uwsgi without system that's weird
13:17:00 <johnthetubaguy> the pbr names
13:17:21 <johnthetubaguy> I think we have nova-metadata-api and nova-api-metadata
13:17:34 <cdent> they need to be different
13:17:38 <cdent> or else they clobber
13:17:45 <johnthetubaguy> yeah, agreed need to be different
13:17:49 <johnthetubaguy> just seems confusing
13:18:02 <johnthetubaguy> nova-metadata-wsgi?
13:18:09 <johnthetubaguy> maybe thats worse
13:18:10 <cdent> yeah, could do that
13:18:12 <cdent> heh
13:18:16 * cdent naming is hard
13:18:40 * johnthetubaguy nods
13:18:45 <sdague> yeh, -wsgi is probably better
13:19:04 <johnthetubaguy> I can see me screwing that up
13:19:33 <sdague> well, the theory is that the eventlet path is deprecated in pike and removed in queens right?
13:19:43 <sdague> the screw up window is small
13:19:44 <johnthetubaguy> I thought so
13:20:03 <johnthetubaguy> thats true
13:21:02 <johnthetubaguy> so I am not the best at decisions, cdent whats your take on the best way forward?
13:21:25 <johnthetubaguy> oh, I guess we need a reno in this chain of patches somewhere
13:21:47 <cdent> I think nova-metadata-wsgi is fine, maps to nova-api-wsgi
13:21:49 <alex_xu> cdent: also metion the doc
13:22:01 <alex_xu> s/metion/mention/
13:22:28 <johnthetubaguy> yeah, I guess its always wsgi, so no halm in that being there
13:22:31 <alex_xu> but i guess that doc isn' in the nova repo
13:23:22 <sdague> we also need to figure out how not to repeat the placement api documentation gap here
13:23:27 <johnthetubaguy> do we have many other projects doing similar PBR names, out of curiosity, I have really kept track of that effort?
13:23:39 <johnthetubaguy> sdague: +1
13:23:41 <cdent> i can make some of those adjustment later today
13:23:44 <sdague> johnthetubaguy: I honestly don't know how far anyone else got here
13:24:13 <mriedem> it'd be in the governance repo
13:24:15 <mriedem> for the release goal
13:24:16 <johnthetubaguy> sdague: something tells me OSIC folks volunteered for some of that
13:24:17 <sdague> I was trying to get the uwsgi and systemd plumbing all in before too many folks did
13:24:19 <mriedem> EmilienM might know
13:24:22 <sdague> johnthetubaguy: yeh
13:24:33 <mriedem> before we deprecate eventlet we have to be running with wsgi on master in CI
13:24:40 <sdague> mriedem: sure
13:25:00 <johnthetubaguy> #link https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html
13:25:15 <johnthetubaguy> seems lots of folks haven't got their responses merged yet
13:26:48 <sdague> "These projects already deploy devstack with API service via WSGI" is pretty error prone as well, as I don't know which of those are wsgi by default
13:28:45 <johnthetubaguy> in case its useful, this is keystone: #link https://github.com/openstack/keystone/blob/master/setup.cfg#L81
13:28:57 <johnthetubaguy> keystone-wsgi-admin and keystone-wsgi-public
13:29:02 * johnthetubaguy shrugs
13:29:19 <cdent> I didn't do it that way because of grenade's grep style for checking if services are running
13:29:48 <cdent> however, since the grep will be against the uwsgi process's command line, not the name of the wsgi script it may not matter
13:29:59 <alex_xu> Will all the projecs switch to uwsgi? or part of them use apache mod_wsgi?
13:30:03 <cdent> (I wanted to be able to grep either nova-api the eventlet thing, or nova-api the uwsgi thing)
13:31:00 <sdague> alex_xu: I want to remove the mod_wsgi bits from devstack
13:31:25 <alex_xu> sdague: ok, got it
13:31:28 <sdague> it's actually kind of error prone in our environment because any apache restart ends up taking all the api services offline for a noticable amount of time
13:32:35 <sdague> whereas when things are in uwsgi state you can do restarts of services seperated from restarts of apache (and apache restarts are much quicker)
13:33:01 <alex_xu> yea
13:33:11 <sdague> cdent: yeh, so once we get across to systemd this cycle, all the grenade stuff can be so much smarter on status tracking
13:34:29 <johnthetubaguy> so adding an extra alias later seems rather cheap, sounds like we are getting to the bottom of some of the details though, which is awesome
13:36:20 <johnthetubaguy> whats next on the agenda?
13:36:49 <alex_xu> that is all for priorities
13:37:10 <alex_xu> and I checked the merged specs
13:37:23 <alex_xu> and BPs
13:37:33 <alex_xu> we have 13 API related BPs approved
13:37:52 <alex_xu> all of them have patches up
13:38:07 <dansmith> mriedem: I think that patch still makes sense as a safety measure, fwiw
13:38:54 <mriedem> the novaclient changes for 2.43, 2.44 and 2.45 are ready
13:39:07 <alex_xu> mriedem: yea
13:39:31 <alex_xu> #link https://review.openstack.org/#/c/459496/
13:39:48 <alex_xu> ^ just left the client patch, then they are finish
13:40:52 <alex_xu> that is all I have
13:41:12 <mriedem> alex_xu: per your comments on the shell and using wraps
13:41:18 <alex_xu> mriedem: yea
13:41:20 <johnthetubaguy> did we get the tags stuff all fixed already?
13:41:22 <mriedem> the shell will still pass through to the api binding which will fail with a 404
13:41:41 <mriedem> alex_xu: but if we cap the shell, it will fail before we emit any deprecation warning
13:42:01 <mriedem> and the deprecation warning says, "Specify --os-compute-api-version less than '
13:42:01 <mriedem> '2.43 to continue using this command until it is removed"
13:42:04 <alex_xu> we will have help text in the `nova help`
13:42:27 <mriedem> it's a 404 either way, but you get the more detailed deprecation warning this way
13:42:28 <mriedem> is my point
13:43:08 <mriedem> johnthetubaguy: what tags stuff?
13:43:25 <johnthetubaguy> the device tags
13:43:36 <johnthetubaguy> we accidentally dropped it, then had to re-add it
13:43:41 <mriedem> that was 2.42
13:43:45 <mriedem> takashin fixed that in novaclient
13:43:47 <mriedem> very nicely
13:43:51 <alex_xu> mriedem: ok, I can test that later. I remember we will hide that command
13:44:03 <johnthetubaguy> ah, good, so this is all on top of that
13:44:05 <mriedem> alex_xu: i don't think we can hide it
13:44:08 <johnthetubaguy> I hadn't seen that go in
13:44:14 <mriedem> alex_xu: that would be like dropping it w/o a warning
13:44:22 <mriedem> johnthetubaguy: yup
13:44:42 <mriedem> alex_xu: we also said in the spec we wouldn't automatically drop down a microversion in the shell
13:45:09 <mriedem> so users can still use the deprecated shell but they have to opt in with the --os-compute-api-version option
13:45:32 <alex_xu> mriedem: whatever the commands will be failed, since the api returned 404
13:46:05 <mriedem> right, unless you specify 2.1 or 2.42, or something in between
13:46:07 <alex_xu> mriedem: even we added that decorator, the user also can use that command with --os-compute-api-version option
13:47:06 <alex_xu> mriedem: anyway, let me check that again after the meeting
13:47:38 <alex_xu> anything more people want to bring up?
13:48:19 <alex_xu> ok, let us close the meeting thanks all!
13:48:22 <alex_xu> #endmeeting