13:00:17 <alex_xu> #startmeeting nova api 13:00:17 <openstack> Meeting started Wed Sep 20 13:00:17 2017 UTC and is due to finish in 60 minutes. The chair is alex_xu. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:00:18 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:00:21 <openstack> The meeting name has been set to 'nova_api' 13:00:25 <alex_xu> who is here today? 13:01:37 <gmann> o/ 13:02:28 <alex_xu> gmann: would you work on the spec of no-more-extension? 13:02:56 <gmann> alex_xu: yea, i will push that tomorrow may be. need to get all policy things 13:03:07 <gmann> it should be quick once i have list of policies 13:03:29 <alex_xu> gmann: yea, a list of policies, probably need to take a look at eachone 13:04:00 <gmann> yea 13:04:00 <alex_xu> at least we can start some cleanup patch? 13:04:04 <alex_xu> without spec? 13:04:23 <gmann> i think yes, only policy removal is something we need spec for 13:04:31 <alex_xu> cool 13:04:50 <alex_xu> gmann: do you have any idea we can co-work on the cleanup? 13:05:09 <gmann> alex_xu: you mean on etherpad etc 13:05:23 <alex_xu> gmann: yea, something like that 13:05:34 <gmann> alex_xu: i will put that, it will avoid any conflict etc 13:05:52 <alex_xu> gmann: thanks 13:06:32 <alex_xu> #link https://review.openstack.org/502516 13:06:45 <alex_xu> gmann: congrats, it already got a +2 13:06:53 <gmann> alex_xu: yea 13:07:02 <alex_xu> add it to my review list 13:07:03 <gmann> sdague: if you check this, it is ready - https://review.openstack.org/#/c/502516/ 13:07:09 <gmann> alex_xu: thanks. 13:07:29 <alex_xu> np 13:07:56 <gmann> alex_xu: catch me if i do not deprecate the policy in code when doing for config option :) 13:08:03 <gmann> i might forgot that 13:08:22 <alex_xu> gmann: ok 13:08:31 <gmann> alex_xu: i will push the code patch by early next week, as not much to do in this 13:08:35 <sdague> o/ 13:08:44 <alex_xu> gmann: thanks 13:08:47 <sdague> gmann: will look 13:08:52 <gmann> sdague: thanks 13:08:57 <alex_xu> sdague: thanks 13:09:23 <alex_xu> #link https://review.openstack.org/490722 13:09:36 <sdague> gmann: +A 13:09:44 <sdague> gmann: thanks for cleaning this up 13:09:48 <gmann> sdague: thanks 13:09:54 <alex_xu> ^ this fix already updated for the ptg discussion 13:10:15 <gmann> alex_xu: nice, i will check tomorrow 13:10:54 <sdague> alex_xu: it seems to need lots of tests fixed 13:11:22 <alex_xu> sdague: you mean to the patch 490722? 13:11:35 <sdague> yeh 13:11:40 <sdague> oh, those look like cloning failures 13:11:45 <sdague> so maybe just a recheck 13:12:15 <alex_xu> oh 13:12:25 <alex_xu> yea, looks like just need recheck 13:12:31 <sdague> yeh, I just did it 13:13:16 <alex_xu> thx 13:13:51 <alex_xu> that is all I have today, anything else people want to bring up? 13:14:10 <gmann> there is 1 mail about server metadata API 13:14:14 <gmann> #link http://lists.openstack.org/pipermail/openstack-dev/2017-September/122319.html 13:14:43 <gmann> schema restrict the more than 1 item in body actually 13:14:44 <gmann> #lnk https://github.com/openstack/nova/blob/5bf1bb47c7e17c26592a699d07c2faa59d98bfb8/nova/api/openstack/compute/schemas/server_metadata.py#L32 13:15:35 <gmann> i think API is good as it in case i missed anything. 13:15:37 <alex_xu> yea 13:16:04 <alex_xu> /servers/{uuid}/metadata is for override all the metadata I think? 13:16:19 <gmann> PUT is yes for override all 13:16:30 <gmann> POST is just replace the input one 13:17:55 <gmann> i replied on ML in case he is getting different behavior 13:18:20 <alex_xu> what different between PUT and POST? 13:18:58 <alex_xu> oops, I mean the 'POST /servers/{id}/metadata' and 'PUT /servers/{id}/metadata/{metadata}' 13:18:59 <gmann> PUT is to replace all existing metadata with the metadata present in request body 13:19:48 <gmann> POST will just create or update the one present in request body and will not remove other exiting earlier 13:20:31 <alex_xu> ah, i see 13:20:51 <alex_xu> so we are good I think, they are APIs with different behaivour 13:21:43 <gmann> yea, mail is actually for PUT metadata key 'PUT /servers/{id}/metadata/{metadata}/{key}' 13:22:33 <gmann> question was API code does allow to update more metadata key than the only one in url 13:23:01 <gmann> #link https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_metadata.py#L80 13:23:36 <gmann> but schema restrict the request body to have only 1 item #link https://github.com/openstack/nova/blob/5bf1bb47c7e17c26592a699d07c2faa59d98bfb8/nova/api/openstack/compute/schemas/server_metadata.py#L32 13:24:31 <alex_xu> the confuse thing is both the url and body includes the key? 13:24:44 <gmann> alex_xu: yea 13:25:36 <gmann> alex_xu: body has with its value 13:25:47 <alex_xu> yea 13:26:37 <gmann> you mean we should only expect the value in body which make it more clear 13:26:58 <alex_xu> no, I think it ism't worth to do it 13:27:09 <gmann> yea, 13:28:15 <gmann> alex_xu: that's all i have for today 13:28:15 <alex_xu> anyway, let see what is jichen requested finally 13:28:34 <alex_xu> ok 13:28:45 <alex_xu> thanks all! 13:28:48 <alex_xu> #endmeeting