17:00:06 <gibi> #startmeeting nova notification
17:00:07 <openstack> Meeting started Tue Jun 14 17:00:06 2016 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:08 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:11 <openstack> The meeting name has been set to 'nova_notification'
17:00:14 <gibi> hi
17:00:18 <sneti> hi
17:00:18 <macsz> hello, world :)
17:00:21 <pumaranikar> hi
17:00:25 <aunnam_> hi
17:00:43 <yohoffman_> !
17:00:58 <gibi> rlrossit told me he will not join today
17:01:55 <gibi> so I guess we can start
17:02:00 <gibi> #topic outstanding reviews
17:02:36 <gibi> the patches that moved around the existing notification code has been merged
17:03:22 <gibi> there is some core attention on the first two transformation patches (wrap exception and instance.delete)
17:03:51 <gibi> I've updated the intance.update one, I guess now it is complete and can be reviewed
17:04:19 <gibi> I saw that multiple transformation is taken from the todo list and patches started to appear
17:04:39 <gibi> I think I managed the do the first round of review on all of them
17:04:51 <gibi> but if you have one I missed then please tell me
17:05:18 <gibi> please update the wiki with the link to your patches for easier discovery
17:05:55 <siva_krish> gibi: https://review.openstack.org/#/c/329214/2. I have updated wiki as well
17:06:11 <gibi> siva_krish: thanks, will check it tomorrow
17:06:18 <syjulian> gibi: I seem to be having issues logging into the wiki
17:06:30 <syjulian> is there another way to take up a task besides editing the wiki
17:07:01 <gibi> tell me which one you want to take and I will put that on the wiki
17:07:08 <macsz> syjulian: wiki is blocked for new logins
17:07:14 <syjulian> ah
17:07:15 <gibi> but also please ask for help on openstack-infra about the wiki login
17:07:27 <syjulian> gotcha. i'll talk to them
17:08:01 <gibi> macsz: thanks
17:08:04 <macsz> most probably they will giveyou a small time window during which you have to register with your launchpadid
17:08:37 <sneti> syjulian, I had issues logging in last week. got help from openstack-infra..
17:09:05 <gibi> great, then infra will help
17:09:12 <syjulian> ah ok. I'll go into their irc and ask for help
17:09:14 <syjulian> thanks guys
17:09:27 <gibi> syjulian: in the meantime I can updatea the wiki with your choice if you want
17:09:59 <syjulian> cool. some folks in my team are also wanting to pick some up. I can send you our choices later
17:10:06 <gibi> syjulian: OK
17:10:42 <gibi> btw, syjulian, you made a good progress on the schema generation patches in oslo.versionedobjects repo.
17:10:56 <syjulian> thanks gibi! :)
17:11:04 <gibi> I will keep an eye on those patches in the coming days
17:11:15 <gibi> I hope rlrossit will have some time also to look at it
17:11:23 <gibi> seems he is busy these days
17:11:53 <gibi> Ok, besides siva_krish, did somebody has a patch about notification we should look at?
17:12:40 <gibi> I take the silence as a firm no :)
17:12:42 <macsz> will have one later today :)
17:12:53 <gibi> macsz: OK, I will check it tomorrow
17:13:08 <pumaranikar> gibi, You reviewed my patch. I made a change that you have suggested
17:13:44 <gibi> pumaranikar: thanks, I will check back later tomorrow
17:14:16 <gibi> In general the patches looked good. Thank you guys for the effort
17:14:38 <gibi> please review each other code that also helps
17:15:22 <gibi> OK so if not other reviews to look at then
17:15:26 <gibi> #topic open discussion
17:15:52 <gibi> anybody has anything else to discuss?
17:16:46 <gibi> seems like this will be a sort meeting
17:17:18 <pumaranikar> gibi, for some actions, we are thinking of changing event type. Any suggestions/inputs on that ?
17:17:51 <gibi> pumaranikar: yeah, if you look at the event type of those actions then you can see some contradictions with the reset
17:17:54 <gibi> rest
17:18:23 <gibi> for example
17:18:35 <gibi> there is instance.live.migration.abort and there is others with instance.live_migrate
17:18:44 <gibi> sorry, live_migration
17:19:32 <gibi> there I would go choose the  live_migration name
17:19:53 <gibi> as that '.' is better to be kept for the separation of the object, action, phase
17:20:14 <pumaranikar> gibi, yes. ok
17:20:47 <gibi> I think in these cases we have to agree in the review which name we shall take
17:21:06 <gibi> I think it won't be a big deal just noted it to remember
17:23:11 <macsz> gibi: shoud we also add new notifications for error? or, for now, just stick with start and end phase?
17:23:21 <gibi> In general we shall focus on merging the reviews we already have before we open new ones as core review bandwidth is limited
17:23:44 <gibi> macsz: if the legacy notification has .error phase then please transform it
17:23:59 <macsz> in case of error old notifications have additional field ‘fault’, which is missing in new notifications
17:24:03 <macsz> ok
17:24:33 <gibi> we have fault field in the IntanceActionPayload
17:24:50 <gibi> so you can put the fault there in case of an .error notification
17:25:49 <macsz> ok, thanks :)
17:25:57 <gibi> there is an example here https://review.openstack.org/#/c/328055/ but it is not a transformation but a new notification
17:26:10 <gibi> but the basics are the same for the .error
17:27:47 <gibi> OK, anything else?
17:28:23 <gibi> if anything pops up, do not hesitate to ping me on irc
17:28:39 <gibi> let's close the meeting then.
17:28:55 <gibi> thanks for showing up! see you around!
17:29:08 <macsz> thanks, see you :)
17:29:12 <pumaranikar> thanks gibi
17:29:15 <gibi> #endmeeting