17:00:23 <gibi_> #startmeeting nova notification
17:00:26 <openstack> Meeting started Tue Jun 28 17:00:23 2016 UTC and is due to finish in 60 minutes.  The chair is gibi_. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:27 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:30 <openstack> The meeting name has been set to 'nova_notification'
17:00:30 <gibi_> hi!
17:00:39 <rlrossit> o/
17:00:46 * rlrossit hopes his internet doesn't drop while he's sitting outside
17:01:33 <gibi_> rlrossit: enjoy your lunch :)
17:02:13 <rlrossit> I will stuff my face and type at the same time
17:02:51 <gibi_> I hope your keyboard is foodproof
17:04:09 <gibi_> it seems this meeting is not popular any more
17:04:29 <gibi_> anyhow let's start and keep it sort :)
17:04:33 <gibi_> #topic outstanding reviews
17:04:49 <gibi_> we are close with the transformation
17:05:03 <gibi_> instance.delete got +2 from johnthetubaguy
17:05:19 <gibi_> instance.update needed small fixes after johnthetubaguy review
17:05:24 <gibi_> but it is up now again
17:05:25 <rlrossit> I should re-+1 as well
17:05:34 <gibi_> rlrossit: yes please :)
17:06:00 <gibi_> also johnthetubaguy went and checked the most of the follow up transformations that was proposed
17:06:12 <gibi_> plentty of the get positive feedback
17:06:23 <gibi_> s/the/them/
17:06:27 <rlrossit> I got up the enum follow patch too
17:06:52 <gibi_> thanks for that, I did a review on it.
17:07:14 <gibi_> fortunately that is refactor so that can go in after the freeze
17:07:15 <gibi_> :)
17:07:46 <rlrossit> yup thanks!
17:07:48 <gibi_> the wiki has some similar TODOs
17:07:52 <gibi_> #link https://wiki.openstack.org/wiki/Nova/VersionedNotificationTransformation#Follow_up_tasks
17:08:12 <gibi_> I will have time to iterate on them after the freeze
17:08:49 <gibi_> it seems julian's schema patches in ovo needs a second core
17:09:10 <gibi_> but that is also close to merge
17:10:10 <gibi_> after a new ovo package is released we can add a small tool to nova to generate the schemas from the notification payload ovos
17:10:22 <gibi_> but that is definitly post N-2
17:10:41 <gibi_> what else
17:10:43 <gibi_> ahh the bug
17:11:02 <gibi_> so I noticed a bug with the version generation when SCHEMA is present
17:11:42 <gibi_> #link https://bugs.launchpad.net/oslo.versionedobjects/+bug/1595552
17:11:42 <openstack> Launchpad bug 1595552 in oslo.versionedobjects "ObjectVersionChecker.test_hashes does not use extra_func to generate the hash" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
17:11:56 <gibi_> and  #link https://bugs.launchpad.net/nova/+bug/1595575
17:11:56 <openstack> Launchpad bug 1595575 in OpenStack Compute (nova) "The hash of a notification object does not depend on its SCHEMA" [Undecided,New] - Assigned to Balazs Gibizer (balazs-gibizer)
17:12:09 <gibi_> first one is on ovo
17:12:25 <gibi_> then we have to fix the nova unit tests as well
17:13:02 <gibi_> the fix for the oslo bug is up on review #link https://review.openstack.org/#/c/333382/
17:14:13 <gibi_> that was all I know about
17:14:30 <gibi_> any other review we shall discuss?
17:14:45 * rlrossit got disconnected
17:15:22 <gibi_> rlrossit: do you have scroll back?
17:15:36 <rlrossit> so I see dansmith +2'd julian's patch, I would poke dims or jaypipes for the second
17:15:39 <rlrossit> gibi_: nope :(
17:15:52 <gibi_> rlrossit: thanks for that pokes
17:16:23 <syjulian> will do
17:16:35 <gibi_> syjulian: hi! :)
17:16:44 <syjulian> o/
17:17:08 <gibi_> rlrossit: so after syjulian patches I mentioned the hash genertion bug
17:17:13 <gibi_> #link https://bugs.launchpad.net/oslo.versionedobjects/+bug/1595552
17:17:13 <openstack> Launchpad bug 1595552 in oslo.versionedobjects "ObjectVersionChecker.test_hashes does not use extra_func to generate the hash" [Undecided,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
17:17:33 <gibi_> but you saw my fix so you are basically up to date with tat
17:17:34 <gibi_> that
17:18:28 <gibi_> anything else I missed and we need to talk about?
17:18:49 <rlrossit_> gibi_: I don't think I can do this... my internet is too terrible :(
17:19:26 <gibi_> rlrossit_: no worries
17:19:34 <gibi_> rlrossit_: enjoy the food
17:19:40 <gibi_> rlrossit_: read the logs later
17:19:57 <gibi_> rlrossit_: you can ping me any time if someting pops up
17:20:05 <rlrossit_> I'll poke for julian's reviews, any other work, just let me know some other time
17:20:15 <rlrossit_> gibi_: thanks :)
17:20:17 <gibi_> rlrossit_: OK, thanks
17:20:53 <gibi_> do I feel right we are out of things to talk about? :)
17:21:52 <syjulian> are there open items I can provide help with?
17:22:23 <gibi_> syjulian: until the freeze the focus is on to get things merged
17:22:41 <gibi_> syjulian: after the freeze we can do refactoring and testing follow ups
17:22:46 <syjulian> gotcha
17:22:56 <gibi_> syjulian: there are some TODOs on the wiki https://wiki.openstack.org/wiki/Nova/VersionedNotificationTransformation#Follow_up_tasks
17:23:25 <gibi_> if you pick one just put your name around it so we can avoid starting the same thing
17:23:40 <syjulian> alright
17:23:51 <syjulian> but I should get started on this after the freeze?
17:24:40 <gibi_> syjulian: you can start right now
17:25:14 <gibi_> most probably cores are focusing on the freeze this week so your follow up will get less attention
17:25:28 <gibi_> but it shall not prevent your to start :)
17:26:08 <syjulian> gotcha
17:27:05 <gibi_> anyithing else?
17:28:35 <gibi_> then let's close the meeting. Thanks for joining. Happy code freeze week! :)
17:28:44 <gibi_> #endmeeting