17:00:10 <gibi_> #startmeeting nova notification 17:00:10 <openstack> Meeting started Tue Jul 5 17:00:10 2016 UTC and is due to finish in 60 minutes. The chair is gibi_. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:00:12 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 17:00:14 <openstack> The meeting name has been set to 'nova_notification' 17:00:15 <gibi_> hi! 17:00:16 <rlrossit> o/ 17:00:22 * rlrossit has better internet today 17:00:58 <gibi_> I hope you had lunch not just internet 17:01:00 <gibi_> :) 17:01:07 <macsz> Hi ! :) 17:01:21 <gibi_> macsz: o/ 17:01:43 <macsz> Not many folks will join today 17:02:00 <macsz> I think it's just us 17:02:02 <rlrossit> we've already got more than last week :) 17:02:06 <gibi_> ok 17:02:08 <gibi_> then lets start 17:02:09 <gibi_> #topic outstanding reviews 17:02:11 <macsz> :D 17:02:34 <gibi_> in the last minute rush we merged the must have commits of the transformation patches 17:03:09 <macsz> That's great 17:03:16 <gibi_> I sent a mail to the ML asking for ffe for the other instance action transformation that is close 17:03:39 <gibi_> mriedem added an item to the ffe tracking etherpad as well 17:03:54 <macsz> I was occupied with other stuff and failed to improve functional tests that were failing on reboot 17:04:03 <macsz> Notification 17:04:28 <gibi_> no decision yet, but I hope for an ffe 17:04:47 <gibi_> macsz: then that will be done in ocata timeframe 17:05:33 <rlrossit> wasn't the meeting for that this morning? 17:05:42 * rlrossit realizes morning is relative 17:05:58 <gibi_> there was, but they didn't talked about the clean up like tasks 17:06:09 <gibi_> I guess that will happen later today, or tomorrow 17:07:10 <gibi_> yeah, it is late afternoon here in the EU :) 17:07:34 <gibi_> beside the transformations 17:08:09 <gibi_> there is the json schema generation. I think not much happend in the last couple days with that 17:09:11 <gibi_> I have one bugfix regarding the hash generation of the payload object. I will poke oslo cores to get the fix merged in ovo 17:09:39 <gibi_> rlrossit: I saw you have a bug about object compatibility test 17:09:54 <rlrossit> yeah, and I kept wondering why it wasn't failing with new notifications... 17:09:56 <gibi_> rlrossit: I left a comment in it today. The notification object tests are moved 17:10:07 <rlrossit> but then I realized we don't register them, so they aren't picked up :) 17:10:14 <gibi_> exactly :) 17:11:02 <gibi_> I'm not 100% sure that we need these compatibility tests for notifications as we are not planning to backport the notification ovos 17:11:11 <gibi_> or at least we haven't planned to do that yet 17:11:48 <rlrossit> yeah I think the bug is of less importance now that we don't register the notification objects 17:12:05 <rlrossit> when we registered them, things would break on the first version bump, but now we don't have to worry anymore 17:12:31 <gibi_> agree 17:12:56 <gibi_> syjulian proposed a followup patch about the exception notification 17:13:08 <gibi_> to remove sensitive data properly from the exception text 17:13:32 <gibi_> https://review.openstack.org/#/c/336284/ 17:13:53 <gibi_> there are other followups on the wiki. mostly testing and doc generation related tasks 17:13:59 <gibi_> I will get to them later this week 17:14:46 <gibi_> that is all I had in my mind 17:14:55 <gibi_> any other review we need to talk about? 17:14:59 <rlrossit> I have my follow-up patch as well 17:15:09 <rlrossit> for moving the enums over to the compute module 17:15:14 <gibi_> right 17:15:15 <rlrossit> you stuck a comment on that, addressing it now 17:15:22 <gibi_> thanks 17:15:28 <gibi_> It is a nice cleanup 17:15:49 <gibi_> I feel bad I didn't do it right in the first place 17:17:30 <gibi_> any other review? 17:18:23 <macsz> Unfortunately no 17:18:44 <gibi_> #topic open discussion\ 17:18:53 <gibi_> #topic open discussion 17:19:39 <gibi_> rlrossit: the usual request, could you report on the thursday's nova meeting about the subteam? I think this week it is in US timezone 17:19:59 <rlrossit> I should be able to 17:20:08 <gibi_> thanks a lot 17:20:13 <rlrossit> it looks like my reminder for that on my calendar expired, I should probably put that back on there 17:20:32 <macsz> Just a newbie question - is there any speed up for tox in general? Executing single functional test ( or rather creating env doing so) takes 10 minutes 17:20:55 <rlrossit> for making venv's, there's no real speed up 17:20:55 <gibi_> I double checked it will be July 7th 2016 2100 UTC, #openstack-meeting 17:21:06 <rlrossit> unless you have a local mirror you can download from 17:21:20 <rlrossit> but if you're running lots of tests, more cores helps (if you do things in VMs) 17:21:21 <gibi_> I guess pip uses local cache already 17:21:45 <rlrossit> you do the venv download once, and then after that you don't need to do it anymore 17:22:01 <rlrossit> so the first run will always be the slowest, after that you will only run tests 17:22:10 <rlrossit> (unless you accidentally have the --recreate flag on tox) 17:22:32 <gibi_> or delete the .tox dir with git clean xdff as I usually do 17:22:46 <macsz> Ok I was unsure if tox does delete venv after tests by default 17:23:27 <gibi_> you can check what happens in your setup, the venv shoudl be under .tox/ dir in the git repo 17:24:31 <gibi_> but I agree rlrossit, more core helps a lot in test execution 17:24:54 <gibi_> I mean more cpu cores :) 17:25:18 <rlrossit> you can also run individual tests with regex's 17:25:43 <rlrossit> like tox -e py27 nova.tests.unit.objects is a frequent one for me 17:26:16 <macsz> I am running single test, the venv and time to create is the only problem 17:26:46 <macsz> Will check .tox next time I run tests 17:27:36 <gibi_> OK, anything else? 17:27:37 <rlrossit> macsz: feel free to ask questions in nova too :) don't be scared! 17:27:43 <gibi_> +! 17:27:44 <rlrossit> #openstack-nova that is 17:27:46 <gibi_> +1 17:27:59 <macsz> Oh I am! But will be brave ! 17:28:02 <macsz> :) 17:29:29 <gibi_> rlrossit: I'm +1 on the vm_state clean up now. thanks 17:29:39 <rlrossit> woo :) 17:29:52 <gibi_> I feel we ran out of topic for today :) 17:30:09 <gibi_> can I close? 17:30:16 <rlrossit> I'm done! 17:30:39 <macsz> Done :) 17:30:53 <gibi_> then thank you for the meeting. See you around! 17:31:06 <gibi_> #endmeeting