17:00:03 <gibi> #startmeeting nova notification
17:00:04 <openstack> Meeting started Tue Oct 18 17:00:03 2016 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:05 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:07 <openstack> The meeting name has been set to 'nova_notification'
17:00:15 <gibi> hi!
17:00:34 <stewie925> hi gibi
17:00:44 <syjulian_> hello!
17:02:06 <gibi> OK let's get started
17:02:41 <gibi> first contgratulations to syjulian_ for merging the last piece of the json schema work in ovo!
17:02:48 <gibi> great job!
17:02:54 <stewie925> +1  :)
17:02:54 <syjulian_> \o/
17:02:59 <syjulian_> thanks!
17:03:34 <gibi> this allow us to soon start the work on https://blueprints.launchpad.net/nova/+spec/json-schema-for-versioned-notifications
17:04:03 <gibi> syjulian_: would you like to start with that? :)
17:04:16 <syjulian_> sure thing!
17:04:19 <gibi> great
17:04:28 <gibi> I will help if needed
17:04:58 <gibi> I hope I will have proper time allocation after the summit, the last couple of weeks was quite busy with non upstream stuff
17:05:18 <gibi> anyhow I see good progress on the notification transformation work
17:05:29 <gibi> couple of patches already looks good for core review
17:05:52 <gibi> I update the https://etherpad.openstack.org/p/ocata-nova-priorities-tracking with those so cores hopefully find them
17:06:14 <gibi> will nagg them on the summit too :)
17:06:53 <syjulian_> lol
17:07:50 <stewie925> load up on the tapas while there, gibi :)
17:08:02 <gibi> I think you already saw the patch https://review.openstack.org/#/c/386659/ that pre-adds some of the event_types and sample file decorators so we can avoid merge conflicts
17:08:15 <gibi> stewie925: I will do :)
17:08:37 <stewie925> yeah I have a question on that patch ....
17:08:41 <gibi> shoot
17:09:03 <stewie925> I dont see rescue-notification under the nova/notifications/objects/instance.py
17:09:09 <gibi> checking...
17:09:11 <stewie925> I do see unrescue
17:09:32 <gibi> yeah that is intentional
17:09:40 <gibi> let me link a code
17:10:22 <gibi> https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3285-L3289
17:10:45 <gibi> there is a need for an extra piece of information in rescue.start and rescue.end
17:10:56 <gibi> the 'rescue_image_name'
17:11:18 <gibi> so we cannot directly use the InstanceActionPayload
17:11:34 <gibi> but we have to have an extended object with the extra data
17:11:55 <stewie925> thanks for the heads-up
17:11:59 <gibi> this is why I didn't pre-added the sample file decorator
17:12:07 <gibi> as that decorator will be on a separate class anyhow
17:12:44 <gibi> I suggest to doing the trasnformation of the easy ones first where the InstanceActionPayload can be re-used directyl
17:12:47 <stewie925> so I just need to modify the notification json to include the rescue-image-name
17:13:02 <gibi> you have to create a new payload class
17:13:15 <gibi> that inherits from the current payload class and adds the extra rescue_image_name field
17:13:18 <gibi> then
17:13:28 <gibi> you have to use that class for the rescue notifications
17:13:42 <gibi> I think there will be soon an example up for review
17:14:09 <gibi> as the create.start notification also needs extended payload
17:14:10 <gibi> https://review.openstack.org/#/c/384621/
17:14:42 <gibi> the author of this patch will publish new patch set soon that will handle thet
17:14:45 <gibi> that
17:15:07 <gibi> or you can check the instance.update notification from Newton
17:15:39 <gibi> here it is https://review.openstack.org/#/c/325923/
17:15:47 <stewie925> awesome, thank you for that info - will look up instance.update
17:16:26 <gibi> if you have question just ping me
17:16:52 <gibi> which actually leads to my last info. I will be on vacation from tomorrow till the summit.
17:17:27 <stewie925> thanks much - oh r&r before the summit ? :)
17:18:01 <gibi> yeah, I'm going to Barcelona a bit earlier to check the tapas ;)
17:18:35 <stewie925> jealous
17:18:50 <gibi> anyhow this means I won't be available really on IRC so use my email address from the launchpad if you want to reach me
17:19:14 <gibi> stewie925: will you join to the summit?
17:19:19 <stewie925> haha no
17:19:22 <stewie925> I wish
17:19:32 <stewie925> been there before on a tour
17:19:49 <gibi> too bad
17:19:53 <stewie925> just watch out for pickpockets hehe
17:20:05 <gibi> thanks for the heads up
17:20:29 <gibi> this was all I had. Anything else to discuss?
17:22:30 <gibi> it seems that was it
17:22:45 <gibi> next meeting will be held after the summit
17:23:00 <gibi> thanks for joining!
17:23:04 <gibi> o/
17:23:04 <stewie925> thank you - enjoy your vacay and the summit!
17:23:14 <gibi> stewie925: thanks!
17:23:46 <gibi> #endmeeting