17:00:04 <gibi> #startmeeting nova notification
17:00:05 <openstack> Meeting started Tue Jan 10 17:00:04 2017 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:06 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:08 <openstack> The meeting name has been set to 'nova_notification'
17:00:28 <gibi> hi
17:00:58 <aunnam> o/
17:01:41 <gibi> let's wait a minute or two for the others
17:01:50 <sneti_> hi
17:03:14 <gibi> OK, let's get started.
17:03:24 <gibi> two important things first
17:03:39 <gibi> 1) Tomorrow there will be a code review sprint
17:04:10 <gibi> so if you have outstanding reviews then it is a good day to ask for a review on IRC
17:04:36 <gibi> and also try to be in IRC to be able to respond and discuss issues with the reviewers
17:05:57 <gibi> 2) feature freeze is around the corner so it is important to focuse on finishing things
17:06:20 <gibi> so please focus more on outstanding reviews than for example starting new notification transformation task
17:07:39 <gibi> after the feature freeze we can still push bug fixes, release notes updates, refactors and test updates
17:08:16 <gibi> I will do the release note for the notification transformation bp so you don't have to worry about that
17:09:00 <gibi> all the other bp owner that got content merged needs to add release notes
17:09:14 <gibi> but as I said we have plenty of time to do that, no worries
17:09:35 <gibi> OK
17:09:54 <gibi> anything bp specific to discuss?
17:10:00 <gibi> anything about flavor notifications?
17:10:48 <gibi> I take it as a no :)
17:10:52 <sneti_> gibi, I've question on adding auto_disk_config field
17:11:09 <gibi> sneti_: that is in the additional-notification-fields-for-searchlight, right?
17:11:18 <sneti_> yes
17:11:24 <gibi> then shoot :)
17:12:05 <aunnam> for searchlight BP as of now only one patch is merged, do we still need to add release notes, if that is the only patch merged before feature freeze?
17:12:51 <gibi> aunnam: yes, please mention that what field is added and that the related payload version is bumped
17:13:09 <gibi> aunnam: but as I said this is not have to be done right now, you can propose it after the feature freeze
17:13:37 <aunnam> ok, cool
17:13:41 <sneti_> any update on what to send enum or boolean for auto_disk_config. There is a comment on this: https://bugs.launchpad.net/nova/+bug/1637634
17:13:41 <openstack> Launchpad bug 1637634 in OpenStack Compute (nova) "Missing fields in compute.end and compute.update notifications" [Undecided,Incomplete]
17:14:16 <gibi> sneti_: checking...
17:15:54 <gibi> sneti_: do searchlight needs the AUTO / MANUAL values in that field of the notification?
17:16:20 <gibi> or it is OK to them to have true / false?
17:17:03 <aunnam> Gibi, they didn't reply for that question, but the api returns AUTO / MANUAL values
17:17:13 <sneti_> gibi, not sure. I've seen any update from them
17:17:56 <gibi> OK just to be able to go forward with this I suggest to propose the change in the notification with an Enum
17:18:22 <gibi> and that Enum can coerce the Enum value from a boolean
17:18:42 <gibi> this way the conversion can be quite automatic when the notification payload is created
17:18:55 <gibi> based on the instance.auto_disk_config boolean value
17:19:03 <sneti_> ok
17:19:27 <gibi> anything else regarding the searchlight bp?
17:20:17 <gibi> I take it as a no :)
17:20:24 <aunnam> I have one
17:20:34 <gibi> aunnam: OK, just ask :)
17:20:35 <aunnam> Looks like the patch you have https://review.openstack.org/#/c/415857/ is ready now, I have reviewed it. So now can I add keypairs patch on top of this patch?
17:21:15 <aunnam> the lazy loading is handled in your patch by removing that line
17:22:09 <gibi> aunnam: could you give me a link to your patch?
17:23:06 <gibi> aunnam: or the patch where we discussed the keypairs lazy-load issue?
17:23:23 <aunnam> I don't have it right now, my question is as keypair is also lazy-loaded you suggested me to wait until the patch you are working on it is ready
17:23:32 <aunnam> yes the same one
17:24:10 <gibi> aunnam: you can move that top of my bugfix yes
17:24:34 <aunnam> ok, thanks
17:25:02 <gibi> anything else on the searchlight bp?
17:25:18 <sneti_> nothing from my side
17:25:21 <gibi> OK
17:25:22 <aunnam> nope
17:26:06 <gibi> on the json-schema-for-versioned-object bp I think syjulian made some progress and the basic tool is up for review
17:26:32 <gibi> however we identified some bugs in the schema generation regarding enum values so that needs an ovo fix
17:27:04 <gibi> as the last ovo lib release for Ocata is next week this might not fitt into Ocata
17:27:47 <gibi> any questions comments on this bp?
17:28:51 <gibi> I take it as a no
17:28:51 <gibi> :)
17:29:06 <gibi> and last but not least the notification transformation bp
17:29:37 <gibi> we have quite many patches up waiting for core review so tomorrow I will try to ping the cores :)
17:29:52 <gibi> any question on the transformation bp?
17:30:40 <gibi> any question on anything?
17:31:17 <gibi> if no then let's close the meeting
17:31:21 <gibi> thanks for joining
17:31:28 <gibi> bye
17:31:33 <sneti_> bye
17:31:40 <gibi> #endmeeting