17:00:13 <gibi> #startmeeting nova notification
17:00:14 <openstack> Meeting started Tue May  2 17:00:13 2017 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:15 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:17 <openstack> The meeting name has been set to 'nova_notification'
17:00:18 <gibi> hi!
17:00:22 <mriedem> o/
17:00:44 <gibi> mriedem: hi! Will this be our personal meeting time? :)
17:01:14 <mriedem> i think so
17:01:45 <gibi> this is a bit worries me
17:01:52 <gibi> not because of you
17:01:58 <gibi> but because of nobody else :)
17:02:27 <mriedem> everyone else is busy with everything else
17:02:52 <gibi> but if it is just you and me then we don't need the meeting slot, I guess
17:03:16 <gibi> and calling this as subteam is a but funny :)
17:03:28 <gibi> anyhow let's keep this sort
17:03:45 <gibi> I saw your patch about uuid in service notifications
17:03:57 <mriedem> yeah just updated it
17:04:12 <gibi> will check again but I'm pretty sure it is OK now
17:04:32 <gibi> besides that I encurage you to look at the volume.attach .detach patches
17:04:47 <gibi> starts here https://review.openstack.org/#/c/401992/
17:04:53 <gibi> these are ready for a while
17:05:40 <mriedem> ok,
17:05:48 <gibi> also we have ready patches here as well https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/additional-notification-fields-for-searchlight
17:05:48 <mriedem> i've been distracted with the summit planning
17:05:57 <gibi> the BDM and the keypairs
17:06:33 <gibi> sure I can imagine forum planning takes a lot of effort
17:06:48 <gibi> it is more like listing for you what we have ready :)
17:07:13 <gibi> I will talk to Kevin_Zheng about tag in instance.create https://review.openstack.org/#/c/459493/
17:07:15 <mriedem> well, 3 talks plus need to get the forum session agenda written up
17:07:16 <gibi> to see if I can help
17:07:26 <mriedem> ok
17:07:42 <mriedem> i was looking at your comment in https://review.openstack.org/#/c/461032/
17:08:02 <mriedem> and i noticed that _verify_notification isn't going to check extra_specs or projects anyway
17:08:11 <mriedem> because those aren't in the db flavor dict passed to that method
17:08:53 <gibi> good point
17:09:03 <gibi> then I think it is not just a comment that is missing
17:09:11 <mriedem> so i could pass expected_projects and expected_extra_specs
17:09:26 <gibi> that sounds OK to me
17:09:35 <mriedem> or,
17:09:42 <mriedem> shouldn't "if field in flavor:" be checked against flavor_obj?
17:10:24 <gibi> if that works (I don't see why doesn't) it is even better
17:11:59 <gibi> so both OK to me but the later seems even nicer
17:12:32 <mriedem> ok i'll mess with it
17:13:51 <gibi> I find nothing else in my mind that need to be discussed. Do you have anything else?
17:13:56 <mriedem> nope
17:14:08 <mriedem> i'll try to get those attach/detach ones reviewed this week
17:14:11 <mriedem> but that might be as much as i can do
17:14:50 <gibi> any review helps! thanks for that
17:15:12 <gibi> I will not schedule a meeting for next week due to the forum
17:15:25 <gibi> I hope you will enjoy Boston
17:15:46 <mriedem> thanks, i'll enjoy when it's over
17:15:53 <gibi> :)
17:16:05 <gibi> let's close this. bye!
17:16:12 <mriedem> ttyl
17:16:14 <gibi> #endmeeting