17:00:03 <gibi> #startmeeting nova notification
17:00:04 <openstack> Meeting started Tue Jul 11 17:00:03 2017 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:05 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:07 <openstack> The meeting name has been set to 'nova_notification'
17:00:10 <gibi> hi!
17:00:53 <mriedem> o/
17:01:18 * gibi that there will be meeting today
17:01:21 <gibi> hi mriedem
17:01:31 <gibi> I mean I'm happy ...
17:01:46 <mriedem> heh
17:01:51 <mriedem> yeah we have at least 2 things
17:01:59 <gibi> mriedem: I saw your comments on the BDM patch so I mostly fixed them today
17:02:12 <gibi> I guess that is one of the things :)
17:02:16 <mriedem> yeah
17:02:23 <mriedem> i haven't checked the changes yet though
17:02:44 <gibi> I still have to remove the explicit bdm detach call from the test
17:03:07 <gibi> that was only needed becauase either the cinder fake or the virt driver fake is stupid
17:03:18 <gibi> I'm in the process to figure out which and why
17:03:26 <mriedem> this? https://review.openstack.org/#/c/448779/36/nova/tests/functional/notification_sample_tests/test_instance.py@453
17:03:50 <gibi> that
17:04:06 <gibi> but besides that I did what you asked for
17:04:07 <mriedem> ok yeah shelve doesn't detach the volume
17:04:13 <mriedem> which is kind of the point,
17:04:28 <gibi> mriedem: yeah, now I checked in devstack and see the difference
17:04:35 <mriedem> it deletes the guest on the hypervisor, but the db continues tracking the volume being attached to the server so you don't 'lose' it
17:05:30 <gibi> for me it was strange as it means the cinder resource is not freed while other resources are freed (cpu, ram)
17:05:46 <mriedem> yes, quota is also not freed up
17:05:53 <mriedem> i don't think anyway
17:06:00 <mriedem> shelve is a really odd operation
17:06:04 <mriedem> and causes all sorts of headaches
17:06:17 <gibi> I had may own today ;)
17:06:33 <mriedem> the other thing was the updated_at patch https://review.openstack.org/#/c/475276/
17:06:45 <mriedem> should be relatively easy to address my comments in there
17:07:30 <gibi> I haven't looked it yet
17:07:42 <gibi> I hope Takashi takes care it tomorrow
17:08:17 <gibi> but you are right adding the updated_at only for the versioned notification is not that hard
17:08:32 <gibi> just copy it from the instance ovo directly
17:09:28 <mriedem> yeah should be an easy fix
17:09:32 <gibi> I also have one question
17:09:56 <gibi> do we have still chance to land the patch that adds tag at instance boot?
17:10:27 <mriedem> yes
17:10:53 <gibi> OK then I will keep an eye on https://review.openstack.org/#/c/459493/ that adds the notification part of that
17:10:54 <mriedem> the final change for the actual api and microversion is https://review.openstack.org/#/c/469800/
17:11:03 <mriedem> alex was +2 on it before
17:11:39 <mriedem> i plan on getting to that this week so hopefully it can be merged, and then the only thing left is the tags in the instance.create notificatoin
17:11:46 <gibi> thanks for the link I didn't notice that https://review.openstack.org/#/c/394321/ was abandoned
17:12:12 <mriedem> yeah the notification patch is stale,
17:12:21 <mriedem> because i'm assuming kevin is waiting to fix that up once the api change is approved
17:12:35 <gibi> yes, I think so as well
17:12:43 <mriedem> so for me this week, i'm focusing on those 3 changes when it comes to notification stuff
17:13:01 <gibi> thanks for that. I will do my part of making them land
17:13:53 <gibi> besides these I think the rest in my status mail is not that important
17:14:06 <mriedem> well, a lot of the other things are bug fixes
17:14:08 <mriedem> or lower priority i think
17:14:15 <gibi> yes
17:14:27 <gibi> transformations, improvements and bugfixes
17:15:01 <gibi> There is nothing else on my side for the meeting.
17:15:15 <gibi> anything on yours?
17:15:33 <mriedem> nope
17:15:41 <gibi> then lets close this
17:15:49 <gibi> thanks for the chat!
17:16:02 <gibi> #endmeeting