17:00:03 <gibi> #startmeeting nova notification
17:00:10 <openstack> Meeting started Tue Apr 17 17:00:03 2018 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:11 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:13 <openstack> The meeting name has been set to 'nova_notification'
17:00:43 <mriedem> o/
17:00:47 <gibi> hi
17:01:04 <mriedem> hello married gibi
17:01:10 <gibi> :)
17:01:32 <gibi> I got married last May. Just the honeymoon needed to wait :)
17:01:47 <mriedem> oh, ok
17:01:54 <gibi> anyhow honeymoon is a good think, I feel I need it every year
17:02:14 <mriedem> that's just called "vacation" until you have kids
17:02:15 <gibi> but back to business
17:02:45 <gibi> ahh don't mention. I'm babysitting my sister kids right now :)
17:03:04 <gibi> anyhow I saw you added couple of things to the agenda
17:03:11 <gibi> https://bugs.launchpad.net/nova/+bug/1763051 Need to audit when notifications are sent during live migration
17:03:12 <openstack> Launchpad bug 1763051 in OpenStack Compute (nova) "Need to audit when notifications are sent during live migration" [Medium,Triaged]
17:03:21 <mriedem> yeah that one should be easy
17:03:32 <mriedem> could also tag it as low hanging fruit
17:03:45 <mriedem> tagged now
17:04:06 <gibi> you want to just move the start notification in the proper place
17:04:22 <gibi> I agree with taht
17:04:24 <gibi> that
17:04:58 <gibi> also I feel we need to do (at some point) an audit on every versioned notification as I feel we have similar problems in other places
17:05:38 <gibi> but for the general audit we might need a bp to gather the places to fix and the follow the progress
17:06:14 <mriedem> yeah that's why i mentioned something like a decorator instead of just right in the code
17:06:28 <mriedem> but that's a bit trickier, it's easier to start small
17:07:12 <gibi> I got this decorator suggestion before I think in the local delete cases
17:07:25 <mriedem> yeah that's the one place we have something like that i think for notifications
17:08:04 <gibi> it is even a context manager :) https://review.openstack.org/#/c/476459/21/nova/compute/api.py
17:08:59 <gibi> so I will open a bp for the future (past Rocky) to audit all the start / end notifications and move them to good places
17:09:47 <gibi> anything else about this bug?
17:10:17 <mriedem> nope
17:11:10 <gibi> https://bugs.launchpad.net/nova/+bug/1761405 impossible to disable notifications
17:11:11 <openstack> Launchpad bug 1761405 in OpenStack Compute (nova) queens "impossible to disable notifications" [Low,In progress] - Assigned to Matt Riedemann (mriedem)
17:11:42 <gibi> The fix has already bben merged
17:11:50 <gibi> thanks for taking care of it
17:11:52 <mriedem> np
17:12:29 <gibi> https://review.openstack.org/#/c/486204/ adds new compute REST API request and response fields for servers but doesn't touch instance payloads, not even for create and rebuild actions - should we require those in a follow up patch and spec amendment?
17:13:32 <mriedem> yeah so in here, the spec just glossed over versioned notifications,
17:13:40 <mriedem> but it's adding a new field to the server get response
17:13:50 <mriedem> which i think we've been trying to mirrow in the versioned notifications
17:14:24 <mriedem> i won't hold up the rest api change for it, but seems like something that should go into the instance payload
17:14:32 <gibi> The notification payload aims to have at least the same information contet that the GET server rsp
17:14:50 <gibi> so it seems logical to add the new field to the payload
17:15:04 <gibi> but I haven't had time yet to look at the exact field added
17:15:31 <gibi> is it a new field on the Instance ovo?
17:15:40 <mriedem> yes
17:15:42 <mriedem> trusted_certs
17:15:48 <mriedem> which is a list of cert IDs
17:16:41 <gibi> then it is a straitforward extension
17:17:06 <gibi> I agree to let the api change merge and do a followup with notifications (including a spec amend)
17:17:23 <mriedem> cool
17:17:31 <gibi> I will propose a spec template update to describe the Notification section a bit better
17:17:38 <mriedem> good idea
17:18:37 <gibi> OK that was on the agenda
17:18:52 <gibi> I also sent a status mail #link http://lists.openstack.org/pipermail/openstack-dev/2018-April/129398.html
17:19:16 <mriedem> i've got a patch up for https://bugs.launchpad.net/nova/+bug/1764390
17:19:17 <openstack> Launchpad bug 1764390 in OpenStack Compute (nova) "Replace passing system_metadata to notification functions with instance.system_metadata usage" [Low,In progress] - Assigned to Matt Riedemann (mriedem)
17:19:22 <mriedem> https://review.openstack.org/#/c/561724/
17:19:32 <gibi> I put that patch into my queue
17:19:48 <gibi> thanks for taking it
17:20:08 <gibi> there is plenty of open bugs so I will also try to squize in some bug fixing time into my schedule
17:20:58 <gibi> but right now I have nothing discuss about them
17:21:19 <gibi> maybe mention that  https://bugs.launchpad.net/nova/+bug/1739325
17:21:20 <openstack> Launchpad bug 1739325 in OpenStack Compute (nova) "Server operations fail to complete with versioned notifications if payload contains unset non-nullable fields" [Medium,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
17:21:30 <gibi> does not progress
17:21:45 <gibi> as I had no time to dig into the upgrades that could cause the problem
17:22:18 <gibi> and I feel bad about it
17:23:05 <gibi> I have one more thing
17:23:21 <gibi> I'm really glad that Kevin_Zheng proposed a patches to https://review.openstack.org/#/q/topic:refactor-notification-samples+status:open
17:23:37 <gibi> I went through it and all looks pertty
17:24:07 <gibi> if you have time you can push through https://review.openstack.org/#/c/560731/ and https://review.openstack.org/#/c/560734/
17:24:09 <mriedem> yeah, takashi pushed him to do that
17:24:24 <mriedem> ok will do
17:24:30 <mriedem> was waiting for him to address gmann's comments
17:25:00 <gibi> he did it. I also fixed a small indent nit then +2d both patch
17:25:22 <gibi> I have nothing else for today
17:25:53 <mriedem> me neither, welcome back
17:25:55 <gibi> (and I need to present some dinner ot the kids)
17:25:58 <gibi> thanks
17:26:05 <mriedem> just throw a box of cereal at them
17:26:07 <gibi> and thanks to kept the things moving
17:26:08 <mriedem> and lock the door
17:26:10 <gibi> :D
17:26:19 <mriedem> o/
17:26:20 <gibi> let's see how it will work out :)
17:26:23 <gibi> see you around
17:26:26 <gibi> #endmeeting