17:00:00 <gibi> #startmeeting nova notification
17:00:01 <openstack> Meeting started Tue Jul  3 17:00:00 2018 UTC and is due to finish in 60 minutes.  The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:04 <openstack> The meeting name has been set to 'nova_notification'
17:01:05 <gibi> mriedem: will you join?
17:01:17 <mriedem> yeah
17:01:23 <mriedem> sorry
17:01:50 <gibi> I promise it will be a quick one
17:02:17 <gibi> 1) thanks for helping finding the root cause of https://bugs.launchpad.net/nova/+bug/1739325
17:02:17 <openstack> Launchpad bug 1739325 in OpenStack Compute (nova) queens "Server operations fail to complete with versioned notifications if payload contains unset non-nullable fields" [Medium,Triaged]
17:02:31 <gibi> I will review the fix
17:02:51 <mriedem> np
17:03:36 <gibi> 2) this is the implementation of the last rocky bp targeting only notifications https://review.openstack.org/#/c/536243/
17:03:56 <gibi> I was +2 before so I think it is close
17:04:02 <gibi> I will rereview it after the meeting
17:04:23 <mriedem> ok
17:05:21 <gibi> 3) Do you know where we are with https://review.openstack.org/#/q/topic:bp/complex-anti-affinity-policies ? it also has a patch changing notifications
17:05:42 <mriedem> the bottom few object changes needed to be updated
17:05:54 <mriedem> i have the tab open to re-review that but then got side tracked with this flavor.disabled bug
17:06:33 <gibi> do we drop the old policies field from the InstanceGroup?
17:06:45 <mriedem> no
17:07:04 <mriedem> https://review.openstack.org/#/c/563375/23/nova/objects/instance_group.py
17:07:11 <mriedem> it's deprecated and only used for compat
17:07:20 <mriedem> we marked it as read only
17:07:26 <mriedem> so callers can't set the policies attribute
17:07:42 <gibi> mriedem: OK, then I can expect that the notification can still contain the old field and just add the new
17:08:17 <mriedem> the InstanceGroup.policies field won't be set
17:08:28 <mriedem> https://review.openstack.org/#/c/563375/23/nova/objects/instance_group.py@168
17:09:41 <gibi> then the notification policies field will be None which I don't really like
17:10:31 <gibi> it does not give a way to the consumer to have a grace period where the old field is still populated with the policies
17:10:56 <gibi> while the new field is there to switch over to
17:11:00 <mriedem> so you want to send both policy and policies in the notification
17:11:21 <mriedem> that's fine, we'd just set self.policies = [self.policy.name] or whatever
17:11:33 <gibi> I don't want to break the consumer without notice about the content of the old policies field
17:11:41 <gibi> I mean without a notice period
17:12:12 <mriedem> oh he's already doing that
17:12:13 <mriedem> self.policies = [group.policy.policy]
17:12:13 <gibi> mriedem: OK, that could work
17:12:42 <gibi> cool :)
17:12:56 <gibi> that was all from my side
17:13:01 <mriedem> ok i don't have anything
17:13:15 <gibi> thanks for joining
17:13:28 <gibi> happy independency day for tomorrow
17:13:38 <gibi> independence
17:13:45 <gibi> #endmeeting