16:01:00 <gthiemonge> #startmeeting Octavia
16:01:00 <openstack> Meeting started Wed Apr 28 16:01:00 2021 UTC and is due to finish in 60 minutes.  The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:01 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:04 <openstack> The meeting name has been set to 'octavia'
16:01:16 <gthiemonge> Hi
16:01:22 <QG> Hello
16:01:26 <johnsom> o/
16:01:27 <haleyb> hi
16:01:53 <gthiemonge> #topic Announcements
16:02:18 <gthiemonge> PEP8 issues: new releases of hacking and pylint have broken our pep8 job
16:02:19 <johnsom> Short agenda this week, nice!
16:02:25 <gthiemonge> it is now fixed on master
16:02:47 <gthiemonge> johnsom: we discussed too much during the PTG
16:02:59 <gthiemonge> But fixes are waiting for reviews on stable branches:
16:03:05 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/788433
16:03:07 <johnsom> Thanks for the quick patch on the pep8 issue
16:03:11 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/788458
16:03:18 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/788464
16:03:49 <gthiemonge> older stable branches already have the cap on pylint
16:04:09 <gthiemonge> I don't have any other announcements for this week. Does anyone have anything?
16:04:12 <johnsom> Yeah, I agree we should do that
16:04:46 <johnsom> Thanks to everyone for a good PTG session. I think we had some good discussions.
16:05:28 <gthiemonge> Yes, that was really interesting
16:05:33 <johnsom> There is a mailing list discussion about sqlalchemy breakage with the new version.
16:05:59 <johnsom> #link http://lists.openstack.org/pipermail/openstack-discuss/2021-April/022094.html
16:06:07 <johnsom> That may be of interest to folks
16:06:08 <gthiemonge> johnsom: I launched the unit tests in a env with the new sqlalchemy release, and I didn't notice anything wrong
16:06:30 <johnsom> Ok cool. I think we also did some of that work already.
16:06:41 <johnsom> I remember it coming up before
16:06:58 <gthiemonge> cool
16:07:21 <gthiemonge> anything else?
16:07:41 <gthiemonge> ok
16:07:48 <gthiemonge> #topic Brief progress reports / bugs needing review
16:08:28 <gthiemonge> Following our discussions on the CentOS 8/stream jobs during the PTG, I deployed my dev environemnt on CentOS Stream.
16:08:41 <johnsom> I think I have mostly been doing reviews and minor patches. I did complete the items I signed up for at the PTG and updated the etherpad with my findings.
16:08:47 <gthiemonge> I patched devstack to not use the current release of RDO (which is still Victoria) but instead I'm using packages from RDO Wallaby.
16:09:06 <gthiemonge> And everything is working fine so far, so I'm confident that we will be able to fix our CentOS jobs after the RDO release.
16:09:29 <gthiemonge> johnsom: yeah thanks for the update on the TLS features that are missing in openstacksdk
16:10:15 <gthiemonge> I also tried to continue the work on amphorav2, I found a couple of bugs when enabling persistence
16:10:34 <gthiemonge> One in Octavia, the max_workers config is not used when jobboard is enabled:
16:10:41 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/788307
16:10:55 <gthiemonge> The second bug in taskflow, I proposed a patch:
16:11:06 <gthiemonge> #link https://review.opendev.org/c/openstack/taskflow/+/788328
16:11:22 <gthiemonge> Oh and there's a last bug with the failover flow:
16:11:28 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/787667
16:11:57 <gthiemonge> I'm also working on the removal of the spare feature (deprecated since Victoria)
16:12:08 <gthiemonge> it will help us to avoid some known issues with amphorav2:
16:12:11 <johnsom> I think it would be nice to get the focal periodic test image build job going for the deployment projects that use the test image:
16:12:13 <johnsom> #link https://review.opendev.org/c/openstack/octavia/+/763092
16:12:20 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/787722
16:12:53 <johnsom> We did finally get the xenial image removed
16:14:00 <gthiemonge> ok, cgoncalves sent a CR-1 for a previous patchset
16:14:58 <gthiemonge> johnsom: I will review it
16:16:05 <gthiemonge> #topic Open Discussion
16:16:17 <johnsom> Yeah, I addressed his comment by removing the other changes we needed at the time that was posted.
16:16:25 <cgoncalves> +2'd
16:16:28 <gthiemonge> johnsom: ok!
16:16:30 <gthiemonge> thanks
16:17:03 <gthiemonge> johnsom: one question for you: during the spare pool removal, I noticed a lot of unused controller tasks in both amphorav1 and amphorav2
16:17:19 <gthiemonge> #link http://paste.openstack.org/show/804828/
16:17:33 <gthiemonge> https://codesearch.opendev.org/?q=UpdateAmphoraeVIPData&i=nope&files=&excludeFiles=&repos=
16:17:40 <gthiemonge> https://codesearch.opendev.org/?q=MarkListenerDeletedInDB&i=nope&files=&excludeFiles=&repos=
16:17:47 <gthiemonge> any reason for that? can we remove them?
16:18:24 <johnsom> I am sure there are some
16:18:30 <cgoncalves> are you by chance suggesting we leave cruft code behind? tss-tss...
16:18:33 <johnsom> Great expectations that never materialized
16:18:49 <gthiemonge> perhaps there's a plan to use them ;-)
16:19:10 <johnsom> Well, some of these, there *was* a plan, like four years ago....
16:19:49 <johnsom> Can we move that to etherpad? That way I can comment on each one?
16:20:10 <gthiemonge> the good thing is that we have tests for those classes :D
16:20:20 <gthiemonge> johnsom: Yeah I will create an etherpad
16:21:06 <gthiemonge> #link https://etherpad.opendev.org/p/octavia-unused-controller-classes
16:21:57 <johnsom> Some of this is leftover from changes I made in the failover flow. I had to leave them in the first patches as v2 was still using them. So, yeah, many of these can go. Some were wishful thinking back when we started the project.
16:22:10 <johnsom> Others make me think we have a bug somewhere.... sigh
16:22:22 <gthiemonge> haha
16:22:58 <johnsom> I will add my comments after the meeting
16:23:14 <gthiemonge> thanks johnsom
16:23:20 <gthiemonge> any other topics today?
16:25:16 <gthiemonge> ok
16:25:21 <gthiemonge> Thanks everyone!
16:25:29 <gthiemonge> #endmeeting