16:00:49 <gthiemonge> #startmeeting Octavia
16:00:49 <opendevmeet> Meeting started Wed Nov 30 16:00:49 2022 UTC and is due to finish in 60 minutes.  The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:49 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:49 <opendevmeet> The meeting name has been set to 'octavia'
16:00:56 <gthiemonge> Hi there
16:01:03 <matfechner> o/
16:01:10 <oschwart> o/
16:01:16 <tweining> o/
16:02:48 <johnsom> o/
16:03:09 <gthiemonge> #topic Announcements
16:03:17 <gthiemonge> well, I have no announcement today
16:04:11 <gthiemonge> anyone?
16:04:17 <johnsom> Nope
16:04:21 <gthiemonge> alright
16:04:28 <gthiemonge> #topic CI Status
16:04:39 <gthiemonge> FIPS: we need an additional CR+2 on
16:04:44 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia/+/864391
16:04:57 <gthiemonge> (it fixes the FIPS job by spliting it into 2 jobs)
16:05:25 <gthiemonge> Ubuntu Jammy support: we are late on this, I still need to figure out why it is failing at
16:05:31 <gthiemonge> #link https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/861369/7
16:08:26 <gthiemonge> (last thing, the stable/zed jobs are still missing in octavia-tempest-plugin, I proposed a patch which is a child of the ubuntu-jammy patch)
16:09:32 <gthiemonge> #topic Brief progress reports / bugs needing review
16:09:55 <pyjou> I reworked my change for Prometheus on Horizon. I just added the listener type and removed the button that automatically adds the prometheus listener. I don't have much time to rewrite the dashboard.
16:09:57 <pyjou> #link https://review.opendev.org/c/openstack/octavia-dashboard/+/866064
16:10:45 <gthiemonge> pyjou: great, I will test it. Thanks!
16:11:05 <johnsom> Last week I posted a patch for the content type issue reported in IRC. Basically if the Accept header to our API included content types other than just JSON, there were some edge cases where pecan would return HTML responses (as they were in the allow list).
16:11:08 <johnsom> #link https://review.opendev.org/c/openstack/octavia/+/865475
16:11:42 <johnsom> I will address the comments today, but could use some more reviews. It should be pretty complete.
16:11:59 <gthiemonge> ack, i'll take a look at it too
16:12:19 <oschwart> I will take a look at those too
16:12:44 <oschwart> I am still missing another +2 on this one
16:12:52 <oschwart> #link https://review.opendev.org/c/openstack/octavia/+/860211
16:14:23 <tweining> I am currently working on replacing python-neutronclient code with openstacksdk in Octavia
16:14:58 <johnsom> Oh, nice!
16:15:14 <johnsom> Creating an alternate network driver?
16:15:16 <tweining> replacing APIs is fairly straightforward, but creating the openstack Connection is trickier than I thought.
16:16:23 <tweining> I try to just replace neutronclient calls with equivalent openstacksdk calls.
16:16:24 <johnsom> Yeah, that has changed some over time too. I can't remember if our code in octavia-dashboard uses a horizon connection that is already setup or if we had to do that.
16:18:59 <johnsom> #link https://github.com/openstack/octavia-dashboard/blob/master/octavia_dashboard/api/rest/lbaasv2.py#L39
16:19:13 <gthiemonge> oh nice
16:20:15 <tweining> I will have a look, thanks
16:20:24 <johnsom> That is reusing the user token, so will need some adjustments for the neutron login info, but at least a starter
16:21:32 <tweining> my approach was to do it similar to this https://opendev.org/openstack/ironic/src/branch/master/ironic/common/neutron.py#L78
16:22:11 <tweining> which I couldn't get to work so far
16:23:42 <johnsom> yeah, the method for setting up a connection has changed over the years. I know Monty had to help us update dashboard at one point. I'm not sure which version is more "correct", but the "get_one_cloud" makes me think that is the newer approach.
16:25:27 <johnsom> Given we have special configs for each service account, this approach might be easier (like dashboard):
16:25:30 <johnsom> #link https://docs.openstack.org/openstacksdk/latest/user/connection.html#using-only-keyword-arguments
16:27:24 <tweining> I've tried it that way too. it created it's own set of issues
16:29:17 <tweining> ok, let's move on.
16:29:45 <gthiemonge> #topic Open Discussion
16:31:03 <tweining> just FYI: if you updated you local env to Python 3.11 you might have noticed that it breaks the test environment.
16:31:13 <tweining> https://review.opendev.org/c/openstack/requirements/+/866125 should fix this
16:32:15 <gthiemonge> tweining: thanks!
16:33:58 <johnsom> Nice catch
16:34:52 <gthiemonge> anything else folks?
16:35:27 <tweining> not from me
16:37:25 <gthiemonge> ok thank you!
16:37:28 <gthiemonge> #endmeeting