16:00:32 <noonedeadpunk> #startmeeting openstack_ansible_meeting
16:00:34 <openstack> Meeting started Tue Jun 23 16:00:32 2020 UTC and is due to finish in 60 minutes.  The chair is noonedeadpunk. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:35 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:37 <openstack> The meeting name has been set to 'openstack_ansible_meeting'
16:00:42 <noonedeadpunk> #topic office hours
16:00:45 <jrosser> o/ hello
16:00:51 <noonedeadpunk> \o/
16:01:29 <noonedeadpunk> we had pretty huge progress last week thanks to jrosser, mgariepy and spatel :)
16:01:55 <noonedeadpunk> so focal is ready (but don't want to merge) and centos8 is passing metal source scenario
16:02:02 <jrosser> we were really on a roll last week
16:02:05 <noonedeadpunk> and it's really pretty close
16:02:22 <noonedeadpunk> yeah
16:02:31 <noonedeadpunk> but we have train failing because of suse:(
16:02:52 <noonedeadpunk> not sure if it's going to pass all in all, orwe should set it to non-voting?
16:03:14 <jrosser> tbh i think we have so much else to do that it should go non-voting
16:03:27 <noonedeadpunk> we eventually have lot's of stuff that ready for merging but fails on gates
16:03:58 <jrosser> i've noticed a lot of failures on buster
16:04:07 <noonedeadpunk> yeah, in lxc
16:04:07 <spatel> noonedeadpunk: thank you for help me out with process, always happy to help you folks :)
16:04:23 <jrosser> spatel: it is really great to see patches from you!
16:04:30 <noonedeadpunk> but it feels it's something we should have fixed
16:04:36 <noonedeadpunk> +2
16:05:31 <noonedeadpunk> also we have copied adjutant role from elastx https://opendev.org/openstack/openstack-ansible-os_adjutant
16:05:45 <noonedeadpunk> but had really no time for it's integration
16:05:57 <noonedeadpunk> and patching with all stuf we have
16:07:03 <jrosser> so i think we should try to make a decision on this strategy plugin thing
16:07:26 <jrosser> it still fails tests when just tested as a single line change
16:07:30 <noonedeadpunk> I think we totally need to get it somehow working
16:07:48 <noonedeadpunk> I mean that maybe we have broken tests at the moment
16:07:50 <jrosser> i still don't really understand what the test is doing which fails
16:08:28 <jrosser> dropping the paramiko fallback is also definately giving another 20% faster
16:08:53 <noonedeadpunk> it didn't differ for me, but now wwe know why)
16:09:03 <noonedeadpunk> bottleneck was before connection...
16:09:35 <noonedeadpunk> actually we probably need to make paramiko configurable? as not sure as everyone use ssh keys
16:10:41 <noonedeadpunk> 737543 looks really pretty fair to me
16:12:09 <noonedeadpunk> but eventually I don't really like iteration over all invetory hosts...
16:13:16 <jrosser> does it do that?
16:13:56 <noonedeadpunk> no, it's what we have now and can get rid of with https://review.opendev.org/#/c/737220/9
16:14:18 <noonedeadpunk> I really can't find why we need pha
16:14:25 <noonedeadpunk> and what use it...
16:14:57 <jrosser> i was thinking it was like a reference
16:15:30 <jrosser> so we add a thing to the object in the loop
16:15:38 <jrosser> and pha is a reference to the object
16:16:27 <noonedeadpunk> you mean LINEAR.display.verbose ?
16:16:36 <noonedeadpunk> I'm not sure it's smth functional at all....
16:17:22 <jrosser> sorry have to go
16:17:24 <jrosser> teatime
16:17:28 <noonedeadpunk> yeah, sure
16:23:20 <noonedeadpunk> looking at https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/strategy/__init__.py#L313 I have even less understanding what and why we're doing these loops...
16:23:23 <noonedeadpunk> lol
16:23:42 <noonedeadpunk> I guess I  know what's wrong
16:25:27 <noonedeadpunk> https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/strategy/linear.py#L212 this is probably supposed to be pha
16:25:32 <noonedeadpunk> than it makes sense
16:28:43 <openstackgerrit> Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible-plugins master: Optimise linear strategy access to physical host variables  https://review.opendev.org/737543
16:34:57 <noonedeadpunk> and problem which was "resolved" with the patch introduced that looks pretty common :p https://opendev.org/openstack/openstack-ansible-plugins/commit/94c93e533f533206611ed70934b5819d7a318289
16:45:35 <openstackgerrit> Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/openstack-ansible-plugins master: Optimise linear strategy access to physical host variables  https://review.opendev.org/737543
16:50:09 <noonedeadpunk> my judgement was wrong... so I still nee no impact from this cycle except logging things. In the meanwhile old code (which it replaced) was really altering behaviour
16:51:33 <noonedeadpunk> #endmeeting