15:00:22 <noonedeadpunk> #startmeeting openstack_ansible_meeting
15:00:22 <opendevmeet> Meeting started Tue Feb  6 15:00:22 2024 UTC and is due to finish in 60 minutes.  The chair is noonedeadpunk. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:22 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:22 <opendevmeet> The meeting name has been set to 'openstack_ansible_meeting'
15:00:27 <noonedeadpunk> #topic rollcall
15:00:28 <noonedeadpunk> o/
15:03:04 <jrosser> o/ hello
15:04:17 <noonedeadpunk> #topic office hours
15:04:39 <noonedeadpunk> So, I've started reviewing some patches from https://etherpad.opendev.org/p/osa-capi
15:04:55 <noonedeadpunk> and most things looks jsut nice except maybe some small nits
15:05:05 <jrosser> yeah, thankyou for taking a look
15:05:32 <jrosser> this needs some attention really https://review.opendev.org/c/openstack/openstack-ansible-plugins/+/900527
15:05:38 <jrosser> i am not happy with that tbh
15:07:01 <noonedeadpunk> So... Maybe with just moving all playbooks to the plugins repo will eliminate a need for such role, as then we can continue using tasks include....
15:07:10 <noonedeadpunk> ie local ones
15:07:18 <noonedeadpunk> as they will be local to playbooks
15:07:35 <noonedeadpunk> But ofc depends on what exactly you don't like ofc
15:07:45 <jrosser> perhaps though the pointt of that patch was i need to do the same thing in the ops repo collection
15:07:55 <noonedeadpunk> Also potentially I didn't get the problem you was solving good enough
15:07:55 <jrosser> so adjacent to playbook is unhelpful
15:08:42 <NeilHanlon> o/ hi folks
15:08:45 <noonedeadpunk> ok, yeah. And the reason you don't like this patch is...?
15:08:55 <noonedeadpunk> \o/
15:09:09 <jrosser> line 172 here https://review.opendev.org/c/openstack/openstack-ansible-ops/+/901450/12
15:09:48 <jrosser> sorry here https://review.opendev.org/c/openstack/openstack-ansible-ops/+/901450/12/mcapi_vexxhost/playbooks/k8s_install.yml#172
15:10:12 <jrosser> what i don't like is that the only way to make it "work" is to run it under roles:
15:10:17 <noonedeadpunk> and doing that with import_role?
15:10:23 <noonedeadpunk> ugh
15:10:29 <noonedeadpunk> ok, I don't like that either then
15:10:31 <jrosser> then the vars defined in defaults/main.yml just are not visible
15:10:33 <jrosser> right
15:10:37 <noonedeadpunk> how does ceph_ansible handles it?
15:10:41 <jrosser> so we need some other way to do this
15:11:00 <jrosser> probably with set_fact as a guess
15:11:22 <noonedeadpunk> https://github.com/ceph/ceph-ansible/tree/main/roles/ceph-defaults
15:11:27 <noonedeadpunk> no, not really I guess
15:11:45 <jrosser> oh i was thinking of https://github.com/ceph/ceph-ansible/tree/main/roles/ceph-facts/tasks
15:12:18 <noonedeadpunk> But I saw ceph-defaults being included/respected as well actually
15:12:35 <jrosser> interesting they are using import_role
15:12:52 <jrosser> the empty tasks file is maybe worth a try
15:12:55 <noonedeadpunk> we have them in roles :( https://opendev.org/openstack/openstack-ansible/src/branch/master/playbooks/ceph-install.yml#L93-L99
15:13:32 <jrosser> anyway - i really had some difficulty to make that work
15:13:42 <jrosser> but tbh i think that i am missing some obvious thing
15:14:55 <noonedeadpunk> Hm, I really don't understand how it works actually....
15:15:32 <noonedeadpunk> as - should included vars in role work the same way then?
15:15:40 <noonedeadpunk> ie - being available outside of the role scope?
15:16:03 <noonedeadpunk> yeah, that worth to have a closer look obviously
15:16:11 <jrosser> right its a very good question
15:16:24 <jrosser> and one that obviously is important for ceph-ansible too
15:18:01 <noonedeadpunk> and potentially it depends on import vs include
15:18:29 <jrosser> i will write a test after the meeting
15:19:26 <noonedeadpunk> btw tempest fix https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/907886 seems to be working now - https://review.opendev.org/c/openstack/openstack-ansible-rabbitmq_server/+/907758 is happy
15:20:12 <noonedeadpunk> there're bunch of improvments that should be done for openstack_resources role, first of which to move service_setup role under it
15:20:35 <noonedeadpunk> I wonder if it's possible to do some kind of collection mapping magic to avoid patching all roles...
15:20:51 <jrosser> why do we need to do that btw?
15:21:04 <noonedeadpunk> well.....
15:21:40 <noonedeadpunk> amount of skipped tasks potentially have smth to do with that: https://opendev.org/openstack/openstack-ansible-plugins/src/branch/master/roles/openstack_resources/tasks/identity.yml#L16-L37
15:23:13 <noonedeadpunk> as role is included 2 times when we'd need to iterate properly over list of domains, since in service_setup context there's only 1 domain is possible
15:23:30 <noonedeadpunk> so for each domain, role is fully included for no good reason more or less
15:23:43 <noonedeadpunk> just to keep compatibility of formats....
15:23:46 <noonedeadpunk> But dunno
15:23:52 <noonedeadpunk> maybe we don't need that at all
15:28:49 <noonedeadpunk> I was having some thought after looking through bunch of bugs lately.
15:29:21 <noonedeadpunk> If there's any will among you folks to do a bug triage/sorting day and spend it on closing/reviving bugs?
15:29:55 <noonedeadpunk> like it feels that 90% of them are not valid, but there're 10% that really worth paying attention to
15:30:40 <noonedeadpunk> and could be missed/still valid today (like https://bugs.launchpad.net/openstack-ansible/+bug/1896589)
15:30:57 <noonedeadpunk> as it's pretty embarassing to have that bug for 4 years....
15:31:35 <noonedeadpunk> I know that it's not best time investment and might be hard to justify...
15:31:42 <noonedeadpunk> So no is also a good answer
15:33:05 <noonedeadpunk> Like if I'd sort bugs by update date - it's getting to 2020 after ~30-40 of them
15:37:20 * noonedeadpunk just found another valid one
15:37:44 <jrosser> would be good to have a bug squash at some point
15:38:00 <jrosser> maybe if it's just sorting out the ancient/invalid and leaving the actual ones
15:38:42 <noonedeadpunk> damiandabrowski: mgariepy wanna take part in that ^ :)
15:38:50 <noonedeadpunk> *it was a question
15:39:32 <noonedeadpunk> Like take couple of hours (or half of the day) for bug fighting day
15:39:58 <noonedeadpunk> and close what's not relevant / triage set priority for what is valid
15:46:36 <jrosser> that would be good - otherwise we just fight all the rubbish ones and waste time
15:55:39 <mgariepy> yes sure when ?
15:59:26 <opendevreview> Dmitriy Rabotyagov proposed openstack/openstack-ansible-os_nova master: Always distribute qemu config file  https://review.opendev.org/c/openstack/openstack-ansible-os_nova/+/908160
15:59:47 <noonedeadpunk> let's agree on some date/time:)
16:00:16 <noonedeadpunk> the closer to end of week - the calmer days in terms of meetings/distracting factors.
16:00:23 <noonedeadpunk> that's for me at least :D
16:00:55 <noonedeadpunk> I can send out a poll after the meeting actually
16:01:06 <mgariepy> ok
16:01:26 <noonedeadpunk> awesome
16:01:31 <noonedeadpunk> #endmeeting