03:02:15 <Sundar> #startmeeting openstack-cyborg
03:02:16 <openstack> Meeting started Thu Mar 19 03:02:15 2020 UTC and is due to finish in 60 minutes.  The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:02:17 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:02:19 <openstack> The meeting name has been set to 'openstack_cyborg'
03:02:29 <Sundar> Agenda: https://wiki.openstack.org/wiki/Meetings/CyborgTeamMeeting#Agenda
03:02:41 <Sundar> #topic Roll call
03:02:47 <Sundar> #info SUndar
03:03:11 <brinzhang_> #info brinzhang
03:03:22 <xinranwang> #info xinranwang
03:03:37 <s_shogo> #info s_shogo
03:04:14 <Sundar> Do we have a qorum to discuss the doc subject? May be we can wait a minute for chenke and Yumeng?
03:04:19 <Sundar> *quorum
03:04:59 <brinzhang_> agree
03:07:35 <Sundar> chenke needs a bit more time
03:07:55 <Sundar> brinzhang_: Do you want to get started on the docs?
03:09:05 <brinzhang_> chenke has a disagree point with https://review.opendev.org/#/c/711869/2/doc/source/index.rst@59
03:09:30 <Sundar> Reference to previous doc disucssion: http://eavesdrop.openstack.org/irclogs/%23openstack-cyborg/%23openstack-cyborg.2020-03-12.log.html#t2020-03-12T03:48:25
03:09:31 <brinzhang_> I think I should wait him, we can start other topic, and then talked this
03:10:00 <Sundar> ok
03:10:34 <brinzhang_> Sundar, thanks send the privous ideas, I will resend it
03:10:46 <chenke> #info chenke
03:10:52 <brinzhang_> I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/
03:10:56 <brinzhang_> I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/
03:11:04 <brinzhang_> I would like to improve the cyborg docs, such as the https://docs.openstack.org/cyborg/latest/
03:11:18 <brinzhang_> Sorry..
03:11:31 <brinzhang_> Sundar, start now, chenke coming
03:12:02 <chenke> Sorry, late.
03:12:24 <Sundar> NP, chenke. Sure, let's get started
03:12:25 <Yumeng> #info Yumeng
03:12:29 <chenke> ok
03:12:34 <Yumeng> Hi all, sorry for late.
03:12:55 <brinzhang_> https://review.opendev.org/#/c/711869/3/doc/source/index.rst
03:13:18 <brinzhang_> Hi all, let talking about this docs change, any suggestions?
03:14:05 <brinzhang_> chenke, I donot know another perfact tittle to change "Writing to the API"
03:14:47 <brinzhang_> if someone can give a good idea, I will be appreviate
03:15:14 <chenke> How about Docs related API
03:15:16 <Sundar> How about: "Using the API"?
03:15:18 <brinzhang_> And is there others link should I add in the latest page?
03:15:32 <chenke> Using the API  +1
03:16:17 <brinzhang_> If I add the api_microversion_history to the index page, it sound not good yet
03:16:25 <Sundar> Line 89,90: Who knows what genondex and modindex do?
03:16:43 <brinzhang_> but Using the API is ok for me
03:17:37 <brinzhang_> Sundar, I dont know what is and I dont why we need Line 89,90
03:17:45 <chenke> I think we can remove
03:18:40 <chenke> LIne 89,90 just a link to the useless link.:https://2346739f9f4d66197c40-6f04b689d71be05d52bf14ef78b20a44.ssl.cf2.rackcdn.com/711869/2/check/openstack-tox-docs/ed5106b/docs/
03:18:45 <Sundar> agreed
03:19:36 <brinzhang_> agree
03:20:38 <Sundar> Anything else on this subject?
03:20:54 <Yumeng> agree both. using the API is good for understanding. remove useless doc also makes it cleaer.
03:21:08 <brinzhang_> If anything need to add this, I think it's ok
03:21:52 <Sundar> OK Sounds good.
03:21:53 <s_shogo> Using the API seems to be natural,agree.
03:22:44 <brinzhang_> Ok
03:22:58 <Sundar> On Nova status, I have been off for a few days for personal reasons, but hope to get back to it soon.
03:23:10 <Sundar> Any other topic to discuss?
03:23:49 <brinzhang_> xinranwang: do we need to talked of the microversion change?
03:24:34 <brinzhang_> https://review.opendev.org/#/c/696860/5
03:25:17 <xinranwang> yes
03:25:23 <xinranwang> Thanks Brin
03:25:29 <brinzhang_> np
03:25:39 <xinranwang> Now we only support 2.0 version
03:26:41 <brinzhang_> My mainly concern is https://review.opendev.org/#/c/696860/5/cyborg/api/controllers/v2/versions.py@24, I think we should use completed version nubmer to help Cyborg control the microversion change
03:28:49 <openstackgerrit> Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index  https://review.opendev.org/711869
03:29:04 <Sundar> I suggest we follow the precedent of placement or nova. Should we get cdent or somebody to review this?
03:29:05 <xinranwang> yes, Cyborg also use completed version number
03:29:28 <xinranwang> which locate L29 L30 in version.py
03:29:33 <xinranwang> brinzhang_:
03:30:17 <xinranwang> It is not the same framework,  maybe ironic and watcher is more similiar
03:30:19 <brinzhang_> xinranwang: yeah, for my comments, do we need L24 and L26?
03:30:53 <xinranwang> brinzhang_:  it is easy for recording every microversion history
03:30:54 <brinzhang_> xinranwang: And I think we need to change the _MIN_VERSION_STRING to _MIN_API_VERSION
03:31:20 <xinranwang> brinzhang_:  how
03:32:16 <brinzhang_> xinranwang: If we will change microversion to 3.0, this way seems not easy to convert, right?
03:32:44 <brinzhang_> xinranwag: maybe it will be have a long time
03:32:49 <xinranwang> the version 3 will be implemented in v3 repo, not here
03:33:09 <xinranwang> and in controller/v3 repo, it will has its own versions.py file
03:33:58 <brinzhang_> xinranwang: Ok, if so, threre is just some nits inline for me, just the defined parameters ^^
03:34:56 <xinranwang> Ok
03:35:16 <xinranwang> This is pecan specific, which is diffirent from nova ;)
03:35:48 <brinzhang_> I know, just want to have a good way to maintain ^^
03:36:26 <xinranwang> Yes, so do we all agree to maintain like this?
03:37:13 <brinzhang_> aree, but I would like you can change the defined parameter name (also just a nit)
03:37:26 <brinzhang_> xinranwang:s/aree/agree
03:38:01 <xinranwang> Ok, thanks
03:38:44 <brinzhang_> Sundar, chenke, Yumeng, s_shogo, do you all have some idea of this ?
03:38:52 <Sundar> For me too, it is just those minor points about variable names.
03:39:02 <chenke> @xinran Overall LGTM. I will. review it again.
03:39:15 <chenke> Yes
03:40:04 <Yumeng> yes. features are good enough.
03:40:18 <brinzhang_> thanks xinranwang and all
03:40:23 <brinzhang_> Sundar, pls do next agenda
03:40:41 <xinranwang> There are other projects naming with release name. If you guys prefer other ways like ADD_X_PARAM, I will update it.  It is flexible.
03:41:24 <xinranwang> btw, please review deployabel API patch when you got time, I think it is almost ready.
03:41:49 <chenke> +1
03:41:50 <Sundar> I don't have any specific next agenda item.
03:42:03 <chenke> how about your nova patches?
03:42:08 <chenke> Sundar
03:42:31 <brinzhang_> xinranwang: just need change  _MIN_VERSION_STRING to _MIN_API_VERSION, and use current_api_version or thers you thinks instead of "Version.sting"
03:42:51 <Sundar> xinranwang: Could you add a pointer to those projects's code that uses release names? If there is any precedent code that I can look at, for microversions in general, that would be useful.
03:43:29 <xinranwang> sure, let me find it.
03:43:37 <Sundar> chenke: I have got some review comments on Novapatches. I was off for a few days but will resume again.
03:44:30 <chenke> Okay.
03:45:32 <Sundar> xinranwang: You can provide those references in Gerrit.
03:45:41 <Sundar> Anything else, folks?
03:45:46 <s_shogo> Mere Reporting , the client topic mentioned in the last IRC :  the cyborg client from pip doesn't include sdk implementation now.(That doesn't be released yet.)
03:45:47 <brinzhang_> https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397
03:46:02 <brinzhang_> pls review this change, I think it's ready to go
03:47:36 <xinranwang> Sundar:  ok
03:47:53 <brinzhang_> s_shogo: so cyborgclinet can support "pip install" and the "SDK" doesnot, right?
03:48:31 <brinzhang_> I have used pip install to install the cyborgclient, but not try to test SDK yet
03:48:56 <s_shogo> brinzhang_ sdk is ok , but client is not yet.
03:49:22 <s_shogo> (by pip)
03:50:10 <brinzhang_> s_shogo: get it, but I can install python-cyborgclinet to my local env (devstack). I will check the client version again
03:51:41 <s_shogo> brinzhang_ thanks .The client installed pip is probably old one,without sdk version.
03:51:43 <brinzhang_> root@ubuntu-OpenStack:~# cyborg --version
03:51:44 <brinzhang_> 1.0.0
03:52:04 <brinzhang_> Ah, 1.0.0
03:52:22 <Sundar> brinzhang_: I think https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 needs to be updated, because the top patches are based on PS 4/6 of the bottom patch, instead of the latest 6/6.
03:53:08 <brinzhang_> Sundar, it's not any impact
03:53:48 <brinzhang_> the base patch just update the json data
03:54:00 <Sundar> ok
03:55:37 <brinzhang_> Sundar: Thanks
03:56:40 <Sundar> Any thoughts or reviews of https://review.opendev.org/#/c/712231/ ?
03:57:24 <Sundar> Oh, I see some comments, but no -1. WIll respond to the comments
03:57:29 <brinzhang_> Sundar I left some comments inline^^
03:57:50 <Sundar> ok
03:58:03 <Yumeng> I was reviewing it yesterday. but not finished.
03:58:05 <Sundar> Thanks, brinzhang_
03:58:13 <Yumeng> I will review it today.
03:58:24 <Sundar> Yumeng, I'll wait, no rush
03:58:31 <Yumeng> ^^ ok
03:58:37 <Sundar> Anything else, folks?
03:58:56 <openstackgerrit> Brin Zhang proposed openstack/cyborg master: Add description column to device_profiles db  https://review.opendev.org/703285
03:59:24 <Yumeng> nope from my side.
03:59:36 <openstackgerrit> Brin Zhang proposed openstack/cyborg master: Add 'description' field to the device profile object  https://review.opendev.org/703293
03:59:55 <Yumeng> ops. https://review.opendev.org/#/c/709433/ need final review.
03:59:58 <Yumeng> thanks!
04:00:10 <brinzhang_> Sundar: About https://review.opendev.org/#/c/703293/, I was rebased on the latest change, pls see again
04:00:18 <brinzhang_> nothing else
04:01:06 <brinzhang_> Yumeng: Will review at afternoon
04:01:20 <Sundar> Ok
04:01:32 <Yumeng> Thank you Brin.
04:01:33 <Sundar> Thanks everybody. Have a good week.
04:01:37 <Sundar> #endmeeting