02:06:26 <xinranwang> #startmeeting openstack-cyborg
02:06:27 <openstack> Meeting started Thu Apr  8 02:06:26 2021 UTC and is due to finish in 60 minutes.  The chair is xinranwang. Information about MeetBot at http://wiki.debian.org/MeetBot.
02:06:28 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
02:06:30 <openstack> The meeting name has been set to 'openstack_cyborg'
02:06:41 <xinranwang> #topic roll call
02:06:45 <xinranwang> #info xinranwang
02:07:01 <brinzhang> #info brinzhang
02:07:18 <xinranwang> I'd like to discuss with you about vgpu status
02:07:27 <xinranwang> #topic vgpu status
02:07:55 <xinranwang> do we have a spec for vgpu support?
02:08:20 <swp20> # info swp20
02:08:47 <brinzhang> xinranwang: yeah, I would like to ask swp20 re-propose the vgpu spec
02:08:50 <swp20> xinranwang: i have reproposed the vgpu support
02:09:06 <xinranwang> cool, please add me as the reviewer
02:09:14 <swp20> https://review.opendev.org/c/openstack/cyborg-specs/+/783785
02:09:25 <brinzhang> https://review.opendev.org/q/topic:%22bp%252Fcyborg-vgpu-support%22+(status:open%20OR%20status:merged)
02:09:33 <swp20> done
02:09:56 <xinranwang> do we need a spec for nova?
02:10:07 <swp20> yeah
02:10:09 <brinzhang> and there are some details need to be cleayly in old spec, you can review and +1 for it if it's ok
02:10:39 <swp20> i see someone have moved the spec to xena, we need to modify some nits.
02:11:04 <xinranwang> please add me as the reviewer in nova spec as well, thanks
02:11:44 <openstackgerrit> Merged openstack/cyborg master: Add backup and snapshot support matrix  https://review.opendev.org/c/openstack/cyborg/+/785086
02:12:07 <brinzhang> swp20: why we need to move the specs/xena/approved/support-vGPU-nova-cyborg-interaction.rst to xena?
02:12:21 <brinzhang> in the fix mirror things patch?
02:12:28 <swp20> ack xinranwang
02:14:01 <brinzhang> spw20: you should move specs/xena/approved/support-vGPU-nova-cyborg-interaction.rst from this commit, and submit a new commit to re-propose it
02:14:14 <swp20> brinzhang: i donnot know, i need to find the commit.
02:15:07 <brinzhang> so please split them
02:15:32 <brinzhang> and make them clear
02:15:39 <xinranwang> I didn't follow you, why we need move the spec location?
02:16:16 <swp20> https://review.opendev.org/c/openstack/nova-specs/+/784369
02:17:06 <brinzhang> xinranwang: no, we dont move it, just need to re-propose it in xena(move it to xena dir) and keep the old one in wallay/approved dir
02:17:35 <xinranwang> ok got it
02:17:51 <xinranwang> do we already re propose the spec in nova?
02:17:53 <brinzhang> in https://review.opendev.org/c/openstack/nova-specs/+/780443 patch, we just need to modify the inconsistent content
02:17:59 <swp20> i think sean make a mistake.
02:18:31 <swp20> i have reproposed: https://review.opendev.org/c/openstack/nova-specs/+/780452
02:19:50 <openstackgerrit> chenker proposed openstack/cyborg master: Fix wrong usage about set which introduced during nova-cyborg interaction  https://review.opendev.org/c/openstack/cyborg/+/784021
02:19:52 <xinranwang> ok, so we need fix nits in w spec, and continue call for review for the xena's one
02:20:01 <brinzhang> swp20: sean didnot update your patch, just renamed it
02:20:31 <brinzhang> you can rebase to master
02:21:23 <swp20> xinranwang: i will fix nits in x spec.
02:21:31 <swp20> brinzhang: ok
02:21:48 <xinranwang> swp20:  ok, got it.
02:24:13 <xinranwang> we need call for nova guys to review it, if there's some opens cannot be nailed down and need more discussion, we'd better start it early before ptg.
02:24:51 <swp20> ack.
02:25:54 <brinzhang> agree, but dont worry
02:27:02 <xinranwang> ok
02:27:54 <xinranwang> #topic AoB
02:28:24 <xinranwang> the smartnic spec in reproposed in nova, please review it if you got time. thansk
02:28:38 <brinzhang> ack
02:28:56 <xinranwang> https://review.opendev.org/q/topic:%22bp%252Fsriov-smartnic-support%22+(status:open%20OR%20status:merged)
02:29:05 <swp20> cool
02:29:16 <xinranwang> also the implementation
02:29:20 <xinranwang> :0
02:29:37 <xinranwang> do you have other things be bring up here?
02:29:42 <brinzhang> we fixed the device profile's api excetption and revert the removed temest case https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/785142
02:30:22 <brinzhang> the backport patch to stable/victoria to check the pep8 https://review.opendev.org/c/openstack/cyborg/+/785318
02:30:43 <brinzhang> there patches need to review and allow them go, I think
02:30:44 <xinranwang> ok, you plan to revert it after the dependency land, right?
02:31:10 <brinzhang> there is no dependency with these patches
02:31:30 <swp20> good works.
02:31:53 <brinzhang> the releted patch has already fixed, see bug 1922183
02:31:55 <openstack> bug 1922183 in Cyborg (OpenStack) wabllaby "tempest failed with test_get_and_delete_device_profile" [Undecided,New] https://launchpad.net/bugs/1922183
02:32:20 <xinranwang> this is already the roll back patch, right?
02:32:50 <brinzhang> xinranwang: do we need to switch to use launchpad now? there is no related with the commit and the bug now
02:32:51 <brinzhang> https://review.opendev.org/c/openstack/cyborg/+/784207
02:33:29 <brinzhang> xinranwang: yes, you can see the fixed patch here https://review.opendev.org/q/topic:%22bug%252F1922183%22+(status:open%20OR%20status:merged)
02:33:44 <xinranwang> ok, cool
02:34:08 <xinranwang> i have no objection to switch to laundpad
02:34:12 <brinzhang> we just need to backport that fix until wallaby, it's enough
02:34:44 <brinzhang> ok, let's review and merge the switch patch, ok?
02:35:10 <swp20> yes, the tempest test case is introduced from wallaby.
02:35:20 <openstackgerrit> Brin Zhang proposed openstack/cyborg master: Switch using Launchpad instead of Storyboard  https://review.opendev.org/c/openstack/cyborg/+/784207
02:35:23 <brinzhang> https://review.opendev.org/c/openstack/cyborg/+/784207
02:36:25 <xinranwang> ok, cool
02:36:44 <brinzhang> xinranwang, swp20: thanks
02:36:54 <swp20> cool
02:36:57 <xinranwang> and please review chenke's patch https://review.opendev.org/c/openstack/cyborg/+/784021
02:37:50 <xinranwang> any other things?
02:38:03 <chenke> i will review the switch launchpad story
02:38:04 <brinzhang> I left commit, this is need to re wrods the commit title, it looks blurry
02:38:22 <xinranwang> I think he has resubmit another one
02:38:29 <brinzhang> I mean chenke's patch
02:38:30 <chenke> brinzhang xinranwang already update.
02:39:07 <chenke> that's sundar's patch Leftover problems.
02:39:14 <brinzhang> chenke: I think we just to say "using List instead of xxx ", how about?
02:39:45 <brinzhang> chenke: yeah, I just want to know what was happened when I see the commit tittle
02:39:58 <openstackgerrit> Merged openstack/cyborg-tempest-plugin master: Add device profiles test case for device_profile APIs  https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/785142
02:40:54 <chenke> brinzhang. Agree your idea. What do you think the new title?
02:41:50 <swp20> 'set' object is not subscriptable
02:42:00 <swp20> i test in py3 env
02:42:09 <xinranwang> uncompatibility of data type?
02:42:14 <chenke> swp20 yes.
02:42:48 <chenke> maybe sundar didn't test this else switch. actually  this is a very python problem.
02:42:55 <brinzhang> Using List to avoid uncompatibility data type
02:43:12 <brinzhang> How do you think?
02:43:46 <xinranwang> Using List to avoid incompatible data type
02:43:59 <swp20> we can use pop
02:44:02 <brinzhang> nice
02:45:02 <brinzhang> Agree swp20
02:45:03 <chenke> OK
02:45:24 <brinzhang> may we will reduce one data change
02:45:24 <chenke> Using List to avoid incompatible data type
02:45:53 <xinranwang> ok, cool
02:46:28 <brinzhang> xinranwang, chenke: what do you think swp20's advice?
02:46:43 <brinzhang> "we can use pop"
02:47:27 <xinranwang> good advice
02:47:31 <xinranwang> +1 for that
02:47:41 <xinranwang> since the length is 1
02:47:56 <chenke> msg = msg % {'code': list(event_codes)[0],
02:47:56 <chenke> 'inst': events[0]["server_uuid"]}
02:48:43 <chenke> pop will change the data.  I think just list transfer it is enough.
02:48:51 <brinzhang> yes, using pop we will have a better efficiency than list
02:49:05 <xinranwang> if the var"event_codes" is not used somewhere after, we can use pop
02:49:20 <brinzhang> xinranwang: yes
02:49:26 <xinranwang> otherwise we'd better keep it no changable
02:49:37 <brinzhang> https://review.opendev.org/c/openstack/cyborg/+/784021
02:50:35 <brinzhang> after enent_codes, there is not used somewhere, we directly raised and end of the interface
02:50:41 <chenke> yes.
02:52:28 <brinzhang> so, let's use pop instead of list, is it ok? chenke
02:52:33 <xinranwang> what do you think chenke
02:52:34 <chenke> ye
02:52:37 <openstackgerrit> chenker proposed openstack/cyborg master: Using pop method to avoid incompatible data type  https://review.opendev.org/c/openstack/cyborg/+/784021
02:52:48 <chenke> please see the update patch
02:52:48 <brinzhang> cool, I have nothing else
02:52:57 <xinranwang> cool
02:53:03 <xinranwang> thanks for the quick update
02:53:10 <xinranwang> anything else?
02:53:13 <swp20> cool
02:53:22 <swp20> nothing from myside
02:53:25 <chenke> haha
02:53:42 <chenke> me too.
02:53:59 <xinranwang> if nothing else, let's wrap up the meeting
02:54:20 <xinranwang> #endmeeting