02:34:11 <xinranwang> #startmeeting openstack-cyborg
02:34:11 <opendevmeet> Meeting started Thu Jul 29 02:34:11 2021 UTC and is due to finish in 60 minutes.  The chair is xinranwang. Information about MeetBot at http://wiki.debian.org/MeetBot.
02:34:11 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
02:34:11 <opendevmeet> The meeting name has been set to 'openstack_cyborg'
02:34:16 <xinranwang> #topic roll call
02:34:41 <brinzhang_> #info brinzhang
02:34:46 <xinranwang> #info xinranwang
02:35:45 <xinranwang> #topic pending patches
02:35:46 <songwenping_> #info songwenping_
02:36:26 <xinranwang> let's go through the pending patches
02:36:49 <xinranwang> 1st: https://review.opendev.org/c/openstack/cyborg/+/790937
02:37:38 <xinranwang> I think this one is good for me. each time we delete trart for on rp, we should check if we need to delete the trait as well.
02:39:14 <xinranwang> brinzhang_ what do you think about this
02:39:32 <xinranwang> 2nd: https://review.opendev.org/c/openstack/cyborg/+/797403
02:41:45 <brinzhang_> for delete the trait I think it's ok, I will review it at afternoon
02:41:59 <xinranwang> brinzhang_:  ok, thanks
02:42:49 <brinzhang_> the sec I have talked with wenping, I suggest to combine the duplicate exception
02:43:09 <xinranwang> what do you mean by combine
02:43:35 <songwenping_> combine name exist and uuid exist exception
02:44:00 <brinzhang_> yes
02:44:04 <songwenping_> to resource existed exception
02:44:35 <songwenping_> need we distingush them
02:45:03 <xinranwang> it should be 2 different exceptions
02:45:28 <brinzhang_> if columns just only exist with name, using string will be better,but it'a an array now, just using arr[0] will be have a risk
02:46:06 <brinzhang_> we can using log + rase exception to warning the user/developer
02:46:17 <xinranwang> i think the array is not for one colume, it records all duplicated columes' name
02:46:27 <xinranwang> so it is a array
02:47:32 <brinzhang_> if so, why are you just call the first key arr[0]?
02:48:34 <xinranwang> we didn't use arr[0] now, the if condition is:  if 'name' in ['name']
02:49:18 <xinranwang> calling arr[0] is a workaround because the value of the list is not 'name', but "xxxxxxname" instead
02:49:24 <songwenping_> just for verify the tempest, we cannot use arr[0] in fact.
02:49:43 <xinranwang> songwenping_: +1
02:50:45 <songwenping_> we should find why the e.columns is different, some env is ok.
02:51:12 <brinzhang_> but now changed with if 'name' in e.columns[0] it will be always using the fist
02:51:18 <brinzhang_> is right?
02:52:10 <songwenping_> we donnot plan to merge arr[0]
02:52:32 <xinranwang> it just a work around. I think we should find out how this array formed
02:52:41 <songwenping_> yes
02:53:06 <songwenping_> why the exception columns is ['name']
02:53:17 <songwenping_> s/is/isnot
02:54:27 <xinranwang> do you think we can try to use 10.0.0,
02:55:04 <songwenping_> perhaps has no relate with the oslo.db version
02:56:02 <songwenping_> need to look into it.
02:56:25 <xinranwang> ok, let's discuss offline
02:56:32 <songwenping_> yes let's continue
02:56:35 <xinranwang> #topic AoB
02:56:52 <xinranwang> anything else you wanna bring up?
02:57:30 <songwenping_> eric xie commit one patch
02:58:13 <xinranwang> you mean the url related one?
02:58:22 <songwenping_> i am finding
02:59:05 <songwenping_> https://review.opendev.org/c/openstack/python-cyborgclient/+/802140
02:59:24 <songwenping_> we donnot support device profile show with name
03:00:23 <songwenping_> should we support to do this?
03:00:49 <xinranwang> oh, yes
03:00:54 <xinranwang> good point.
03:00:56 <songwenping_> the patch is not reasonable
03:01:10 <xinranwang> I think we should support using name
03:01:53 <songwenping_> i talked with him to discuss in the ptg, maybe we need a spec to do this.
03:02:59 <xinranwang> cool, thanks wenping
03:03:24 <songwenping_> no problem
03:03:47 <xinranwang> anything else?
03:03:55 <songwenping_> nothing
03:04:11 <xinranwang> ok, if nothing else, let's wrap up the meeting
03:04:41 <songwenping_> ok
03:04:43 <songwenping_> bye
03:04:44 <xinranwang> #endmeeting