15:01:34 #startmeeting openstack search 15:01:34 Meeting started Thu Sep 10 15:01:34 2015 UTC and is due to finish in 60 minutes. The chair is TravT. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:35 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:37 The meeting name has been set to 'openstack_search' 15:01:48 o/ 15:01:59 o/ 15:02:12 o/ 15:02:14 o/ 15:02:14 o/ 15:02:23 #link https://etherpad.openstack.org/p/search-team-meeting-agenda 15:02:25 that's starting to look creepy 15:02:45 the agenda or the o/ 15:02:50 :) 15:02:57 plz add anything to it. 15:03:08 #topic general status updates 15:03:28 thanks for some productivity yesterday at the review hour. 15:03:34 i know not everybody could make it 15:03:59 but we actually did get 5 patches in yesterday 15:04:36 i don't have any other general updates. so... 15:04:44 #topic Release 15:05:02 been looking at this: 15:05:02 https://wiki.openstack.org/wiki/ReleaseTeam/How_To_Release#Swift_intermediary_releases 15:05:46 I think that's similar to what we want to do, but I saw in the release tools repo there are some new scripts 15:06:19 probably nikhil and david have the most experience with the release tooling 15:06:39 I was planning to reach out to rel management team next week 15:06:54 to see if we need to run it ourselves or not 15:07:05 +1 to that 15:07:10 david-lyle: nikhil_k_: they pretty much do it for horizon and glance, right? 15:07:17 if we import os libraries we should run by them 15:07:23 yes 15:07:25 being part of the integrated release. 15:07:52 TravT: yes 15:08:08 sjmc7: the most I've used it the gerrit review system with SHA to tag stuff 15:08:47 TravT: we would need to define requirements similar to global caps. not sure if we have a patch that does it now 15:09:05 one thing we'll have to figure out, which maybe nikhil_k_ and david-lyle would know is if we need to reset the milestone target on all our bugs and BPs 15:09:06 https://blueprints.launchpad.net/searchlight/liberty 15:09:20 automated if through relmgr 15:09:27 they have scripts 15:09:34 right now, i've been keeping them up with when they would have released had we done milestone releases 15:09:58 I think even if you do the release, you would use the same scripts and tooling 15:10:37 ok. well, i'll reach out to the release management team next week to start prep work. 15:11:03 also, as we discussed awhile back, i'll set up a seccore team 15:11:23 it will be a subset of the core team. 15:11:34 I think so too. or thierry can run the script (with admin rights or whatever) to fix the bug statuses 15:12:00 ok, good to know 15:12:34 so, if you get an invite to join the seccore team, please accept it if you can. 15:12:47 if you specifically have an interest of being on it, let me know. 15:14:01 so, lets talk about current BP statuses a bit. 15:14:08 #link https://blueprints.launchpad.net/searchlight/liberty 15:14:36 lakshmiS how are functional tests coming? still looking to be good for liberty release? 15:14:59 yes i removed WIP status 15:15:02 ready for reviews 15:15:21 ok. i filed a bug yesterday that I didn't put up a patch on. 15:15:27 but i think it'll affect functional tests 15:15:27 we can always add more but i guess there's enough of them now 15:15:51 are you testing for "Fields" now? 15:15:52 api, load and listener core functionality is tested 15:16:11 lakshmiS, i'll revierw that again today 15:16:12 Fields in ES response? 15:16:16 as input. 15:16:26 https://bugs.launchpad.net/searchlight/+bug/1493586 15:16:26 Launchpad bug 1493586 in OpenStack Search (Searchlight) "Missing _source parameter" [Undecided,New] 15:16:40 i have no idea why we are remapping fields to _source 15:16:47 but we shouldn't IMO. 15:16:51 remapping? 15:17:07 you can send in fields parameter to searchlight 15:17:09 if you specify 'fields' e-s won't return the _source doc 15:17:11 but it is actually _source 15:17:21 but there is a fields parameter for ES 15:17:23 that is different 15:17:29 err... um. 15:17:34 confused the heck out of me yesterday 15:17:50 me too :) i'll have a look if i get time later 15:17:53 or a day ago... 15:17:58 we do get _source 15:18:25 well, possibly i was doing something wrong. it was nearly midnight 15:18:43 but i'm pretty sure we pop fields from the request and send it in as _source 15:19:41 anyway, lakshmiS, that's great about the functional tests 15:19:53 I'll try to give them a go. 15:19:59 ok 15:20:10 next bp is designate. 15:20:21 ekarlso has been really working through that with sjmc7 and i 15:20:36 seems that it is very close 15:21:02 i asked to put in parent child relationship for some of the data mapping, which has caused a little churn on it 15:21:41 but i think designate will be in for release. 15:22:02 bp glance-metadef-plugin 15:22:32 lakshmiS found one bug in that 15:22:38 and has a fix up 15:22:55 i also have been experiencing some pain with metadefs on some horizon work i'm doing 15:23:03 *hangs head* 15:23:08 but haven't debugged that yet. 15:23:43 query-perf-tests 15:23:49 nikhil_k_: that's yours ^ 15:24:28 TravT: I doubt if I can complete them in next 2 weeks. THings have been sitting for a while as Glance was heavy past few weeks 15:24:44 well, i don't think it is a release blocker. 15:24:55 But if we really need them, I can try to define some scenarios that we can try to get in for L 15:25:23 sure, we can chat offline when you have a better picture of all other features 15:25:29 i think it's fine after L. it's to feed into fixing things 15:25:43 sounds good... i think perf testing will be a big topic in a lot of areas... 15:25:50 yeah, possibly cross project interaction and some types queries 15:25:53 yeah. it would be good to do before the summit tho 15:25:56 i'm actually a bit more worried about indexing perf than query perf 15:25:59 yep 15:26:01 me too 15:26:08 I see 15:27:08 I agree that perf scenarios and testing should be really tackled in M. 15:27:41 so nikhil_k_, i'll defer that BP to next 15:27:48 thanks 15:28:19 next up, of interest to you david-lyle 15:28:28 horizon integration. 15:28:45 we won't have an in horizon trunk integration for liberty, but... 15:29:06 i have a search panel for horizon that's coming along okay. 15:29:38 it won't be perfect, but i've been thinking about what to do with it. 15:29:49 i was thinking about a few options 15:30:08 1) holding off and proposing to mitaka horizon trunk 15:30:19 2) putting it into contrib on searchlight repo 15:30:24 3) creating a new repo 15:31:18 but we need something to actually show searchlight capabilities in liberty 15:31:29 we've also been fiddling with a single search box type thing 15:31:46 yes, i gave a thumbs up to the invision mocks on that 15:31:55 went back and forth a bit 15:32:15 but the search panel actually brings some qualities that the top nav search doesn't have. 15:32:19 and can be plugged in. 15:32:43 i have a fear that it'll be the end of mitaka before we can get the top nav figured out in horizon proper. 15:33:13 david-lyle must be asleep 15:33:29 doh, too many streams 15:33:34 ^ 15:34:27 basically i'm asking what I should do with a proof of concept horizon search panel plugin for liberty searchlight 15:35:13 easiest if probably a different github repo for now or a feature branch, that way you could continue to iterate up to the summit 15:35:26 and then merge into master when baked 15:35:49 otherwise the patch approval process will slow you down, I fear 15:36:21 yeah, last week I came to the realization that we had to do something like this 15:37:06 I think it's valid to demo a POC that is targeted to merging 15:37:38 well, perhaps I just should keep it as one massive patch and propose to horizon. 15:37:49 could do that as well 15:37:52 it subsumes the searchlight api patch steve already had up. 15:38:23 ok, that is pretty easy... 15:38:52 i'll start with that. 15:39:00 never enough runway ;) 15:39:26 will be nice to get the code (as ugly as it is at the moment up into a system off mine). 15:39:55 okay. next BP: plugin-config-options 15:40:07 ekarlso and sjmc7 were debating starting that yesterday 15:40:17 i think ekarlso said he'd put up a patch 15:40:24 i'm pretty keen to sort out the config stuff before L 15:40:32 probably based off what they have in designate 15:40:35 me too sjmc7 15:40:36 it's going to be a problem for actual deployments 15:40:42 which will no doubt fall into my lap :) 15:40:47 lol 15:41:08 i look forward to much cursing from you 15:41:20 an advantage of being english 15:41:27 ok, so let's keep that BP for liberty 15:41:42 bp enable-cors 15:41:58 i'm still very much interested in this, but it still isn't a must 15:42:09 at least for horizon use cases 15:42:16 since we proxy through horizon atm. 15:42:36 seems like a nice Mitaka item 15:42:54 yeah, most likely. 15:43:17 #topic bugs 15:43:20 #link https://bugs.launchpad.net/searchlight 15:43:36 so far we've done a good job staying on top of them. 15:43:55 but there are a few opportunities out there. 15:44:30 does anybody have any they'd like to discuss? 15:44:38 so what are we deciding on https://bugs.launchpad.net/searchlight/+bug/1490697? modified fields for glance client 1.0.0 15:44:40 Launchpad bug 1490697 in OpenStack Search (Searchlight) "python glance-client for image-members has upgraded" [High,In progress] - Assigned to Lakshmi N Sampath (lakshmi-sampath) 15:44:53 functional tests depend on this bug 15:45:07 nikhil_k_: sigmavirus24: rosmaita: ^ 15:45:19 ah, yeah. so what was the deal - use glance-client 1.0.0 or no? 15:45:24 what's global-requirements doing? 15:45:48 python-glanceclient>=0.18.0 is in global-reqs on master 15:45:57 no upper cap 15:46:20 https://review.openstack.org/#/c/219168/ 15:46:26 that leaves it open :) 15:46:48 nikhil_k_: if you look at comments on bottom of that patch 15:46:52 does horizon show image members? 15:47:08 we just aren't sure if we should put a hard requirement on glance client 1.0 on searchlight 15:47:37 I don't believe so 15:47:39 or if we need some conditional code 15:48:19 not sure how other projects deal with backward incompatible code on python clients 15:48:25 if there's no global-reqs cap, everyone will get 1.0.0 15:48:29 horizon does not explicitly show image members or even allow updating them. 15:48:46 but it does do filtering based on image members 15:48:55 we could put a hack in though; look for both attributes 15:48:56 but i believe it is implicit 15:48:59 lakshmiS: TravT currently, jokke_ and I are having that conversation on how to deal with the situation 15:49:13 if not owned by me and is not public, then must be shared with me. 15:49:34 http://lists.openstack.org/pipermail/openstack-operators/2015-September/thread.html#8079 15:50:04 worst case, we do the conversion - look for member_id and turn it into member. or vice versa 15:50:34 hack would be easy if we dont have a clear solution 15:51:02 it's not really a hack per se 15:51:11 nikhil_k, can you give a two sentence summary 15:51:16 i'm ok with doing it 15:51:45 lakshmiS: i more okay with that than only working with glanceclient 1.0 15:52:13 TravT: we are currently deciding if the CLI should support back-compact changes for v1 API 15:52:14 i will meanwhile update the patch with the hack 15:52:15 i also have terrible grammar in irc 15:52:43 nikhil_k: if you are going to take a decision please update the patch. I will wait until monday 15:52:44 let's put the conditional in 15:52:51 or that :) 15:53:01 TravT: sorry, that's just one line and that's it 15:53:05 lakshmiS: sure 15:53:23 tbh, i'd just put in the conditional 15:53:28 yep 15:54:18 TravT: sure 15:54:28 ok, cool 15:54:46 lakshmiS: i saw you also updated the member notification patch based on feedback from nikhil_k_ 15:55:09 is it ready for him and other glance guys to review? 15:55:10 yes I did fix some of the test cases. 15:55:36 there are still 2 tests failing on glance store which i am looking currently (need to understand that part of code which is new to me) 15:55:49 thanks, if you have a link it would help a ton! (got around 100 FF tabs open atm) 15:56:19 https://review.openstack.org/#/c/221307/ 15:56:26 thanks!! 15:57:29 ok, just a couple minutes left 15:57:53 if i send out another "review hour" request for next week tuesday or wednesday, would that be helpful? 15:58:27 sure 15:58:34 preference in days? 15:59:15 any day is fine with me 15:59:45 ok, my coffee IV line needs to be changed and we are out of time anyway. 15:59:52 thanks everybody! 15:59:57 aye. thanks 15:59:59 #endmeeting