19:05:00 <stevemar> #startmeeting openstackclient
19:05:01 <openstack> Meeting started Thu Aug 13 19:05:00 2015 UTC and is due to finish in 60 minutes.  The chair is stevemar. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:05:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:05:04 <openstack> The meeting name has been set to 'openstackclient'
19:05:23 <stevemar> anyone have any topic they want to discuss, the wiki hasn't been updated, but it's cool
19:05:32 <lhcheng> o/
19:05:54 <stevemar> #topic osc 1.6.0 has been released
19:05:55 <lhcheng> no topic from me :)
19:06:12 <stevemar> we released 1.6.0 on tuesday, didn't break the gate (yay)
19:06:22 <stevemar> dhellmann: thanks for all your help with that btw
19:06:29 <lhcheng> \o/
19:06:45 <stevemar> cliff 1.14.0(?) was also released
19:07:06 * sigmavirus24 golfclap
19:07:13 <stevemar> so if you type in the wrong command, you'll get some sweet help output
19:07:32 <stevemar> and --help works now, it'll give you help based on that command
19:07:41 <stevemar> and we have a TON of volume v2 related code dropped in
19:08:11 <stevemar> i have a TODO to chat with someone from the cinder team, to see if they are interested in backing osc in favor of their cli
19:08:20 <terrylhowe> yeh, lots of features
19:08:30 <terrylhowe> cool stevemar
19:09:01 <stevemar> yeah, i'll add that to the pile (it's getting large)
19:09:47 <stevemar> there was a bug with OCC that came up last night
19:10:20 <stevemar> that ended up causing gate failures, it was only seen through osc usage, so we got some initial blame there :)
19:11:15 <stevemar> its all fixed up for now though
19:11:39 <stevemar> #topic anything else?
19:11:44 <terrylhowe> osc needs to get out of the business of providing a token_endpoint plugin and ksc should be in that business
19:11:47 <lhcheng> stevemar: what was the fix for the --help issue? I'm curious what was the issue.
19:11:48 <terrylhowe> I think
19:12:10 <sigmavirus24> lhcheng: probably delayed help printing
19:12:15 <sigmavirus24> I think that is a thing with cliff
19:12:24 <sigmavirus24> help is either printed eagerly or lazily
19:12:41 <terrylhowe> things like ‘os image set —help’ prints image set help instead of general help
19:12:48 <stevemar> lhcheng: previously, if you have issued --help with a command it would give you the same output as if you had typed 'openstack --help'
19:13:04 <lhcheng> sigmavirus24: ah cool
19:13:24 <sigmavirus24> lhcheng: oh I think stevemar and I understood the question differently
19:13:34 <stevemar> now it should work the same as if you typed 'openstack help image set' and 'openstack image set --help'
19:13:37 <stevemar> sigmavirus24: seems that way
19:13:48 * sigmavirus24 isn't sure which was the right answer though
19:13:54 <lhcheng> sigmavirus24: I actually understand the symptom, just wondering what was the fix
19:13:57 * stevemar i think mine is
19:13:58 <lhcheng> sigmavirus24: you got it right
19:14:06 * lhcheng sorry for the unclear question
19:14:08 <sigmavirus24> stevemar: did I get the fix right?
19:14:13 <sigmavirus24> lhcheng: don't apologize
19:14:24 <stevemar> yep, i can link the patch
19:14:47 <stevemar> https://review.openstack.org/#/c/201258/
19:15:08 <stevemar> the second improvement to help was pretty cool, too...
19:15:20 <stevemar> if you type in 'openstack tag' (not a command)
19:15:22 <lhcheng> stevemar: cool, thanks!
19:15:48 <stevemar> now you'll get back git style feedback "did you mean 'openstack catalog'"
19:15:56 <stevemar> that's done in this patch: https://review.openstack.org/#/c/202053/
19:16:13 <sigmavirus24> oooooh
19:16:29 <stevemar> neat stuff :)
19:16:58 <terrylhowe> yeh, definitely
19:17:19 <lhcheng> sweet
19:18:19 <stevemar> terrylhowe: did you want to chat about the logging stuff?
19:18:51 <terrylhowe> Yeh, definitely.  I’m just trying to move logging stuff out of shell.py to make it more testable and reduce churn on shell.py
19:19:11 <stevemar> the less stuff in shell.py the better
19:19:15 <terrylhowe> https://review.openstack.org/#/c/186720/ was a patch I didn’t submit, but got me started
19:19:19 <stevemar> #topic logging
19:19:51 <stevemar> i really like the cleanup you did on that one
19:19:56 <terrylhowe> shell.py is hard to test because you have to structure your tests almost like functional tests
19:20:53 <terrylhowe> there a bunch of dependent patches to that, the first 3 are pretty simple and then it gets more complicated
19:21:08 <stevemar> terrylhowe: are you happy with the logging-everytime patch?
19:21:26 <stevemar> not just the code, but the overall design and such
19:21:33 <terrylhowe> yeh, it works as it is the follow on patches clean things up more
19:21:48 <stevemar> i'll look into those
19:22:05 <stevemar> i almost want to say wait for dtroyer to take a look at it
19:22:54 <stevemar> its definitely cleaner now
19:23:14 <stevemar> let me look at the follow on patches, maybe viewing it as a whole will give me confidence in the initial patch
19:23:18 <terrylhowe> I think Dean looked at #186720 at least
19:24:29 <stevemar> true
19:24:47 <terrylhowe> his input on some of the later patches would certainly be good.  The first couple I think are pretty simple.
19:25:26 <stevemar> terrylhowe: what's a filt?
19:25:43 <terrylhowe> filter maybe?
19:25:46 <stevemar> https://review.openstack.org/#/c/210820/1/openstackclient/tests/common/test_context.py
19:25:54 <stevemar> write it out maybe? :P
19:26:42 <terrylhowe> not sure why I didn’t :)
19:28:38 <terrylhowe> In one of the last patches I added the capability to enable logging for dependencies  https://review.openstack.org/#/c/211682/
19:28:59 <terrylhowe> logging:
19:29:00 <terrylhowe> keystoneclient.session: debug
19:29:04 <terrylhowe> for example
19:29:18 <stevemar> thats interesting
19:29:34 <terrylhowe> I thought that might be useful.  It only works in clouds.yaml with that
19:29:41 <stevemar> i see
19:29:57 <stevemar> file a bug for that one, if you want
19:30:26 <terrylhowe> Probably should get Monty to look at that too.  I wasn’t sure how much interest there would be for that.
19:33:08 <stevemar> yep, for sure
19:33:33 <terrylhowe> https://bugs.launchpad.net/python-openstackclient/+bug/1484660
19:33:33 <openstack> Launchpad bug 1484660 in python-openstackclient "Allow enabling of dependent loggers" [Undecided,In progress] - Assigned to Terry Howe (thowe-g)
19:33:40 <uvirtbot> Launchpad bug 1484660 in python-openstackclient "Allow enabling of dependent loggers" [Undecided,In progress] https://launchpad.net/bugs/1484660
19:33:41 <uvirtbot> Launchpad bug 1484660 in python-openstackclient "Allow enabling of dependent loggers" [Undecided,In progress]
19:33:51 <terrylhowe> anyway, that is about it for logging
19:34:21 <terrylhowe> Depending on how that goes, I’d like to look at doing something similar for configuration
19:34:25 <stevemar> thanks for the bug :D
19:35:24 <stevemar> anyone else have another topic?
19:35:29 <stevemar> #topic bueller?
19:36:23 <stevemar> calling it!
19:36:29 <stevemar> #endmeeting