16:00:36 #startmeeting oslo 16:00:37 Meeting started Mon Nov 30 16:00:36 2015 UTC and is due to finish in 60 minutes. The chair is dims. Information about MeetBot at http://wiki.debian.org/MeetBot. 16:00:37 courtesy ping for GheRivero, amotoki, amrith, bknudson, bnemec, dansmith, dhellmann, dougwig, e0ne, flaper87, garyk, harlowja, haypo, 16:00:38 courtesy ping for ihrachyshka, jd__, jecarey, johnsom, jungleboyj, kgiusti, kragniz, lifeless, lintan, ozamiatin, redrobot, rpodolyaka, spamaps 16:00:39 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 16:00:39 courtesy ping for sergmelikyan, sreshetnyak, sileht, sreshetnyak, stevemar, therve, thinrichs, toabctl, viktors, zhiyan, zzzeek, gcb 16:00:41 The meeting name has been set to 'oslo' 16:00:42 o/ 16:00:43 o/ 16:00:44 o/ 16:00:44 hi 16:00:45 o/ 16:00:47 o/ 16:00:49 o/ 16:01:00 yo yo 16:01:02 o/ 16:01:06 kick things off :) Welcome to our new oslo core - welcome gcb!! 16:01:16 o/ 16:01:18 o/ 16:01:23 gcb, welcome ! 16:01:23 congrats to gcb 16:01:27 yaaaa welcome! 16:01:29 well deserved 16:01:36 ./ 16:01:42 It's really excited to become an Oslo core reviewer. Thanks, everyone :-). 16:01:49 o/ 16:01:52 o/ 16:01:57 welcome to the team, gcb! 16:02:10 #topic Red flags for/from liaisons 16:02:35 nothing for keystone. 16:02:54 Nothing here 16:03:04 (Though I have been out of the office) 16:03:28 just curious how it goes with deprecation warning on 'obsolete' oslo.messaging driver aliases. 16:03:39 liaisons, please take a look at lifeless' openstack-spec for backward compats https://review.openstack.org/#/c/226157/ 16:03:55 lifeless is looking for feedback on that 16:04:20 ihrachys : don't think we have nailed that yet 16:04:32 Ok, will have a look 16:04:46 thanks bknudson johnsom 16:04:48 #topic Releases for Mitaka 16:04:49 Does anyone need releases today? please file reviews in openstack/releases repo. 16:05:31 any specific requests for this week? 16:05:44 * harlowja_at_home thinks some people still in turkey coma lol 16:06:06 exactly, just wanted to be sure 16:06:09 #topic cleanup oslo-incubator 16:06:09 Please bid fond farewell to https://review.openstack.org/#/c/245461/ 16:06:36 please cast your vote to cleanup oslo-incubator code, will +2A it later today! 16:06:37 yay! 16:06:44 lol 16:06:56 dhellmann wanted to give it a proper sendoff 16:06:59 ha 16:07:26 does that include a burial at sea? 16:07:40 we all built it, we should all have a role in killing it :-) 16:07:45 treat it as a pirate? :) 16:07:51 the incubator repo still exists? 16:08:08 it does still, I think, have some of our tool scripts in it, doesn't it dims? 16:08:10 I'm wondering if we delete the repo or the coce 16:08:11 Now, question was, what to replace it with, lifeless to the rescue again 16:08:20 dhellmann yes, just yanking out the code for now 16:08:29 will completely cleanup later in the cycle 16:08:37 #topic Policy Spec Review 16:08:38 #link https://review.openstack.org/#/c/247902/ (Replace incubator with unstable libraries.) 16:08:46 bknudson just the code in that review 16:09:09 * harlowja_at_home also not sold on v1, v2... 16:09:14 in the spec review, please note the v1/v2 package names for public api 16:09:46 alternatives are very welcome. my alternative is to just say what we did before, "till library is 1.0, anything can change" 16:09:53 ya, i like that... 16:09:57 thats more normal imho 16:09:58 So, some useful stuff can move to oslo.* like #https://review.openstack.org/#/c/249107/ 16:10:18 gcb : let's try to keep that to a minimum 16:10:30 if the code isn't backwards compatible then how to release without breaking everything? 16:10:45 dims, and if a library releases a 1.0 and everything is all broken, well thats why debtcollector exists and such, to make it so that u can change things in a manner that works as people use your library... 16:10:46 bknudson : we file reviews in consumers first and then release 16:11:00 just like we catch backwards incompat bugs today 16:11:51 +1 v1/v2/v3 starts to feel like ummm, we can do better... using known patterns of how to do better... 16:11:51 i just did not want to formalize on v1/v2 names as they tend to NOT go away 16:11:55 maybe we'll have caps on libs for tox eventually 16:12:37 any way let's add stuff to the review please 16:12:48 #topic Stuck Spec Review 16:12:48 #link https://review.openstack.org/#/c/103825/ (OSprofiler cross service & project profiling) 16:13:45 boris-42_ is trying really hard to get projects to accept the concept and agree on implementation 16:14:06 please take a look as this is something that will affect a lot of projects 16:14:19 (crap i forgot the oslo meeting) 16:14:30 lol 16:14:36 my specific feedback was what changes we needed in oslo.messaging and oslo.db, that was not clear to me 16:14:41 haypo : haha 16:15:22 oslo.messaging was relying on a class that we were yanking out and oslo.db was relying on a global thing that Nova no longer uses 16:15:40 for examle 16:15:42 example 16:15:45 dims: I'll take a look at oslo.db part 16:16:30 another point of contention was if we can switch it off completely for projects that do not want it enabled by default 16:16:53 agree, we need a way to disable it 16:17:09 so liaisons, please take a look at the review, there's one in openstack-specs as well i think 16:17:14 boris-42_ : are you around? 16:17:23 * harlowja_at_home although i do wonder if the projects that think they want to enable it don't quite understand how useful it is 16:17:36 jd__ : around? 16:17:39 *that think they don't want to enable it 16:18:51 harlowja_at_home : yes, hence the ask for reviews. last time there was significant pushback from nova folks i think 16:19:03 I didn't look at the spec, but I thought the idea was to have it enabled by default and triggered by special API requests 16:19:09 so you don't profile all the time 16:19:21 but you don't have to enable it explicitly and restart the services either 16:19:24 rpodolyaka : right, in the oslo-spec, what does that mean to our libraries 16:19:34 ack, will take a look 16:19:43 thanks! 16:19:48 #topic New Spec Review 16:19:48 #link https://review.openstack.org/243114 (Pluggable CMDB for oslo.config) 16:19:49 #link https://review.openstack.org/#/c/247668/ (message compression proposal) 16:20:02 api call relies of a hmac, if deployer doesn't set the hmac we can't enable it 16:20:18 if we put a default value, we introduce security issue 16:20:18 sileht: got it. thanks! 16:20:31 sileht : interesting 16:20:48 sileht what do you think of using driver-supported compression 16:20:56 dims, I like :) 16:21:06 sileht, kgiusti : https://review.openstack.org/#/c/247668/ 16:21:17 ozamiatin__ ^^ 16:21:32 dims, I was thinking of using msgpack in the past as a new message format, but the compression approach looks better 16:21:35 dims: +1 already) 16:21:53 tcammann : i think https://review.openstack.org/#/c/243114/ is ready now 16:21:56 interesting... 16:22:08 lxsli : you had looked at https://review.openstack.org/#/c/243114/ as well, please take another look 16:22:30 * harlowja_at_home woah we have messages that pass through openstack that are dozens of MB in size :-/ 16:22:56 sounds like, ummm, that should be fixed, ha 16:23:02 harlowja_at_home, I agree that's ugly 16:23:06 kgiusti : one thing that ozamiatin__ and others were looking at was, if we could do a compression before we hit the driver. but apparently some drivers like zmq using pickled stuff 16:23:19 harlowja_at_home : +10000 16:23:20 crazy ugly, lol 16:23:43 kgiusti and kombu for example has compression built in 16:23:54 dims: amqp1 driver doesn't have compression built in 16:24:07 which messages are these? any idears? (scheduler select * hosts message?) 16:24:07 dims: so something above the driver would be the only option atm 16:24:24 dims: re-reviewed that this morning 16:24:26 also another issue that crops up is rolling upgrades 16:24:29 lxsli thanks! 16:25:05 we can just ask some stats on message sizes in a comment on the spec 16:25:06 dims: IIRC nothing in amqp1 needs access to the msg contents, so pre compressed isn't a problem 16:25:10 kgiusti : so would it be ok for some drivers to use "above the driver" and some use "in the driver"? 16:25:14 haypo, +1 16:25:29 dims: we should allow for that IMHO 16:25:48 kgiusti : cool, please chime in on the review when you get a chance 16:25:55 about upgrades, just a description of how the driver should take care of the new format should be suffiscient 16:25:57 dims: will do 16:26:15 dhellmann, harlowja_at_home : would love your input to https://review.openstack.org/#/c/243114/ 16:26:41 oslo.config changes are scary :) 16:26:51 dims, yup, i'll look over that one again, i'm fine with it honestly, it will be interesting to see where it goes, 16:26:51 dims : yes, I'm deeply skeptical of this being a good idea 16:26:57 lol 16:27:33 can we stop making *everything* pluggable in openstack please? 16:27:36 dhellmann : the idea is for a container to start up say using keystone, and when the container is starting up, it pulls the configuration needed to start itself 16:27:45 haypo, impossible! 16:27:46 haypo : use case ^^ 16:27:46 lol 16:27:49 (i didn't read the spec) 16:27:56 the central config service becomes a single-point-of-failure for the entire cluster, it introduces all sorts of complexity and synchronicity issues, *and* it doesn't eliminate the need to have client-specific configuration (client id at least) on each node 16:28:30 dims : sure, I understand it, I just think it's a bad idea ^^ 16:28:36 lol :) 16:28:47 please let's tell them about potential problems :) 16:29:06 #topic Open discussion 16:29:07 Any other stuck reviews? 16:29:11 open floor 16:29:34 so another option is to have oslo.cmdb or something that provides common cmdb -> oslo.config translators or something 16:30:06 amrith : kzaitsev_mb : kragniz : jecarey : anything from your side? 16:30:06 yes, i would like your opinion on https://review.openstack.org/#/c/250731/ "Fix request_id type on Python 3: use text (Unicode)" IHMO my change fixes a bug in oslo.context, but dhellmann complains (as always) that "i break the API" 16:30:36 If people can take a look to this https://review.openstack.org/#/c/234716/, and tell me if this looks good or not or need a spec to discus 16:30:39 my change only impacts python 3, and i checked most openstack projects, to update them (see the comments and dependency list) 16:30:42 dims, nothing from my side. I thought there was something to bring up last week at the meeting but it turned out to be a false alarm. 16:30:51 sileht : does it break API for python 2.7? 16:31:06 dims: nothing here either 16:31:06 * dhellmann refers haypo to the number of library releases in the last year blocked from global-requirements because of breaking API changes 16:31:12 dims, I guess you mean haypo 16:31:18 oops yes 16:31:36 dhellmann : right 16:31:40 dims: my change is specific to python 3, it doesn't change oslo.context on python 2 16:31:51 sileht, i'll look over for that today 16:31:51 haypo, is python 4 out yet? 16:31:57 haypo : so you're saying that things will only break when applications start trying to port to python 3? 16:32:06 haypo : so if we break, we'd break python3 unit tests 16:32:22 dhellmann: the major risk is breaking voting python3 jobs 16:32:27 don't even joke about python 4. 16:32:36 bknudson : haha 16:32:42 haypo : right. 16:32:44 :) 16:32:59 I think request ID is bytes is a bug. 16:33:08 should be text 16:33:58 haypo : you have looked for and ran tests on lots of projects already right? 16:34:13 amrith : thanks 16:34:16 dims: "major" projects yes 16:34:38 haypo : and searched using codesearch.openstack.org too 16:35:08 * harlowja_at_home just learned about codesearch 16:35:18 dims: cinder, neutron, nova, ceilometer, heat 16:35:20 harlowja_at_home : that was intentional plug :) 16:35:43 dims: yes. but i'm not sure that my search is enough to find all cases 16:36:00 haypo : let's drop an email to the -dev list as heads up, wait for all the Depends-On to merge that you filed already 16:36:28 bknudson: "I think request ID is bytes is a bug. should be text" exactly. oslo.log currents write lines like [b'req-83a6...' 54492... - - -] ... 16:36:39 and then let the change in 16:36:49 dims: an email to [all]? 16:37:01 haypo [oslo][all] 16:37:24 dhellmann did offer a way around this 16:38:06 haypo : what's the counter to doug's work around? 16:39:10 quickly rip off band-aid? :) 16:39:51 dims: sorry, which work around? 16:40:13 haypo : "Instead of changing the return type of this function, we could add a new function that returns a unicode string, deprecate the old function, and update all of our applications to use the new one " 16:40:34 dims: my problem is the .request_id attribute, i don't care of the generate_request_id() function, i guess that it's not called directly (but i didn't check) 16:40:58 dims: i don't want to deprecate the .request_id, it's like used everyone (i guess) 16:41:02 everywhere* 16:41:08 ack thanks haypo 16:41:21 any other reviews or things to discuss? 16:41:55 dhellmann mentioned a multi-callback system on um... 16:42:07 https://review.openstack.org/#/c/251422 16:42:07 * harlowja_at_home should try to write up an oslo blog entry soon 16:42:19 harlowja_at_home : ++ 16:42:19 i swear i'm gonna finally do it! lol 16:42:21 From taskflow. Is that a thing? 16:42:41 lxsli : yeah, I really thought at the summit we said we wouldn't put callbacks into oslo.config at all, so I'm surprised to see it growing support for handling multiple callbacks. 16:42:51 lxsli, define thing :-P 16:42:52 taskflow is a thing, ha 16:43:11 dhellmann: I was in Nova meetings the whole summit so please educate me 16:43:38 lxsli : the idea is that since the service-level code receives whatever signal to trigger the config reload, it can handle that, the application updates, and any other libraries at the same time 16:43:40 dhellmann: what's your solution and will it take more than 6 months to achieve? 16:44:01 lxsli : I'm just saying this code needs to live somewhere else. 16:44:18 dhellmann: OK seems fair - then I'd like to remove the singular hook before oslo.config releases next 16:44:21 oslo.config is at the bottom of the stack right now, and we don't want to make it really complicated 16:44:28 lxsli, http://docs.openstack.org/developer/taskflow/types.html#taskflow.types.notifier.Notifier was an idea, but i think we didn't want to go there yet, but maybe people still want to 16:44:28 lxsli : yes, I'll +2 that change if you ping me 16:44:34 will do, cheers 16:44:41 dims : is this what you remember? ^^ 16:45:14 dhellmann : don't recall, will find my notes later 16:45:20 dims : ack 16:45:45 I'm trying to remember if that was an oslo session, or if it was the cross-project session on reloading config data. Probably the latter. 16:45:59 dhellmann : yes, it was probably the latter 16:46:01 * harlowja_at_home thinks it was the latter 16:46:14 as i did not attend it LOL 16:46:26 dims : oh, right 16:46:40 harlowja_at_home : were you in that session? am I remembering correctly? 16:47:03 dhellmann, don't think i was, i just heard your results from what i remember 16:47:16 (your summary) 16:47:46 17:30 < sileht> If people can take a look to this https://review.openstack.org/#/c/234716/, and tell me if this looks good or not or need a spec to discus 16:48:54 https://etherpad.openstack.org/p/mitaka-cross-project-dynamic-config-services dhellmann dims i think that was the one 16:49:19 k let's take this to our channel and let everyone else go. 16:49:28 thanks everyone! 16:49:35 np 16:49:36 #endmeeting