14:00:24 #startmeeting powervm_driver_meeting 14:00:25 Meeting started Tue Jan 9 14:00:24 2018 UTC and is due to finish in 60 minutes. The chair is esberglu. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:27 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:30 The meeting name has been set to 'powervm_driver_meeting' 14:00:54 \o 14:01:38 o/ 14:02:03 #topic In-tree Driver 14:02:23 The pypowervm uc change merged yesterday 14:02:35 OVS has passed CI and is ready for reviews 14:03:06 awesome 14:03:15 I ran SEA CI IT manually and it looked good and merged last night 14:03:20 I pinged mriedem and sdague to start reviewing yesterday afternoon 14:03:36 I merged the *-powervm requirements bumps this morning. 14:03:44 However it's broken on the actual SEA patch, but works for everything else 14:04:08 do we know why? 14:04:11 When it tries to apply the OVS & SEA patches onto the SEA patch it gets a merge failure 14:04:21 We hit this last release and I thought we fixed it 14:04:43 did we only fix it OOT? 14:04:49 But we've changed a few things with how we set up the repos since then 14:05:16 No this would probably hit that as well, just not a very common case 14:05:35 That's first on my list today 14:05:41 yep 14:06:03 I will let mriedem and sdague know the OVS is fully ready, SEA we're still working a CI issue 14:06:17 edmondsw: Cool tx 14:06:43 The vSCSI patch is looking good functionally. I need to clean up the comment throughout a couple of the files that are outdated, missing params, returns, etc. 14:07:23 The UT is passing tox locally, but some of the tests are failing the gerrit tox 14:07:44 Have you -r'd locally? 14:09:05 efried: Not recently, but I have at some point since they started failing upstream 14:09:08 https://review.openstack.org/#/c/526094/15/nova/tests/unit/virt/powervm/volume/test_vscsi.py 14:09:18 It's various tests in this file, not the same ones every time 14:09:42 hm, that doesn't bode well. 14:10:00 I think that they may just be taking too long? 14:10:02 http://logs.openstack.org/94/526094/15/check/openstack-tox-py27/c736859/job-output.txt.gz#_2018-01-08_21_19_34_770605 14:11:54 These tests call the top level attach/detach_volume methods and test the entire flows in each test 14:13:03 does sound like a potential timeout issue 14:13:04 Which is not how most of the other UT for the IT work has been done, that was mostly smaller sets of code in each UT 14:13:13 yeah, UT should be smaller 14:13:38 I based them off of the OOT tests, I've been trying to keep them as in sync as I can 14:13:43 Think it's worth reworking? 14:13:55 we might have to 14:13:56 If that is indeed the issue 14:14:14 you could try bumping the timeouts first and see if that resolves them 14:14:25 to confirm the issue is what we think it is 14:14:52 I can't bump the timeouts, they're passing locally and I can't control the upstream zuul 14:15:10 oh I meant locally 14:15:59 It's just one file, it shouldn't be that much work to break the UT into smaller sections 14:16:09 k, let's start there 14:17:04 or reduce the timeouts locally and see if the same kind of errors pop up. 14:17:21 Sure I can try that 14:17:35 That's all I had for IT, any other thoughts from you guys? 14:17:56 efried will you be able to review the SEA and OVS patches today? 14:18:07 Just finished the OVS patch. 14:18:13 sweet 14:18:26 Will look at the SEA patch. 14:18:34 Been ignoring vSCSI because WIP and Zuul -1 14:18:43 yep 14:19:27 esberglu let us know when we should start looking at vSCSI, or if there are parts of it we should start looking at, like the non-test bits? 14:19:45 I would appreciate reviews for vSCSI sooner rather than later 14:20:01 The UT is ready for review except for test_vscsi.py 14:20:38 ok, I'll review that today 14:21:17 tx 14:22:46 #topic Out-of-tree Driver 14:22:57 I merged the *-powervm requirements bumps this morning. 14:23:16 The only thing I had OOT was the SaveBDM stuff from yesterday 14:24:04 that was OOT? 14:24:18 I thought that was part of the IT vSCSI work 14:24:43 Well I'm assuming the same errors I was hitting IT will hit OOT, but don't have an OOT stack right now to confirm 14:24:59 oh, sure 14:25:32 The plan from yesterday was to confirm that it hits OOT as well, and remove if it's not needed there either 14:26:00 I'm not sure if it's needed for live migration or something 14:26:02 yep, absolutely 14:26:14 all changes that we've made in the IT patches should be worked back to OOT 14:26:22 for OVS and SEA as well as vSCSI 14:27:46 Yep 14:27:50 I'll fix the tests for that bdm cleanup patch I threw up yesterday... should have that up again in a few min 14:28:13 I'm not thinking of anything else OOT of the top of my head 14:28:17 I'll put together a list on the etherpad 14:29:07 #topic Device Passthrough 14:30:57 efried: Anything to discuss here? 14:31:54 I can summarize the current status of the work in nova if you like, but in general we've just got quite a lot of work to squeeze in before feature freeze. I'm heads down on that. 14:32:11 * efried apparently has multiple heads 14:32:36 just don't start talking to yourself :) 14:33:01 we can probably skip the summary and give you time to do the work for today 14:33:16 Whereas I wouldn't object to reviews from you guys, that's not strictly necessary; and there's really nothing else y'all can do to help without significant ramp-up. 14:33:25 esberglu there was also a summary on the ML a couple days ago 14:33:34 yep 14:33:43 Though edmondsw and charles may want to review the report client stuff out of interest since you're going to be working up similar code for pvc 14:33:57 efried link? 14:34:21 Series starting at https://review.openstack.org/#/c/521685/ 14:34:37 tx 14:35:08 Goal this week will be to clear some of those WIPs at the top 14:35:26 (and get those bottom ones merged - that's on cores now) 14:36:13 looks like the bottom two are in the gate, cool. 14:36:31 Nothing else from me. 14:36:44 [looks like the bottom two are in the gate, cool.] <== so edmondsw don't -1 them! 14:36:58 lol... sure 14:37:48 Alright sounds like we can move on 14:37:51 #topic PowerVM CI 14:38:08 Not much to talk about here other than the issue already mentioned 14:38:23 ping me when you figure that one out? 14:38:31 edmondsw: ok 14:39:01 I don't have anything else 14:39:23 After feature freeze I'd like to be heads down on CI for a bit 14:39:35 Matthew Edmonds proposed openstack/nova-powervm master: cleanup private bdm methods https://review.openstack.org/531874 14:39:44 I want to upgrade the undercloud to pike, update all of the management services 14:40:10 And have a ton of other small changes/cleanup to do 14:40:25 ok, tx for the heads up... I think we can afford that after ff 14:41:06 Oh and get depends-on working 14:41:18 meh, low priority 14:41:42 #topic Open Discussion 14:42:16 Nothing else from me 14:42:20 same 14:44:19 #endmeeting