17:00:32 <mtreinish> #startmeeting qa
17:00:33 <openstack> Meeting started Thu Dec 17 17:00:32 2015 UTC and is due to finish in 60 minutes.  The chair is mtreinish. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:34 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:37 <openstack> The meeting name has been set to 'qa'
17:00:48 <mtreinish> hi, who's here today?
17:00:49 <mkoderer> hello
17:00:55 <dwalleck> o/
17:01:08 <mtreinish> #link https://wiki.openstack.org/wiki/Meetings/QATeamMeeting#Proposed_Agenda_for_December_17th_2015_.281700_UTC.29
17:01:15 <mtreinish> ^^^ today's agenda
17:01:49 <andreaf> o/
17:02:51 <mtreinish> let's get started
17:02:57 <mtreinish> #topic Specs Reviews
17:03:03 <mtreinish> #link https://review.openstack.org/#/q/status:open+project:openstack/qa-specs,n,z
17:03:29 <dpaterson> o/
17:03:29 <mtreinish> we've got a couple of open specs still
17:03:35 <mtreinish> #link https://review.openstack.org/173334
17:03:52 <mtreinish> and
17:03:54 <mtreinish> #link https://review.openstack.org/233187
17:04:05 <mtreinish> although there both from andreaf now that I look at it :)
17:04:15 <mtreinish> and 1 still needs to be updated
17:04:38 <mtreinish> but just a reminder that we should still keep an eye on specs. We don't want things to bog down there
17:04:59 <andreaf> yes I need to update the specs - but I think they could use reviews anyways
17:05:15 <mkoderer> I have time for reviews tomorrow.. will do
17:05:47 <andreaf> regarding test-resources, afazekas proposed to use testfixtures and testresources there, but it's not clear to me how they would fit really
17:06:47 <andreaf> regarding the o-h one, I will update it, and we probably could close it as well then as the 4 pages are up and running now
17:07:19 <mtreinish> andreaf: do we even want to bother anymore with the o-h spec?
17:07:47 <mtreinish> as for the testfixtures testresources, yeah I'm not sure where that would fit in. Unless he's saying make the test interface to the resources a fixture
17:08:06 <andreaf> mtreinish: I thought it was nice to have it there, but it's probably more interesting have docs on o-h side
17:08:35 <mkoderer> andreaf: +1 for docs
17:09:16 <mtreinish> andreaf: yeah I think just having docs would be better
17:09:31 <andreaf> mtreinish: also it would be great to have your review on the resources spec :)
17:09:40 <mtreinish> it would have been better if we wrote a spec in ft collins when we started the project, but it's a bit late now
17:09:46 <mtreinish> andreaf: sure I'll try to take a look post-meeting
17:09:51 <mtreinish> ok is there anything else on specs?
17:09:55 <andreaf> there is also another spec I've started implementing, #link https://review.openstack.org/#/c/92804/ - this is very very old
17:10:29 <andreaf> but rather than trying to get the spec up to date I started implementing it, as it's easier to understand what I had in mind there
17:10:40 <dmellado> o/ sorry for the late arrival
17:10:51 <mkoderer> dmellado: np
17:11:02 <andreaf> #link https://review.openstack.org/#/c/258566/ - this is the first patch, I'd love more reviews / opinions on that
17:11:19 <andreaf> it's a client manager refactor / split
17:11:39 <andreaf> to provide a client manager that can go to tempest-lib and lazy load of clients
17:11:58 <mkoderer> andreaf: this is really needed
17:12:15 <mtreinish> andreaf: wow, that is an older spec. Like you first submitted it when we started specs
17:12:39 <andreaf> mtreinish: :D indeed
17:13:16 <mkoderer> andreaf: should we try to convert the manila client to see how it's working?
17:14:10 <andreaf> mkoderer: sure - I'd love that - the register interface is not implemented yet, but it shouldn't take me long
17:14:30 <mkoderer> andreaf: are you working on that tomorrow? we can try to spilt the effort
17:14:59 <andreaf> I also think this will help with the clients refactors, as it's painful to carry around many clients where it used to be one
17:15:15 <andreaf> mkoderer: yes, I will be working on this topic tomorrow most likely
17:15:30 <mkoderer> andreaf: ok cool I will ping you
17:15:32 <andreaf> mkoderer: let's sync in IRC
17:15:59 <mtreinish> ok, let's move on
17:16:12 <mtreinish> #topic Priority Items
17:16:19 <mtreinish> #link https://etherpad.openstack.org/p/mitaka-qa-priorities
17:16:37 <mtreinish> Does anyone have anything to discuss on any of the priority work items?
17:17:26 <mtreinish> andreaf, jlanoux: how goes the ssh auth stuff?
17:18:11 <andreaf> mtreinish: the patch to fix the deprecation part is done
17:18:23 <jlanoux> #link https://review.openstack.org/#/c/253444/
17:18:42 <jlanoux> after that, I plan to do the wrapper around compute and remote_client
17:18:59 <andreaf> mtreinish: there is also work to be done to take some of the neutron scenario tests functionality out and back into the validation framework
17:19:40 <mtreinish> andreaf: do you have an example?
17:19:41 <andreaf> mtreinish: but honestly I would even consider that an extra - post spec work -
17:19:50 <mtreinish> sure, that wasn't part of the spec
17:20:04 <mtreinish> I'd just like to see the spec finally finished :)
17:20:09 <mtreinish> it's been a long road
17:20:24 <andreaf> mtreinish: well the scenario tests have a lot of validation helpers, everytime I try to follow the code through them I get lost
17:20:47 <andreaf> mtreinish: and it would be good to make sure they all as much as possible honour all validation settings
17:21:06 <mtreinish> andreaf: right, I agree
17:21:11 <afazekas> self.var usage is confusing , we should do more explicit parameter passing
17:21:29 <andreaf> afazekas: +100
17:21:44 <mtreinish> afazekas: yes, there is a bug open for that (or there was) there were patches starting to clean it up
17:21:47 <mtreinish> but it's still a mess
17:22:55 <mtreinish> ok, is there anything else on priority efforts?
17:22:58 <dpaterson> two cli patches could use reviews
17:23:07 <dpaterson> #link https://review.openstack.org/#/c/247240/
17:23:17 <dpaterson> #link https://review.openstack.org/#/c/252428/
17:23:52 <dwalleck> I'll have a look at them this afternoon
17:24:47 <mtreinish> ok, let's move on
17:24:55 <mtreinish> #topic Tempest
17:25:12 <mtreinish> there are 2 items on the agenda for tempest
17:25:28 <mtreinish> mkoderer: yours is up first :)
17:25:32 <mkoderer> ok :)
17:25:44 <mkoderer> IMHO we have an issue with logging and tempest CLI
17:25:59 <mkoderer> the this is that logging.conf isn't really used
17:26:07 <dmellado> wasn't the log environment not working anymore?
17:26:10 <dmellado> yep
17:26:38 <mkoderer> so all the scripts log to tempest.log but nothing is shown on stdout
17:26:48 <mkoderer> for instance stress
17:27:13 <mkoderer> I started to clean it up here https://review.openstack.org/#/c/258955
17:27:52 <mkoderer> but the question is: do we want a default logging.conf that defines stdout logging for all cmd output
17:28:37 <mkoderer> or we use "print" for all the user output
17:29:02 <mtreinish> mkoderer: I'm thinking if we want to do stdout we should just use print
17:29:18 <mtreinish> or manually write to sys.stdout
17:29:23 <mkoderer> mtreinish: that fine for me
17:29:43 <mtreinish> I feel like the logging should probably be left configurable for users
17:30:19 <mkoderer> mtreinish: so I will fix stress and cleanup cmd then
17:30:26 <mtreinish> ok, cool
17:30:38 <dpaterson> Guess I am a bit confused, some scripts are using LOG. and some print()
17:30:53 <mtreinish> dpaterson: yeah, that's the issue :)
17:30:54 <dpaterson> Are you saying we should change all to print()?
17:31:16 <mtreinish> dpaterson: if the tool wants something to go to stdout (like final output of a command) it should use print
17:31:18 <mkoderer> dpaterson: no.. log messages we use LOG but for user output we use print
17:31:44 <mkoderer> dpaterson: for instance the statistics of the stress test run should go to stdout
17:32:41 <mkoderer> ok I push some patches tomorrow
17:33:03 <mtreinish> ok, then the other topic under tempest was from me
17:33:20 <mtreinish> about removing the ec2 tests from tempest
17:33:21 <dpaterson> mkoderer: I'm fine with refactoring all cmd scripts, I was trying to get them to parity with cliff first
17:33:31 <mtreinish> #link https://review.openstack.org/#/c/222737/
17:33:35 <dpaterson> I noticed the inconsistancies too
17:34:11 <mtreinish> basically nova has deprecated their in-tree ec2 implementation, and want to remove it soon
17:34:21 <mkoderer> dpaterson: yeah cool let's have a review on it tomorrow
17:34:32 <mtreinish> but the tempest tests are blocking that. We also said the only reason we keep the tests in tree is because nova has it in tree
17:34:59 <dpaterson> mkoderer: sure, tx
17:35:00 <dmellado> mtreinish: then it looks like a straightforward move to remove them too
17:35:13 <mtreinish> so I made a tempest plugin with the code and put it up on github (also the ec2-api project has their own tempest plugin) to preserve the tests
17:35:25 <mtreinish> just in case someone want to use them for something in the future
17:35:32 <mtreinish> dmellado: yep
17:35:36 <mkoderer> mtreinish: +1
17:35:40 <dmellado> +1
17:35:44 <mtreinish> I've brought it up on the ML before too
17:36:00 <mtreinish> I just wanted to bring it up on the meeting, because we should be good to land the removal patch
17:36:18 <mtreinish> I'll push a tag after we remove it to signify the removal
17:37:29 <mtreinish> ok, does anyone else have anything else to discuss on tempest this week?
17:37:49 <andreaf> mtreinish: I had some comment on that patch, I'll re-review tomorrow if that's ok
17:38:10 <mtreinish> andreaf: that's fine. (although dims respun the patch to jsut remove the options)
17:39:34 <mtreinish> ok, if there's nothing else let's move on
17:39:45 <mtreinish> #topic DevStack + Grenade
17:40:00 <mtreinish> does anyone have anything to discuss about devstack or grenade?
17:40:06 <mtreinish> sdague, dtroyer: ^^^
17:40:42 <sdague> the extras.d patch landed
17:40:44 <sdague> finally
17:40:51 <mtreinish> yay
17:41:02 <mtreinish> it only took a week of rechecks :)
17:41:12 <sdague> yeh
17:41:32 <sdague> I also brought over some code from d-g to make our apt_get_update more resilient to mirror breaks
17:41:40 <sdague> that seems to be helping, as is backported
17:42:06 <mtreinish> cool
17:42:17 <sdague> I've also got a new angle on the "can't ssh" to test nodes issue
17:42:30 <sdague> which is that there is a race in the fixed ip allocator in nova
17:42:45 <sdague> where we might allocate an ip that has an oustanding lease
17:43:03 <sdague> so the guest won't get a valid ip, and dhcp fails
17:43:09 <sdague> there is a nova patch up for that
17:43:16 <sdague> I can't wait to see how that impacts things
17:43:26 <mtreinish> cool, that does sound like it could impact things for the better
17:43:38 <mtreinish> do you have a link to the patch?
17:44:59 <mtreinish> ok, does anyone else have anything to discuss on devstack or grenade this week?
17:46:11 <mtreinish> ok, then lets move on
17:46:15 <mtreinish> #topic Critical Reviews
17:46:36 <mtreinish> does anyone have any reviews they'd like to get extra eyes on?
17:48:06 <afazekas> https://review.openstack.org/#/c/257557/
17:48:59 <mtreinish> afazekas: yeah that does feel like something that should be a neutron side fix
17:49:13 <mtreinish> afazekas: I'll follow up with armax or someone to get them to weigh in on it
17:49:37 <afazekas> mtreinish: Actually it is not, but IMHO the neutron agent scheduler tests should be in the neutron repo
17:49:48 <afazekas> These kind of behaviors kind of internal.
17:50:11 <mtreinish> afazekas: oh, yeah that definitely feels like an internal neutron thing
17:50:30 <mtreinish> are there any other reviews?
17:51:33 <mtreinish> ok, then lets open up the floor
17:51:38 <mtreinish> #topic Open Discussion
17:51:53 <mtreinish> does anyone have something they'd like to discuss that wasn't on the agenda?
17:53:23 <mtreinish> oh, one thing is I'm gonna cancel the next 2 meetings
17:53:37 <mtreinish> because of the holidays I expect not too many people will be around
17:53:38 <dmellado> +1 from me, almost everybody would be out for Christmas
17:53:57 <mtreinish> I'll send something to the ML about that today
17:54:15 <mtreinish> ok, if there isn't anything else I'll end here
17:54:19 <mtreinish> thanks everyone
17:54:22 <mtreinish> #endmeeting