21:01:07 <danwent> #startmeeting quantum
21:01:08 <openstack> Meeting started Mon Nov 19 21:01:07 2012 UTC.  The chair is danwent. Information about MeetBot at http://wiki.debian.org/MeetBot.
21:01:09 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
21:01:10 <openstack> The meeting name has been set to 'quantum'
21:01:11 <salv-orlando> hi!
21:01:19 <danwent> #info agenda: http://wiki.openstack.org/Network/Meetings
21:01:26 <magana> hello all!
21:01:44 <danwent> #info grizzly-1 branch date is end-of-work tomorrow
21:02:11 <danwent> so the only changes we'll make to G-1 past that point are "critical" bugs
21:02:29 <magana> do we have a list of them?
21:02:47 <danwent> of course, this early in the cycle, there's no need to "cram" extra features into G-1, as the difference between being in G-1 and G-2 are not major
21:03:08 <danwent> so don't feel we need to get something merged if we don't feel like there was enough time to review… good reviews take priority
21:03:42 <danwent> magana: there are known outstanding at this point, but if they popped up in testing, then we would only merge a serious fix into the G-1 milestone proposed branch
21:03:57 <danwent> #info current status of grizzly https://launchpad.net/quantum/+milestone/grizzly-1
21:04:32 <danwent> so from a feature perspective, we should be focused on only those 4 features in terms of reviews.
21:04:36 <danwent> let's go through them
21:04:43 <danwent> https://blueprints.launchpad.net/quantum/+spec/quantum-security-groups-iptables
21:04:51 <danwent> https://review.openstack.org/#/c/16210/
21:05:00 <garyk> danwent: i have started to review that
21:05:09 <nati_uen_> I got review comment from garyk, akihiro, aaron
21:05:12 <arosen> me too
21:05:18 <nati_uen_> I'll fix the comment in 5 hours
21:05:22 <danwent> ok, looks like we're covered in terms of reviewers
21:05:53 <garyk> nati_uen_: take your time. i'll be in the office in another 8 or 9.
21:06:05 <nati_uen_> garyk: Thanks
21:06:05 <danwent> Ok, I will need to know for sure about this by the main openstack meeting tomorrow
21:06:43 <danwent> so let's have people do one more round of reviews after nachi's next patchset, and then we'll need to figure out if we're just talking about consemtic changes needed, or anything structural
21:07:09 <danwent> nati_ueno: can you ping me tomorrow morning (pacific time) about status and we'll decide to keep in G-1 or move to G-2?
21:07:22 <nati_ueno> danwent: I got it. I'll mail you about the situation of nest round.
21:07:31 <danwent> ok, next up: https://blueprints.launchpad.net/quantum/+spec/rpc-for-l3-agent
21:07:37 <danwent> https://review.openstack.org/#/c/15619/
21:07:44 <gongysh> salvatore:  I will have a look at the problem you mentioned. I hope it is true.
21:07:57 <salv-orlando> I hope it is not true actually
21:08:00 <danwent> have the big picture design questions been figured out here?
21:08:42 <salv-orlando> I'd like to hear from markmcclain too. I'd say that there are aspect which can be improved, but overall the patch is by itself a good improvement
21:08:53 <danwent> markmcclain ?
21:08:54 <salv-orlando> so I think we can do other improvements incrementally
21:09:09 <markmcclain> salv-orlando: I've gotten through part of it, just not all of it
21:09:10 <danwent> again, I don't want to "ram" this in just b/c of G-1… if we feel like it needs more discussion, that is OK.
21:09:43 <danwent> Ok, markmcclain , do you anticipate finishing review by later today?
21:09:47 <markmcclain> yes
21:09:56 <danwent> i guess it already is later today in your neck of the woods :P
21:10:16 <danwent> ok.  I'l check the review later.
21:10:34 <gongysh> markmcclain:  it is blocking other fetures, multi host , scheduler and multi instance.
21:10:49 <markmcclain> right
21:10:51 <danwent> gongysh: yes, but we need to make sure we're merging good designs as well
21:10:53 <danwent> its a balance :)
21:10:58 <gongysh> that are important to large scale deployment.
21:11:07 <salv-orlando> gongysh: indeed
21:11:23 <gongysh> so take the time to review it.
21:11:29 <salv-orlando> that's why your patch is being granted extra care :)
21:11:33 <gongysh> make it progress.
21:11:40 <danwent> gongysh: please be polite :)
21:12:06 <gongysh> dan: hi i am polite to all of u guys. :)
21:12:22 <danwent> Ok, so I am going to plan on this going in tomorrow.  If there are any serious red flags, please raise it on the main ML, as this has been in review for a while
21:12:56 <danwent> ok, next up, markmcclain https://blueprints.launchpad.net/quantum/+spec/metadata-overlapping-networks
21:13:15 <danwent> https://review.openstack.org/#/c/16282/
21:13:20 <danwent> this relies on a nova patch as well
21:13:54 <danwent> https://review.openstack.org/#/c/16281/
21:14:03 <garyk> danwent: markmcclain i ran into some issues here (with all 3 patches)
21:14:21 <gongysh> markmcclain: I like this feature.
21:14:23 <danwent> seems like there's no real action on the nova review from nova cores, so i'm guessing this as an entire feature-set will not arrive in G-1
21:14:41 <danwent> yes, i can't wait to have this :)
21:14:59 <markmcclain> yeah.. I'll to pester a few devs
21:15:15 <garyk> markmcclain: is the nova side backward compatible?
21:15:17 <markmcclain> *nova devs, but I think it will help to make sure we're +1 on it first
21:15:19 <danwent> markmcclain: ok, let me know if I can help with that...
21:15:31 <markmcclain> yes.. the nova changes are 100% backwards compatible
21:15:53 <garyk> markmcclain: great. i think that if you state this in the commit message then it will certain help move it forward
21:16:07 <markmcclain> ok.. I'll update the commit message
21:16:19 <markmcclain> garyk: I can't find your probs that you reported
21:16:20 <garyk> markmcclain: thanks
21:16:24 <markmcclain> can you resend them?
21:16:38 <garyk> markmcclain: sure.
21:16:48 <markmcclain> thanks
21:16:54 <gongysh> markmcclain: I need a simple chart to show your idea of the BP.
21:17:02 <danwent> markmcclain: as I mentioned in my review, I'd like to see at least a design sketch on LP on this, particular describing the two different flows (as I understand it).
21:17:32 <markmcclain> yeah.. working on those to make the review easier to understand
21:17:35 <danwent> doesn't need to be a book, just the "big picture" to help reviewers have context, and to help people writing the docs understand what's going on.
21:17:57 <gongysh> great minds think alike...
21:18:03 <danwent> Ok, so i'm going to continue to work on this, but my guess is that this is less likely to be completely merged (quantum + nova) in G-1
21:18:32 <danwent> markmcclain: let's sync up before the main openstack meeting tomorrow
21:18:41 <danwent> and see how things have progressed
21:18:47 <markmcclain> ok.. I'll ping you PST morning
21:18:52 <danwent> thx
21:19:20 <danwent> https://blueprints.launchpad.net/quantum/+spec/quantum-service-framework
21:19:31 <salv-orlando> it's in a good shape
21:19:34 <enikanorov_> all comments've been resolved so far. I'm waiting for approval.
21:19:49 <salv-orlando> I am giving it a last round of tests, then will +2 if nothing comes up (but nothing should)
21:19:49 <danwent> https://review.openstack.org/#/c/15733/
21:20:26 <danwent> ok, will keep it targeted.  if something pops up, please notify me, otherwise i'll assume it merges tomorrow.
21:20:36 <markmcclain> I'm close to a +2 on it too
21:20:37 <danwent> i see gongysh and garyk as other recent core revewers
21:20:53 <magana> salv-orlando: let me review it as well no later that that 3:00pm PST
21:20:56 <danwent> ok, markmcclain , i'll count on you as second core dev
21:21:03 <garyk> danwent: i had some minor nits. thay have been addressed
21:21:28 <danwent> holy jesus there's been a lot of comments/updates on gerrit for that review :P
21:21:43 <danwent> ok, so those are the outstanding features
21:21:44 <enikanorov_> yep
21:21:49 <gongysh> danwent: my comments have be dealt with.
21:22:02 <enikanorov_> i'd prefer to recieve "nits" in a pack rather than 1 per update
21:22:06 <gongysh> I will check if I can give +2 first.
21:22:19 <danwent> gongysh: ok, can you put a minus on it, so others know not to merge?
21:22:31 <salv-orlando> seems like I'm not required anymore.
21:22:31 <gongysh> fine. Yes sir.
21:22:34 <danwent> let's try to get that wrapped up today
21:22:44 <danwent> enikanorov_: i imagine its late-night for you?
21:22:54 <enikanorov_> yes, as usual
21:22:54 <salv-orlando> So I'll put this way: I'll -2 if something is really wrong :)
21:23:10 <danwent> so let's try to get all outstanding issue on this patch in so enikanorov_ sees them in his AM.
21:23:32 <enikanorov_> that would be great
21:23:41 <salv-orlando> danwent: agreed.
21:24:04 <danwent> but similar to the l3-rpc branch, there are a lot of dependencies here, so the sooner the better
21:24:15 <danwent> ok, now onto bugs
21:24:47 <danwent> we want to particular focus on bugs that are relevant for folsom, as we're planning on pushing distros to make sure they take all our stable changes at the end of G-1
21:24:54 <danwent> https://bugs.launchpad.net/quantum/+bugs?field.tag=folsom-backport-potential
21:25:09 <danwent> garyk has been the champion of stable/folsom for quantum and is leading that charge
21:25:42 <danwent> https://review.openstack.org/#/c/15758/
21:25:52 <danwent> this one is mine, i just need to respond to salv's feedback, and we should be good
21:25:56 <garyk> danwent: i think that we are looking good at the moment (the critical on you resolved has already been added to stable)
21:26:13 <danwent> https://review.openstack.org/#/c/16044/
21:26:16 <garyk> danwent: i'll review that one tomorrow
21:26:28 <danwent> ok, great, garyk will be second for this one
21:26:59 <danwent> rkukura: seems like the -1 from Alex is more of a nit?
21:27:00 <rkukura> danwent: I'll post an updated patch today that should be ready.
21:27:17 <danwent> ok, i will re-review that one
21:27:32 <garyk> danwent: rkukura this one will be a challenge to backport as the ovs code was refactored a bit...
21:27:38 <rkukura> Are log messages supposed to be internationalized?
21:27:46 <alexxu> rkukura, After you updated the patch, I will help to review again :)
21:28:08 <garyk> rkukura: i think so. not 100% sure
21:28:10 <danwent> rkukura: yes, moving forward we are going to enforce that we at least can internationalize (i.e., we use the underscore) in quantum
21:28:21 <rkukura> OK
21:29:04 <danwent> garyk: hrmmm… so we need a special backport patch?
21:29:27 <garyk> danwent: yup. i'll do it. i'll just need an extra few eyes...
21:29:39 <danwent> garyk: great
21:29:42 <rkukura> It should be straightforward
21:30:03 <danwent> are there other folsom relevant fixes we're looking to backport?
21:30:38 <danwent> garyk: only one for G-1 i had a question about was this: https://bugs.launchpad.net/bugs/1080286
21:30:39 <garyk> danwent: just the two that you mentioned. there is one still pending a fix (external networks and provider)
21:30:40 <uvirtbot> Launchpad bug 1080286 in quantum "L3 agent logging does not work" [Medium,In progress]
21:31:06 <danwent> garyk: yes, but provider networks one may be tricky from a backward compat perspective… probably not something we want to rush in.
21:31:13 <garyk> danwent: this problem is only if the G version. it was with the usage of the common logging.
21:31:15 <rkukura> I'll look at the provide networks tomorrow
21:31:23 <danwent> garyk: ah, great
21:31:33 <garyk> danwent: gongysh has resolved this with the l3-agent patch (2 birds with one stone)
21:31:33 <danwent> rkukura: cool
21:32:03 <danwent> ok, so last bug review I wanted to mention was this one: https://review.openstack.org/#/c/16151/
21:32:25 <markmcclain> this doesn't actually fix the bug
21:32:36 <danwent> in my testing, this slightly reduces the memory usage
21:32:45 <garyk> danwent: markmcclain correct - it does not solve the issue of the memory
21:32:50 <danwent> or at least seems to, given my testing of one run without it, and onewith it
21:32:56 <danwent> 1.4 GB -> 0.9 GB
21:33:09 <markmcclain> still 750 MB too much :)
21:33:14 <danwent> so the question is: is this a useful half step?
21:33:18 <danwent> clearly we need to do better
21:33:29 <garyk> danwent: yes.
21:33:49 <danwent> markmcclain: is this inline with what you think the more complete fix is?
21:34:00 <markmcclain> no
21:34:27 <danwent> markmcclain: ok, so then can you review and -2 if you don't think it should be merged?
21:34:47 <markmcclain> ok.. I think the real fix is going to be more involved
21:34:54 <markmcclain> and I'd rather it land early G2
21:35:37 <danwent> ok, is there anyone for whom the current leak is a blocker, and would be helped by memory at least going down to under 1 GB?
21:35:52 <danwent> otherwise, delaying it a bit probably has little cost
21:36:16 <salv-orlando> it is bad but I don't feel the need for rushing anything in G-1.
21:36:24 <gongysh> I think we can keep it there and hope the developer investigates more.
21:36:30 <danwent> ok, markmcclain, please -2 the review explaining why
21:36:35 <markmcclain> will do
21:36:36 <gongysh> I mean the patch.
21:36:58 <gongysh> no need to -2.
21:37:03 <gongysh> I think
21:37:04 <danwent> markmcclain: perhaps if you provide a few pointers, the developer of the existing patch might improve on it.
21:37:12 <markmcclain> that was my plan
21:37:28 <danwent> gongysh: well, if we don't think something should be merged, it should either be abandoned or -2'd otherwise others might merge it.
21:37:34 <danwent> Ok, anything else on G-1?
21:37:55 <danwent> #topic open discussion
21:38:15 <danwent> one thing I wanted to mention is that release day (thursday) is a US holiday
21:38:45 <garyk> danwent: i gues you guys will need to cancel the holiday.
21:38:45 <danwent> so those of you not in the US, please keep an eye on the ML aliases in case anything urgent pops up.
21:38:53 <danwent> garyk: haha… tell that to my wife :P
21:39:17 <danwent> salv-orlando will be the official point person for any last minute issues with G-1
21:39:26 <salv-orlando> I am totally sure that I garyk and gongysk will be more than happy thant calling you direct on the phone :)
21:39:35 <danwent> as he is completely "un-american"
21:39:50 <danwent> ok, any other open discussion?
21:40:00 <garyk> salv-orlando: please send me his cell no. i'll start practicing
21:40:08 <salv-orlando> danwent: by writing that on IRC, you've just unleashed the CIA and the FBI on me
21:40:12 <salv-orlando> oh and the NSA too
21:40:20 <danwent> :)
21:40:36 <danwent> ok, thanks folks.  keep up the great work on reviews to wrap up G-1!
21:40:39 <danwent> #endmeeting