17:08:10 <boris-42> #startmeeting Rally
17:08:11 <openstack> Meeting started Tue Mar 17 17:08:10 2015 UTC and is due to finish in 60 minutes.  The chair is boris-42. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:08:12 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:08:14 <openstack> The meeting name has been set to 'rally'
17:08:21 <oanufriev> hallloooooo
17:08:26 <amaretskiy> hi
17:08:26 <boris-42> hallooo
17:08:35 <andreykurilin> salut
17:08:38 <amaretskiy> s/hi/halloooo/
17:08:39 <rvasilets> hi
17:08:58 <meteorfox> boris-42: hi
17:09:35 <andreykurilin> boris-42: https://www.youtube.com/watch?v=Fe2s32YqGpU
17:10:11 <boris-42> andreykurilin: ^ LOL
17:10:21 <oanufriev> wassssaaaaaaaaaaaap&
17:10:23 <oanufriev> ?
17:10:54 <boris-42> wasssaaaappppp
17:10:58 <dpaterson> o/
17:11:02 <boris-42> dprince: tosky hi there
17:11:06 <tosky> (hi, lurking around)
17:11:50 <boris-42> hehe=)
17:12:23 <boris-42> So like usually short updates
17:12:26 <boris-42> #Updates
17:12:32 <boris-42> #topic Updates
17:12:50 <boris-42> Okay guys we made new release 0.0.2
17:13:14 <boris-42> who doesn't know what the hell take a look at http://boris-42.me/rally-v0-0-2-whats-new/
17:13:33 <boris-42> Our goal is to start doing releases each 2 weeks
17:13:53 <boris-42> this will allow to ship to users new features/plugins rapidly
17:14:12 <boris-42> which I think is crucial
17:14:36 <dpaterson> +1
17:15:03 <boris-42> As well the another thing regarding to releases is to start using http://semver.org/
17:15:49 <boris-42> for now 0.y.x -> 0.y.x+1 means fully backward compable
17:16:18 <boris-42> 0.y.x -> 0.y+1.0 means something changed (like depracated plugins / API were removed)
17:16:35 <e0ne> hi
17:16:40 <boris-42> e0ne: hi there
17:17:18 <boris-42> when we cut 1.0.0 release we will use semver fully
17:17:57 <meteorfox> boris-42: sounds reasonable
17:18:05 <e0ne> boris-42: +1
17:18:06 <yfried_> boris-42: semver is a guideline, not an automatic tool, right?
17:18:12 <boris-42> yfried_: yep
17:18:21 <yfried_> boris-42: ok. +1
17:18:31 <boris-42> yfried_: so I hope I won't make any mistakes as release manager=)
17:19:20 <boris-42> So as well we have some changes in read the docs
17:19:30 <boris-42> we have new menu https://rally.readthedocs.org/en/latest/
17:19:37 <boris-42> Release Notes
17:19:38 <yfried_> boris-42: so long as it's you and not me ... :)
17:19:42 <boris-42> so it will be some kind of hisotry
17:20:03 <meteorfox> cool
17:20:36 <boris-42> So I would like to discuss a bit commit message formats
17:20:43 <boris-42> #topic Commit message format
17:21:11 <boris-42> During the process of making release notes I understand that it's terrible hard task
17:21:27 <boris-42> 1) Title of commit messages sometimes are absolutelly unclear
17:21:49 <boris-42> 2) Commit message has only titile
17:21:54 <boris-42> and so on
17:22:10 <boris-42> I believe that we need to do cleanup this stuff
17:22:20 <yfried_> boris-42: ^ that's reviewer/core resp to make sure commit is good
17:22:21 <meteorfox> boris-42: I know I'm guilty of that :P
17:22:24 <tosky> shouldn't the format of commit message addressed during reviews (I mean, shouldn't the review receive -1 if the message is unclear)?
17:22:54 <boris-42> yfried_: tosky I dislike a bit this idea of manual work
17:23:01 <boris-42> people gets angry if it is not CI
17:23:03 <boris-42> =)
17:23:22 <tosky> boris-42: but that's about the semantic, a human is still needed
17:23:23 <boris-42> so I would like to have checks for commit message
17:23:32 <tosky> unless you have skynet in your computer
17:23:38 <boris-42> tosky: I have=)
17:23:54 * tosky checks for the emergency exits
17:23:55 <boris-42> so
17:24:04 * boris-42 tosky: it won't help
17:24:24 <boris-42> So let's just start from small steps
17:24:33 <boris-42> First of all is to add tags to commit message
17:24:35 <boris-42> like
17:24:58 <boris-42> [nova] Add servers benchmark context
17:25:02 <yfried_> boris-42: -1
17:25:08 <boris-42> yfried_: why so?
17:25:28 <yfried_> boris-42: I suggested this exact thing for tempest early on
17:25:45 <boris-42> yfried_: and?
17:25:51 <boris-42> yfried_: why -1 then?)
17:25:53 <yfried_> boris-42: commit subject should be less than 50 char
17:26:09 <boris-42> yfried_: I would prefer to have it 72 but with tag
17:26:17 <yfried_> boris-42: and adding tags would get in the way
17:26:20 <yfried_> boris-42: still
17:26:20 <boris-42> yfried_: it will be better then tag
17:26:27 <boris-42> yfried_: one tag is not big deal
17:26:49 <boris-42> yfried_: [nova] == 6 chars, [ceilometer] <<- 12
17:26:51 <amaretskiy> boris-42 maybe put commit message notation into doc/specs/ ?
17:26:51 <boris-42> it's not so big?
17:27:25 <boris-42> amaretskiy: you mean propose spec instead of dicussing it on Meeting?
17:27:30 <amaretskiy> no
17:27:42 <amaretskiy> I propose to discuss and then write a spec
17:27:48 <meteorfox> boris-42: I'm with yfried_ , and I liked his initial suggestion of keeping it simple, and reviewers doing commit reviews
17:27:49 <amaretskiy> so anyone can be pointed
17:28:04 <meteorfox> commit message*
17:28:25 <boris-42> meteorfox: yep message
17:28:33 <boris-42> meteorfox: okay I can do that
17:28:47 <boris-42> But the idea is to have strict format and test that automatically checks it
17:29:01 <yfried_> boris-42: [nova][neutron].. gets out of hand
17:29:29 <boris-42> yfried_: why do you need [nova] [neutron] together?
17:29:42 <yfried_> boris-42: if I write a patch for network wrapper
17:29:53 <boris-42> yfried_: it will be [network]
17:29:58 <andreykurilin> :)
17:30:09 <boris-42> yfried_: the idea is to have 1 tag
17:30:13 <boris-42> okay let me make spec
17:30:14 <andreykurilin> tags should not be strict
17:30:28 <yfried_> boris-42: andreykurilin: spec
17:30:31 <boris-42> amaretskiy: yep but it will be nice to have them if they touch specific places
17:30:45 <boris-42> so commit message body should be required
17:30:54 <boris-42> if there is word "fix" it should point to bug
17:31:01 <boris-42> and so on and so on
17:31:05 <boris-42> we can check a lot of
17:31:35 <yfried_> boris-42: http://lists.openstack.org/pipermail/openstack-dev/2013-December/023032.html
17:32:10 <boris-42> yfried_: okay but commit message is not only about tags
17:32:13 <boris-42> it's just one thing
17:32:35 <oanufriev> Let the short message contain only tags of [subsystem][action]... and long description contain long description )
17:32:37 <yfried_> boris-42: I understand. but let's cover that in spec
17:32:48 <boris-42> yfried_: sure
17:33:00 <boris-42> okay
17:33:03 <boris-42> next topics
17:33:33 <boris-42> #topic Avarage Reviewer CI
17:33:44 <boris-42> I would like to do make a bot
17:34:01 <boris-42> that will put avarage reviewer opinion as comment to patch
17:34:26 <yfried_> boris-42: could you please explain?
17:34:27 <tosky> and the goal is?
17:34:44 <boris-42> https://www.irccloud.com/pastebin/uT3kra2F
17:34:50 <boris-42> tosky: yfried_ the goal is next
17:35:03 <meteorfox> boris-42: not trying to be that guy, but I assume you meant average, not avarage?
17:35:07 <boris-42> There are bunch of patches that contains > 700-800 LOC
17:35:14 <boris-42> avarage*
17:35:25 <boris-42> average
17:35:38 <boris-42> it just explains feeling of core reviewer when he see patch
17:35:41 <meteorfox> boris-42: ok, got it
17:35:59 <yfried_> boris-42: so you want to -1 all patches above 800 LOC?
17:36:10 <boris-42> yfried_: no I don't want to -1
17:36:15 <tosky> is it kind of soft-gate check?
17:36:17 <boris-42> but put comment in review
17:36:27 <dpaterson> LOC?
17:36:29 <boris-42> from Average Code Reviewer
17:36:32 <boris-42> dpaterson: lines of code
17:36:35 <yfried_> boris-42: Lines Of Code
17:36:39 <dpaterson> tx
17:36:53 <boris-42> as well we can check is new code cover by unit tests
17:36:56 <yfried_> boris-42: well I agree, but if it's not -1, it would be ignored
17:37:10 <boris-42> yfried_: so we can make some soft/hard rules
17:37:18 <boris-42> so if evertyhing is nice +1
17:37:32 <yfried_> boris-42: like most ppl always do recheck 3-10 times before they bother to see why tempest failed their patch
17:37:35 <boris-42> if there are some bad stuff like 600 LOC there will be just comment
17:37:57 <boris-42> if things are terrible (code not covered by unit test) it will be -1
17:38:05 <boris-42> or there 2000 LOC
17:38:20 <boris-42> so 3 possible marks +1/0/-1
17:38:51 <yfried_> boris-42: the basic idea seems reasonable
17:39:27 <boris-42> yfried_: so it's quite simple to implement
17:39:40 <boris-42> yfried_: and we can store rules in rally_repo for example
17:39:52 <boris-42> so it will be simple to add/remove/refactor them
17:40:02 <boris-42> I mean we will make separated project
17:40:13 <yfried_> boris-42: but I think, like your previous topic, we should publish more strict review guidelines before we let the bot do this stuff
17:40:14 <boris-42> that is easy plugable
17:40:24 <meteorfox> yfried_: +1
17:40:28 <boris-42> yfried_: I think we can do this in parallel=)
17:40:32 <dpaterson> the bot would be useful for any project, it will go upstream somewhere?
17:40:32 <yfried_> boris-42: agreed
17:40:41 <boris-42> dpaterson: yep on stackforge
17:40:50 <boris-42> dpaterson: but it will be easy plugable like Rally
17:41:26 <yfried_> boris-42: I mean that we should feel that it's ok to "shoot down" patches for being too long or covering too many things at once and point to a specific line in "rally guidelines"
17:41:29 <dpaterson> boris-42: One doesn't already exist?  Seems like a common usecase
17:42:28 <yfried_> boris-42: if you follow the unwritten guidelines - the bot's commit message would be the actual guidelines :)
17:42:54 <boris-42> yfried_: dpaterson https://github.com/boris-42/AvgReviewer
17:43:03 <boris-42> yfried_: dpaterson going to move it to stackforge soon
17:43:23 <boris-42> yfried_: nobody reads guidelines
17:43:30 <boris-42> yfried_: so bot == guidelins
17:43:33 <boris-42> =)
17:44:21 <boris-42> so ok =)
17:44:30 <boris-42> #topic Open Discussion
17:44:48 <boris-42> do we need to discuss something?
17:45:00 <meteorfox> boris-42: the name of the AvgReview
17:45:04 <meteorfox> AvgReviewer
17:45:06 <meteorfox> :)
17:45:20 <boris-42> meteorfox: so?
17:45:23 <boris-42> meteorfox: you dislike it ?
17:45:29 <boris-42> meteorfox: we can call it CoreProtector
17:45:31 <boris-42> =)
17:45:43 <boris-42> NerdReviewer
17:45:48 <meteorfox> boris-42: so the average part throws me off
17:45:56 <boris-42> meteorfox: why?)
17:46:31 <meteorfox> boris-42: I think you are trying to use average as in common, popular opinion right?
17:46:31 <yfried_> boris-42: +1 NerdReviewer
17:46:47 <yfried_> boris-42: "teacher's pet"
17:46:48 <boris-42> meteorfox: what about NerdReviewer?
17:46:52 <meteorfox> lol
17:47:01 <boris-42> I think it is really great
17:47:31 <amaretskiy> what about SkyNet ? :)
17:47:35 <oanufriev> Nazi
17:47:47 <meteorfox> boris-42: yeah, it's cool. Here's my suggestion, CommitSheriff
17:47:51 <oanufriev> ReviewNazi
17:48:09 <meteorfox> oanufriev: lol
17:48:21 <oanufriev> Cerberus
17:48:22 <boris-42> ReviewNazi - I like
17:48:29 <yfried_> I like skynet and sheriff
17:48:40 <boris-42> Cerberus?
17:48:44 <boris-42> nice btw
17:48:53 <boris-42> it sound great + have great meaning
17:49:09 <oanufriev> three head dog
17:49:23 <yfried_> Cerberus +1
17:49:29 <meteorfox> boris-42: cerberus is taken :( https://github.com/stackforge/cerberus
17:49:31 <boris-42> Cerberus +1
17:49:33 <oanufriev> only really dead guy can pass
17:49:36 <rvasilets> CoP(CoreProtector))
17:50:09 <dpaterson> BeanCounter
17:50:13 <oanufriev> ok, cerberus-42 =)
17:50:17 <rvasilets> We can call it Sean)
17:50:18 <meteorfox> lol
17:50:30 <boris-42> rvasilets: Sean is bad reviewer
17:50:36 <boris-42> he is not nitpicking
17:50:40 <rvasilets> <sntiSean)
17:50:46 <rvasilets> *AntiSean
17:50:50 <boris-42> just Joe
17:50:51 <boris-42> =)
17:51:01 <oanufriev> joebot
17:51:26 <boris-42> What about
17:51:32 <boris-42> Code Cerberus
17:51:42 <boris-42> CodeCerberus
17:51:54 <boris-42> CerbusIO
17:52:38 <oanufriev> CRBerus - CodeReviewBot_e_rus
17:52:56 <boris-42> lol CodeReviewBot_e_rus
17:53:09 <boris-42> meteorfox: yfried_ any ideas?
17:53:22 <boris-42> maybe back to
17:53:26 <boris-42> NerdReviewer?)
17:53:55 <yfried_> boris-42: NerdReviewer, Cerberus.
17:54:02 <amaretskiy> SkyNet
17:54:03 <rvasilets> Navigator -second person on RaLLY RACES)
17:54:04 <boris-42> I just see in comment "Ahhh fuuu Nerd Reviewer put -1 again!"
17:54:45 <boris-42> Okay let's use NerdReviewer for now
17:55:12 <meteorfox> boris-42: drop the Reviewer, just nerd  (The Social Network reference)
17:55:24 <oanufriev> crb
17:55:31 <oanufriev> codename_crb
17:55:46 <dpaterson> nerd +2
17:55:49 <oanufriev> fuuuugen
17:55:53 <oanufriev> )
17:56:43 <boris-42> lol
17:56:50 <boris-42> okay we need to actually finish meeting
17:57:00 <boris-42> so I will publish this project on stackforge
17:57:04 <boris-42> setup CI for it
17:57:08 <boris-42> and put some base structure
17:57:17 <meteorfox> boris-42: ok
17:57:33 <boris-42> I think it won't take too much time to create base
17:57:37 <boris-42> and integrate it
17:57:50 <boris-42> okay see you guys!
17:57:57 <meteorfox> bye
17:57:57 <boris-42> #endmeeting