16:00:11 <smcginnis_> #startmeeting releaseteam
16:00:11 <openstack> Meeting started Thu Nov 21 16:00:11 2019 UTC and is due to finish in 60 minutes.  The chair is smcginnis_. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:12 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:15 <openstack> The meeting name has been set to 'releaseteam'
16:00:23 <hberaud> o/
16:00:29 <smcginnis_> Ping ttx armstrong diablo_rojo, diablo_rojo_phon
16:00:44 <smcginnis_> o/ hberaud
16:00:54 <smcginnis_> #link https://etherpad.openstack.org/p/ussuri-relmgt-tracking Agenda
16:00:58 <ttx> o/
16:01:49 <smcginnis_> I'm guessing it will just be us, so I'll get going.
16:01:53 <smcginnis_> Light agenda anyway.
16:02:03 <smcginnis_> #topic Stuck reviews
16:02:13 <smcginnis_> #link https://review.opendev.org/#/c/694297/
16:02:42 <smcginnis_> ttx: I think this is probably long enough - I can just approve.
16:02:46 <ttx> ack
16:03:00 <smcginnis_> No one has commented with issues. And it's just a process doc update that we can easily update.
16:03:17 <ttx> evrardjp: well my check used a modern flake8 which does not have a bug with f-strings
16:03:52 <ttx> Granted I should have tested with the pre-2016 one OpenStack uses
16:04:02 <smcginnis_> Which check is that?
16:04:03 * fungi is around, not that it probably helps ;)
16:04:15 <smcginnis_> fungi: It always helps to have you around. :)
16:04:27 <evrardjp> o/
16:04:48 <ttx> flake8 not happy with my use of f-strings in https://review.opendev.org/695457 failing with AttributeError: 'FlakesChecker' object has no attribute 'JOINEDSTR'
16:05:17 <evrardjp> oh sorry it seems I have missed that patch
16:05:26 <ttx> I'm trying to find a solution that does not involve me rewriting all my f-strings
16:05:36 <ttx> because I like f-strings
16:05:55 <fungi> that sounds like a flake8 bug?
16:06:10 <ttx> fungi: yes, long fixed
16:06:13 <fungi> ahh
16:06:26 <fungi> we're just pinned to an old version? any reason not to update?
16:06:41 <ttx> I suspect there is a very good reason not to update
16:07:02 <smcginnis_> We can probably try updating and see if anything breaks.
16:07:04 <evrardjp> could we just try?
16:07:07 <evrardjp> haha
16:07:12 <evrardjp> I like your style smcginnis_
16:07:17 <ttx> which is why I was trying to workaround the failure by tweaking my code, but nothing short of removing my f-strings seems to work :)
16:07:19 <smcginnis_> I think in other projects it highlighted some new issues, but easy enough to fix things up.
16:07:21 <smcginnis_> evrardjp: ;)
16:07:46 <fungi> ideally you can just add exclusions in tox.ini for any new checks which they added and solve them later (or not)
16:07:48 <smcginnis_> We shouldn't need to support <3.6, so no reason we shouldn't take advantage of newer functionality.
16:07:54 <smcginnis_> True
16:08:00 <ttx> Having trouble to see where that pin is
16:08:00 <evrardjp> (also I think of the joke on style for a flake8 failure is priceless)
16:08:33 <ttx> probably https://opendev.org/openstack/hacking/src/branch/master/requirements.txt#L6
16:09:09 <smcginnis_> I thought we stopped using global-requirements for releases since we don't need to be coinstallable with other OpenStack services.
16:09:09 <fungi> this is the time in the cycle where everyone should be up-revving static analysis tools anyway
16:09:09 <ttx> Fix is in flake8 1.3.1 / 1.4.0 https://github.com/PyCQA/pyflakes/pull/80
16:09:16 <smcginnis_> fungi: ++
16:09:25 <evrardjp> fungi: agreed
16:09:32 <smcginnis_> We could propose a requirements update.
16:09:46 <evrardjp> bump to latest, see what fails?
16:09:48 <ttx> smcginnis_: it does not appear in requirements. Only in hacking deps
16:09:55 <smcginnis_> Especially as others may start wanting to use 3.6+ functionality.
16:10:00 <smcginnis_> Ah
16:10:35 <ttx> oh well, let's not derail the meetnig
16:10:49 <smcginnis_> Seems like there are just some things to work through.
16:11:11 <smcginnis_> It's not super time critical, so my preference would be to get things moving forward.
16:11:14 <evrardjp> ttx: derailing would be to drop hacking to support black instead
16:11:23 <smcginnis_> No!! :D
16:11:34 <evrardjp> sorry! :p
16:11:44 <evrardjp> anyway...
16:11:45 <fungi> #link https://review.opendev.org/520377 it's been almost 2 years since openstack updated their use of flake8
16:11:58 <ttx> ouch
16:12:09 <fungi> looong overdue
16:12:12 <smcginnis_> Time to get up to date I think.
16:12:16 <ttx> Just tried upgrading to latest flake8 and it's.... noisy
16:12:33 <fungi> yeah, blacklist checks in tox.ini and worry about them later
16:12:35 <smcginnis_> I would expect a little cleanup work, but nothing serious.
16:12:58 <ttx> like it reports about 40 issues in releases (in other code) when I try to run the current version
16:13:10 <smcginnis_> Wow.
16:13:32 <smcginnis_> I like fungi's plan. Let's just blacklist some checks to start, then cleanup things as we go.
16:13:33 <ttx> W504 line break after binary operator looks like a favorite
16:13:43 <smcginnis_> I like that one. ;)
16:13:56 <ttx> W605 invalid escape sequence too
16:14:14 <ttx> like wtf
16:14:16 <ttx> ./openstack_releases/tests/fixtures.py:41:44: W605 invalid escape sequence '\s'
16:14:18 <ttx> gnupg_version_re = re.compile('^gpg\s.*\s([\d+])\.([\d+])\.([\d+])')
16:14:35 <smcginnis_> Just need to make it a raw string.
16:14:45 <fungi> in my opinion, most style checks are predominantly wtf territory, but my opinion is not a common one it seems
16:14:53 <smcginnis_> We've had to fix a lot of other places where those have been generating deprecation warnings.
16:15:12 <smcginnis_> I few of the checks at least are early warning signs for future issues
16:15:21 <fungi> gnupg_version_re = re.compile(r'^gpg\s.*\s([\d+])\.([\d+])\.([\d+])')
16:15:21 <smcginnis_> Anyway...
16:15:26 <fungi> but yeah
16:15:37 <smcginnis_> Any other, any other reviews we should highlight?
16:16:06 <smcginnis_> Lag is killing me. :D
16:16:28 <smcginnis_> OK
16:16:32 <smcginnis_> #topic Review days
16:16:43 <openstackgerrit> Merged openstack/releases master: Update process for R+1 week  https://review.opendev.org/694297
16:16:45 <smcginnis_> We probably should have discussed this at the PTG.
16:16:55 <smcginnis_> Anyone want to update or change review days?
16:17:05 <smcginnis_> ttx: Seems like Monday's have been good review days for you.
16:18:29 <ttx> My review day is Thursday
16:18:43 <ttx> I'm doing Mondays when nobody else does :)
16:18:48 <evrardjp> I will be less active, as I said.
16:18:59 <evrardjp> I am currently listed on Wednesday, and I am trying my best.
16:19:25 <smcginnis_> Any reviews are appreciated.
16:19:38 <smcginnis_> Very appreciated.
16:19:41 <evrardjp> yeah please ping if urgent things, I probably won't have that much of a look as I used to
16:19:50 <smcginnis_> +1
16:20:00 <evrardjp> (end also end of year holidays are early for me, so... just ping.)
16:20:13 <smcginnis_> Well, if anyone wants to change their review day, feel free to update the etherpad.
16:20:43 <smcginnis_> I just try to take a look whenever I can, so any day I am down for can be switched if anyone else wants that day.
16:21:01 <smcginnis_> I think it's hard for all of us right now to declare a designated day to do reviews.
16:21:21 <smcginnis_> So best effort by everyone is appreciated.
16:21:42 <evrardjp> thanks for being understanding
16:22:05 <smcginnis_> It's just the new reality. ;)
16:22:16 <smcginnis_> #topic AOB
16:22:30 <smcginnis_> ttx: We don't have a countdown email yet, right?
16:22:32 * smcginnis_ looks
16:23:02 <smcginnis_> OK, yeah. Next one the week before milestone 1.
16:23:24 <ttx> yes
16:24:05 <smcginnis_> Other than that, I think we've gotten all caught up with -em tagging and stable reviews.
16:24:12 <smcginnis_> At least last I checked the review dashboard.
16:24:25 <smcginnis_> Nice to finally see that dashboard down to a smaller list again.
16:24:50 <ttx> \o/
16:25:05 <smcginnis_> Thanks team for getting those through.
16:25:49 <smcginnis_> I don't really have anything else. Anyone got anything?
16:26:07 <fungi> nothing coming up infra-wise which needs warning
16:26:18 <smcginnis_> That's good.
16:26:26 <smcginnis_> Hopefully a quiet time for infra too.
16:26:38 <fungi> i hope so ;)
16:26:55 <evrardjp> I had a question for fungi for signing releases and rotation of gpg keys relatively to intermediary -- that can wait for the end of the meeting
16:27:49 <smcginnis_> Alright, guess I'll end it. Suppose I should get to keynotes.
16:28:02 <smcginnis_> Thanks everyone. All your work is very appreciated.
16:28:07 <evrardjp> haha enjoy smcginnis_!
16:28:11 <fungi> thanks smcginnis_!
16:28:13 <smcginnis_> #endmeeting