18:02:19 #startmeeting sahara 18:02:20 Meeting started Thu Mar 5 18:02:19 2015 UTC and is due to finish in 60 minutes. The chair is SergeyLukjanov. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:02:21 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:02:22 hi 18:02:24 The meeting name has been set to 'sahara' 18:02:26 #link https://wiki.openstack.org/wiki/Meetings/SaharaAgenda 18:02:31 :) 18:02:32 hi 18:02:33 #topic sahara@horizon status (crobertsrh, NikitaKonovalov) 18:02:42 #link https://etherpad.openstack.org/p/sahara-reviews-in-horizon 18:02:43 Looks like we're up to about 10 changes pending review at the moment, but we have seen a bit of an uptick in reviews over the past couple weeks. 18:03:08 Some are small ones that should [hopefully] be picked-up quickly 18:03:09 crobertsrh: yes looks like we are getting reviews 18:03:31 I'm still working on event log support 18:03:54 I added two test related reviews to the list; hopefully others will come soon 18:04:20 tosky: I'll keep an eye out for test reviews. 18:04:27 it looks more or less working, but there are still a lot of things to be done 18:04:57 okay 18:05:23 #topic News / updates 18:05:26 folks, please 18:05:38 #info FPF is today 18:05:54 working on the barbican integration patch, hope to land it today or tomorrow. also putting together a bug for the swift passwords to get them migrated into barbican. 18:05:55 working on patch with renaming sahara service 18:06:05 still working on tests (horizon, sahara) - and I would like to talk about tempest them especially if sreshetn1ak is around 18:06:10 (he is around) 18:06:16 it means that all CRs for new features should be proposed till tomorrow, FPF exception are ok, please, ping me to discuss if you need an exception 18:06:17 patches in tempest devstack and horizon on review 18:06:18 I am working on job-types-endpoint changes, and default templates (is_default flag review is up, but not the default template CLI yet) 18:06:30 working on the new logging style. hopefully it'll be done until Monday. 18:06:39 I have a few more tweaks to the job execution guide. Those tweaks have also caused me to go back and fix-up a couple other forms in the UI so they'll play nicely with the guides. 18:06:41 working on hbase common lib on HDFS when running edp job https://blueprints.launchpad.net/sahara/+spec/edp-add-hbase-lib 18:06:47 SergeyLukjanov: just to be clear you are talking about specs and not patch reviews? 18:07:00 I was busy with internal customer-oriented stuff, so only updating my patches, making review 18:07:26 seems like we have some gate errors that are common across CRs. Tempest service catalog issue, and heat_hdp_2 issue 18:07:45 One bad news from Cloudera, finally they decided not to host cloudera cdh image on their site. 18:07:47 elmiko, +1 on question 18:08:02 elmiko, I'm talking about code change requests - https://wiki.openstack.org/wiki/Kilo_Release_Schedule 18:08:10 https://wiki.openstack.org/wiki/FeatureProposalFreeze is FPF description 18:08:30 SergeyLukjanov: that language on the wiki is vague 18:08:36 elmiko, yeah 18:08:43 let me try to explain 18:08:50 SergeyLukjanov: specifically, if a spec has been approved do we need an exception to land changes against that spec? 18:09:00 elmiko, yup 18:09:12 but we're doing FPF for the first time 18:09:18 * elmiko scratches head 18:09:41 so, technically, if i don't put the barbican integration code up (even though spec is approved), i need an exception? 18:09:48 so, I will need an exception against default-templates. And, my job-type-endpoint spec is not merged yet (more during open discussion) 18:09:54 elmiko, yeah, that's correct 18:09:59 ooph, ok 18:10:05 elmiko, I think so. but, exceptions come from the core team, not the os release wranglers 18:10:06 I've send an email with reminder a few days ago 18:10:13 so we control it ourselves 18:10:19 tmckay, yup 18:10:28 SergeyLukjanov: i saw the email, but i thought it applied to specs not code reviews 18:10:38 The project PTL, with the assistance of the core developers of the associated product, will evaluate the request and grant or deny the exception. 18:10:54 ack, and we should send to ML for exceptions? 18:11:04 nope, let's just do it in IRC 18:11:37 ok, i need to request an exception for the code part of bp/improved-secret-storage =) 18:11:48 SergeyLukjanov, can we set up an etherpad so we know which CRs are granted exceptions, so we don't workflow+1 non-approved changes by accident? 18:11:49 it's enough for us to have a brief discussion on IRC 18:11:56 SergeyLukjanov: sounds good 18:11:57 and i will maintain wiki page with a list of exceptions 18:12:07 ah :) 18:12:09 thanks 18:12:15 :) 18:12:21 what about bug fixes ? 18:12:35 elmiko, it's only about new features 18:12:39 k, awesome 18:12:48 elmiko, if you can make it a bug, you can implement a new feature :) 18:12:58 :) 18:13:01 bug: security needs more work 18:13:02 my intention is to make a bug to move the swift passwords into the external key manager 18:13:06 tmckay: lol 18:13:26 elmiko, I will definitely approve the fpf exception for experimental integration with barbican 18:13:35 \o/ 18:13:47 because risks are low and benefits are huge enough 18:13:58 +1 18:14:05 I really like that our security dreams are becoming true :) 18:14:11 me too! 18:14:17 I feel safer already 18:15:16 egafford: we talked about the fpf exceptions, you will need to make requests for the code portions of the specs that are up now. fyi 18:15:25 tmckay, +1 ;) 18:15:42 Working on shell job patches mostly. elmiko: Ah, good to know. 18:16:51 oh, I've checked ACLs in gerrit for our stable branches in proejcts 18:17:11 for all projects except sahara itself the core team has all permissions for stable branches 18:17:15 so, I think it's ok 18:17:52 any other updates? 18:18:08 nope from my side 18:18:12 oh! 18:18:29 you want to advertise your logs CR? :) 18:18:39 Question: I've been poking the job interface map change; because UI support definitely won't make Kilo, though, is it safe to assume this should slip to Liberty? 18:18:48 I remember. now hacking check don't verify if import groups a correct. 18:19:14 Nikolay_St, is it a bug or as designed? 18:19:30 egafford, honestly I think it's safier to postpone to L 18:19:34 SergeyLukjanov: really don't know 18:19:46 (R/T updates as work on the job interface map is status, though I'll be happy to reintroduce the question in discussion. :) ) SergeyLukjanov: I agree; it's a non-trivial change. 18:19:47 SergeyLukjanov: we just faced it today during CR 18:19:57 SergeyLukjanov: I'll check it tomorrow 18:20:32 egafford, ok 18:20:49 Nikolay_St, could you please investigate it? IMO groups checking is very important... 18:21:01 SergeyLukjanov: yeap, sure 18:21:06 speaking of logging, did anyone notice this http://lists.openstack.org/pipermail/openstack-dev/2015-March/058226.html ? 18:21:12 egafford, it's an awesome improvement, but okay for L. It was not in scope until long after Paris. 18:21:17 a new logging working group 18:21:27 #action investigate hacking checks for import groups 18:21:59 given all the logging work we've done recently, i think we should have someone as liaison to that gorup 18:22:02 *group 18:22:02 elmiko: not me 18:22:03 tmckay: Ack. 18:22:14 elmiko: I'll attend next meeting 18:22:28 Nikolay_St: yay! 18:22:39 SergeyLukjanov: what do you think about it? 18:22:39 thanks, i think it's worthwhile 18:22:55 #action Nikolay_St to investigate hacking checks for import groups 18:23:19 Nikolay_St, elmiko +1 18:23:55 #action Nikolay_St attend next Log Working Group meeting 18:24:05 #link https://review.openstack.org/161448 18:24:05 #link https://review.openstack.org/161250 18:24:05 #link https://review.openstack.org/157563 18:24:05 I need reviews on these. Specifically, there is a question about the output format from the python client, sample output is in the spec. And SergeyLukjanov had a question about relabeling fields in the REST response that was never resolved. I would like to get the spec and the client/engine CRs merged soon. 18:24:40 Nikolay_St, I'll add you to the cross project liasons list as the sahara liasons for the log wg 18:25:07 tmckay, relabeling? 18:25:16 SergeyLukjanov: ok 18:25:37 SergeyLukjanov, Nikolay, this hacking checks was removed from 0.10 version of hacking. They decided this changes too hard, and removed this checks 18:25:41 SergeyLukjanov, yeah, let me find the comment. old patch set on the spec. You suggested different field names, but the field names are from the template records 18:26:10 vgridnev_: ok. but that sucks 18:26:24 can we enable this check locally in Sahara? 18:26:25 tmckay, oh, shame on me so :) 18:26:26 tmckay: does it mean i have the question with egafford? that i should merge horizon patch before their deadline? not our time on 3/19 ? 18:26:33 SergeyLukjanov, https://review.openstack.org/#/c/157563/5/specs/kilo/edp-job-types-endpoint.rst 18:26:49 Nikolay_St, IMO we should add them to Sahara (as a 3rd party checks) 18:26:55 tmckay :same question like egafford 18:27:23 Nikolay_St, can you do it? (probably copy paste check from the git history of hacking :) ) 18:27:26 huichun_, hmm, I missed the earlier question. Yes, though, I think for a horizon change we need to land on their schedule 18:27:32 SergeyLukjanov: yeap 18:27:36 egafford, ^^ is this your understanding? 18:27:43 tmckay: horizon follows the common schedule 18:28:16 the changes(if they are proposed in time) should be merged before the code freeze 18:28:25 tmckay, oh, I understand, probably we can do it as nesting this section under the single plugin field? 18:28:28 SergeyLukjanov: should I do it ASAP? before FPF? 18:28:30 NikitaKonovalov, are they using FPF? 18:28:49 tmckay: not sure about that 18:28:59 tmckay: I believe so, yes; we need to land Horizon changes per the Horizon team's guidelines. 18:29:02 Nikolay_St, it's not a new feature, so, it could be just a bug, so FPF will not apply for it 18:29:13 SergeyLukjanov: ok, get it 18:29:20 #topic Open discussion 18:29:27 I forgot to change topic ;) 18:29:38 (Speaking of which, there is a patch in Horizon re: Shell job forms which should be reviewed. :) ) 18:30:36 SergeyLukjanov, nesting this section under the plugin field, not sure what you're referring to. Please add comments on the CRs and I will understand :) 18:30:44 egafford: is it in this list https://etherpad.openstack.org/p/sahara-reviews-in-horizon ? 18:30:57 if not, please add it there 18:31:23 tmckay, ack 18:31:45 I've seen horizon cores use that etherpad to find patches for review 18:31:56 tmckay, I'll review it again today 18:32:05 huichun_, so it sounds like you should follow the Horizon schedule, which sounds like a freeze on 3/19. Sooner is better :) 18:32:14 SergeyLukjanov, thank you 18:32:25 NikitaKonovalov: Done; thanks. 18:32:52 guys, need your attention here 18:32:53 huichun_, ^^ note this etherpad. Add something here when you have a CR up. 18:32:54 NikitaKonovalov: hi NikitaKonovalov, so does it mean that i should have add my horizon patch on the etherpad? 18:33:05 #link https://review.openstack.org/#/c/154037/ 18:33:30 huichun_: yes, please add your horizon patches to that etherpad 18:33:37 tmckay: thanks you Trevor ^^ 18:33:39 Nikolay_St, ack 18:34:19 tmckay: thx 18:34:43 I have several patches in horizon waiting for new sahara python client, I should wait for global requirements update, right? 18:34:51 please review https://review.openstack.org/#/c/155428/ 18:35:00 so, do we know what is causing gate failures? Seems like common errors across CRs, spells trouble 18:35:35 tmckay: +1; we're seeing almost universal Tempest failures and very frequent HDP-heat failure. 18:35:46 #link https://review.openstack.org/#/c/160814/ 18:35:48 for example 18:36:10 me too +1 18:36:11 service catalog problem (recent service name change?) 18:36:55 and heat-hdp_2, not sure about that one. maybe a message queue timeout? 18:37:00 "APIException: Error occurred during validation" so informative lol 18:37:21 tmckay: that's what i suggested before! 18:37:36 elmiko, yeah, depends what log you look in 18:37:39 it only seems to happen on that hdp2 test though 18:38:02 I wonder if we should make that hdp 2 test non-voting? Is that too aggressive? 18:38:10 i wonder if there is a slow network issue that is exagerated by nova+heat+hdp2? 18:38:15 it's holding things up. tempest too 18:38:21 could be 18:38:29 Are we registering as data_processing or data-processing in our tempest tests? 18:38:47 egafford, ? don't know 18:38:51 Looks like data_processing. 18:39:17 as data_processing in mirantis ci 18:40:45 Okay. elmiko and I were talking about this earlier; I believe he theorized that we might need to switch to data-processing (though if that is the case, we have a fairly troublesome backward compatibility issue.) 18:40:47 I wonder if we can register as both? 18:41:03 that's my speculation 18:41:12 sreshetn1ak, ^^ 18:41:18 tmckay: i think we could, but we need 2 sets of endpoints then 18:41:27 for the 2 different service ids 18:41:34 we can't register the same endpoint under 2 names? 18:41:45 no, they resolve to service ids 18:42:01 i don't think it's an issue though since you are still going through keystone for the endpoints 18:42:05 Service type is a field of the service object, yeah. Endpoint just pks to service. 18:42:13 /s/pks/fks/ 18:42:32 tempest-sahara-tests don't use endpoints from service catalog 18:42:47 ahh, well there goes that theory ;) 18:43:14 sreshetn1ak: why are those errors complaining about the service catalog then? 18:43:14 APIException: Failed to parse response from Sahara. Check if service catalog configured properly. 18:43:25 so that error is not meaningful? 18:43:29 maybe it's just a bad error msg 18:43:36 Presumably the client is suggesting that as the most likely problem in the most likely case. 18:43:43 yea 18:43:47 (Where the most likely case is not our Tempest tests. :) 18:44:03 Still, good to know that's not the issue. 18:44:03 i think need to see api logs 18:44:28 sreshetn1ak: https://sahara.mirantis.com/logs/14/160814/3/check/tempest-sahara-tests/9dea7b8/console.html 18:44:36 (one example) 18:44:42 yeah, it's failing on everything. 18:45:26 SergeyLukjanov: did you ever get in touch with the person who was looking for Kilo release information from us? 18:45:29 I wonder if we can log the response, where it says "Failed to parse response from Sahara" 18:45:48 SergeyLukjanov: malini1 was the name 18:46:11 elmiko, hm, probably yes 18:46:30 k, just following up =) 18:47:20 ekmiko: example don't contain sahara-api logs :( 18:48:28 doh! 18:49:02 before closing: tests. Question about the approach here, if you generally agree: https://review.openstack.org/#/c/161370/ and about few points raised by sreshetn1ak/sreshetnyak 18:49:05 and related question to alazarev and https://review.openstack.org/#/c/142632/ 18:49:12 (when you are done with the log issue) 18:49:34 sreshetn1ak: Yeah, logs for that specific test don't seem to contain sahara-api logs even in the positive case (so we have null information rather than negative information.) 18:50:48 degorenko working on problem with logs 18:50:54 https://review.openstack.org/#/c/142632/ need probably moved to heat repo 18:51:26 *be moved 18:52:20 and question "what to do if there is no fake plugin" is definitely make sense, probably need to implement custom check in tempest 18:53:24 alazarev: about this: if you check the other review, I had to face the same issue for API tests; maybe you can recycle the templates 18:53:36 s/recycle/reuse/ 18:54:53 the question I have is: I defined only one template for each plugin, choosing a plugin version available in all supported openstack versions (as for tempest rules) 18:55:35 should I change it to have more versions for each plugin, so that at least the latest one is always used for each plugin, or doesn't it matter? 18:56:23 good question 18:57:17 i'm not sure on that one. i guess it depends how deep we want the testing to go 18:57:29 also, will we need to then worry about deprecating older plugins? 18:57:58 so, the templates are used for testing the basic API, so you don't need many combinations there 18:58:21 ah ok, in that case why not? 18:58:24 but, as I was suggesting, they could be used elsewhere (see alazarev patch), so maybe having more templates for more versions could be more useful 18:58:32 yea 18:58:37 1 min left 18:58:39 :) 18:58:47 in the future they could be merged with the input templates used for the new set of tests too 18:59:05 makes sense to me 18:59:34 any other opinion? You can comment also on the review(s) 18:59:38 pleeease do :) 18:59:49 #endmeeting