13:00:35 <yanyanhu> #startmeeting senlin
13:00:36 <openstack> Meeting started Tue Feb 14 13:00:35 2017 UTC and is due to finish in 60 minutes.  The chair is yanyanhu. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:00:37 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:00:39 <openstack> The meeting name has been set to 'senlin'
13:00:46 <yanyanhu> hello everyone
13:01:32 <elynn> Hi
13:01:37 <yanyanhu> hi, elynn
13:01:54 <Qiming> hello
13:01:59 <yanyanhu> hi, Qiming
13:02:32 <yanyanhu> good evening, I guess somebody may leave for valentine's day :)
13:03:19 <yanyanhu> lets wait for minutes for other attenders
13:04:46 <yanyanhu> ok, lets get started
13:05:10 <yanyanhu> https://wiki.openstack.org/wiki/Meetings/SenlinAgenda#Agenda_.282017-02-14_1300_UTC.29
13:05:19 <yanyanhu> here is the agenda, please feel free to add items
13:05:27 <yanyanhu> #topic ocata work items
13:05:41 <yanyanhu> "Feature Rich" Nova Server
13:06:01 <elynn> It's ongoing
13:06:03 <yanyanhu> hi, elynn, I noticed basic support has been done
13:06:06 <yanyanhu> yes
13:06:10 <elynn> Three patches merged.
13:06:25 <yanyanhu> nice
13:06:28 <elynn> Now it support to create ports with security_groups and floating_ip
13:06:36 <yanyanhu> ok
13:06:49 <yanyanhu> so what is the next step?
13:06:52 <elynn> There're two patches are under reviewing
13:07:08 <elynn> One is to support jinja2 in user_data
13:07:20 <elynn> I think that is also important one.
13:07:32 <yanyanhu> ok
13:07:50 <yanyanhu> I guess those ones have been enough to support VDU case xinhui described before?
13:08:03 <elynn> Another one is to handle network update
13:08:20 <elynn> Not without the jinja2 patch yanyanhu
13:08:28 <yanyanhu> that is for support vdu node update, right
13:08:46 <yanyanhu> for deployment, I guess it is enough?
13:08:59 <yanyanhu> elynn, I see
13:09:06 <Qiming> the network update logic is a mess
13:09:14 <elynn> And Bran from vmware are testing and migrating their existing templates to  use senlin vdu profile
13:09:15 <Qiming> just spent some time reading the code
13:09:27 <elynn> Qiming, Why do you say so?
13:09:46 <Qiming> I have previously spent a whole week to refactor the code to covery all possible paths and possbilities
13:09:51 <elynn> It's not easy to handle network update actually...
13:10:02 <Qiming> so I know how tricky it is to get things right
13:10:32 <yanyanhu> yes, network update is not easy for we need to control the sequence of network resource operations carefully
13:11:11 <Qiming> I said it is a mess because there are some new inline functions introduced, that does nothing at all
13:11:26 <Qiming> it is not easy, that part I agree
13:12:17 <elynn> You mean I should expand inline functions in _update_network function?
13:12:21 <elynn> Qiming
13:12:46 <Qiming> you don't need the _get_network call at all, for example
13:13:04 <Qiming> it has been well encapsulated in the sdk exception annotator
13:14:17 <Qiming> it involves a lot of unnecessary DB transactions which can be safely combined
13:15:14 <yanyanhu> I guess we can define some util functions if those logics are generic enough to reuse, otherwise, we can just define local function in VDU server module
13:15:28 <elynn> yes
13:15:38 <Qiming> line 1127 to 1154 is now made an inline function, that is making writing test cases for it very difficult
13:15:44 <elynn> I can refactor that.
13:15:52 <Qiming> the logic is already very complicated ...
13:16:42 <yanyanhu> Qiming, +1, inline function is very difficult to test...
13:16:48 <Qiming> I was never successful when trying to write an elegant unit test for inline functions
13:16:48 <elynn> You mean move that logic out? Qiming
13:17:10 <Qiming> it is bad programming style, thus should be fixed
13:17:11 <elynn> okay, I could do that.
13:18:11 <Qiming> in previous work, I tried very hard to save code lines for validation
13:18:31 <Qiming> that is the reason I introduced 'reason' parameter to _validate_network
13:19:09 <elynn> I saw that logic Qiming
13:19:11 <Qiming> in this revised version, I need more time to understand how the logic flows and every corner cases covered
13:19:52 <elynn> After refactoring, 'reason' parameter is used only for a limit part.
13:20:02 <yanyanhu> so, elynn, please keeping refactoring the code, thanks a lot :)
13:20:11 <elynn> I can show you the logic behind this patch :)
13:20:37 <yanyanhu> :)
13:20:39 <Qiming> okay, if possible, keep function complexity below 20
13:20:47 <Qiming> keep function lines below 100
13:21:15 <Qiming> that is a high bar
13:21:17 <elynn> I can try...
13:21:44 <Qiming> but for maintainability's sake, it is no less important than functional correctness
13:22:55 <Qiming> if you find some logics requently called, you may want to move them into the corresponding driver
13:23:35 <Qiming> that's all from me
13:23:37 <elynn> okay, I will keep in mind :)
13:23:43 <Qiming> many thanks
13:23:52 <yanyanhu> great, lets move on
13:24:10 <yanyanhu> next one, Engine Improvement
13:24:15 <yanyanhu> xuefeng is not here I think
13:24:24 <XueFengLiu> hi
13:24:28 <XueFengLiu> yanyan
13:24:34 <XueFengLiu> :)
13:24:37 <yanyanhu> hi :)
13:24:47 <yanyanhu> I throught you are not here
13:25:02 <XueFengLiu> Come back
13:25:23 <XueFengLiu> About action improvement
13:25:50 <XueFengLiu> Will split the patch
13:26:04 <yanyanhu> yes
13:26:26 <XueFengLiu> Then you guys help to review
13:26:42 <yanyanhu> we can split the logic at DB API layer and upper layer
13:26:53 <yanyanhu> XueFengLiu, thanks a lot
13:27:35 <XueFengLiu> my pleasure
13:27:38 <yanyanhu> and please keep working on this as well :)
13:27:39 <yanyanhu> https://review.openstack.org/#/c/424073/
13:27:44 <XueFengLiu> Will do this tomorrow
13:27:55 <yanyanhu> thanks
13:28:03 <XueFengLiu> Yes
13:28:06 <yanyanhu> ok, lets move on
13:28:12 <yanyanhu> Health Management
13:28:14 <XueFengLiu> Ok
13:28:24 <Qiming> so yanyan's patch won't be revived?
13:28:37 <yanyanhu> Qiming, you mean the one about action purging?
13:28:42 <Qiming> yes
13:28:45 <Qiming> 329338
13:28:46 <yanyanhu> sorry haven't resumed it...
13:29:01 <yanyanhu> I guess there won't be difficult to restore it
13:29:07 <XueFengLiu> https://review.openstack.org/#/c/431401/
13:29:09 <Qiming> I think 431401 is doing the same thing, right?
13:29:09 <yanyanhu> difficulty
13:29:31 <XueFengLiu> This one
13:29:39 <XueFengLiu> Yes
13:29:56 <Qiming> okay, then 329338 can be abandoned forever?
13:29:57 <XueFengLiu> With recent code
13:30:06 <XueFengLiu> HaHa
13:30:07 <Qiming> that is confusing
13:30:08 <yanyanhu> Qiming, I guess my patch is more generic solution for action purging
13:30:27 <yanyanhu> oh, you mean this one
13:30:31 <yanyanhu> https://review.openstack.org/#/c/431401/
13:30:39 <yanyanhu> I guess I can abandon mine
13:30:48 <Qiming> xuefeng didnt continue your patch
13:30:56 <yanyanhu> and lets keep working on 431401
13:31:00 <Qiming> seems to me he started a new one
13:31:10 <XueFengLiu> The same one
13:31:12 <yanyanhu> it's ok
13:31:14 <Qiming> okay, let's forget 329338 then
13:31:18 <yanyanhu> yes
13:31:31 <yanyanhu> I will abandon 329338
13:31:37 <XueFengLiu> Two patches about action
13:31:40 <Qiming> reassign this to XueFeng now
13:32:04 <XueFengLiu> The first is about cluster check action
13:32:31 <XueFengLiu> And https://review.openstack.org/#/c/431401/  is the same with yanyan's
13:32:45 <Qiming> got it
13:32:56 <Qiming> we can move on then
13:32:57 <yanyanhu> so please keep working on it
13:32:57 <XueFengLiu> To delete all actions when we delete a cluster/node
13:33:09 <XueFengLiu> OK
13:33:32 <yanyanhu> nice, lets move on
13:33:35 <yanyanhu> document
13:33:50 <yanyanhu> Qiming worked hard on document I think
13:33:55 <Qiming> need eyes on review
13:33:59 <yanyanhu> and the one for lb policy has been done
13:34:08 <Qiming> I want all policy types documented before final RC
13:34:12 <yanyanhu> yes, please help to review them, thanks a lot
13:34:15 <XueFengLiu> Yes, it's a hard work
13:34:23 <Qiming> then during the last week, we'll focus only on critical bugs
13:34:51 <yanyanhu> sounds great
13:35:04 <yanyanhu> ok, next one
13:35:06 <yanyanhu> Senlinclient
13:35:23 <Qiming> from release time's point of view, all RCs are just practices for the final release
13:35:31 <yanyanhu> yep :)
13:35:40 <Qiming> the ultimate goal is to make the final release stable
13:36:21 <Qiming> I'll try get the 3 other policy types documented in the next two days
13:36:21 <yanyanhu> hi, XueFengLiu, so the functional test for client has not been started?
13:36:35 <yanyanhu> Qiming, thank you so much, will help to review
13:36:44 <XueFengLiu> Yanyan, sorroy not time to do now
13:36:49 <yanyanhu> no problem
13:36:50 <Qiming> yanyanhu, I think we need your expertise in setting up the gate job
13:37:18 <yanyanhu> yes, I think I will try to spend some time on it
13:37:23 <yanyanhu> to set up the gate job
13:37:37 <yanyanhu> and then XueFengLiu can keep working on the test case
13:37:51 <XueFengLiu> No problem
13:37:53 <yanyanhu> will start this work in this week
13:37:56 <XueFengLiu> :)
13:38:00 <Qiming> would be greate
13:38:07 <yanyanhu> :)
13:38:18 <yanyanhu> ok next one
13:38:19 <Qiming> wrting test case can be split across the team
13:38:19 <yanyanhu> profile
13:38:33 <yanyanhu> Qiming, yes, that can be done in parallel
13:38:42 <yanyanhu> haiwei is not here?
13:38:44 <XueFengLiu> Yes
13:39:04 <yanyanhu> ok, lets skip it. Although that is one of the most important TODO for us in next cycle
13:39:10 <Qiming> another two patches need your review
13:39:23 <Qiming> they are about support status at client side
13:39:37 <yanyanhu> Qiming, yes, saw them, will check them tomorrow
13:39:50 <Qiming> $ senlin policy-type-list
13:39:50 <Qiming> WARNING (shell) "senlin policy-type-list" is deprecated and will be removed by Apr 2017, please use "openstack cluster policy type list" instead.
13:39:51 <Qiming> +--------------------------------+---------+----------------------------+
13:39:51 <Qiming> | name                           | version | support_status             |
13:39:51 <Qiming> +--------------------------------+---------+----------------------------+
13:39:52 <Qiming> | senlin.policy.affinity         | 1.0     | SUPPORTED since 2016.10    |
13:39:54 <Qiming> | senlin.policy.batch            | 1.0     | EXPERIMENTAL since 2017.02 |
13:39:56 <Qiming> | senlin.policy.deletion         | 1.0     | SUPPORTED since 2016.04    |
13:39:58 <Qiming> | senlin.policy.health           | 1.0     | EXPERIMENTAL since 2017.02 |
13:40:00 <Qiming> | senlin.policy.loadbalance      | 1.0     | SUPPORTED since 2016.04    |
13:40:02 <Qiming> | senlin.policy.region_placement | 1.0     | EXPERIMENTAL since 2016.04 |
13:40:04 <Qiming> |                                |         | SUPPORTED since 2016.10    |
13:40:07 <yanyanhu> looks nice
13:40:08 <Qiming> | senlin.policy.zone_placement   | 1.0     | EXPERIMENTAL since 2016.04 |
13:40:10 <Qiming> |                                |         | SUPPORTED since 2016.10    |
13:40:12 <Qiming> +--------------------------------+---------+----------------------------+
13:40:14 <Qiming> this is the output
13:40:26 <yanyanhu> sorry, I broke the line :)
13:40:38 <yanyanhu> this looks great
13:40:50 <Qiming> you broke nothing at my side
13:40:57 <yanyanhu> :P
13:41:11 <Qiming> it is all caused by connection delay
13:41:18 <yanyanhu> yes
13:41:54 <yanyanhu> XueFengLiu, elynn, please help to review them as well if you guys have time :)
13:42:03 <yanyanhu> ok, those are all items in the list
13:42:14 <XueFengLiu> OK
13:42:16 <yanyanhu> #topic Ocata RC3 for senlin and final release for senlin-dashboard
13:42:24 <elynn> will
13:42:33 <yanyanhu> so this week will be the time for senlin rc3 and final release for senlin-dashboard
13:42:57 <yanyanhu> plan to cut the release by this Tuesday
13:43:08 <Qiming> come on
13:43:17 <elynn> today is tuesday
13:43:19 <Qiming> today is Tuesday
13:43:20 <yanyanhu> so if there is any critical fix, please push it
13:43:24 <yanyanhu> sorry...
13:43:27 <yanyanhu> misclicking
13:43:31 <yanyanhu> Thursday
13:43:59 <yanyanhu> ate too much chocolate
13:44:19 <elynn> :)
13:44:44 <Qiming> bad for your brain, boy
13:44:44 <yanyanhu> ok, so open discussion now
13:44:50 <yanyanhu> Qiming, agree...
13:44:59 <yanyanhu> #topic open discussion
13:45:25 <Qiming> I'm really curious about the mistral workflow progress
13:45:25 <yanyanhu> any more want to discuss?
13:45:34 <yanyanhu> oh, btw, our final mascot has been ready
13:45:42 <elynn> o?
13:45:46 <Qiming> but ... I think the girl may be dating ...
13:45:51 <yanyanhu> Qiming, I think xinhui will talk with mistral guys in PTG
13:45:58 <yanyanhu> hope she can bring back more news
13:46:05 <Qiming> https://www.dropbox.com/sh/b8kpj5k29eaf65t/AADoIo9VUz14A81c--UTRtLNa?dl=0
13:46:05 <yanyanhu> WoW
13:46:13 <yanyanhu> good for her :P
13:46:40 <yanyanhu> elynn, will forward you guys the mail about Mascot
13:46:43 <yanyanhu> it's cool
13:46:50 <Qiming> the link I pasted above
13:46:55 <elynn> What's that?
13:47:01 <Qiming> that is the mascot for Senlin
13:47:04 <elynn> An unknown webside
13:47:06 <Qiming> the final version
13:47:16 <yanyanhu> sigh,I can't open that link...
13:47:21 <yanyanhu> at home
13:47:23 <Qiming> need proxy I think
13:47:27 <yanyanhu> yes
13:47:30 <yanyanhu> seems so
13:47:59 <Qiming> can you access https://snag.gy/ ?
13:48:02 <elynn> That is the final version?
13:48:08 <yanyanhu> elynn, think so
13:48:32 <yanyanhu> Qiming, yes
13:48:34 <yanyanhu> that is accessible
13:48:45 <elynn> Looks sweet, looks like tree family.
13:48:53 <Qiming> okay, I'm pasting to that site
13:48:56 <yanyanhu> haha
13:49:14 <Qiming> the link will be ..
13:49:17 <Qiming> ..
13:49:22 <Qiming> (uploading )
13:49:24 <Qiming> ..
13:49:27 <Qiming> ..
13:49:30 <Qiming> https://snag.gy/ZUNIkV.jpg
13:49:54 <yanyanhu> saw it, haha
13:50:04 <XueFengLiu> haha
13:50:29 <Qiming> so many .... trees
13:50:31 <Qiming> :D
13:50:35 <yanyanhu> thanks a lot for the effort of Heidi and her team
13:51:08 <elynn> Where will we put that logo?
13:51:16 <Qiming> anywhere
13:51:23 <Qiming> when you need to tell a story about it
13:51:38 <yanyanhu> you can print it on your T-shirt
13:51:39 <yanyanhu> :)
13:51:57 <elynn> That's a good idea :D
13:52:01 <XueFengLiu> For example senlin wiki
13:52:14 <Qiming> right, right
13:52:18 <Qiming> I should have done that
13:52:56 <Qiming> noted, as a work item in etherpad
13:53:15 <yanyanhu> thanks :)
13:53:34 <yanyanhu> ok, so that's all topics for today
13:53:38 <yanyanhu> any more for discussion?
13:53:45 <Qiming> no from me
13:54:00 <elynn> nope
13:54:15 <yanyanhu> ok, thanks all you guys for joining
13:54:19 <XueFengLiu> In wiki we'd better add two things:1.tell peoplesome link need vpn  2.add some Frequently Asked Questions
13:54:45 <yanyanhu> XueFengLiu, +1, FAQ is important
13:54:59 <XueFengLiu> :)
13:55:15 <Qiming> added to etherpad
13:55:24 <yanyanhu> thanks, Qiming
13:55:38 <XueFengLiu> No need much ,just several FAQ
13:56:13 <yanyanhu> ok, so happy valentine's day to you all and have a good night:)
13:56:36 <Qiming> u 2
13:56:37 <XueFengLiu> good night, all:)
13:56:39 <Qiming> bye
13:56:44 <yanyanhu> bye
13:56:45 <elynn> good night
13:56:48 <yanyanhu> #endmeeting