19:00:28 <dtruong> #startmeeting senlin 19:00:29 <openstack> Meeting started Thu Dec 20 19:00:28 2018 UTC and is due to finish in 60 minutes. The chair is dtruong. Information about MeetBot at http://wiki.debian.org/MeetBot. 19:00:30 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 19:00:32 <openstack> The meeting name has been set to 'senlin' 19:00:50 <dtruong> who's here today? 19:01:58 <eandersson> o/ 19:03:56 <dtruong> judecross here? 19:05:03 <dtruong> #topic announcements 19:05:32 <dtruong> Not much except that we still cancel the meetings for the next two weeks for the holidays. 19:05:59 <dtruong> Next regularly scheduled meeting will be on Friday January 11 at 530 UTC. 19:06:11 <JudeCross> o/ 19:07:29 <dtruong> #topic Reviews 19:07:47 <dtruong> We need reviews on the following patch sets: 19:08:03 <dtruong> #link https://review.openstack.org/#/c/624248/ 19:09:56 <dtruong> We need this one so that the py35 integration tests pass. 19:10:54 <dtruong> #link https://review.openstack.org/#/c/620767/ 19:11:12 <dtruong> This one is a fix to make senlinclient work again 19:11:28 <eandersson> *dashboard 19:11:36 <dtruong> oh yea, sorry 19:14:39 <dtruong> eandersson: i had to remove your unit test because it didn't work anymore with the fix to pass keystone session to openstacksdk 19:18:02 <eandersson> Not a big fan due to the risk of regression, so we should follow up with some sort of automatic testing 19:18:58 <eandersson> but needs to be fixed asap, so gave my +1 19:19:09 <dtruong> I was thinking maybe we can add something in the senlin-tempest integration tests 19:19:24 <eandersson> pretty sure we can at least test the api endpoint without too much effort 19:19:38 <dtruong> Yea, that's what i'm thinking 19:19:49 <dtruong> Request the senlin client from the senlin dashboard api 19:19:55 <dtruong> and run some basic tests 19:20:38 <eandersson> We could talk to the SDK group as well, to see if we can get some standardized implementation for the dashboards and make sure there are tests around those 19:21:54 <dtruong> Yea, the standardized implementation probably would not use senlin client and instead talk to openstacksdk directly :) 19:24:11 <eandersson> That would indeed be ideal 19:24:47 <dtruong> i heard judecross would like to work on that ;) 19:26:10 <JudeCross> I dont mind :P 19:28:58 <dtruong> all right, that's all i have for today 19:29:10 <dtruong> anybody have anything else to discuss? 19:34:25 <dtruong> ok, let's end the meeting then 19:34:43 <dtruong> happy holidays everyone and thanks for joining 19:34:47 <dtruong> #endmeeting