14:01:05 <saggi> #startmeeting smaug
14:01:06 <openstack> Meeting started Tue May 31 14:01:05 2016 UTC and is due to finish in 60 minutes.  The chair is saggi. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:08 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:01:09 <yuval> hello everybody :)
14:01:11 <openstack> The meeting name has been set to 'smaug'
14:01:19 <saggi> Are we waiting for anyone?
14:01:22 <zhonghua-lee> hi
14:01:33 <xiangxinyong> ^-^
14:01:37 <gampel> hi everyone
14:01:44 <gsagie> o/
14:01:47 <chenhuayi> hi
14:01:52 <yamamoto> saggi: hi
14:02:55 <saggi> #topic news
14:03:06 <saggi> We had an internal meeting earlier this week.
14:03:26 <saggi> We are trying to use trello more
14:03:57 <zengchen> saggi:great
14:04:14 <saggi> Also every day at 09:00 UTC is happy hour at the #smaug channel.
14:04:21 <yuval> Currently the Trello is organized by topics
14:04:31 <gsagie> saggi, yuval: Trello link
14:04:35 <zhonghua-lee> saggi: could you please print the Trello link here
14:04:35 <saggi> where you can get you patch boosted to the top of the core reviewer list just by showing up.
14:04:47 <xiangxinyong> yeah. I update some bugs which need to be reviewed
14:04:50 <yuval> https://trello.com/invite/b/Sudr4fKT/826e3dcffc7259b1447d4ecc448c1a45/smaug
14:04:56 <saggi> I'
14:05:05 <gsagie> #link https://trello.com/invite/b/Sudr4fKT/826e3dcffc7259b1447d4ecc448c1a45/smaug
14:05:09 <zhonghua-lee> yuval: thank you
14:05:28 <yuval> Feel free to open cards in tasks you think need review
14:05:45 <yuval> Archive tasks that are complete and requrie no further discussion or work
14:06:21 <xiangxinyong> ok. good rules
14:06:36 <yuval> If someone is in need of admin priviliges for the Trello, tell me
14:06:50 <saggi> We currently give priority in review to the Protection Service.
14:07:14 <xiangxinyong> yuval: could you give me admin priviliges
14:07:18 <xiangxinyong> ?
14:08:29 <xiangxinyong> saggi: yeah. protection service is very important
14:08:59 <gampel> additional update--> yuval and zhonghua-lee will propose a topic about smaug to openstack day in china
14:09:04 <yuval> chenying here?
14:09:23 <saggi> I submitted the patch for the meeting change but it hasn't gotten merged yet. Hopefully this is the last week the guys from china need to stay up late. :)
14:09:39 <saggi> #topic china openstack day
14:09:41 <gampel> please share so we could vote
14:09:44 <zhonghua-lee> gampel:yeah
14:09:50 <saggi> Could you elaborate on what you intend to do there?
14:10:03 <zhonghua-lee> gampel:but there still have some work to do
14:10:34 <gampel> zhonghua-lee: yuval:  what topics are you planing to propose ?
14:11:49 <zhonghua-lee> gampel: I am planning to present all the projects related protection that OpenStack have
14:11:51 <yuval> We are proposing an introduction talk about Smaug. The intention is to give people idea what is smaug, how does it work, the difference and interface with other DR solutions
14:12:01 <zhonghua-lee> gampel: we may think it over
14:12:24 <xiangxinyong> Architecture and high availability? may be this one
14:12:35 <zhonghua-lee> yuval: yeah that's the important one
14:12:45 <xiangxinyong> zhonghua-lee: :)
14:12:59 <zhonghua-lee> yuval: especially the difference between Smaug and Freezer
14:13:25 <gampel> xiangxinyong demo video  could be part of it
14:14:05 <zhonghua-lee> xingxinyong:I think so, it should be part of the presentation
14:14:50 <xiangxinyong> gampel: got iy
14:14:55 <xiangxinyong> got it.
14:15:32 <saggi> #topic full stack testing
14:16:27 <gampel> i noticed it is failing, does any one know why ?
14:16:29 <saggi> How are the patches for $topic? We've got a important stuff being blocked on this.
14:16:30 <yuval> chenying not here?
14:17:20 <zhonghua-lee> yuval:he is connecting
14:17:26 <xiangxinyong> the failed reason is this patch.
14:17:28 <xiangxinyong> https://review.openstack.org/#/c/323316/
14:17:49 <zhonghua-lee> yuval: as far as I know :)
14:18:31 <xiangxinyong> I research it and find the novnv should be removed from the ci
14:19:13 <gampel> Ok  i saw that patch from chenying
14:19:19 <saggi> So we're blocked on infra
14:19:32 <saggi> There was also a patch with misc fixes that was supposed to be related.
14:19:48 <saggi> I asked for it to be split to several logical bits.
14:20:11 <chenying_> hi
14:20:17 <gampel> hi
14:20:40 <gampel> we were just talking about the CI (fullstack)
14:21:42 <saggi> chenying, what is preventing it from working?
14:22:17 <chenying_> This afternoon, zhangshua and chenpengzhi have test protent/delte full test OK
14:22:31 <chenying_> Did they submit the patches?
14:22:54 <gampel> that's great news so we have end to end with cinder volume ?
14:22:55 <yuval> We have this patch, which should fix the noVNC issue. Please review and +1 it: https://review.openstack.org/#/c/323316/
14:22:59 <saggi> As I said, I saw a huge patch of misc fixes. I asked for it to get split up.
14:23:02 <yuval> (patch by xiangxinyong)
14:23:11 <chenying_> jikins check have problom, xiangxinyong have submit a patch to fix it.
14:23:44 <chenying_> As I said, I saw a huge patch of misc fixes. I asked for it to get split up.   Yes I am splitint up it.
14:24:08 <saggi> chenying, thanks!
14:24:10 <chenying_> Yes I am spliting up the patch. I will submit it later.
14:24:16 <xiangxinyong> hi guys, about the fullstack.
14:24:17 <xiangxinyong> https://review.openstack.org/#/q/owner:1523688226%2540qq.com+status:merged
14:24:31 <xiangxinyong> these patches are merged by chenpengzi
14:25:02 <xiangxinyong> https://review.openstack.org/#/c/323166/
14:25:02 <xiangxinyong> https://review.openstack.org/#/c/322725/
14:25:23 <xiangxinyong> these patches are reviewing by zhangshuai
14:26:21 <chenying_> I have submited a patch about checkpoint delete. This flow works now.
14:27:47 <saggi> So we just need to tie up a few loose threads and then it should all work
14:28:27 <saggi> #topic patch splitting
14:28:53 <saggi> I try and not be too strict about patches containing more than one fix
14:29:09 <saggi> But it's becoming harder and harder to review
14:29:39 <saggi> Please make sure to take out parts of you patch that are unrelated to the core fix and can be submitted independently.
14:30:01 <saggi> It also makes more patches require to be manually rebased
14:30:01 <yuval> May I add: write commit messages
14:30:07 <saggi> +1
14:30:10 <gampel> the patch will be merged faster if it is small
14:30:44 <chenying_> I think so
14:30:47 <saggi> So try and get all the cleanups in a base patch and the complex logic in a patch on top of it
14:31:32 <gampel> we have currently 32 open patch for review
14:31:35 <saggi> It will make things easier for everyone. Most of the time the base patches can just be merged and at least part of your change is now in master.
14:32:21 <saggi> If you don't already know about `git add -p` and `git reset -p` I suggest you read the man page. It will help you split up patches once you are done with a fix.
14:33:34 <xiangxinyong> saggi: thanks your guide
14:33:37 <saggi> git is built to make this kind of stuff easy.
14:34:53 <saggi> #topic open discussion
14:35:17 <saggi> Since we already did a team meeting yesterday there isn't much coordination to do.
14:35:23 <saggi> Anyone else anything they want to raise?
14:36:02 <chenying_> about the wiki and doc. saggi can you give a link to us?
14:36:19 <saggi> #link https://wiki.openstack.org/wiki/Smaug
14:37:02 <gampel> we need to add install Guide and maybe a tutorial how to use it
14:37:37 <chenying_> the api docment Can we need write like othe project such as cinder ?
14:37:49 <gampel> you mean in md file
14:37:59 <saggi> chenying: I can try and generate it from the swagger yaml
14:38:11 <chenying_> Ok
14:38:20 <gampel> saggi: we could convert the swag to html
14:38:25 <chenying_> install Guide and maybe a tutorial how to use it  I think I can do this work.
14:38:51 <saggi> xiangxinyong, do you have time to work on the user guide?
14:39:00 <xiangxinyong456> yeah.
14:39:06 <zhonghua-lee> chenying_:please add me in
14:39:20 <saggi> zhonghua-lee: Add you where?
14:39:36 <gampel> https://github.com/swagger-api/swagger-codegen#generating-static-api-documentation
14:39:41 <zhonghua-lee> saggi: document work
14:39:43 <saggi> chenying, you can work on the install guide.
14:39:52 <saggi> or zhonghua-lee
14:40:20 <chenying_> zhonghua-lee Do you have time to do this?
14:40:36 <zhonghua-lee> saggi:ok
14:40:49 <zhonghua-lee> chenying_: let's work together
14:40:57 <chenying_> Ok
14:41:07 <chenying_> we work together
14:41:22 <saggi> Don't forget to add links to the wiki pages you make to the main wiki page.
14:42:08 <saggi> anything else?
14:42:26 <gampel> I think we need html view of the API
14:42:35 <chenying_> xiangxinyong I think we could plan to do integration testing with UI. what's your opinion?
14:42:39 <saggi> I'll generate it from swagger
14:42:45 <saggi> I should already have the tools installed
14:42:45 <gampel> :)
14:44:05 <zhonghua-lee> chenying_: do you mean the manual test from UI?
14:44:11 <xiangxinyong456> chenying: i think it is not most important at present.
14:44:28 <chenying_> Net step I think most importent work is review. We need spent more time to review and get these patches marged ASAP.
14:44:37 <saggi> +2
14:44:52 <yuval> chenying_: I agre3e
14:45:28 <xiangxinyong456> +1
14:45:54 <xiangxinyong456> we should stable our present function
14:45:57 <zengchen> hi, guys, please review my two patch which are listed in the trello.
14:46:57 <saggi> BTW, tomorrow I'll be available an hour early on IRC from 10:00-11:00 IST which I think is 15:00 in China and then I'll be gone for the rest of the day. So try and be there if there are stuff you want me to look at.
14:47:35 <zengchen> saggi:got it.
14:47:50 <yuval> I'll be here all day, but on Thursday I'll be at the OpenStack Israel conference
14:48:04 <saggi> I'm going to try and be available for an hour or two the days I'm not working so that things don't get stuck but I need your help. Can't make any promises though. Finals month is next month :(
14:48:26 <saggi> OK, thanks everybody.
14:48:46 <yuval> thanks
14:48:46 <xiangxinyong456> thanks guy
14:49:13 <saggi> #endmeeting