19:00:14 <Zara> #startmeeting StoryBoard
19:00:15 <openstack> Meeting started Wed Jan 17 19:00:14 2018 UTC and is due to finish in 60 minutes.  The chair is Zara. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:16 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:00:19 <openstack> The meeting name has been set to 'storyboard'
19:00:34 <Zara> #link https://wiki.openstack.org/wiki/Meetings/StoryBoard
19:00:41 <Zara> ^ agenda, looks like it's not updated for this week
19:00:45 <Zara> hopefully will be a short one! :D
19:00:50 <Zara> #topic Announcements
19:00:55 <Zara> THERE ARE NONE, EXCELLENT WORK
19:01:01 <Zara> #topic In-progress Work
19:01:18 <Zara> I believe the agenda items are from last week, it notes story templates and launchpad migration
19:01:24 <Zara> I guess jump in with things on those if you have them
19:01:44 <Zara> so instead quick round up of things currently in review
19:02:04 <Zara> dhellman has sent many, many patches to our docs! :D
19:02:29 <Zara> since it's more than 10 I won't link them individually
19:02:37 <Zara> #link https://review.openstack.org/#/q/project:openstack-infra/storyboard
19:02:42 <Zara> ^ that is where they can be found
19:02:58 <Zara> they range from new content to theming to various formatting fixes
19:03:21 <Zara> I'm very happy someone is taking time to update these and clean them up; thanks dhellman! :)
19:04:03 * persia is also very excited to see a new approach to the docs
19:04:32 <Zara> on the webclient side, we have some general updating afoot
19:05:04 <Zara> mix of updating our existing packages in an effort to reduce the wall of deprecation warnings and replacing things with newer tooling
19:05:18 <Zara> #link https://review.openstack.org/#/c/384554/
19:05:27 <Zara> ^ is one that could do with more eyes on it to check if it breaks anything
19:05:42 <Zara> #link https://review.openstack.org/#/c/534424/
19:05:55 <Zara> ^ a wip for webpack (thanks mordred!) so we can see where things are headed there
19:06:10 <mordred> \o/
19:06:30 <Zara> we also have other patches in need of review more generally
19:06:38 <Zara> #link https://review.openstack.org/#/c/534461/
19:06:47 <Zara> hopefully fixes links displaying as links
19:07:10 <Zara> I haven't got to reviewing that yet, but looks like nobody else has, so waving arms here! :D
19:07:30 <Zara> #link https://review.openstack.org/#/c/526219/
19:07:43 <Zara> needs more eeyes
19:08:12 <Zara> aiui idea is so that project teams can link directly to that in case they want to fill some fields automatically
19:08:18 <Zara> for templates etc
19:08:31 <SotK> indeed
19:08:42 <Zara> #link https://review.openstack.org/#/c/530656/
19:08:54 <Zara> 'allow branches to be browsed by project id'
19:08:54 <SotK> it also enables the construction of a link which will automatically create a private story with for example the VMT team added
19:09:04 <Zara> ah yes I remember now
19:09:06 <SotK> it also requires that change
19:09:18 <Zara> aha I was about to say I know nothing about that change but assume it depends on it
19:09:26 <Zara> I think it went up when I was very distracted, sorry :)
19:09:56 <Zara> anyone interested in bug templates and VMT support should review those changes, then
19:10:15 <Zara> on the api side...
19:10:16 <SotK> indeed it did
19:10:22 <Zara> #link https://review.openstack.org/#/c/529433/
19:10:36 <Zara> zuul has a problem with this, I have no idea why, is a fix to a migration script
19:10:44 <Zara> looked like it was just timeouts
19:11:22 <Zara> maybe needs poking, maybe needs more rechecks
19:11:37 <Zara> #link https://review.openstack.org/#/c/533353/
19:11:45 <Zara> 'fallback to natural language search if syntax is bad'
19:11:52 <Zara> I haven't looked at this at allllllll
19:11:54 <SotK> hmm, we really should try to find time to properly solve that timeout issue
19:12:00 <Zara> I like the idea of it though
19:12:00 <Zara> yep
19:12:06 <Zara> our tests are ugh
19:12:14 <SotK> oh yeah I did that when I was vaguely bug triaging the other day
19:12:20 <Zara> thanks :)
19:12:49 <Zara> oh also I sent this
19:12:54 <Zara> #link https://review.openstack.org/#/c/532367/
19:13:00 <Zara> that removes stuff about the vagrant setup
19:13:08 <Zara> since nobody uses it or has used it in... 3 years?
19:13:21 <Zara> I need to investigate why zuul is complaining
19:13:36 * fungi looks
19:14:06 <Zara> it might've just been sent at a weird time, I remmeber there were some status messages going up in channel around then
19:14:17 <Zara> though it's also possible there are some tests that expect it that I didn't remove
19:14:39 <fungi> yeah, looks like tox_install_sibling_packages failed on all of them. recheck it
19:14:52 <Zara> done! :)
19:14:53 <Zara> thanks
19:15:04 <Zara> #topic Open Discussion
19:15:08 <fungi> it was being refactored and a mistake slipped through
19:15:20 <Zara> ah okay, thanks for catching that! :D
19:15:26 <fungi> and our tests weren't correctly exercising that
19:15:41 <fungi> or we would have caught it
19:16:04 <Zara> it's a good way to find gaps. :) I raced through items so we know what's currently going on and people can pick the most interesting to talk about
19:16:25 <Zara> so roundup complete, Openly Discuss away! :D
19:17:11 <Zara> I'm trying not to focus on too many things personally so my own focus is on updating our packages, especially for the webclient
19:17:33 <Zara> because I don't want to suddenly hit a wall with it when some transitive dependency is removed forever
19:17:41 <fungi> i did bring the robots.txt topic up in the infra meeting yesterday. i think we're going to try rewriting the baked-in one on the production server and then see if goog indexes anything (or whether there's any performance impact)
19:18:14 <Zara> cool, it will be interesting to see! :) I should be able to check for any strange performance
19:18:33 <SotK> nice, hopefully it works better than expected
19:18:58 <fungi> yeah, not holding out much hope but we'll see
19:19:03 <Zara> I'm wondering if it'll index the things at the api endpoints instead
19:19:16 <fungi> entirely possible
19:19:39 <Zara> #link https://storyboard.openstack.org/api/v1/stories/2000001
19:19:47 <Zara> (for anyone wondering what I mean by that, there's an example)
19:20:06 <Zara> which could still be useful I suppose, though likely confusing for most :D
19:20:11 <Zara> better than nothing
19:20:30 <persia> As part of the general upgrade-all-the-components, is an upgrafde to newer angular also planned?  That might help with the robots.txt bits.
19:20:43 <Zara> hopefully updating more of the webclient more generally will make it more feasible to change our routing
19:21:12 <persia> That's the first-ever bug filed in production after LP migrations started?  Wow.  Interesting artifact.
19:21:15 * fungi isn't webdev-savvy enough to know what "routing" means in this context anyway
19:21:38 <Zara> persia: I don't think we intend to change the angular version itself any time soon, but my hope is to update various packages we're using atm and steadily replace them with the newer ones
19:22:14 <persia> I believe "routing" means "determine what to do for a given URL": in the case of Storyboard, the ansewr is mostly "give the browser the webui, and have the webui consume the XML at the endpoint"
19:22:25 <fungi> aha, got it
19:22:38 <fungi> a decision tree of sorts
19:22:47 <Zara> it's also some things like 'what to do when something hasn't loaded yet'
19:22:51 <fungi> not unlike how traditional network routers operated
19:22:54 <persia> Zara: The reason I asked is because I was pointed at features in angular2 that would server-side render the app, which might help in the crawler case.
19:22:59 <SotK> we aren't likely to switch to angular (as opposed to angularjs/angular 1) any time soon, it would need a large amount of work
19:23:22 <Zara> yeah, that's the issue, it's a very big change
19:23:50 <Zara> we'd *like* it to be 2, but I don't think there's anyone around who can take that on atm
19:24:03 <Zara> I want it to be 2 because then I could read the code
19:24:09 <persia> fungi: Likely more important for cases where something in the middle is the break between "path" and "data", e.g.: "http://example.org/programs/myexecutable.cgi/widgets/suppliers/index/"
19:24:10 <fungi> maybe mordred's secretly scheming to work on that ;)
19:24:12 <Zara> #link https://review.openstack.org/#/c/384554/
19:24:25 <Zara> shows some routing things if curious
19:24:34 <Zara> the js changes
19:24:42 <fungi> cool!
19:25:04 <Zara> possibly not done right since I was mostly pattern matching from docs, but it's that kiiiind of thing
19:25:32 <fungi> well, there are _worse_ places to take usage examples from than the documentation for the framework you're trying to use, i suppose
19:25:39 <Zara> :) I think historically we used a separate package for page routes because there wasn't one built into angular
19:25:46 <Zara> then later on one was built in
19:25:57 <Zara> but I came to things way later and can barely write js
19:25:58 <fungi> sounds likely
19:26:26 <fungi> the angular growing one in its stdlib thing, not your js proficiency
19:26:37 <persia> SotK: Ah.  I was confused by the name.  When the first suggestion in results for "upgrade from angularjs to angular" is "rewrite your app", I appreciate that this may not happen.
19:26:41 <fungi> you're far more effective at this than i could hope to be
19:26:55 <Zara> hahaha dw :) so in general there are some design decisions that made sense at the time but would be very strange to make now :)
19:27:24 <Zara> persia: there's both angular 1 and angular 2, 2 isn't backwards compatible with 1, and both have.. microversions?
19:27:43 <Zara> so 'upgrade angular' could also mean '1.5 to 1.whatever' and that'd be fine
19:27:47 <persia> Or even just "versions" :)  Yes.  I appreciate that now, in a way that I did not at the start of the meeting.
19:28:10 <SotK> and "2" is now just "angular", because it is up to something like 4
19:28:17 <persia> In the case of 384554, it's a downgrade from 1.6.7 to 1.5.8, as a handy example of changing version while staying within the same epoch.
19:28:51 <Zara> ('we should move to angular 2' is kinda a running joke because the reason it was rewritten was it was so tough to use)
19:29:34 <Zara> angular 1 terminology is verrrry dense and angular1-specific imo)
19:29:47 <Zara> (but I'm biased because I generally have no idea what's going on)
19:29:53 <Zara> (sotk's a better authority on that one)
19:30:34 <Zara> anyyyway
19:31:28 <Zara> please check that patch with some logging in and logging out and navigating in both states, an earlier local draft hit bugs when logging out
19:31:40 <Zara> it'd be extra great if someone could test it with token expiry
19:32:30 * SotK will do some testing at some point
19:32:50 <Zara> #link https://storyboard.openstack.org/#!/story/2000407
19:32:57 <Zara> may be helpful for directions
19:33:22 <Zara> right at the end of that description are the steps we took to check access token interaction last time
19:33:50 <Zara> anyone have anything else to discuss?
19:34:03 <SotK> I don't think I have anything pressing
19:34:51 <Zara> I'm really happy so many people are helping out with patches and review in general! :D
19:35:00 <Zara> it is very motivational
19:35:06 <Zara> so thanks everyone for that
19:35:16 <Zara> I don't have anything else personally, I have a wall of review
19:35:36 <persia> Indeed.  I think I've thought about Storyboard more this week than I have otherwise for a couple months.
19:36:46 <Zara> :)
19:37:01 <Zara> in that case, I will end the meeting!
19:37:07 <Zara> #endmeeting