19:00:14 #startmeeting StoryBoard 19:00:15 Meeting started Wed Jan 17 19:00:14 2018 UTC and is due to finish in 60 minutes. The chair is Zara. Information about MeetBot at http://wiki.debian.org/MeetBot. 19:00:16 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 19:00:19 The meeting name has been set to 'storyboard' 19:00:34 #link https://wiki.openstack.org/wiki/Meetings/StoryBoard 19:00:41 ^ agenda, looks like it's not updated for this week 19:00:45 hopefully will be a short one! :D 19:00:50 #topic Announcements 19:00:55 THERE ARE NONE, EXCELLENT WORK 19:01:01 #topic In-progress Work 19:01:18 I believe the agenda items are from last week, it notes story templates and launchpad migration 19:01:24 I guess jump in with things on those if you have them 19:01:44 so instead quick round up of things currently in review 19:02:04 dhellman has sent many, many patches to our docs! :D 19:02:29 since it's more than 10 I won't link them individually 19:02:37 #link https://review.openstack.org/#/q/project:openstack-infra/storyboard 19:02:42 ^ that is where they can be found 19:02:58 they range from new content to theming to various formatting fixes 19:03:21 I'm very happy someone is taking time to update these and clean them up; thanks dhellman! :) 19:04:03 * persia is also very excited to see a new approach to the docs 19:04:32 on the webclient side, we have some general updating afoot 19:05:04 mix of updating our existing packages in an effort to reduce the wall of deprecation warnings and replacing things with newer tooling 19:05:18 #link https://review.openstack.org/#/c/384554/ 19:05:27 ^ is one that could do with more eyes on it to check if it breaks anything 19:05:42 #link https://review.openstack.org/#/c/534424/ 19:05:55 ^ a wip for webpack (thanks mordred!) so we can see where things are headed there 19:06:10 \o/ 19:06:30 we also have other patches in need of review more generally 19:06:38 #link https://review.openstack.org/#/c/534461/ 19:06:47 hopefully fixes links displaying as links 19:07:10 I haven't got to reviewing that yet, but looks like nobody else has, so waving arms here! :D 19:07:30 #link https://review.openstack.org/#/c/526219/ 19:07:43 needs more eeyes 19:08:12 aiui idea is so that project teams can link directly to that in case they want to fill some fields automatically 19:08:18 for templates etc 19:08:31 indeed 19:08:42 #link https://review.openstack.org/#/c/530656/ 19:08:54 'allow branches to be browsed by project id' 19:08:54 it also enables the construction of a link which will automatically create a private story with for example the VMT team added 19:09:04 ah yes I remember now 19:09:06 it also requires that change 19:09:18 aha I was about to say I know nothing about that change but assume it depends on it 19:09:26 I think it went up when I was very distracted, sorry :) 19:09:56 anyone interested in bug templates and VMT support should review those changes, then 19:10:15 on the api side... 19:10:16 indeed it did 19:10:22 #link https://review.openstack.org/#/c/529433/ 19:10:36 zuul has a problem with this, I have no idea why, is a fix to a migration script 19:10:44 looked like it was just timeouts 19:11:22 maybe needs poking, maybe needs more rechecks 19:11:37 #link https://review.openstack.org/#/c/533353/ 19:11:45 'fallback to natural language search if syntax is bad' 19:11:52 I haven't looked at this at allllllll 19:11:54 hmm, we really should try to find time to properly solve that timeout issue 19:12:00 I like the idea of it though 19:12:00 yep 19:12:06 our tests are ugh 19:12:14 oh yeah I did that when I was vaguely bug triaging the other day 19:12:20 thanks :) 19:12:49 oh also I sent this 19:12:54 #link https://review.openstack.org/#/c/532367/ 19:13:00 that removes stuff about the vagrant setup 19:13:08 since nobody uses it or has used it in... 3 years? 19:13:21 I need to investigate why zuul is complaining 19:13:36 * fungi looks 19:14:06 it might've just been sent at a weird time, I remmeber there were some status messages going up in channel around then 19:14:17 though it's also possible there are some tests that expect it that I didn't remove 19:14:39 yeah, looks like tox_install_sibling_packages failed on all of them. recheck it 19:14:52 done! :) 19:14:53 thanks 19:15:04 #topic Open Discussion 19:15:08 it was being refactored and a mistake slipped through 19:15:20 ah okay, thanks for catching that! :D 19:15:26 and our tests weren't correctly exercising that 19:15:41 or we would have caught it 19:16:04 it's a good way to find gaps. :) I raced through items so we know what's currently going on and people can pick the most interesting to talk about 19:16:25 so roundup complete, Openly Discuss away! :D 19:17:11 I'm trying not to focus on too many things personally so my own focus is on updating our packages, especially for the webclient 19:17:33 because I don't want to suddenly hit a wall with it when some transitive dependency is removed forever 19:17:41 i did bring the robots.txt topic up in the infra meeting yesterday. i think we're going to try rewriting the baked-in one on the production server and then see if goog indexes anything (or whether there's any performance impact) 19:18:14 cool, it will be interesting to see! :) I should be able to check for any strange performance 19:18:33 nice, hopefully it works better than expected 19:18:58 yeah, not holding out much hope but we'll see 19:19:03 I'm wondering if it'll index the things at the api endpoints instead 19:19:16 entirely possible 19:19:39 #link https://storyboard.openstack.org/api/v1/stories/2000001 19:19:47 (for anyone wondering what I mean by that, there's an example) 19:20:06 which could still be useful I suppose, though likely confusing for most :D 19:20:11 better than nothing 19:20:30 As part of the general upgrade-all-the-components, is an upgrafde to newer angular also planned? That might help with the robots.txt bits. 19:20:43 hopefully updating more of the webclient more generally will make it more feasible to change our routing 19:21:12 That's the first-ever bug filed in production after LP migrations started? Wow. Interesting artifact. 19:21:15 * fungi isn't webdev-savvy enough to know what "routing" means in this context anyway 19:21:38 persia: I don't think we intend to change the angular version itself any time soon, but my hope is to update various packages we're using atm and steadily replace them with the newer ones 19:22:14 I believe "routing" means "determine what to do for a given URL": in the case of Storyboard, the ansewr is mostly "give the browser the webui, and have the webui consume the XML at the endpoint" 19:22:25 aha, got it 19:22:38 a decision tree of sorts 19:22:47 it's also some things like 'what to do when something hasn't loaded yet' 19:22:51 not unlike how traditional network routers operated 19:22:54 Zara: The reason I asked is because I was pointed at features in angular2 that would server-side render the app, which might help in the crawler case. 19:22:59 we aren't likely to switch to angular (as opposed to angularjs/angular 1) any time soon, it would need a large amount of work 19:23:22 yeah, that's the issue, it's a very big change 19:23:50 we'd *like* it to be 2, but I don't think there's anyone around who can take that on atm 19:24:03 I want it to be 2 because then I could read the code 19:24:09 fungi: Likely more important for cases where something in the middle is the break between "path" and "data", e.g.: "http://example.org/programs/myexecutable.cgi/widgets/suppliers/index/" 19:24:10 maybe mordred's secretly scheming to work on that ;) 19:24:12 #link https://review.openstack.org/#/c/384554/ 19:24:25 shows some routing things if curious 19:24:34 the js changes 19:24:42 cool! 19:25:04 possibly not done right since I was mostly pattern matching from docs, but it's that kiiiind of thing 19:25:32 well, there are _worse_ places to take usage examples from than the documentation for the framework you're trying to use, i suppose 19:25:39 :) I think historically we used a separate package for page routes because there wasn't one built into angular 19:25:46 then later on one was built in 19:25:57 but I came to things way later and can barely write js 19:25:58 sounds likely 19:26:26 the angular growing one in its stdlib thing, not your js proficiency 19:26:37 SotK: Ah. I was confused by the name. When the first suggestion in results for "upgrade from angularjs to angular" is "rewrite your app", I appreciate that this may not happen. 19:26:41 you're far more effective at this than i could hope to be 19:26:55 hahaha dw :) so in general there are some design decisions that made sense at the time but would be very strange to make now :) 19:27:24 persia: there's both angular 1 and angular 2, 2 isn't backwards compatible with 1, and both have.. microversions? 19:27:43 so 'upgrade angular' could also mean '1.5 to 1.whatever' and that'd be fine 19:27:47 Or even just "versions" :) Yes. I appreciate that now, in a way that I did not at the start of the meeting. 19:28:10 and "2" is now just "angular", because it is up to something like 4 19:28:17 In the case of 384554, it's a downgrade from 1.6.7 to 1.5.8, as a handy example of changing version while staying within the same epoch. 19:28:51 ('we should move to angular 2' is kinda a running joke because the reason it was rewritten was it was so tough to use) 19:29:34 angular 1 terminology is verrrry dense and angular1-specific imo) 19:29:47 (but I'm biased because I generally have no idea what's going on) 19:29:53 (sotk's a better authority on that one) 19:30:34 anyyyway 19:31:28 please check that patch with some logging in and logging out and navigating in both states, an earlier local draft hit bugs when logging out 19:31:40 it'd be extra great if someone could test it with token expiry 19:32:30 * SotK will do some testing at some point 19:32:50 #link https://storyboard.openstack.org/#!/story/2000407 19:32:57 may be helpful for directions 19:33:22 right at the end of that description are the steps we took to check access token interaction last time 19:33:50 anyone have anything else to discuss? 19:34:03 I don't think I have anything pressing 19:34:51 I'm really happy so many people are helping out with patches and review in general! :D 19:35:00 it is very motivational 19:35:06 so thanks everyone for that 19:35:16 I don't have anything else personally, I have a wall of review 19:35:36 Indeed. I think I've thought about Storyboard more this week than I have otherwise for a couple months. 19:36:46 :) 19:37:01 in that case, I will end the meeting! 19:37:07 #endmeeting