19:03:18 <SotK> #startmeeting storyboard
19:03:19 <openstack> Meeting started Wed Jan 16 19:03:18 2019 UTC and is due to finish in 60 minutes.  The chair is SotK. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:03:20 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:03:22 <openstack> The meeting name has been set to 'storyboard'
19:03:34 <SotK> #link https://wiki.openstack.org/wiki/Meetings/StoryBoard#Agenda_for_next_meeting Agenda
19:03:54 * diablo_rojo waves hello
19:05:05 <SotK> #topic Announcements
19:06:21 <SotK> oauth 3.0.0 is breaking things and we need to solve that
19:06:31 <SotK> thanks fungi for starting to look at it
19:06:39 <diablo_rojo> I think I saw a patch from fungi?
19:06:46 * diablo_rojo goes to double check
19:06:48 <SotK> yup!
19:06:56 <SotK> I think its a work in progress though
19:06:58 <diablo_rojo> FOr now we just pinned the version to be less than 3.0.0
19:07:18 <fungi> yeah, the patch from me is just to be able to recreate the errors so we can work on squashing them
19:07:23 <diablo_rojo> #link https://review.openstack.org/#/c/631260/ WIP
19:07:41 <fungi> looks like there are several basic test failures in there, a couple of which might be interrelated
19:08:07 <diablo_rojo> Yeah I think the one I saw in unit tests wasn't the one you were hitting, but it was still related to OAuth
19:08:40 <fungi> one of them is actually
19:08:51 <fungi> the story i opened quotes the version from the test failure
19:09:10 <fungi> just for consistency and ease of investigation
19:09:31 <diablo_rojo> Got a story link?
19:09:35 <fungi> but it's the same exception i saw in production (well, on a new dev server deployment at least)
19:10:02 <fungi> #link https://storyboard.openstack.org/#!/story/2004789 InvalidRedirectURIError with oauthlib 3.0.0
19:10:33 <diablo_rojo> Thanks!
19:10:53 <fungi> figured that gives us a better place to collaborate, and possibly to point a github issue/pr at if we determine it's a legit oauthlib regression and not just us doing things wrong
19:11:38 <diablo_rojo> good thinking
19:11:54 <SotK> yep, good idea
19:13:15 <fungi> the good news is that now https://storyboard-dev.openstack.org/ is being served from a server named storyboard-dev01.opendev.org (note the different domain name for the machine) running ubuntu xenial
19:13:39 <diablo_rojo> That's super awesome :)
19:13:41 <fungi> once i figured out the oauthlib problem, that was the last blocker
19:13:44 <SotK> nice!
19:14:13 <fungi> so i can now proceed with the database move on storyboard-dev and confirm that's happy
19:14:43 <diablo_rojo> That's exciting :)
19:14:47 <fungi> oh, actually we're also getting an error emitted from puppet about characterset collation settings for the db, which i need to dig into first i suppose
19:14:58 <fungi> but it doesn't seem to be causing any actual service issues
19:15:15 <fungi> may affect raw query result ordering/sorting from sql
19:16:30 <diablo_rojo> Interesting
19:16:37 <fungi> i doubt it's an issue with the migrations, probably just with one of the db configuration parameters we're setting in the puppet manifest
19:17:10 <fungi> but i need to reacquaint myself with the error details since i was focused more on the openid auth problem
19:18:15 <diablo_rojo> That's fair. Still making good progress it sounds like :)
19:18:45 <SotK> indeed, thanks for working on all these things :)
19:19:41 <diablo_rojo> I can try to look into the OAuth failures a little more to see whats up there.
19:20:31 <fungi> thanks, one is just an http response code mismatch between 400 vs 401
19:20:47 <diablo_rojo> Yeah I was gonna start with the easy stuff first :)
19:20:56 <fungi> that one is likely easy to fix. definitely take a look at the oauthlib changelog though
19:21:40 <fungi> #link https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst oauthlib changelog
19:21:58 <diablo_rojo> Yeah that was going to be my starting point. Thanks for the link again!
19:22:11 <fungi> also the flowchart and explanation in rfc 6749 are a good reference to explain how that stuff is supposed to work
19:22:26 <diablo_rojo> Noted
19:22:49 <fungi> #link https://tools.ietf.org/html/rfc6749#section-4.1 IETF RFC 6749 The OAuth 2.0 Authorization Framework 4.1 Authorization Code Grant
19:24:51 <SotK> thanks in advance diablo_rojo :)
19:25:10 <diablo_rojo> Lol don't thank me yet ;)
19:25:28 <SotK> :D
19:25:29 <SotK> #topic In Progress Work
19:25:52 <fungi> note the oauthlib story isn't not urgent, just worth supporting latest oauthlib eventually
19:26:00 <fungi> er, is not urgent
19:27:16 <SotK> diablo_rojo: thanks for the reviews and merges
19:27:24 <diablo_rojo> My pleasure :)
19:27:31 <SotK> and sorry I've not done any myself again
19:30:25 * SotK hopes to get to properly thinking about breaking down the attachments work at some point in the next week
19:30:38 <diablo_rojo> That would be awesome.
19:30:50 <diablo_rojo> But I get that you're busy too
19:32:49 <diablo_rojo> I'll do another loop through open things to see what I can single core approve.
19:33:00 <diablo_rojo> I know I have a few patches out there that need attention
19:33:07 <diablo_rojo> I probably shouldn't approve my own ;)
19:33:25 <SotK> probably not :)
19:33:50 * SotK sticks a "DO CODE REVIEW" post-it above his screen
19:36:29 <SotK> does anyone have anything else to discuss or shall we end the meeting?
19:37:18 <diablo_rojo> Nothing else new atm
19:38:14 <fungi> nothing on my end
19:38:29 <SotK> in that case, thank you both for coming :)
19:38:35 <fungi> thanks for chairing!
19:38:36 <SotK> #endmeeting