21:04:01 <timburke> #startmeeting swift
21:04:01 <opendevmeet> Meeting started Wed Sep  8 21:04:01 2021 UTC and is due to finish in 60 minutes.  The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot.
21:04:01 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
21:04:01 <opendevmeet> The meeting name has been set to 'swift'
21:04:16 <timburke> sorry, i *was* distracted ;-)
21:04:25 <timburke> who's here for the swift meeting?
21:04:32 <kota> hello
21:04:40 <mattoliver> o/
21:05:31 <timburke> i think acoles is out, and we'll just see as we go whether clayg and zaitcev (and anyone else) are around
21:05:43 <timburke> as usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift
21:06:10 <timburke> #topic PTG
21:06:49 <timburke> just a reminder to add any topics you want to discuss to the etherpad
21:06:54 <timburke> #link https://etherpad.opendev.org/p/swift-ptg-yoga
21:06:54 <mattoliver> ahh, that'll explain why I couldn't get to gerrit just now
21:07:17 <kota> lol
21:07:34 <mattoliver> I think I added a few. But no doubt there are more and we still need to add the normal ones like opps feedback :)
21:07:38 <timburke> we're a little more than a month away; it'll be good to see everyone again (even if just via video chat)
21:08:16 <timburke> #topic ring v2
21:08:49 <zaitcev> I added that little e-mail from Arkady
21:09:02 <zaitcev> to the Etherpad.
21:09:24 <timburke> thanks zaitcev!
21:10:22 <timburke> i don't know that we've proposed any new patches for ring v2 yet, but i've got a chain that i've started on; hopefully i'll have it to a state that i'm happy to push it up in another week or two
21:10:58 <timburke> while i was doing that, i wrote up some history of ring formats (as best as i could make out): https://gist.github.com/tipabu/435fc63f1aa76d6b346956571a393665
21:11:49 <mattoliver> oh nice a gist, I'll take a look. we did have  https://review.opendev.org/c/openstack/swift/+/803665 which implemented a part of it as POC to see how it looked. But looking forward to seeing what you've done esp post etherpad.
21:12:15 <mattoliver> I think that was right can't get into gerrit to double check :P
21:12:40 <timburke> huh. worked for me -- "ring: store actual ring replica count to better deserialize"
21:13:01 <mattoliver> oh its back!
21:14:28 <mattoliver> looking forward to working out this v2 serialization format, because it'll open the doors to last_primary improvements we can add to things
21:15:21 <timburke> yeah, that's my thinking, too: we can make a few different things a good bit smarter if they've got some ring history
21:15:37 <timburke> #topic sharder and reconciler
21:15:57 <timburke> #link https://review.opendev.org/c/openstack/swift/+/800748
21:16:05 <mattoliver> Not as much progress here as I'd like in the last week or so
21:16:46 <timburke> no worries -- i just wanted to check in on it and see what we can do to help get it moving again
21:16:55 <mattoliver> reconciler does things a little different. and we were spitballing ways to make the root -> shard SPI migrations act similarly
21:17:30 <mattoliver> I left a suggestion in the patch discussion.. and now waiting on others to comment.
21:17:37 <mattoliver> but Al's on vacation.. so kinda got stalled.
21:17:46 <mattoliver> hopefully have an update next week :)
21:18:27 <timburke> sounds good. and i'll try to load up the problem in my head and get a useful review out :-)
21:18:46 <mattoliver> thanks :)
21:19:50 <timburke> one last-minute topic
21:20:02 <timburke> #topic reviewed but not merged patches
21:20:41 <timburke> i've got a few patches w/ a +2 but no +A: https://review.opendev.org/q/project:openstack/swift+label:Code-Review%252B2+is:open+-age:52w
21:21:06 <timburke> anybody want to call for more eyes on some of those, or should we just merge them?
21:21:38 <timburke> the query params patch still has me nervous, but i think the others are probably good to go? but then, i'm biased
21:22:48 <zaitcev> Why nervous? Security?
21:23:30 <mattoliver> The fact that they have a +2 means they're in good shape. Only worry is, was the +A not added because the reviewer wasn't 100% sure? I'm leaning towards just landing them. But I'll give them a parse over today and land or comment.
21:24:21 <zaitcev> Yes. I wrote "The scenarios Tim is considering are concerning, but fortunately the allowed_headers list is empty by default." Now I cannot remember a blessed thing about that patch. What did I mean exactly ....
21:24:45 <mattoliver> lol
21:24:53 <zaitcev> Always write it down!
21:25:57 <zaitcev> The EC watcher is no big deal, I can just land it now.
21:27:33 <zaitcev> Oh, righ
21:27:40 <zaitcev> I see why. It has no tests.
21:28:01 <timburke> switch it to a -1 then ;-) i can work on adding some
21:28:13 <zaitcev> I meant to signal "fine by me, but you guys are always so strict about tests, so I'll leave it with just +2 for now".
21:29:01 <timburke> i do have some security concerns on the tempurl patch, yeah. the default is secure, but the motivation for the patch makes me think that it's likely people will allow multipart-manifest, which seems to have a security impact
21:30:44 <timburke> all right, that's all i've got
21:30:50 <timburke> #topic open discussion
21:30:59 <timburke> anything else we should talk about this week?
21:31:18 <mattoliver> maybe hold off on the tempurl and let's discuss it at PTG maybe?
21:31:38 <mattoliver> we can brainstorm security impact maybe
21:31:40 <zaitcev> Going back to right history gist, we have a "History" section in https://docs.openstack.org/swift/latest/overview_ring.html
21:31:56 <zaitcev> Is this something worth rolling into one document or whatevs
21:32:22 <zaitcev> s/right /ring /
21:32:41 <timburke> yeah, probably a good idea. i can work on getting a docs patch up
21:34:31 <mattoliver> made some interesting progress on the opentracing integration into swift. https://review.opendev.org/c/openstack/swift/+/803879 our SREs have been playing with it. And it's really nice visualising swift requests across a cluster. Start seeing paterns and hopefully ares to fix.
21:34:44 <mattoliver> I'll show some traces at PTG maybe :)
21:34:47 <zaitcev> Yeah, it's our world... Whenever our something small and useful pops, it turns into this whole thing. EC watcher needs tests, gists can be more useful in docs, etc.
21:35:59 <timburke> always more work to be done :-)
21:37:37 <timburke> all right, seems like we can let kota and mattoliver get on with their mornings
21:37:48 <timburke> thank you all for coming, and thank you for working on swift!
21:37:51 <timburke> #endmeeting