08:02:41 <yasufum> #startmeeting tacker
08:02:42 <openstack> Meeting started Tue May 11 08:02:41 2021 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:02:43 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:02:45 <openstack> The meeting name has been set to 'tacker'
08:03:12 <yasufum> #link https://etherpad.opendev.org/p/tacker-meeting
08:04:50 <yasufum> hi
08:04:55 <takahashi-tsc> hi
08:05:43 <yasufum> Do you have any topic although no one on the etherpad?
08:06:43 <takahashi-tsc> I don't write it, but I have 1 topic to discuss.
08:07:48 <yasufum> OK, go ahead please.
08:08:04 <takahashi-tsc> https://review.opendev.org/c/openstack/tacker/+/787066
08:08:47 <takahashi-tsc> This is just a bugfix, but I'd like to discuss how to fix and how to make UT.
08:10:16 <takahashi-tsc> This is because of bug of python zipfile module, so change to use subprocess and Linux unzip command. And add UT for the method.
08:10:55 <takahashi-tsc> As a result, UT execute Linux unzip command but UT env does not include Linux unzip.
08:12:46 <takahashi-tsc> I don't know how to add new package to UT env... 1 solution is use mock for subprcess. But if we use mock, UT becomes meaningless.
08:13:28 <yasufum> sure
08:13:31 <takahashi-tsc> So I'd like to discuss how to proceed...
08:14:21 <takahashi-tsc> 1. Not make UT / Make UT with mock / (any others?)   2. Is there any other good fix without using subprocess?
08:18:20 <ueha> takahasi-tsc: Sorry, could you tell me one thing?
08:18:30 <ueha> Is there something wrong with tacker when permission is changed to 644?
08:19:58 <takahashi-tsc> The problem is change permission of package files, which is VNF's files. So in my opinion, Tacker should keep permission.
08:23:39 <ueha> Thanks, There is no particular problem.
08:24:05 <ueha> But it should be same permission download by `openstack vnf package download` command. right?
08:24:41 <takahashi-tsc> For example, mgmt driver use some shell script and VNF assume such file's permission is 755. Anyway, Tacker cannot/should not know such VNF's assumption.
08:26:39 <ueha> I see. thank you.
08:34:45 <takahashi-tsc> I think checking premission of unzipped file is not UT... so I think using mock is OK. But I'm not sure such UT is necessary.
08:36:07 <yasufum> I’m not sure what should be done in your patch. You try to install unzip because it’s not included, right?
08:37:31 <takahashi-tsc> You mean editting devstack setting? Yes but this is for only FT env. I cannot find the way to install unzip into UT env.
08:37:43 <yasufum> I am also not sure why devstack/settings is removed in the latest patch set.
08:38:16 <takahashi-tsc> Sorry ,it is just a mistake... he want to rollback setting change, so please ignore the change.
08:39:51 <takahashi-tsc> The problem is failing UT such as openstack-tox-py36, py38.
08:43:14 <yasufum> umm
08:43:59 <yasufum> Did you try to use zlib instead?
08:44:15 <yasufum> Although I’m not sure it support such a permission support...
08:47:18 <takahashi-tsc> He may not try zlib, we'll try it.
08:47:47 <takahashi-tsc> But same problem might occur...
08:49:07 <yasufum> Anyway, we might have several possible options for the problem.
08:50:31 <takahashi-tsc> OK, first try to use zlib. And is it OK to upload UT using mock?
08:50:34 <yasufum> I am not so well understanding about zip related libs, but would like to consider
08:50:59 <yasufum> I don’t agree to make it a mock currently.
08:52:19 <takahashi-tsc> OK... I try to check zip related solutions.
08:52:35 <yasufum> thnaks
08:53:49 <yasufum> please continue the discussion on gerrit.
08:54:10 <yasufum> Is there any topic?
08:54:44 <takahashi-tsc> not from myside.
08:54:52 <yasufum> or close this meeting because it almost the end of the time.
08:55:42 <ueha> I have no topic today.
08:55:59 <yasufum> OK
08:56:17 <yasufum> wrap up the meeting
08:56:30 <yasufum> Thank you for joining. Bye!
08:56:39 <masazumi-ota> Bye
08:56:45 <ueha> thanks, bye
08:56:47 <takahashi-tsc> bye
08:57:05 <yasufum> #endmeeting