08:02:40 <yasufum> #startmeeting tacker
08:02:40 <opendevmeet> Meeting started Tue Jun 15 08:02:40 2021 UTC and is due to finish in 60 minutes.  The chair is yasufum. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:02:40 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:02:40 <opendevmeet> The meeting name has been set to 'tacker'
08:02:59 <yasufum> #link https://etherpad.opendev.org/p/tacker-meeting
08:04:07 <yasufum> we have one topic today from manpreet.
08:04:22 <yasufum> could you start it?
08:04:28 <manpreetk> yes, thanks
08:04:36 <yasufum> #topic Migration for SQLAlchemy 1.4
08:05:13 <manpreetk> The OpenStack has migrated to SqlAlchemy 1.4,this change has cause gate job failures in the tacker.
08:05:13 <manpreetk> Proposed solution, https://review.opendev.org/c/openstack/tacker/+/796160
08:05:53 <manpreetk> But the proposed patch is failing for an open bug in SQLAlchemy.
08:05:53 <manpreetk> https://github.com/juliotrigo/sqlalchemy-filters/issues/61
08:05:53 <manpreetk> 
08:05:53 <manpreetk> Would like to know how to address/resolve this problem in tacker.
08:07:36 <yasufum> umm
08:07:57 <yasufum> Have you tried to run unit tests on your local env?
08:08:01 <manpreetk> yes
08:08:18 <manpreetk> same results its failing
08:14:44 <yasufum> I’m not sure from the zuul log at a glance, but seems happened something in sqlalchemy, not in tacker…
08:14:44 <manpreetk> yes its sqlalchemy problem
08:15:18 <yasufum> and caused several time through the test.
08:16:48 <yasufum> Are you sure which version of sqlalchemy running on zuul and your local? Are there the same?
08:19:04 <manpreetk> Yes i rechecked both versions are same, SQLAlchemy==1.4.15,sqlalchemy-filters==0.12.0
08:19:24 <yasufum> got it
08:20:09 <yasufum> I also would like to know this error happens other patches than yours.
08:20:18 <yasufum> if you know.
08:21:23 <manpreetk> i did tried to find the same error in other projects but hard luck :( seems its tacker that is using apply_filters method
08:22:03 * yasufum Oops, I’ve found other ones also the same situation, such as https://zuul.opendev.org/t/openstack/build/56881bc1fc2a4fa7b9d8ae7848073e7d
08:22:15 <yasufum> https://review.opendev.org/c/openstack/tacker/+/676918
08:22:43 <yasufum> manpreet: OK, thanks
08:24:44 <yasufum> It must be a problem for all updates for tacker, so we should fix it.
08:26:54 <yasufum> Anyway, I’ll try to find the cause of the error.
08:27:20 <yasufum> Do you anyone have a comment or suggestion for the issue?
08:28:21 <ueha> BTW, Looking at the FT error, it seems that the DB migration of barbican failed.
08:28:38 <ueha> ++ /opt/stack/barbican/devstack/lib/barbican:init_barbican:178 :   /usr/local/bin/barbican-manage db upgrade -v head
08:28:52 <ueha> ERROR: The argument passed to Dialect.has_table() should be a <class 'sqlalchemy.engine.base.Connection'>, got <class 'sqlalchemy.engine.base.Engine'>. Additionally, the Dialect.has_table() method is for internal dialect use only; please use ``inspect(some_engine).has_table(<tablename>>)`` for public API use.
08:29:29 <manpreetk> Thanks for pointing out, will look into this as well
08:29:32 <ueha> Barbican seems to be working on migrating Sqlalchemy with the following patch, and Tacker's FT doesn't seem to work until it is merged.
08:29:49 <ueha> https://review.opendev.org/c/openstack/barbican/+/796059 & https://review.opendev.org/c/openstack/barbican/+/796284
08:30:27 <ueha> or either.
08:33:35 <yasufum> ueha: thank you for sharing.
08:33:36 <ueha> That's all from my side, I'll also try to find the cause of the error. Thanks.
08:33:41 <manpreetk> Thanks, would like to know direction for the solution, shall we revisit the tacker query or fix issue in sqlalchemy?
08:36:11 <yasufum> Although it depends on the situation, I think we’d better to revisit tacker first.
08:37:36 <manpreetk> Hmm fair enough, would revisit tacker query for solution. Thanks for help, thats all from my side.
08:39:23 <yasufum> Thanks
08:40:14 <yasufum> If no more comment, go to next topic.
08:40:31 <yasufum> or close this meeting if no topics anymore.
08:43:23 <yasufum> Do you have any topic?
08:43:36 <ueha> Nothing from my side today, let me talk a little about Zuul FT of Mgmt Driver next week.
08:44:24 <yasufum> sure
08:44:42 <takahashi-tsc> Nothing from my side.
08:44:52 <ueha> Thank you.
08:45:07 <yasufum> takahashi-tsc: Can I ask you to review patches waiting for another +2?
08:45:34 <yasufum> After the issue of sqlalchemy is fixed.
08:45:39 <takahashi-tsc> Sure
08:47:49 <yasufum> Ah, I should ask team one more thing.
08:48:17 <yasufum> Asking for voting for the name of Y has posted on ML, so please vote it.
08:48:40 <yasufum> Thank you for joining today. I’d close this meeting.
08:48:45 <yasufum> Bye
08:49:00 <manpreetk> thanks and bye.
08:49:00 <ueha> Thanks, bye
08:49:18 <yasufum> #endmeeting tacker